[PATCH v2 net] tcp: fix TLP timer not set when CA_STATE changes from DISORDER to OPEN

ACK, to avoid spurious RTO caused by RTO timer early expires. 2) Reduce the xmit timer reschedule once per ACK when the RACK reorder timer is set. Link: https://lore.kernel.org/netdev/1611311242-6675-1-git-send-email-yan...@wangsu.com Signed-off-by: Pengcheng Yang Cc: Neal Cardwell Cc: Yuchung

Re: [PATCH net] tcp: fix TLP timer not set when CA_STATE changes from DISORDER to OPEN

On Sat, Jan 23, 2021 at 9:27 AM "Jakub Kicinski" wrote: > > On Fri, 22 Jan 2021 11:53:46 +0100 Eric Dumazet wrote: > > On Fri, Jan 22, 2021 at 11:28 AM Pengcheng Yang wrote: > > > > > > When CA_STATE is in DISORDER, the TLP timer is not set when receivin

Re: [PATCH net] tcp: fix TLP timer not set when CA_STATE changes from DISORDER to OPEN

On Sat, Jan 23, 2021 at 5:02 AM "Yuchung Cheng" wrote: > > On Fri, Jan 22, 2021 at 6:37 AM Neal Cardwell wrote: > > > > On Fri, Jan 22, 2021 at 5:53 AM Eric Dumazet wrote: > > > > > > On Fri, Jan 22, 2021 at 11:28 AM Pengcheng Yang wrote: > &g

[PATCH net] tcp: fix TLP timer not set when CA_STATE changes from DISORDER to OPEN

: Pengcheng Yang Cc: Neal Cardwell --- include/net/tcp.h | 2 +- net/ipv4/tcp_input.c| 10 ++ net/ipv4/tcp_recovery.c | 5 +++-- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/include/net/tcp.h b/include/net/tcp.h index 78d13c8..67f7e52 100644 --- a/include/net

Re: tcp: rearm RTO timer does not comply with RFC6298

On Thu, Jan 21, 2021 at 11:51 PM Neal Cardwell wrote: > > On Thu, Jan 21, 2021 at 9:05 AM Pengcheng Yang wrote: > > > > On Thu, Jan 21, 2021 at 2:59 AM Yuchung Cheng wrote: > > > > > > On Wed, Jan 20, 2021 at 6:59 AM Neal Cardwell > > > wrote: &g

[PATCH net-next] tcp: remove unused ICSK_TIME_EARLY_RETRANS

Since the early retransmit has been removed by commit bec41a11dd3d ("tcp: remove early retransmit"), we also remove the unused ICSK_TIME_EARLY_RETRANS macro. Signed-off-by: Pengcheng Yang --- include/net/inet_connection_sock.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

Re: tcp: rearm RTO timer does not comply with RFC6298

On Thu, Jan 21, 2021 at 2:59 AM Yuchung Cheng wrote: > > On Wed, Jan 20, 2021 at 6:59 AM Neal Cardwell wrote: > > > > On Wed, Jan 20, 2021 at 5:50 AM Pengcheng Yang wrote: > > > > > > hi, > > > > > > I have a doubt about tcp_rearm_rto(). &

tcp: rearm RTO timer does not comply with RFC6298

hi, I have a doubt about tcp_rearm_rto(). Early TCP always rearm the RTO timer to NOW+RTO when it receives an ACK that acknowledges new data. Referring to RFC6298 SECTION 5.3: "When an ACK is received that acknowledges new data, restart the retransmission timer so that it will expire after RTO s

Re: [PATCH net] tcp: fix TCP_SKB_CB(skb)->tcp_tw_isn not being used

On Fri, Jan 15, 2021 at 1:12 AM Eric Dumazet wrote: > > On Thu, Jan 14, 2021 at 5:53 PM Jakub Kicinski wrote: > > > > On Tue, 29 Dec 2020 05:59:20 +0800 Pengcheng Yang wrote: > > > TCP_SKB_CB(skb)->tcp_tw_isn contains an ISN, chosen by > > > tcp_timewait

[PATCH net] tcp: fix TCP_SKB_CB(skb)->tcp_tw_isn not being used

fix this case, we record tcp_tw_isn before tcp_v4_restore_cb() and then set it in tcp_v4_fill_cb(). V6 does the same. Fixes: eeea10b83a13 ("tcp: add tcp_v4_fill_cb()/tcp_v4_restore_cb()") Reported-by: chenc Signed-off-by: Pengcheng Yang --- net/ipv4/tcp_ipv4.c | 14 -- n