All series:
Reviewed-by: Pavel Fedin
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
-Original Message-
From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On
Behalf Of Sunil Goutham
Sent: Thursday, December 10, 2015 10:55 AM
b/drivers/net/ethernet/cavium/thunder/nicvf_queues.h
> @@ -10,6 +10,7 @@
> #define NICVF_QUEUES_H
>
> #include
> +#include "nic.h"
> #include "q_struct.h"
>
> #define MAX_QUEUE_SET128
> @@ -75,7 +76,7 @@
> */
> #defin
inner_l4_offset:8;
> + u64inner_l3_offset:8;
> + u64tso_start:8;
> + u64rsvd3:2;
> u64tso_max_paysize:14; /* W1 */
> #elif defined(__LITTLE_ENDIAN_BITFIELD)
> u64tot_len:20;
> u64rsvd1:4;
> u64l3_offset:8;
> u64
ink up") VF will not fully bring itself up without it.
This patch fixes the potential problem by doing VF number checks against
the num_vf_en. Since lmac_cnt is not used anywhere else, it is removed.
Additionally some duplicated code is factored out into nic_enable_vf()
Signed-off-by:
Tested-by: Pavel Fedin
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On
> Behalf Of Sunil
> Goutham
> Sent: Monday, December 07, 20
) VF will
not fully bring itself up without it.
This patch fixes the potential problem by removing unnecessary structure
member and doing VF number checks against correct one.
Additionally some duplicated code is factored out into nic_enable_vf()
Signed-off-by: Pavel Fedin
---
drivers/ne
errata patches (also posted on lists, all
merged into 4.4), took defconfig, adjusted it according to my needs, and this
is what i'm running on my board and this is what i'm using for development. If
you point me at what i'm doing wrong way, i'll be glad to accept this.
I'
ng in guest i tried to apply it to host. With total of
128 virtual functions (= 128 interfaces) it does not work at all. Even after
bumping cma region size to insane value of 2GB more than half of interfaces
still failed to allocate queues. And after setting cma=3G i could not mount my
rootfs.
l BGX driver patches on my 4.2 host
kernel build. It fails to send NIC_MBOX_MSG_BGX_LINK_CHANGE, so nothing works.
I have retested this series on top of 4.3 running on ThunderX. It has good BGX
driver and everything works fine. Therefore, the
whole series can be safely applied and...
Tested-by:
Just a reminder, we have issue with this one too, which is not addressed yet.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On
> Behalf
from version
to version. I enabled it and rebuilt the kernel, but in order to get the driver
working with this patch i had to also add cma=32M option to kernel arguments.
With default of 16M the allocation still fails.
Should we add Kconfig dependencies?
Kind regards,
Pavel Fedin
Expert Enginee
ool?
3. The driver could check value of atomic_pool_size and adjust own memory
requirements accordingly. This indeed looks like a quick hack, but would at
least make things running quickly.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this
patch aimed
> for linux-4.5 ?
Why not? It's just a networking driver. And, i also have the same problem on
4.3 running as KVM guest with VFIO.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: send the line "
Hello!
This one causes the network to stop working on Fedora 21. Probably has to do
with NetworkManager, which sees something unexpected.
IP address is never set up and connection is never activated, despite it has UP
flag.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics
/0x84
[] SyS_sendmsg+0x10/0x20
thunder-nicvf 0002:01:08.4 enP2p1s8f4: Failed to alloc/config VF's QSet
resources
--- cut ---
And none of interfaces work after this. Reverting this patch helps.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
> -
In some cases the crash is caused by nicvf_remove() being called from
outside. For example, if we try to feed the device to vfio after the
probe has failed for some reason. So, move the check to better place.
Signed-off-by: Pavel Fedin
---
drivers/net/ethernet/cavium/thunder/nicvf_main.c | 13
If device probe fails, driver remains bound to the PCI device. However,
driver data has been reset to NULL. This causes crash upon dereferencing
it in nicvf_remove()
Signed-off-by: Pavel Fedin
---
v1 => v2:
- Do the test in nicvf_remove(), this allows to cover more situations
---
drivers/
Hello!
> > If device probe fails, driver remains bound to the PCI device. However,
> > driver data has been reset to NULL. This causes crash upon dereferencing
> > it in nicvf_remove()
> >
> > Signed-off-by: Pavel Fedin
>
> Applied, thanks.
Thank you ve
function
during probe, it is changed to use PMT_CTRL register.
The problem could be observed on SMDK5410 board.
Signed-off-by: Pavel Fedin
---
drivers/net/ethernet/smsc/smsc911x.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/net/ethernet/smsc
If device probe fails, driver remains bound to the PCI device. However,
driver data has been reset to NULL. This causes crash upon dereferencing
it in nicvf_remove()
Signed-off-by: Pavel Fedin
---
drivers/net/ethernet/cavium/thunder/nicvf_main.c | 3 +++
1 file changed, 3 insertions(+)
diff
x27;t have anything to change, do i? Or is it
just a formal requirement to RESEND? I can do this, if you want to.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a
is the way to go.
So, what do you really think?
BTW, where is Steve, whose address is specified in MAINTAINERS for this code?
Is it abandonware?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: send the line "unsubscribe
Hello! So, what should we do with this?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On
> Behalf Of Pavel
> Fedin
> Sent: Monday, Novem
t; the chip should have been already set up. In order to be able to function
> > during probe, it is changed to use PMT_CTRL register.
> >
> > The problem could be observed on SMDK5410 board.
> >
> > Signed-off-by: Pavel Fedin
>
> I'm pretty sure this is g
function
during probe, it is changed to use PMT_CTRL register.
The problem could be observed on SMDK5410 board.
Signed-off-by: Pavel Fedin
---
drivers/net/ethernet/smsc/smsc911x.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/net/ethernet/smsc
. Attempting
to dispose the driver without calling phy_disconnect() causes deallocation
of DELAYED_WORK being active. This shortly causes a bad crash in timer
code.
The problem can be discovered by enabling CONFIG_DEBUG_OBJECTS_TIMERS and
CONFIG_DEBUG_OBJECTS_FREE
Signed-off-by: Pavel Fedin
---
drivers
interface is reopen.
Signed-off-by: Pavel Fedin
---
Changes for v3:
- Fixed (actually hand-edited) file permissions to be 644. I occasionally
pushed them as 755 to my
local repo.
Changes for v2:
- Fixed a couple of checkpatch.pl reports (was forgotten in v1)
- Adjusted email client prefs
interface is reopen.
Signed-off-by: Pavel Fedin
---
Differences from v1:
- Fixed a couple of checkpatch.pl reports (was forgotten in v1)
- Adjusted email client prefs, hopefully will not corrupt patches any more.
---
drivers/net/ethernet/cavium/thunder/nic.h| 1 +
drivers/net/ethernet
interface is reopen.
Signed-off-by: Pavel Fedin
---
drivers/net/ethernet/cavium/thunder/nic.h| 1 +
drivers/net/ethernet/cavium/thunder/nicvf_main.c | 12 ++--
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/cavium/thunder/nic.h
b/drivers/net
29 matches
Mail list logo
