Re: [PATCH] Re: mv643xx_eth_start_xmit: calls skb_linearize with interrupts off

2006-01-13 Thread Paul Janzen
"Dale Farnsworth" <[EMAIL PROTECTED]> writes: >> +if (has_tiny_unaligned_frags(skb)) { >> +if ((skb_linearize(skb, GFP_ATOMIC) != 0) >> +|| has_tiny_unaligned_frags(skb)) { > > There is no way that skb_linearize can return without removing all frags >

[PATCH] Re: mv643xx_eth_start_xmit: calls skb_linearize with interrupts off

2006-01-08 Thread Paul Janzen
Paul Janzen <[EMAIL PROTECTED]> writes: > In mv643xx_eth_start_xmit: > [...] > spin_lock_irqsave(&mp->lock, flags); > [...] > /* Since hardware can't handle unaligned fragments smaller >* than 9 bytes, if we find any, we line

mv643xx_eth_start_xmit: calls skb_linearize with interrupts off

2006-01-07 Thread Paul Janzen
Hi, I am seeing backtraces on 2.6.15-rc7 on NFS traffic that are similar to this one: Badness in local_bh_enable at kernel/softirq.c:140 Call trace: [c0005340] check_bug_trap+0xb0/0xd0 [c0005bb4] program_check_exception+0x174/0x4f0 [c0004f04] ret_from_except_full+0x0/0x4c [c0021b8c] local_bh