Re: [PATCH v3 net 11/16] ipv6: input: convert to dev_net_rcu()

2025-02-04 Thread Paul E. McKenney
On Tue, Feb 04, 2025 at 01:30:25PM -0800, Jakub Kicinski wrote: > On Tue, 4 Feb 2025 13:17:08 -0800 Paul E. McKenney wrote: > > > > TBH I'm slightly confused by this, and the previous warnings. > > > > > > > > The previous one was from a timer callback.

Re: [PATCH v3 net 11/16] ipv6: input: convert to dev_net_rcu()

2025-02-04 Thread Paul E. McKenney
On Tue, Feb 04, 2025 at 10:06:15PM +0100, Eric Dumazet wrote: > On Tue, Feb 4, 2025 at 10:00 PM Jakub Kicinski wrote: > > > > On Tue, 4 Feb 2025 21:10:59 +0100 Eric Dumazet wrote: > > > > Test output: > > > > https://netdev-3.bots.linux.dev/vmksft-net-dbg/results/978202/61-l2tp-sh/ > > > > Decoded

Re: [PATCHv7 bpf-next 1/4] bpf: run devmap xdp_prog on flush instead of bulk enqueue

2021-04-19 Thread Paul E. McKenney
On Tue, Apr 20, 2021 at 12:16:40AM +0200, Toke Høiland-Jørgensen wrote: > "Paul E. McKenney" writes: > > > On Mon, Apr 19, 2021 at 11:21:41PM +0200, Toke Høiland-Jørgensen wrote: > >> "Paul E. McKenney" writes: > >> > >> > On Mon,

Re: [PATCHv7 bpf-next 1/4] bpf: run devmap xdp_prog on flush instead of bulk enqueue

2021-04-19 Thread Paul E. McKenney
On Mon, Apr 19, 2021 at 11:21:41PM +0200, Toke Høiland-Jørgensen wrote: > "Paul E. McKenney" writes: > > > On Mon, Apr 19, 2021 at 08:12:27PM +0200, Toke Høiland-Jørgensen wrote: > >> "Paul E. McKenney" writes: > >> > >> > On Sat,

Re: [PATCHv7 bpf-next 1/4] bpf: run devmap xdp_prog on flush instead of bulk enqueue

2021-04-19 Thread Paul E. McKenney
On Mon, Apr 19, 2021 at 08:12:27PM +0200, Toke Høiland-Jørgensen wrote: > "Paul E. McKenney" writes: > > > On Sat, Apr 17, 2021 at 02:27:19PM +0200, Toke Høiland-Jørgensen wrote: > >> "Paul E. McKenney" writes: > >> > >> > On

Re: [PATCHv7 bpf-next 1/4] bpf: run devmap xdp_prog on flush instead of bulk enqueue

2021-04-19 Thread Paul E. McKenney
On Sat, Apr 17, 2021 at 02:27:19PM +0200, Toke Høiland-Jørgensen wrote: > "Paul E. McKenney" writes: > > > On Fri, Apr 16, 2021 at 11:22:52AM -0700, Martin KaFai Lau wrote: > >> On Fri, Apr 16, 2021 at 03:45:23PM +0200, Jesper Dangaard Brouer wrote: > >&

Re: [PATCHv7 bpf-next 1/4] bpf: run devmap xdp_prog on flush instead of bulk enqueue

2021-04-16 Thread Paul E. McKenney
On Fri, Apr 16, 2021 at 11:22:52AM -0700, Martin KaFai Lau wrote: > On Fri, Apr 16, 2021 at 03:45:23PM +0200, Jesper Dangaard Brouer wrote: > > On Thu, 15 Apr 2021 17:39:13 -0700 > > Martin KaFai Lau wrote: > > > > > On Thu, Apr 15, 2021 at 10:29:40PM +0200, Toke Høiland-Jørgensen wrote: > > > >

Re: Something is leaking RCU holds from interrupt context

2021-04-04 Thread Paul E. McKenney
On Sun, Apr 04, 2021 at 07:24:53PM +0100, Matthew Wilcox wrote: > On Sun, Apr 04, 2021 at 09:48:08AM -0700, Paul E. McKenney wrote: > > On Sun, Apr 04, 2021 at 11:24:57AM +0100, Matthew Wilcox wrote: > > > On Sat, Apr 03, 2021 at 09:15:17PM -0700, syzbot wrote: > > >

Re: Something is leaking RCU holds from interrupt context

2021-04-04 Thread Paul E. McKenney
On Sun, Apr 04, 2021 at 11:24:57AM +0100, Matthew Wilcox wrote: > On Sat, Apr 03, 2021 at 09:15:17PM -0700, syzbot wrote: > > HEAD commit:2bb25b3a Merge tag 'mips-fixes_5.12_3' of git://git.kernel.. > > git tree: upstream > > console output: https://syzkaller.appspot.com/x/log.txt?x=1284c

[PATCH drivers/net] #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend()

2021-03-03 Thread Paul E. McKenney
used only in CONFIG_PM_SLEEP=y kernels. This commit therefore wraps them in #ifdef CONFIG_PM_SLEEP. Cc: Andrew Lunn Cc: Heiner Kallweit Cc: Russell King Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Signed-off-by: Paul E. McKenney diff --git a/drivers/net/phy/phy_device.c b/drive

Re: [PATCH drivers/net] #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend()

2021-03-03 Thread Paul E. McKenney
On Wed, Mar 03, 2021 at 06:04:22PM +, Russell King - ARM Linux admin wrote: > On Wed, Mar 03, 2021 at 09:53:38AM -0800, Paul E. McKenney wrote: > > drivers/net: #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend() > > > > The following build error is emitted by rcuto

Re: [stabe-rc 5.9 ] sched: core.c:7270 Illegal context switch in RCU-bh read-side critical section!

2020-12-15 Thread Paul E. McKenney
On Tue, Dec 15, 2020 at 07:50:31AM +0530, Naresh Kamboju wrote: > There are two warnings "WARNING: suspicious RCU usage" noticed on arm64 > juno-r2 > device while running selftest bpf test_tc_edt.sh and net: udpgro_bench.sh. > These warnings are occurring intermittently. > > metadata: > git bra

Re: [PATCH] bpf: don't fail kmalloc while releasing raw_tp

2020-11-17 Thread Paul E. McKenney
On Tue, Nov 17, 2020 at 08:09:22PM -0500, Steven Rostedt wrote: > On Tue, 17 Nov 2020 16:42:44 -0800 > Matt Mullins wrote: > > > > > Indeed with a stub function, I don't see any need for > > > READ_ONCE/WRITE_ONCE. > > > > I'm not sure if this is a practical issue, but without WRITE_ONCE, ca

Re: [PATCH net-next 0/7] rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition

2020-09-16 Thread Paul E. McKenney
On Wed, Sep 16, 2020 at 11:45:21AM -0700, Jakub Kicinski wrote: > Hi! > > So I unfolded the RFC patch into smaller chunks and fixed an issue > in SRCU pointed out by build bot. Build bot has been quiet for > a day but I'm not 100% sure it's scanning my tree, so let's > give these patches some ML e

Re: [PATCH net-next] rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition

2020-09-15 Thread Paul E. McKenney
On Mon, Sep 14, 2020 at 05:30:29PM -0700, Jakub Kicinski wrote: > On Mon, 14 Sep 2020 17:20:11 -0700 Paul E. McKenney wrote: > > > Seems like quite a few places depend on the macro disappearing its > > > argument. I was concerned that it's going to be had to pick out whe

Re: [PATCH net-next] rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition

2020-09-14 Thread Paul E. McKenney
On Mon, Sep 14, 2020 at 03:47:38PM -0700, Jakub Kicinski wrote: > On Mon, 14 Sep 2020 16:21:22 -0400 Joel Fernandes wrote: > > On Tue, Sep 08, 2020 at 05:27:51PM -0700, Jakub Kicinski wrote: > > > On Tue, 08 Sep 2020 21:15:56 +0300 niko...@cumulusnetworks.com wrote: > > > > Ah, you want to solve

Re: [PATCH v2 bpf-next] bpf: Fix build without BPF_SYSCALL, but with BPF_JIT.

2020-08-31 Thread Paul E. McKenney
d BPF trampoline logic won't be used without BPF_SYSCALL. > > Reported-by: kernel test robot > Fixes: 1e6c62a88215 ("bpf: Introduce sleepable BPF programs") > Acked-by: Paul E. McKenney > Signed-off-by: Alexei Starovoitov Looks goo

Re: [PATCH bpf-next] bpf: Fix build without BPF_SYSCALL, but with BPF_JIT.

2020-08-30 Thread Paul E. McKenney
On Sun, Aug 30, 2020 at 05:53:21PM -0700, Alexei Starovoitov wrote: > On Sun, Aug 30, 2020 at 03:03:13PM -0700, Paul E. McKenney wrote: > > On Sun, Aug 30, 2020 at 01:43:28PM -0700, Alexei Starovoitov wrote: > > > From: Alexei Starovoitov > > > > > > Whe

Re: [PATCH bpf-next] bpf: Fix build without BPF_SYSCALL, but with BPF_JIT.

2020-08-30 Thread Paul E. McKenney
used without > BPF_SYSCALL. > > Reported-by: kernel test robot > Fixes: 1e6c62a88215 ("bpf: Introduce sleepable BPF programs") > Signed-off-by: Alexei Starovoitov A couple of nits below, but overall: Acked-by: Paul E. McKenney > --- > include/linux/rcupdate_trace

Re: [ovs-discuss] Double free in recent kernels after memleak fix

2020-08-10 Thread Paul E. McKenney
On Mon, Aug 10, 2020 at 04:08:59PM -0400, Joel Fernandes wrote: > On Fri, Aug 07, 2020 at 03:20:15PM -0700, Paul E. McKenney wrote: > > On Fri, Aug 07, 2020 at 04:47:56PM -0400, Joel Fernandes wrote: > > > Hi, > > > Adding more of us working on RCU as well. Johan from a

Re: [ovs-discuss] Double free in recent kernels after memleak fix

2020-08-07 Thread Paul E. McKenney
On Fri, Aug 07, 2020 at 04:47:56PM -0400, Joel Fernandes wrote: > Hi, > Adding more of us working on RCU as well. Johan from another team at > Google discovered a likely issue in openswitch, details below: > > On Fri, Aug 7, 2020 at 11:32 AM Johan Knöös wrote: > > > > On Tue, Aug 4, 2020 at 8:52

Re: [PATCH v5 bpf-next 2/5] bpf: Introduce sleepable BPF programs

2020-06-30 Thread Paul E. McKenney
e_disable() and > new bpf_map_release_elem() will do corresponding migrate_enable(). > Or explicit bpf_migrate_disable/enable() helpers will be introduced. > > Signed-off-by: Alexei Starovoitov > Acked-by: Andrii Nakryiko >From an RCU viewpoint: Acked-by: Paul E. McKenney I was going to

Re: [PATCH v5 bpf-next 1/5] bpf: Remove redundant synchronize_rcu.

2020-06-30 Thread Paul E. McKenney
i Starovoitov > Acked-by: Andrii Nakryiko >From an RCU perspective: Acked-by: Paul E. McKenney > --- > kernel/bpf/arraymap.c | 9 - > kernel/bpf/hashtab.c | 8 +++- > kernel/bpf/lpm_trie.c | 5 - > kernel/bpf/queue_stack_maps.c |

Re: [PATCH RFC v3 bpf-next 1/4] bpf: Introduce sleepable BPF programs

2020-06-11 Thread Paul E. McKenney
On Thu, Jun 11, 2020 at 07:13:01PM -0700, Alexei Starovoitov wrote: > On Thu, Jun 11, 2020 at 05:04:47PM -0700, Paul E. McKenney wrote: > > On Thu, Jun 11, 2020 at 03:29:09PM -0700, Alexei Starovoitov wrote: > > > On Thu, Jun 11, 2020 at 3:23 PM Alexei Starov

Re: [PATCH RFC v3 bpf-next 1/4] bpf: Introduce sleepable BPF programs

2020-06-11 Thread Paul E. McKenney
On Thu, Jun 11, 2020 at 03:29:09PM -0700, Alexei Starovoitov wrote: > On Thu, Jun 11, 2020 at 3:23 PM Alexei Starovoitov > wrote: > > > > /* dummy _ops. The verifier will operate on target program's ops. */ > > const struct bpf_verifier_ops bpf_extension_verifier_ops = { > > @@ -205,14 +206,12 @

Re: [PATCH v2 bpf-next 2/7] tools/memory-model: add BPF ringbuf MPSC litmus tests

2020-05-25 Thread Paul E. McKenney
On Mon, May 25, 2020 at 04:33:15PM -0700, Andrii Nakryiko wrote: > On Fri, May 22, 2020 at 11:51 AM Andrii Nakryiko > wrote: > > > > On Thu, May 21, 2020 at 5:34 PM Paul E. McKenney wrote: > > > > > > On Sun, May 17, 2020 at 12:57:22PM -0700, Andrii Nakryiko w

Re: [PATCH v2 bpf-next 1/7] bpf: implement BPF ring buffer and verifier support for it

2020-05-25 Thread Paul E. McKenney
On Fri, May 22, 2020 at 11:46:49AM -0700, Andrii Nakryiko wrote: > On Thu, May 21, 2020 at 5:25 PM Paul E. McKenney wrote: > > > > On Sun, May 17, 2020 at 12:57:21PM -0700, Andrii Nakryiko wrote: > > > This commits adds a new MPSC ring buffer implementation into BPF >

Re: [PATCH v2 bpf-next 2/7] tools/memory-model: add BPF ringbuf MPSC litmus tests

2020-05-21 Thread Paul E. McKenney
en2=1; px=2; > 0:rFail=0; 1:rFail=0; 2:rFail=0; 3:rFail=0; cx=1; len1=1; len2=1; px=3; > 0:rFail=0; 1:rFail=0; 2:rFail=0; 3:rFail=0; cx=2; len1=1; len2=1; px=2; > 0:rFail=0; 1:rFail=0; 2:rFail=0; 3:rFail=0; cx=2; len1=1; len2=1; px=3; > Ok > Witnesses > Positive: 558 Negative:

Re: [PATCH v2 bpf-next 1/7] bpf: implement BPF ring buffer and verifier support for it

2020-05-21 Thread Paul E. McKenney
On Sun, May 17, 2020 at 12:57:21PM -0700, Andrii Nakryiko wrote: > This commits adds a new MPSC ring buffer implementation into BPF ecosystem, > which allows multiple CPUs to submit data to a single shared ring buffer. On > the consumption side, only single consumer is assumed. [ . . . ] Focusing

Re: [PATCH bpf-next 1/6] bpf: implement BPF ring buffer and verifier support for it

2020-05-14 Thread Paul E. McKenney
On Thu, May 14, 2020 at 02:30:11PM -0700, Andrii Nakryiko wrote: > On Thu, May 14, 2020 at 1:39 PM Thomas Gleixner wrote: > > > > Jakub Kicinski writes: > > > > > On Wed, 13 May 2020 12:25:27 -0700 Andrii Nakryiko wrote: > > >> One interesting implementation bit, that significantly simplifies (an

Re: Re: Re: Re: Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

2020-05-06 Thread Paul E. McKenney
On Wed, May 06, 2020 at 02:59:26PM +0200, SeongJae Park wrote: > TL; DR: It was not kernel's fault, but the benchmark program. > > So, the problem is reproducible using the lebench[1] only. I carefully read > it's code again. > > Before running the problem occurred "poll big" sub test, lebench e

Re: Re: Re: Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

2020-05-05 Thread Paul E. McKenney
On Tue, May 05, 2020 at 08:34:02PM +0200, SeongJae Park wrote: > On Tue, 5 May 2020 11:17:07 -0700 "Paul E. McKenney" > wrote: > > > On Tue, May 05, 2020 at 07:56:05PM +0200, SeongJae Park wrote: > > > On Tue, 5 May 2020 10:30:36 -0700 "Paul E. McKenne

Re: Re: Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

2020-05-05 Thread Paul E. McKenney
On Tue, May 05, 2020 at 08:40:07PM +0200, SeongJae Park wrote: > On Tue, 5 May 2020 11:27:20 -0700 "Paul E. McKenney" > wrote: > > > On Tue, May 05, 2020 at 07:49:43PM +0200, SeongJae Park wrote: > > > On Tue, 5 May 2020 10:23:58 -0700 "Paul E. McKenne

Re: Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

2020-05-05 Thread Paul E. McKenney
On Tue, May 05, 2020 at 07:49:43PM +0200, SeongJae Park wrote: > On Tue, 5 May 2020 10:23:58 -0700 "Paul E. McKenney" > wrote: > > > On Tue, May 05, 2020 at 09:25:06AM -0700, Eric Dumazet wrote: > > > > > > > > > On 5/5/20 9:13 AM, Seon

Re: Re: Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

2020-05-05 Thread Paul E. McKenney
On Tue, May 05, 2020 at 07:56:05PM +0200, SeongJae Park wrote: > On Tue, 5 May 2020 10:30:36 -0700 "Paul E. McKenney" > wrote: > > > On Tue, May 05, 2020 at 07:05:53PM +0200, SeongJae Park wrote: > > > On Tue, 5 May 2020 09:37:4

Re: Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

2020-05-05 Thread Paul E. McKenney
On Tue, May 05, 2020 at 07:05:53PM +0200, SeongJae Park wrote: > On Tue, 5 May 2020 09:37:42 -0700 Eric Dumazet wrote: > > > > > > > On 5/5/20 9:31 AM, Eric Dumazet wrote: > > > > > > > > > On 5/5/20 9:25 AM, Eric Dumazet wrote: > > >> > > >> > > >> On 5/5/20 9:13 AM, SeongJae Park wrote: > >

Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

2020-05-05 Thread Paul E. McKenney
On Tue, May 05, 2020 at 09:37:42AM -0700, Eric Dumazet wrote: > > > On 5/5/20 9:31 AM, Eric Dumazet wrote: > > > > > > On 5/5/20 9:25 AM, Eric Dumazet wrote: > >> > >> > >> On 5/5/20 9:13 AM, SeongJae Park wrote: > >>> On Tue, 5 May 2020 09:00:44 -0700 Eric Dumazet > >>> wrote: > >>> > O

Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

2020-05-05 Thread Paul E. McKenney
On Tue, May 05, 2020 at 09:25:06AM -0700, Eric Dumazet wrote: > > > On 5/5/20 9:13 AM, SeongJae Park wrote: > > On Tue, 5 May 2020 09:00:44 -0700 Eric Dumazet wrote: > > > >> On Tue, May 5, 2020 at 8:47 AM SeongJae Park wrote: > >>> > >>> On Tue, 5 May 2020 08:20:50 -0700 Eric Dumazet > >>>

Re: rcu_barrier() + membarrier() + scheduler deadlock?

2020-04-30 Thread Paul E. McKenney
On Thu, Apr 30, 2020 at 09:28:32AM -0400, Qian Cai wrote: > > On Apr 30, 2020, at 9:15 AM, Paul E. McKenney wrote: > >> https://raw.githubusercontent.com/cailca/linux-mm/master/x86.config > >> > >> [53294.651754][T149877] futex_wake_op: trinity-c25 tries t

Re: KCSAN: data-race in find_next_bit / rcu_report_exp_cpu_mult

2019-10-07 Thread Paul E. McKenney
On Mon, Oct 07, 2019 at 12:04:16PM +0200, Marco Elver wrote: > +RCU maintainers > This might be a data-race in RCU itself. Quite possibly. I will take a look, but there will be delays due to this week being bootcamp and all. Thanx, Paul >

Re: inet: frags: Turn fqdir->dead into an int for old Alphas

2019-06-08 Thread Paul E. McKenney
On Sat, Jun 08, 2019 at 10:50:51AM -0700, Linus Torvalds wrote: > On Sat, Jun 8, 2019 at 10:42 AM Linus Torvalds > wrote: > > > > There are no atomic rmw sequences that have reasonable performance for > > the bitfield updates themselves. > > Note that this is purely about the writing side. Reads

Re: [PATCH] inet: frags: Remove unnecessary smp_store_release/READ_ONCE

2019-05-31 Thread Paul E. McKenney
On Fri, May 31, 2019 at 08:45:47AM -0700, Eric Dumazet wrote: > > > On 5/31/19 7:45 AM, Herbert Xu wrote: > > On Fri, May 31, 2019 at 10:24:08AM +0200, Dmitry Vyukov wrote: > >> > >> OK, let's call it barrier. But we need more than a barrier here then. > > > > READ_ONCE/WRITE_ONCE is not some ma

Re: [PATCH v2 6/6] sched: Annotate perf_domain pointer with __rcu

2019-02-25 Thread Paul E. McKenney
ng __rcu will also help sparse catch any future bugs. > > Signed-off-by: Joel Fernandes (Google) >From an RCU perspective: Reviewed-by: Paul E. McKenney > --- > kernel/sched/sched.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sc

Re: [PATCH v2 5/6] rcuwait: Annotate task_struct with __rcu

2019-02-25 Thread Paul E. McKenney
:16: sparse: error: incompatible types in comparison expression > > Signed-off-by: Joel Fernandes (Google) >From an RCU perspective: Reviewed-by: Paul E. McKenney > --- > include/linux/rcuwait.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH v2 4/6] sched_domain: Annotate RCU pointers properly

2019-02-25 Thread Paul E. McKenney
fair.c:9421:16: error: incompatible types in comparison expression > fair.c:9421:16: error: incompatible types in comparison expression > > Signed-off-by: Joel Fernandes (Google) >From an RCU perspective: Reviewed-by: Paul E. McKenney > --- > include/linux/sched/topology.h |

Re: [PATCH v2 3/6] sched/cpufreq: Annotate cpufreq_update_util_data pointer with __rcu

2019-02-25 Thread Paul E. McKenney
arse catch any future RCU misuage bugs. > > Signed-off-by: Joel Fernandes (Google) >From an RCU perspective: Reviewed-by: Paul E. McKenney > --- > kernel/sched/cpufreq.c | 2 +- > kernel/sched/sched.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >

Re: [PATCH v2 2/6] ixgbe: Fix incorrect RCU API usage

2019-02-25 Thread Paul E. McKenney
Signed-off-by: Joel Fernandes (Google) >From an RCU perspective: Reviewed-by: Paul E. McKenney > --- > drivers/net/ethernet/intel/ixgbe/ixgbe.h | 4 ++-- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 15 ++- > 2 files changed, 12 insertions(+), 7 deletions(-) &g

Re: [PATCH v2 1/6] net: rtnetlink: Fix incorrect RCU API usage

2019-02-25 Thread Paul E. McKenney
ab net/core/rtnetlink.c:332:13:got struct > rtnl_link *[noderef] * > > Signed-off-by: Joel Fernandes (Google) >From an RCU perspective: Reviewed-by: Paul E. McKenney > --- > net/core/rtnetlink.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --

Re: [PATCH RFC 3/5] sched/cpufreq: Fix incorrect RCU API usage

2019-02-21 Thread Paul E. McKenney
On Thu, Feb 21, 2019 at 12:13:11PM -0500, Joel Fernandes wrote: > On Thu, Feb 21, 2019 at 05:11:44PM +0100, Peter Zijlstra wrote: > > On Thu, Feb 21, 2019 at 07:52:18AM -0800, Paul E. McKenney wrote: > > > On Thu, Feb 21, 2019 at 04:31:17PM +0100, Peter Zijlstra wrote: > >

Re: [PATCH RFC 3/5] sched/cpufreq: Fix incorrect RCU API usage

2019-02-21 Thread Paul E. McKenney
On Thu, Feb 21, 2019 at 04:31:17PM +0100, Peter Zijlstra wrote: > On Thu, Feb 21, 2019 at 10:21:39AM -0500, Joel Fernandes wrote: > > On Thu, Feb 21, 2019 at 10:18:05AM +0100, Peter Zijlstra wrote: > > > On Thu, Feb 21, 2019 at 12:49:40AM -0500, Joel Fernandes (Google) wrote: > > > > @@ -34,8 +34,1

Re: bpf memory model. Was: [PATCH v4 bpf-next 1/9] bpf: introduce bpf_spin_lock

2019-02-01 Thread Paul E. McKenney
On Thu, Jan 31, 2019 at 10:47:50AM -0800, Alexei Starovoitov wrote: > On Thu, Jan 31, 2019 at 06:01:56AM -0800, Paul E. McKenney wrote: > > On Wed, Jan 30, 2019 at 02:57:43PM -0800, Alexei Starovoitov wrote: > > > On Wed, Jan 30, 2019 at 01:05:36PM -0800, Paul E. McKenney wro

Re: bpf memory model. Was: [PATCH v4 bpf-next 1/9] bpf: introduce bpf_spin_lock

2019-01-31 Thread Paul E. McKenney
On Wed, Jan 30, 2019 at 02:57:43PM -0800, Alexei Starovoitov wrote: > On Wed, Jan 30, 2019 at 01:05:36PM -0800, Paul E. McKenney wrote: > > On Wed, Jan 30, 2019 at 11:51:14AM -0800, Alexei Starovoitov wrote: > > > On Wed, Jan 30, 2019 at 10:36:18AM -0800, Paul E. McKenney wro

Re: bpf memory model. Was: [PATCH v4 bpf-next 1/9] bpf: introduce bpf_spin_lock

2019-01-30 Thread Paul E. McKenney
On Wed, Jan 30, 2019 at 11:51:14AM -0800, Alexei Starovoitov wrote: > On Wed, Jan 30, 2019 at 10:36:18AM -0800, Paul E. McKenney wrote: > > On Wed, Jan 30, 2019 at 06:11:00PM +, Will Deacon wrote: > > > Hi Alexei, > > > > > > On Mon, Jan 28, 2019 at 01:56:

Re: bpf memory model. Was: [PATCH v4 bpf-next 1/9] bpf: introduce bpf_spin_lock

2019-01-30 Thread Paul E. McKenney
On Wed, Jan 30, 2019 at 06:11:00PM +, Will Deacon wrote: > Hi Alexei, > > On Mon, Jan 28, 2019 at 01:56:24PM -0800, Alexei Starovoitov wrote: > > On Mon, Jan 28, 2019 at 10:24:08AM +0100, Peter Zijlstra wrote: > > > On Fri, Jan 25, 2019 at 04:17:26PM -0800, Alexei Starovoitov wrote: > > > > Wh

Re: [PATCH v4 bpf-next 1/9] bpf: introduce bpf_spin_lock

2019-01-25 Thread Paul E. McKenney
On Fri, Jan 25, 2019 at 05:18:12PM +0100, Jann Horn wrote: > On Fri, Jan 25, 2019 at 5:12 AM Paul E. McKenney > wrote: > > On Fri, Jan 25, 2019 at 02:46:55AM +0100, Jann Horn wrote: > > > On Fri, Jan 25, 2019 at 2:22 AM Paul E. McKenney > > > wrote: > > &g

Re: [PATCH v4 bpf-next 1/9] bpf: introduce bpf_spin_lock

2019-01-25 Thread Paul E. McKenney
On Fri, Jan 25, 2019 at 04:47:20AM +, Alexei Starovoitov wrote: > On 1/24/19 8:31 PM, Paul E. McKenney wrote: > > On Fri, Jan 25, 2019 at 04:27:02AM +, Alexei Starovoitov wrote: > >> On 1/24/19 6:38 PM, Alexei Starovoitov wrote: > >>>> For programs created

Re: [PATCH v4 bpf-next 1/9] bpf: introduce bpf_spin_lock

2019-01-24 Thread Paul E. McKenney
On Fri, Jan 25, 2019 at 04:27:02AM +, Alexei Starovoitov wrote: > On 1/24/19 6:38 PM, Alexei Starovoitov wrote: > >> For programs created with CAP_SYS_ADMIN, > >> things get more tricky because you can create your own functions and > >> call them repeatedly; I'm not sure whether the pessimal ru

Re: [PATCH v4 bpf-next 1/9] bpf: introduce bpf_spin_lock

2019-01-24 Thread Paul E. McKenney
On Fri, Jan 25, 2019 at 02:46:55AM +0100, Jann Horn wrote: > On Fri, Jan 25, 2019 at 2:22 AM Paul E. McKenney > wrote: > > On Thu, Jan 24, 2019 at 04:05:16PM -0800, Alexei Starovoitov wrote: > > > On Thu, Jan 24, 2019 at 03:42:32PM -0800, Paul E. McKenney wrote: > >

Re: [PATCH v4 bpf-next 1/9] bpf: introduce bpf_spin_lock

2019-01-24 Thread Paul E. McKenney
On Thu, Jan 24, 2019 at 04:05:16PM -0800, Alexei Starovoitov wrote: > On Thu, Jan 24, 2019 at 03:42:32PM -0800, Paul E. McKenney wrote: > > On Thu, Jan 24, 2019 at 07:56:52PM +0100, Peter Zijlstra wrote: > > > On Thu, Jan 24, 2019 at 07:01:09PM +0100, Peter Zijlstra wrote: >

Re: [PATCH v4 bpf-next 1/9] bpf: introduce bpf_spin_lock

2019-01-24 Thread Paul E. McKenney
On Thu, Jan 24, 2019 at 07:56:52PM +0100, Peter Zijlstra wrote: > On Thu, Jan 24, 2019 at 07:01:09PM +0100, Peter Zijlstra wrote: > > > > Thanks for having kernel/locking people on Cc... > > > > On Wed, Jan 23, 2019 at 08:13:55PM -0800, Alexei Starovoitov wrote: > > > > > Implementation details:

Re: [PATCH RFC 3/4] barriers: convert a control to a data dependency

2019-01-07 Thread Paul E. McKenney
On Mon, Jan 07, 2019 at 02:13:29PM -0500, Michael S. Tsirkin wrote: > On Mon, Jan 07, 2019 at 11:02:36AM -0800, Paul E. McKenney wrote: > > On Mon, Jan 07, 2019 at 08:36:36AM -0500, Michael S. Tsirkin wrote: > > > On Mon, Jan 07, 2019 at 10:46:10AM +0100, Peter Zijlstra wrote: &

Re: [PATCH RFC 3/4] barriers: convert a control to a data dependency

2019-01-07 Thread Paul E. McKenney
On Mon, Jan 07, 2019 at 08:36:36AM -0500, Michael S. Tsirkin wrote: > On Mon, Jan 07, 2019 at 10:46:10AM +0100, Peter Zijlstra wrote: > > On Sun, Jan 06, 2019 at 11:23:07PM -0500, Michael S. Tsirkin wrote: > > > On Mon, Jan 07, 2019 at 11:58:23AM +0800, Jason Wang wrote: > > > > On 2019/1/3 上午4:57,

Re: WARNING in __rcu_read_unlock

2018-12-18 Thread Paul E. McKenney
On Tue, Dec 18, 2018 at 02:26:00PM +0100, Dmitry Vyukov wrote: > On Tue, Dec 18, 2018 at 1:40 PM Stefano Brivio wrote: > > > > On Tue, 18 Dec 2018 09:49:17 +0100 > > Dmitry Vyukov wrote: > > > > > On Tue, Dec 18, 2018 at 12:18 AM Stefano Brivio > > > wrote: > > > > > > > > On Mon, 17 Dec 2018 1

Re: WARNING in __rcu_read_unlock

2018-12-17 Thread Paul E. McKenney
On Mon, Dec 17, 2018 at 07:45:58PM +0100, Dmitry Vyukov wrote: > On Mon, Dec 17, 2018 at 12:29 PM Paul E. McKenney > wrote: > > Any chance of a bisection? > > Better later then never. Bisection also needs testing :) Well, it looks like it did pass the test, arriving at th

Re: WARNING in __rcu_read_unlock

2018-12-17 Thread Paul E. McKenney
On Mon, Dec 17, 2018 at 03:40:06PM +0100, Dmitry Vyukov wrote: > On Mon, Dec 17, 2018 at 3:14 PM Arjan van de Ven > wrote: > > > > On 12/17/2018 3:29 AM, Paul E. McKenney wrote: > > > As does this sort of report on a line that contains simple integer > > &g

Re: WARNING in __rcu_read_unlock

2018-12-17 Thread Paul E. McKenney
On Mon, Dec 17, 2018 at 10:44:52AM +0100, Dmitry Vyukov wrote: > On Sun, Dec 16, 2018 at 8:04 PM Paul E. McKenney > wrote: > > > > On Sat, Dec 15, 2018 at 04:41:03AM -0800, syzbot wrote: > > > Hello, > > > > > > syzbot found the following crash on:

Re: linux-next: manual merge of the rcu tree with the net-next tree

2018-12-10 Thread Paul E. McKenney
On Fri, Dec 07, 2018 at 03:47:07PM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the rcu tree got conflicts in: > > net/bridge/br_mdb.c > net/bridge/br_multicast.c > > between commits: > > 19e3a9c90c53 ("net: bridge: convert multicast to generic rhashtable") >

[tip:core/rcu] net/decnet: Replace rcu_barrier_bh() with rcu_barrier()

2018-12-04 Thread tip-bot for Paul E. McKenney
Commit-ID: dd06d25d06f4932c570540877eba88d868dbba9b Gitweb: https://git.kernel.org/tip/dd06d25d06f4932c570540877eba88d868dbba9b Author: Paul E. McKenney AuthorDate: Wed, 7 Nov 2018 15:12:34 -0800 Committer: Paul E. McKenney CommitDate: Sat, 1 Dec 2018 12:38:51 -0800 net/decnet

[tip:core/rcu] net/core/skmsg: Replace call_rcu_sched() with call_rcu()

2018-12-04 Thread tip-bot for Paul E. McKenney
Commit-ID: 0245b80e284d4fdabbf50589180482dc4d2cf277 Gitweb: https://git.kernel.org/tip/0245b80e284d4fdabbf50589180482dc4d2cf277 Author: Paul E. McKenney AuthorDate: Wed, 7 Nov 2018 15:09:25 -0800 Committer: Paul E. McKenney CommitDate: Sat, 1 Dec 2018 12:38:50 -0800 net/core/skmsg

[tip:core/rcu] net/bridge: Replace call_rcu_bh() and rcu_barrier_bh()

2018-12-04 Thread tip-bot for Paul E. McKenney
Commit-ID: 1a56f7d53b5c8e82442e86eeac0b5d549088ee42 Gitweb: https://git.kernel.org/tip/1a56f7d53b5c8e82442e86eeac0b5d549088ee42 Author: Paul E. McKenney AuthorDate: Tue, 6 Nov 2018 19:45:50 -0800 Committer: Paul E. McKenney CommitDate: Sat, 1 Dec 2018 12:38:48 -0800 net/bridge

[tip:core/rcu] net/core: Replace call_rcu_bh() and synchronize_rcu_bh()

2018-12-04 Thread tip-bot for Paul E. McKenney
Commit-ID: 5da54c1810e52f7abba0ff7932761f945875 Gitweb: https://git.kernel.org/tip/5da54c1810e52f7abba0ff7932761f945875 Author: Paul E. McKenney AuthorDate: Tue, 6 Nov 2018 19:43:32 -0800 Committer: Paul E. McKenney CommitDate: Sat, 1 Dec 2018 12:38:47 -0800 net/core: Replace

[tip:core/rcu] net/sched: Replace call_rcu_bh() and rcu_barrier_bh()

2018-12-04 Thread tip-bot for Paul E. McKenney
Commit-ID: ae0e33494a601e13df79c4742d88d4d2bc2b0a87 Gitweb: https://git.kernel.org/tip/ae0e33494a601e13df79c4742d88d4d2bc2b0a87 Author: Paul E. McKenney AuthorDate: Tue, 6 Nov 2018 19:40:39 -0800 Committer: Paul E. McKenney CommitDate: Sat, 1 Dec 2018 12:38:46 -0800 net/sched: Replace

[tip:core/rcu] drivers/vhost: Replace synchronize_rcu_bh() with synchronize_rcu()

2018-12-04 Thread tip-bot for Paul E. McKenney
Commit-ID: d05faa5f1ac50beef77b4ceba0e8e157d41146e2 Gitweb: https://git.kernel.org/tip/d05faa5f1ac50beef77b4ceba0e8e157d41146e2 Author: Paul E. McKenney AuthorDate: Mon, 5 Nov 2018 17:14:53 -0800 Committer: Paul E. McKenney CommitDate: Tue, 27 Nov 2018 09:21:37 -0800 drivers/vhost

[tip:core/rcu] ethernet/realtek: Replace synchronize_sched() with synchronize_rcu()

2018-12-04 Thread tip-bot for Paul E. McKenney
Commit-ID: 16f11500842ce022fe654e38bd447e15790911dd Gitweb: https://git.kernel.org/tip/16f11500842ce022fe654e38bd447e15790911dd Author: Paul E. McKenney AuthorDate: Mon, 5 Nov 2018 17:07:39 -0800 Committer: Paul E. McKenney CommitDate: Tue, 27 Nov 2018 09:21:37 -0800 ethernet/realtek

[tip:core/rcu] ethernet/sis: Replace synchronize_sched() with synchronize_rcu()

2018-12-04 Thread tip-bot for Paul E. McKenney
Commit-ID: fd8e688b0e8cc0c0a8ca18acb69cb8397ed62eec Gitweb: https://git.kernel.org/tip/fd8e688b0e8cc0c0a8ca18acb69cb8397ed62eec Author: Paul E. McKenney AuthorDate: Mon, 5 Nov 2018 17:05:08 -0800 Committer: Paul E. McKenney CommitDate: Tue, 27 Nov 2018 09:21:36 -0800 ethernet/sis

Re: [PATCH bpf-next 2/3] tools, perf: use smp_{rmb,mb} barriers instead of {rmb,mb}

2018-10-19 Thread Paul E. McKenney
On Fri, Oct 19, 2018 at 12:02:43PM +0100, Will Deacon wrote: > On Thu, Oct 18, 2018 at 08:53:42PM -0700, Alexei Starovoitov wrote: > > On Thu, Oct 18, 2018 at 09:00:46PM +0200, Daniel Borkmann wrote: > > > On 10/18/2018 05:33 PM, Alexei Starovoitov wrote: > > > > On Thu, Oct 18, 2018 at 05:04:34PM

Re: [PATCH 2/5] rhashtable: don't hold lock on first table throughout insertion.

2018-07-25 Thread Paul E. McKenney
On Wed, Jul 25, 2018 at 02:53:36PM +1000, NeilBrown wrote: > On Tue, Jul 24 2018, Paul E. McKenney wrote: > > > On Tue, Jul 24, 2018 at 07:52:03AM +1000, NeilBrown wrote: > >> On Mon, Jul 23 2018, Paul E. McKenney wrote: > >> > >> > On Mon, Jul 23,

[tip:core/rcu] netfilter: Remove now-redundant smp_read_barrier_depends()

2018-01-03 Thread tip-bot for Paul E. McKenney
Commit-ID: 4be2b04e43fd3d8164d7aeb1808e47fbeb0c0de0 Gitweb: https://git.kernel.org/tip/4be2b04e43fd3d8164d7aeb1808e47fbeb0c0de0 Author: Paul E. McKenney AuthorDate: Mon, 9 Oct 2017 12:09:04 -0700 Committer: Paul E. McKenney CommitDate: Mon, 4 Dec 2017 10:52:57 -0800 netfilter: Remove

[tip:core/rcu] drivers/vhost: Remove now-redundant read_barrier_depends()

2018-01-03 Thread tip-bot for Paul E. McKenney
Commit-ID: 3a5db0b108e0a40f08c2bcff6a675dbf632b91e0 Gitweb: https://git.kernel.org/tip/3a5db0b108e0a40f08c2bcff6a675dbf632b91e0 Author: Paul E. McKenney AuthorDate: Mon, 27 Nov 2017 09:45:10 -0800 Committer: Paul E. McKenney CommitDate: Tue, 5 Dec 2017 11:57:55 -0800 drivers/vhost

[tip:core/rcu] drivers/net/ethernet/qlogic/qed: Fix __qed_spq_block() ordering

2018-01-03 Thread tip-bot for Paul E. McKenney
Commit-ID: cb7e125e03274cffa97d74433c876765efffaf6a Gitweb: https://git.kernel.org/tip/cb7e125e03274cffa97d74433c876765efffaf6a Author: Paul E. McKenney AuthorDate: Mon, 9 Oct 2017 09:26:25 -0700 Committer: Paul E. McKenney CommitDate: Mon, 4 Dec 2017 10:52:52 -0800 drivers/net

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

2017-12-05 Thread Paul E. McKenney
On Wed, Dec 06, 2017 at 12:09:36AM +0200, Michael S. Tsirkin wrote: > On Tue, Dec 05, 2017 at 10:57:00PM +0100, Peter Zijlstra wrote: > > On Tue, Dec 05, 2017 at 11:24:49PM +0200, Michael S. Tsirkin wrote: > > > READ_ONCE is really all over the place (some code literally replaced all > > > memory a

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

2017-12-05 Thread Paul E. McKenney
On Tue, Dec 05, 2017 at 11:43:41PM +0200, Michael S. Tsirkin wrote: > On Tue, Dec 05, 2017 at 01:36:44PM -0800, Paul E. McKenney wrote: > > On Tue, Dec 05, 2017 at 11:24:49PM +0200, Michael S. Tsirkin wrote: > > > On Tue, Dec 05, 2017 at 12:08:01PM -0800, Paul E. McKenney wro

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

2017-12-05 Thread Paul E. McKenney
On Tue, Dec 05, 2017 at 11:24:49PM +0200, Michael S. Tsirkin wrote: > On Tue, Dec 05, 2017 at 12:08:01PM -0800, Paul E. McKenney wrote: > > On Tue, Dec 05, 2017 at 09:51:48PM +0200, Michael S. Tsirkin wrote: > > > On Tue, Dec 05, 2017 at 11:33:39AM -0800, Paul E. McKenney wro

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

2017-12-05 Thread Paul E. McKenney
On Tue, Dec 05, 2017 at 09:51:48PM +0200, Michael S. Tsirkin wrote: > On Tue, Dec 05, 2017 at 11:33:39AM -0800, Paul E. McKenney wrote: > > On Tue, Dec 05, 2017 at 09:24:21PM +0200, Michael S. Tsirkin wrote: [ . . . ] > > > and this barrier is no longer paired with anythi

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

2017-12-05 Thread Paul E. McKenney
On Tue, Dec 05, 2017 at 09:24:21PM +0200, Michael S. Tsirkin wrote: > On Tue, Dec 05, 2017 at 08:17:33PM +0100, Peter Zijlstra wrote: > > On Tue, Dec 05, 2017 at 08:57:46PM +0200, Michael S. Tsirkin wrote: > > > > > I don't see WRITE_ONCE inserting any barriers, release or > > > write. > > > > Co

[PATCH tip/core/rcu 14/21] netfilter: Remove now-redundant smp_read_barrier_depends()

2017-12-01 Thread Paul E. McKenney
READ_ONCE() now implies smp_read_barrier_depends(), which means that the instances in arpt_do_table(), ipt_do_table(), and ip6t_do_table() are now redundant. This commit removes them and adjusts the comments. Signed-off-by: Paul E. McKenney Cc: Pablo Neira Ayuso Cc: Jozsef Kadlecsik Cc

[PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

2017-12-01 Thread Paul E. McKenney
Because READ_ONCE() now implies read_barrier_depends(), the read_barrier_depends() in next_desc() is now redundant. This commit therefore removes it and the related comments. Signed-off-by: Paul E. McKenney Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: Cc: Cc: --- drivers/vhost/v

[PATCH tip/core/rcu 03/21] drivers/net/ethernet/qlogic/qed: Fix __qed_spq_block() ordering

2017-12-01 Thread Paul E. McKenney
smp_read_barrier_depends(). Signed-off-by: Paul E. McKenney Cc: Ariel Elior Cc: Cc: --- drivers/net/ethernet/qlogic/qed/qed_spq.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_spq.c b/drivers/net/ethernet/qlogic/qed/qed_spq.c index

Re: [Patch net 01/16] net_sched: introduce a workqueue for RCU callbacks of tc filter

2017-10-27 Thread Paul E. McKenney
On Thu, Oct 26, 2017 at 09:39:26PM -0700, Eric Dumazet wrote: > On Thu, 2017-10-26 at 21:28 -0700, Cong Wang wrote: > > On Thu, Oct 26, 2017 at 9:05 PM, Eric Dumazet > > wrote: > > > On Thu, 2017-10-26 at 18:24 -0700, Cong Wang wrote: > > >> ... > > > > > >> On the other hand, this makes tcf_bloc

Re: [Patch net 00/15] net_sched: remove RCU callbacks from TC

2017-10-26 Thread Paul E. McKenney
On Wed, Oct 25, 2017 at 09:49:09PM -0700, Cong Wang wrote: > On Wed, Oct 25, 2017 at 5:19 PM, Paul E. McKenney > wrote: > > On Wed, Oct 25, 2017 at 03:37:40PM -0700, Cong Wang wrote: > >> My solution is introducing a workqueue for tc filters > >> and let each RCU c

Re: [Patch net 00/15] net_sched: remove RCU callbacks from TC

2017-10-25 Thread Paul E. McKenney
On Wed, Oct 25, 2017 at 03:37:40PM -0700, Cong Wang wrote: > On Tue, Oct 24, 2017 at 6:43 PM, David Miller wrote: > > From: Cong Wang > > Date: Mon, 23 Oct 2017 15:02:49 -0700 > > > >> Recently, the RCU callbacks used in TC filters and TC actions keep > >> drawing my attention, they introduce at

Re: Get rid of RCU callbacks in TC filters?

2017-10-20 Thread Paul E. McKenney
On Thu, Oct 19, 2017 at 08:26:01PM -0700, Cong Wang wrote: > On Wed, Oct 18, 2017 at 12:35 PM, Paul E. McKenney > wrote: > > On Wed, Oct 18, 2017 at 10:36:28AM -0700, Cong Wang wrote: > >> Hi, all > >> > >> Recently, the RCU callbacks used in TC filt

Re: Get rid of RCU callbacks in TC filters?

2017-10-18 Thread Paul E. McKenney
On Wed, Oct 18, 2017 at 10:36:28AM -0700, Cong Wang wrote: > Hi, all > > Recently, the RCU callbacks used in TC filters and TC actions keep > drawing my attention, they introduce at least 4 race condition bugs: > > 1. A simple one fixed by Daniel: > > commit c78e1746d3ad7d548bdf3fe491898cc453911

Re: [PATCH 0/4] RCU: introduce noref debug

2017-10-11 Thread Paul E. McKenney
On Wed, Oct 11, 2017 at 04:50:36PM +0200, Paolo Abeni wrote: > On Tue, 2017-10-10 at 21:02 -0700, Paul E. McKenney wrote: > > Linus and Ingo will ask me how users decide how they should set that > > additional build flag. Especially given that if there is code that > >

Re: [PATCH 0/4] RCU: introduce noref debug

2017-10-10 Thread Paul E. McKenney
On Mon, Oct 09, 2017 at 06:53:12PM +0200, Paolo Abeni wrote: > On Fri, 2017-10-06 at 09:34 -0700, Paul E. McKenney wrote: > > On Fri, Oct 06, 2017 at 05:10:09PM +0200, Paolo Abeni wrote: > > > Hi, > > > > > > On Fri, 2017-10-06 at 06:34 -0700, Paul E. McKenney

Re: [PATCH RFC tip/core/rcu 14/15] netfilter: Remove now-redundant smp_read_barrier_depends()

2017-10-10 Thread Paul E. McKenney
On Tue, Oct 10, 2017 at 10:43:34AM +0200, Peter Zijlstra wrote: > On Mon, Oct 09, 2017 at 05:22:48PM -0700, Paul E. McKenney wrote: > > READ_ONCE() now implies smp_read_barrier_depends(), which means that > > the instances in arpt_do_table(), ipt_do_table(), and ip6t_do_tabl

[PATCH RFC tip/core/rcu 03/15] drivers/net/ethernet/qlogic/qed: Fix __qed_spq_block() ordering

2017-10-09 Thread Paul E. McKenney
smp_read_barrier_depends(). Signed-off-by: Paul E. McKenney Cc: Ariel Elior Cc: Cc: --- drivers/net/ethernet/qlogic/qed/qed_spq.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_spq.c b/drivers/net/ethernet/qlogic/qed/qed_spq.c index

[PATCH RFC tip/core/rcu 14/15] netfilter: Remove now-redundant smp_read_barrier_depends()

2017-10-09 Thread Paul E. McKenney
READ_ONCE() now implies smp_read_barrier_depends(), which means that the instances in arpt_do_table(), ipt_do_table(), and ip6t_do_table() are now redundant. This commit removes them and adjusts the comments. Signed-off-by: Paul E. McKenney Cc: Pablo Neira Ayuso Cc: Jozsef Kadlecsik Cc

Re: [PATCH 0/4] RCU: introduce noref debug

2017-10-06 Thread Paul E. McKenney
On Fri, Oct 06, 2017 at 05:10:09PM +0200, Paolo Abeni wrote: > Hi, > > On Fri, 2017-10-06 at 06:34 -0700, Paul E. McKenney wrote: > > On Fri, Oct 06, 2017 at 02:57:45PM +0200, Paolo Abeni wrote: > > > The networking subsystem is currently using some kind of long-l

Re: [PATCH 0/4] RCU: introduce noref debug

2017-10-06 Thread Paul E. McKenney
On Fri, Oct 06, 2017 at 02:57:45PM +0200, Paolo Abeni wrote: > The networking subsystem is currently using some kind of long-lived > RCU-protected, references to avoid the overhead of full book-keeping. > > Such references - skb_dst() noref - are stored inside the skbs and can be > moved across re

  1   2   3   4   >