Re: [PATCH net-next v3 1/2] net: dsa: mv88e6xxx: Introduce _mv88e6xxx_phy_page_{read,write}

2016-03-30 Thread Patrick Uiterwijk
Hi, Could this patch and the patch 2/2 v3 "net: dsa: mv88e6xxx: Clear the PDOWN bit on setup" be put on net, since this fixes a bug with the clearfog, which was introduced in v4.5? Thanks, Patrick On Wed, Mar 30, 2016 at 1:39 AM, Patrick Uiterwijk wrote: > Add versions of the phy_

[PATCH net-next v3 2/2] net: dsa: mv88e6xxx: Clear the PDOWN bit on setup

2016-03-29 Thread Patrick Uiterwijk
is patch checks whether this flag has been clear prior by something else, and if not make us clear it. Reviewed-by: Andrew Lunn Signed-off-by: Patrick Uiterwijk --- drivers/net/dsa/mv88e6xxx.c | 36 drivers/net/dsa/mv88e6xxx.h | 8 2 files changed

[PATCH net-next v3 1/2] net: dsa: mv88e6xxx: Introduce _mv88e6xxx_phy_page_{read,write}

2016-03-29 Thread Patrick Uiterwijk
Add versions of the phy_page_read and _write functions to be used in a context where the SMI mutex is held. Tested-by: Vivien Didelot Reviewed-by: Vivien Didelot Signed-off-by: Patrick Uiterwijk --- drivers/net/dsa/mv88e6xxx.c | 49 + 1 file changed

Re: [PATCH net-next v2 2/2] net: dsa: mv88e6xxx: Clear the PDOWN bit on setup

2016-03-29 Thread Patrick Uiterwijk
Hi Vivien, On Tue, Mar 29, 2016 at 6:49 PM, Vivien Didelot wrote: > Hi Andrew, Patrick, > > Andrew Lunn writes: > >> On Tue, Mar 29, 2016 at 12:23:06PM -0400, Vivien Didelot wrote: >>> Hi Patrick, >>> >>> Two comments below. >>>

[PATCH net-next v2 2/2] net: dsa: mv88e6xxx: Clear the PDOWN bit on setup

2016-03-29 Thread Patrick Uiterwijk
is patch checks whether this flag has been clear prior by something else, and if not make us clear it. Signed-off-by: Patrick Uiterwijk --- drivers/net/dsa/mv88e6xxx.c | 36 drivers/net/dsa/mv88e6xxx.h | 8 2 files changed, 44 insertions(+) diff --gi

[PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Introduce _mv88e6xxx_phy_page_{read,write}

2016-03-29 Thread Patrick Uiterwijk
Add versions of the phy_page_read and _write functions to be used in a context where the SMI mutex is held. Signed-off-by: Patrick Uiterwijk --- drivers/net/dsa/mv88e6xxx.c | 49 + 1 file changed, 36 insertions(+), 13 deletions(-) diff --git a

Re: [PATCH 1/2] net: dsa: mv88e6xxx: Introduce _mv88e6xxx_phy_page_{read,write}

2016-03-25 Thread Patrick Uiterwijk
On Sat, Mar 26, 2016 at 2:45 AM, Guenter Roeck wrote: > On 03/25/2016 05:10 PM, Patrick Uiterwijk wrote: >> >> Add versions of the phy_page_read and _write functions to >> be used in a context where the SMI mutex is held. >> >> Signed-off-by: Patrick Uiter

[PATCH 1/2] net: dsa: mv88e6xxx: Introduce _mv88e6xxx_phy_page_{read,write}

2016-03-25 Thread Patrick Uiterwijk
Add versions of the phy_page_read and _write functions to be used in a context where the SMI mutex is held. Signed-off-by: Patrick Uiterwijk --- drivers/net/dsa/mv88e6xxx.c | 42 -- 1 file changed, 32 insertions(+), 10 deletions(-) diff --git a/drivers

[PATCH 2/2] net: dsa: mv88e6xxx: Clear the PDOWN bit on setup

2016-03-25 Thread Patrick Uiterwijk
is patch checks whether this flag has been clear prior by something else, and if not make us clear it. Signed-off-by: Patrick Uiterwijk --- drivers/net/dsa/mv88e6xxx.c | 99 +++-- drivers/net/dsa/mv88e6xxx.h | 8 2 files changed, 76 insertions(+