Re: [PATCH net-next] mcast: ensure L-L IPv6 packets are accepted by bridge

2019-08-14 Thread Patrick Ruddy
that this is a bridge change > better, please rearrange it like so - bridge: mcast: ... > More below, > > > On Tue, Aug 13, 2019 at 03:18:04PM +0100, Patrick Ruddy wrote: > > > At present only all-nodes IPv6 multicast packets are accepted by > > > a bridge int

[PATCH net-next] mcast: ensure L-L IPv6 packets are accepted by bridge

2019-08-13 Thread Patrick Ruddy
multicast router mode. This aligns the code with IPv4 link-local reception and RFC4291 Signed-off-by: Patrick Ruddy --- include/net/addrconf.h| 15 +++ net/bridge/br_multicast.c | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/include/net/addrconf.h b

Re: [PATCH net-next v3 1/2] netlink: ipv4 igmp join notifications

2018-09-25 Thread Patrick Ruddy
On Wed, 2018-09-19 at 21:47 -0700, David Ahern wrote: > On 9/18/18 6:12 AM, Patrick Ruddy wrote: > > > > I've hit a small snag with adding the new groups. The number of defined > > groups currently sits at 31 so I can only add one before hitting the > > I be

Re: [PATCH net-next v3 1/2] netlink: ipv4 igmp join notifications

2018-09-18 Thread Patrick Ruddy
On Thu, 2018-09-13 at 10:03 -0700, Roopa Prabhu wrote: > On Thu, Sep 6, 2018 at 8:40 PM, Roopa Prabhu > wrote: > > On Thu, Sep 6, 2018 at 2:10 AM, Patrick Ruddy > > wrote: > > > Some userspace applications need to know about IGMP joins from the > > > kernel

Re: [PATCH net-next v3 1/2] netlink: ipv4 igmp join notifications

2018-09-13 Thread Patrick Ruddy
On Thu, 2018-09-13 at 10:03 -0700, Roopa Prabhu wrote: > On Thu, Sep 6, 2018 at 8:40 PM, Roopa Prabhu > wrote: > > On Thu, Sep 6, 2018 at 2:10 AM, Patrick Ruddy > > wrote: > > > Some userspace applications need to know about IGMP joins from the > > > kernel

[PATCH net-next v3 2/2] netlink: ipv6 MLD join notifications

2018-09-06 Thread Patrick Ruddy
multicast addresses using the RTM_NEWMDB and RTM_DELMDB messages with AF_INET6. It also provides the RTM_GETMDB extension to allow multicast join state to be read from the kernel. Signed-off-by: Patrick Ruddy --- v3 rework to use RTM_***MDB messages as per review comments. net/ipv6/addrconf.c | 34

[PATCH net-next v3 1/2] netlink: ipv4 igmp join notifications

2018-09-06 Thread Patrick Ruddy
multicast addresses using the RTM_NEWMDB and RTM_DELMDB messages with AF_INET. It also provides the RTM_GETMDB extension to allow multicast join state to be read from the kernel. Signed-off-by: Patrick Ruddy --- v3 rework to use RTM_***MDB messages as per review comments. net/ipv4/igmp.c | 139

Re: [PATCH net-next v2 1/2] netlink: ipv4 igmp join notifications

2018-09-04 Thread Patrick Ruddy
On Mon, 2018-09-03 at 16:12 -0700, Roopa Prabhu wrote: > On Sun, Sep 2, 2018 at 4:18 AM, Patrick Ruddy > wrote: > > Hi Roopa > > > > inline > > > > thx > > > > -pr > > > > On Fri, 2018-08-31 at 09:29 -0700, Roopa Prabhu wrote: >

Re: [PATCH net-next v2 1/2] netlink: ipv4 igmp join notifications

2018-09-04 Thread Patrick Ruddy
On Mon, 2018-09-03 at 16:12 -0700, Roopa Prabhu wrote: > On Sun, Sep 2, 2018 at 4:18 AM, Patrick Ruddy > wrote: > > Hi Roopa > > > > inline > > > > thx > > > > -pr > > > > On Fri, 2018-08-31 at 09:29 -0700, Roopa Prabhu wrote: >

Re: [PATCH net-next v2 1/2] netlink: ipv4 igmp join notifications

2018-09-02 Thread Patrick Ruddy
Hi Roopa inline thx -pr On Fri, 2018-08-31 at 09:29 -0700, Roopa Prabhu wrote: > On Fri, Aug 31, 2018 at 4:20 AM, Patrick Ruddy > wrote: > > Some userspace applications need to know about IGMP joins from the kernel > > for 2 reasons > > 1. To allow the programming of

[PATCH net-next v2 2/2] netlink: ipv6 MLD join notifications

2018-08-31 Thread Patrick Ruddy
multicast addresses using the RTM_NEWADDR and RTM_DELADDR messages. It also provides the RTM_GETADDR extension to allow multicast join state to be read from the kernel. Signed-off-by: Patrick Ruddy --- v2: fix kbuild issues. net/ipv6/addrconf.c | 44 +- net/ipv6/mcast.c

[PATCH net-next v2 1/2] netlink: ipv4 igmp join notifications

2018-08-31 Thread Patrick Ruddy
multicast addresses using the RTM_NEWADDR and RTM_DELADDR messages. It also provides the RTM_GETADDR extension to allow multicast join state to be read from the kernel. Signed-off-by: Patrick Ruddy --- v2: fix kbuild warnings. include/linux/igmp.h | 4 ++ net/ipv4/devinet.c | 39

[PATCH net-next 0/2] netlink: multicast join notifications

2018-08-30 Thread Patrick Ruddy
address families has been modified to include the multicast l3 addresses. Patrick Ruddy (2): netlink: ipv4 IGMP join notifications netlink: ipv6 MLD join notifications include/linux/igmp.h | 2 + net/ipv4/devinet.c | 39 +-- net/ipv4/igmp.c | 90

Re: [PATCH net-next 1/2] netlink: ipv4 IGMP join notifications

2018-08-30 Thread Patrick Ruddy
in a RTM_NEW/DELADDR and blindly dereference it. Finally the RTM_GETADDR for both address families has been modified to include the multicast l3 addresses. Patrick Ruddy (2): netlink: ipv4 IGMP join notifications netlink: ipv6 MLD join notifications include/linux/igmp.h | 2 + net/ipv4/devi

[PATCH net-next 1/2] netlink: ipv4 IGMP join notifications

2018-08-30 Thread Patrick Ruddy
multicast addresses using the RTM_NEWADDR and RTM_DELADDR messages. It also provides the RTM_GETADDR extension to allow multicast join state to be read from the kernel. Signed-off-by: Patrick Ruddy --- include/linux/igmp.h | 2 + net/ipv4/devinet.c | 39 +-- net/ipv4/igmp.c

[PATCH net-next 2/2] netlink: ipv6 MLD join notifications

2018-08-30 Thread Patrick Ruddy
multicast addresses using the RTM_NEWADDR and RTM_DELADDR messages. It also provides the RTM_GETADDR extension to allow multicast join state to be read from the kernel. Signed-off-by: Patrick Ruddy --- net/ipv6/addrconf.c | 44 +- net/ipv6/mcast.c| 66

Re: [net-next PATCH] net: netlink messages for HW addr programming

2016-10-03 Thread Patrick Ruddy
On Tue, 2016-09-20 at 07:49 +0200, Jiri Pirko wrote: > Tue, Sep 20, 2016 at 07:31:27AM CEST, ro...@cumulusnetworks.com wrote: > >On 9/19/16, 7:46 AM, Patrick Ruddy wrote: > >> On Sun, 2016-09-18 at 07:51 -0700, Roopa Prabhu wrote: > >>> On 9/15/16, 9:48 AM, P

Re: [net-next PATCH] net: netlink messages for HW addr programming

2016-09-19 Thread Patrick Ruddy
On Sun, 2016-09-18 at 07:51 -0700, Roopa Prabhu wrote: > On 9/15/16, 9:48 AM, Patrick Ruddy wrote: > > Add RTM_NEWADDR and RTM_DELADDR netlink messages with family > > AF_UNSPEC to indicate interest in specific unicast and multicast > > hardware addresses. These messages ar

[net-next PATCH] net: netlink messages for HW addr programming

2016-09-15 Thread Patrick Ruddy
notifications to be replayed to avoid loss of state due to application start ordering or restart. Signed-off-by: Patrick Ruddy --- include/linux/netdevice.h | 1 + net/core/dev_addr_lists.c | 157 -- net/core/rtnetlink.c | 8 ++- 3 files

Re: [PATCH] Netlink messages for multicast HW addr programming

2016-02-03 Thread Patrick Ruddy
ssages > >> >> >are sent when addressed are added or deleted from the appropriate > >> >> >interface driver. > >> >> > > >> >> >Signed-off-by: Patrick Ruddy > >> >> > > >> >> >diff --git a/net/core/

Re: [PATCH] Netlink messages for multicast HW addr programming

2016-01-22 Thread Patrick Ruddy
d RTM_DELADDR netlink messages to indicate > >> >interest in specific multicast hardware addresses. These messages > >> >are sent when addressed are added or deleted from the appropriate > >> >interface driver. > >> > > >> >Si

Re: [PATCH] Netlink messages for multicast HW addr programming

2016-01-22 Thread Patrick Ruddy
are added or deleted from the appropriate > >interface driver. > > > >Signed-off-by: Patrick Ruddy > > > >diff --git a/net/core/dev_addr_lists.c b/net/core/dev_addr_lists.c > >index c0548d2..a0ebadd 100644 > >--- a/net/core/dev_ad

[PATCH] Netlink messages for multicast HW addr programming

2016-01-21 Thread Patrick Ruddy
Add RTM_NEWADDR and RTM_DELADDR netlink messages to indicate interest in specific multicast hardware addresses. These messages are sent when addressed are added or deleted from the appropriate interface driver. Signed-off-by: Patrick Ruddy diff --git a/net/core/dev_addr_lists.c b/net/core