Re: [PATCH net 1/4] net: freescale/fman: Split the main resource region reservation

2020-12-10 Thread Patrick Havelange
On 2020-12-10 10:05, Madalin Bucur wrote: -Original Message- From: Patrick Havelange [snipped] But then that change would not be compatible with the existing device trees in already existing hardware. I'm not sure how to handle that case properly. One needs to be back

Re: [PATCH net 1/4] net: freescale/fman: Split the main resource region reservation

2020-12-10 Thread Patrick Havelange
On 2020-12-09 19:55, Madalin Bucur wrote: -Original Message- From: Patrick Havelange Sent: 09 December 2020 16:17 To: Madalin Bucur ; David S. Miller ; Jakub Kicinski ; netdev@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: [PATCH net 1/4] net: freescale/fman: Split the main

Re: [PATCH net 1/4] net: freescale/fman: Split the main resource region reservation

2020-12-09 Thread Patrick Havelange
area. I'm assuming this is the problem you are trying to address here, besides the stack corruption issue. Yes exactly. I did not add this behaviour (having a main region and subdrivers using subregions), I'm just trying to correct what is already there. For example: this is some content of /pro

Re: [PATCH net 1/4] net: freescale/fman: Split the main resource region reservation

2020-12-08 Thread Patrick Havelange
On 2020-12-03 16:47, Madalin Bucur wrote: -Original Message- From: Patrick Havelange Sent: 03 December 2020 15:51 To: Madalin Bucur ; David S. Miller ; Jakub Kicinski ; netdev@vger.kernel.org; linux-ker...@vger.kernel.org Cc: Patrick Havelange Subject: [PATCH net 1/4] net: freescale

Re: [PATCH 2/4] net: freescale/fman-port: remove direct use of __devm_request_region

2020-12-03 Thread Patrick Havelange
On 2020-12-03 09:44, Madalin Bucur wrote: -Original Message- From: Patrick Havelange Sent: 02 December 2020 18:16 To: Madalin Bucur ; David S. Miller ; Jakub Kicinski ; netdev@vger.kernel.org; linux-ker...@vger.kernel.org Cc: Patrick Havelange Subject: [PATCH 2/4] net: freescale/fman

[PATCH net 3/4] net: freescale/fman-mac: remove direct use of __devm_request_region

2020-12-03 Thread Patrick Havelange
Since the main fman driver is no longer reserving the complete fman memory region, it is no longer needed to use a custom call to __devm_request_region, so replace it with devm_request_mem_region Signed-off-by: Patrick Havelange --- drivers/net/ethernet/freescale/fman/mac.c | 8 +++- 1 file

[PATCH net 4/4] net: freescale/fman: remove fman_get_mem_region

2020-12-03 Thread Patrick Havelange
This function is no longer used, so we can remove it. The pointer to the resource that was kept inside struct fman_state_struct can also be removed for the same reason. Signed-off-by: Patrick Havelange --- drivers/net/ethernet/freescale/fman/fman.c | 17 - drivers/net/ethernet

[PATCH net 1/4] net: freescale/fman: Split the main resource region reservation

2020-12-03 Thread Patrick Havelange
: Patrick Havelange --- drivers/net/ethernet/freescale/fman/fman.c | 103 + drivers/net/ethernet/freescale/fman/fman.h | 9 +- 2 files changed, 69 insertions(+), 43 deletions(-) diff --git a/drivers/net/ethernet/freescale/fman/fman.c b/drivers/net/ethernet/freescale/fman/fman.c

[PATCH net 2/4] net: freescale/fman-port: remove direct use of __devm_request_region

2020-12-03 Thread Patrick Havelange
same time. Signed-off-by: Patrick Havelange --- drivers/net/ethernet/freescale/fman/fman_port.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/freescale/fman/fman_port.c b/drivers/net/ethernet/freescale/fman/fman_port.c index d9baac0dbc7d..354974939d9d 10

[PATCH net 0/4] freescale/fman: remove usage of __devm_request_region

2020-12-03 Thread Patrick Havelange
ilar change, let's do it at the same time. I think they all should be part of the same series. Patrick Havelange (4): net: freescale/fman: Split the main resource region reservation net: freescale/fman-port: remove direct use of __devm_request_region net: freescale/fman-mac: remove dire

[PATCH 3/4] net: freescale/fman-mac: remove direct use of __devm_request_region

2020-12-02 Thread Patrick Havelange
Since the main fman driver is no longer reserving the complete fman memory region, it is no longer needed to use a custom call to __devm_request_region, so replace it with devm_request_mem_region Signed-off-by: Patrick Havelange --- drivers/net/ethernet/freescale/fman/mac.c | 8 +++- 1 file

[PATCH 4/4] net: freescale/fman: remove fman_get_mem_region

2020-12-02 Thread Patrick Havelange
This function is no longer used, so we can remove it. The pointer to the resource that was kept inside struct fman_state_struct can also be removed for the same reason. Signed-off-by: Patrick Havelange --- drivers/net/ethernet/freescale/fman/fman.c | 17 - drivers/net/ethernet

[PATCH 2/4] net: freescale/fman-port: remove direct use of __devm_request_region

2020-12-02 Thread Patrick Havelange
same time. Signed-off-by: Patrick Havelange --- drivers/net/ethernet/freescale/fman/fman_port.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/freescale/fman/fman_port.c b/drivers/net/ethernet/freescale/fman/fman_port.c index d9baac0dbc7d..354974939d9d 10

[PATCH 1/4] net: freescale/fman: Split the main resource region reservation

2020-12-02 Thread Patrick Havelange
: Patrick Havelange --- drivers/net/ethernet/freescale/fman/fman.c | 103 + drivers/net/ethernet/freescale/fman/fman.h | 9 +- 2 files changed, 69 insertions(+), 43 deletions(-) diff --git a/drivers/net/ethernet/freescale/fman/fman.c b/drivers/net/ethernet/freescale/fman/fman.c