Re: [PATCH] amd-xgbe: set skb to NULL after freeing it

2018-11-28 Thread PanBian
On Wed, Nov 28, 2018 at 10:49:31AM -0800, David Miller wrote: > From: Pan Bian > Date: Wed, 28 Nov 2018 16:09:45 +0800 > > If either of these two cases are executed, it means that it must be > the case that: > > !last || context_next > > is FALSE, therefore the conditional in the tail cod

Re: [PATCH V2] libceph: fix use after free

2018-11-27 Thread PanBian
On Tue, Nov 27, 2018 at 11:17:26AM +0100, Ilya Dryomov wrote: > On Tue, Nov 27, 2018 at 10:22 AM Pan Bian wrote: > > > > The function ceph_monc_handle_map calls kfree(old) to free the old > > monitor map, old points to monc->monmap. However, after that, it reads > > monc->monmap->epoch and passes

Re: [PATCH] libceph: fix use after free

2018-11-27 Thread PanBian
On Tue, Nov 27, 2018 at 11:47:56AM +0300, Sergei Shtylyov wrote: > Hello! > > On 27.11.2018 10:02, Pan Bian wrote: > > >The function ceph_monc_handle_map calls kfree(old) to free the old > >monitor map, old points to monc->monmap. However, after that, it reads > >monc->monmap->epoch and passes it

Re: [PATCH 1/1] tipc: check return value of nlmsg_new

2017-04-23 Thread PanBian
On Sun, Apr 23, 2017 at 12:17:16AM -0700, Joe Perches wrote: > On Sun, 2017-04-23 at 15:09 +0800, Pan Bian wrote: > > Function nlmsg_new() will return a NULL pointer if there is no enough > > memory, and its return value should be checked before it is used. > > However, in function tipc_nl_node_get