On 18.11.20 21:19, David Ahern wrote:
>
> You forgot to remove the dst part of that. rt6 == dst so to be in this
> branch dst != NULL.
Damn. I've indeed overseen that one.
Just submitted version 4.
Thanks for guiding me through this!
This patch adds an IPv6 routes encapsulation attribute
to the result of netlink RTM_GETROUTE requests
(i.e. ip route get 2001:db8::).
Signed-off-by: Oliver Herms
---
net/ipv6/route.c | 4
1 file changed, 4 insertions(+)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 7e0ce7af8234
This patch adds an IPv6 routes encapsulation attribute
to the result of netlink RTM_GETROUTE requests
(i.e. ip route get 2001:db8::).
Signed-off-by: Oliver Herms
---
net/ipv6/route.c | 4
1 file changed, 4 insertions(+)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 7e0ce7af8234
This patch adds an IPv6 routes encapsulation attribute
to the result of netlink RTM_GETROUTE requests
(i.e. ip route get 2001:db8::).
Signed-off-by: Oliver Herms
---
net/ipv6/route.c | 4
1 file changed, 4 insertions(+)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 82cbb46a2a4f
This patch adds an IPv6 routes encapsulation attribute
to the result of netlink RTM_GETROUTE requests
(e.g. ip route get 2001:db8::).
Signed-off-by: Oliver Herms
---
net/ipv6/route.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 82cbb46a2a4f
This patch adds an IPv4 routes encapsulation attribute
to the result of netlink RTM_GETROUTE requests
(e.g. ip route get 192.0.2.1).
Signed-off-by: Oliver Herms
---
net/ipv4/route.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 1d7076b78e63
This patch adds an IPv4 routes encapsulation attribute
to the result of netlink RTM_GETROUTE requests
(e.g. ip route get 192.0.2.1).
Signed-off-by: Oliver Herms
---
net/ipv4/route.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index dc2a399cd9f4
On 04.11.20 20:52, Willem de Bruijn wrote:
Fixes: c54419321455 ("GRE: Refactor GRE tunneling code.")
>>>
>>> How did you arrive at this SHA1?
>> I think the legacy usage of hard_header_len in ipv6/sit.c was overseen in
>> c54419321455.
>> Please correct me if I'm wrong.
>
> I don't see any
On 03.11.20 19:42, Willem de Bruijn wrote:
> Thanks. Yes, this is long overdue.
>
> The hard_header_len issue was also recently discussed in the context
> of GRE in commit fdafed459998 ("ip_gre: set dev->hard_header_len and
> dev->needed_headroom properly").
>
> Question is whether we should rese
d for more than
net.ipv6.route.gc_thresh flows.
Fixes: c54419321455 ("GRE: Refactor GRE tunneling code.")
Signed-off-by: Oliver Herms
---
net/ipv6/sit.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c
index 5e2c34c0ac97..5e7983cb6154 100644
--- a
On 30.06.20 08:22, Jakub Kicinski wrote:
> On Fri, 26 Jun 2020 00:44:35 +0200 Oliver Herms wrote:
>> The calculation of the effective tunnel mtu, that is used to create
>> mtu exceptions if necessary, is currently not done correctly. This
>> leads to unnecessary entries in the
Hi list,
is there a reason sysctl settings like net/ipv4/route/
- max_size
- gc_thresh
- gc_min_interval
- gc_min_interval_ms
- gc_elasticity
are still around in current kernels?
I find this just confusing and misleading.
If there are no concerns I'd like to remove those. I have a patch ready.
tch also corrects the calculation of the payload's packet size.
Fixes: c54419321455 ("GRE: Refactor GRE tunneling code.")
Signed-off-by: Oliver Herms
---
net/ipv4/ip_tunnel.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/ipv4/ip_tunnel.c b/net
On 24.06.20 18:42, Eric Dumazet wrote:
>
> Our intention is to get rid of the IPv6 garbage collection, so we need to
> make sure
> we do not rely on it ;)
Hi Eric,
I can't really follow. Did you mean to get rid of the GC or the route cache?
And what is the plan? Separate structures for routes,
s: c54419321455 ("GRE: Refactor GRE tunneling code.")
Signed-off-by: Oliver Herms
---
net/ipv4/ip_tunnel.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c
index f4f1d11eab50..871d28bd29fa 100644
--- a/net/ipv4/ip_tunnel.c
+++ b
, the MTU of the path is exclusive of the ethernet header
and the 20 bytes for the IP header are being subtracted separately
already. Thus hard_header_len is removed from this calculation.
For IPIP and GRE tunnels this doesn't change anything as hard_header_len
is zero in those cases anywa
On 24.06.20 00:06, Michal Kubecek wrote:
> On Tue, Jun 23, 2020 at 01:30:29AM +0200, Oliver Herms wrote:
>>
>> I'm encountering the issues due to cache entries that are created by
>> tnl_update_pmtu. However, I'm going to address that issue in another thread
>&g
On 23.06.20 00:55, Eric Dumazet wrote:
>
>
> On 6/22/20 1:53 PM, Oliver Herms wrote:
>> When fib6_run_gc is called with parameter force=true the spinlock in
>> /net/ipv6/ip6_fib.c:2310 can lock all CPUs in softirq when
>> net.ipv6.route.max_size is exceeded (seen t
On 22.06.20 23:44, Michal Kubecek wrote:
> On Mon, Jun 22, 2020 at 10:53:55PM +0200, Oliver Herms wrote:
>> When fib6_run_gc is called with parameter force=true the spinlock in
>> /net/ipv6/ip6_fib.c:2310 can lock all CPUs in softirq when
>> net.ipv6.route.max_size is exceede
C is going on already so it is
save to just skip another execution of the GC.
Signed-off-by: Oliver Herms
---
net/ipv6/route.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 82cbb46a2a4f..7e6fbaf43549 100644
--- a/net/ipv6/route.c
+++
20 matches
Mail list logo
