Re: PROBLEM: [1/2] Marvell 88E8040 (sky2) stopped working

2019-05-29 Thread Octavio Alvarez
On 5/28/19 11:57 PM, Petr Štetiar wrote: I just pulled from master and I don't see any updates for sky2.c. it was fixed in commit 6a0a923dfa14 ("of_net: fix of_get_mac_address retval if compiled without CONFIG_OF"). Oh! I see it now. I appreciate the quick help. Thanks! Octavio.

Re: PROBLEM: [1/2] Marvell 88E8040 (sky2) stopped working

2019-05-28 Thread Octavio Alvarez
On 5/18/19 8:22 PM, Octavio Alvarez wrote: Hi, Petr, I'm just shooting out of the blue, as I don't have currently any rational explanation for that now, but could you please change the line above to following: if (!IS_ERR_OR_NULL(iap)) It worked! Thank you for bein

Re: PROBLEM: [2/2] Marvell 88E8040 (sky2) fails after hibernation

2019-05-28 Thread Octavio Alvarez
Hi! On 5/18/19 11:07 AM, Octavio Alvarez wrote: PROBLEM: [2/2] Marvell 88E8040 (sky2) fails after hibernation Hibernating the machine and bringing it back does not properly bring back the Marvell NIC. Most of the time a module reload does not help. Problem starts on the following commit

Re: PROBLEM: [2/2] Marvell 88E8040 (sky2) fails after hibernation

2019-05-19 Thread Octavio Alvarez
Hi, I want to add some details: On 5/18/19 11:07 AM, Octavio Alvarez wrote: > PROBLEM: [2/2] Marvell 88E8040 (sky2) fails after hibernation > > It occurs since 4.14. Sorry, 4.14 is the last known good version. Quoting section 5 of my report: > [5.] Most recent kernel version which

Re: PROBLEM: [1/2] Marvell 88E8040 (sky2) stopped working

2019-05-18 Thread Octavio Alvarez
Hi, Petr, On 5/18/19 4:58 PM, Petr Štetiar wrote: >> Linux version 5.1.0-12511-g72cf0b07418a (alvarezp@alvarezp-samsung) > > What do I need to do/apply in order to get the same source tree with > 72cf0b07418a hash? I'm not able to find that commit. It's the most recent master, so my guess is jus