Re: RFC: Fixing SK_REUSEPORT from sk_lookup_* helpers

2019-05-16 Thread Nitin Hande
On Thu, May 16, 2019 at 2:57 PM Alexei Starovoitov wrote: > > On Thu, May 16, 2019 at 09:41:34AM +0100, Lorenz Bauer wrote: > > On Wed, 15 May 2019 at 18:16, Joe Stringer wrote: > > > > > > On Wed, May 15, 2019 at 8:11 AM Lorenz Bauer wrote: > > > > > > > > In the BPF-based TPROXY session with J

[PATCH v2 bpf-next] bpf: Extend the sk_lookup() helper to XDP hookpoint.

2018-10-28 Thread Nitin Hande
hookpoint. A XDP program can map the incoming packet to the 5-tuple parameter and invoke the API to find the corresponding socket structure. Signed-off-by: Nitin Hande --- v1->v2 - For sockets with reuseport socket option, there was a case where the sk returned by the helper can vary due to

Re: [PATCH bpf-next] bpf: Extend the sk_lookup() helper to XDP hookpoint.

2018-10-19 Thread Nitin Hande
, Daniel Borkmann > >>> wrote: > >>>> On 10/18/2018 11:06 PM, Joe Stringer wrote: > >>>>> On Thu, 18 Oct 2018 at 11:54, Nitin Hande > >>>>> wrote: > >>>> [...] > >>>>>> Open Issue > >&g

Re: [PATCH bpf-next] bpf: Extend the sk_lookup() helper to XDP hookpoint.

2018-10-18 Thread Nitin Hande
On Thu, 18 Oct 2018 23:20:17 +0200 Daniel Borkmann wrote: > On 10/18/2018 11:06 PM, Joe Stringer wrote: > > On Thu, 18 Oct 2018 at 11:54, Nitin Hande wrote: > [...] > >> Open Issue > >> * The underlying code relies on presence of an skb to find out the > >

[PATCH bpf-next] bpf: Extend the sk_lookup() helper to XDP hookpoint.

2018-10-18 Thread Nitin Hande
available at XDP hookpoint, the helper function will return the first available sk based off the 5 tuple hash. If the desire is to return a particular sk matching reuseport_cb function, please suggest way to tackle it, which can be addressed in a future commit. Signed-off-by: Nitin Hande --- net/core