ing, so this refactors these uses of max() to use the
> new const_max() instead.
>
> [1] https://lkml.org/lkml/2018/3/7/621
For the btrfs portion :
Reviewed-by: Nikolay Borisov
>
> Signed-off-by: Kees Cook
> ---
> drivers/input/touchscreen/cyttsp4_core.c | 2 +-
> fs/btrfs/
On 8.02.2018 13:43, Tetsuo Handa wrote:
>>From 361d37a7d36978020dfb4c11ec1f4800937ccb68 Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa
> Date: Thu, 8 Feb 2018 10:35:35 +0900
> Subject: [PATCH v2] lockdep: Fix fs_reclaim warning.
>
> Dave Jones reported fs_reclaim lockdep warnings.
>
> ==
Cc: # 4.6
Signed-off-by: Nikolay Borisov
---
Cahnges since v1:
* Moved the sysctl initialization to inet_init_net based on Eric Dumazet's
suggestion
net/ipv4/af_inet.c | 7 +++
net/ipv4/igmp.c| 6 --
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/net/ipv4/af_ine
sted-by: Gerardo Exequiel Pozzi
Signed-off-by: Nikolay Borisov
Cc: # 4.6
---
net/ipv4/igmp.c | 6 --
net/ipv4/tcp_ipv4.c | 6 ++
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
index 28f14afd0dd3..498706b072fb 100644
--- a/net/ipv4/igm
>>
>>
>> New report from linux-next/c0b7b2b33bd17f7155956d0338ce92615da686c9
>>
>> [ cut here ]
>> kernel BUG at net/unix/garbage.c:149!
>> invalid opcode: [#1] SMP KASAN
>> Dumping ftrace buffer:
>>(ftrace buffer empty)
>> Modules linked in:
>> CPU: 0 PID: 1806 Co
On 24.12.2016 14:43, Haishuang Yan wrote:
> Signed-off-by: Haishuang Yan
Reviewed-by: Nikolay Borisov
[Added Dave Miller to see what's the status of this patch]
On 08/30/2016 12:18 PM, Miklos Szeredi wrote:
> On Tue, Aug 30, 2016 at 12:37 AM, Miklos Szeredi wrote:
>> On Sat, Aug 27, 2016 at 11:55 AM, Miklos Szeredi wrote:
>
>> crash> list -H gc_inflight_list unix_sock.link -s unix_sock.inflight
On 08/30/2016 12:18 PM, Miklos Szeredi wrote:
> On Tue, Aug 30, 2016 at 12:37 AM, Miklos Szeredi wrote:
>> On Sat, Aug 27, 2016 at 11:55 AM, Miklos Szeredi wrote:
>
>> crash> list -H gc_inflight_list unix_sock.link -s unix_sock.inflight |
>> grep counter | cut -d= -f2 | awk '{s+=$1} END {print
On Thu, Aug 25, 2016 at 12:40 AM, Hannes Frederic Sowa
wrote:
> On 24.08.2016 16:24, Nikolay Borisov wrote:
[SNIP]
>
> One commit which could have to do with that is
>
> commit fc64869c48494a401b1fb627c9ecc4e6c1d74b0d
> Author: Andrey Ryabinin
> Date: Wed May 18 19:19:27 2
Hello,
I hit the following BUG:
[1851513.239831] [ cut here ]
[1851513.240079] kernel BUG at net/unix/garbage.c:149!
[1851513.240313] invalid opcode: [#1] SMP
[1851513.248320] CPU: 37 PID: 11683 Comm: nginx Tainted: G O
4.4.14-clouder3 #26
[1851513.24
On 08/01/2016 11:56 AM, Erez Shitrit wrote:
> The GID (9000:0:2800:0:bc00:7500:6e:d8a4) is not regular, not from
> local subnet prefix.
> why is that?
>
So I managed to debug this and it tuns out the problem lies between veth
and ipoib interaction:
I've discovered the following strange thing. I
Hello,
I accidentally saw that even having an ip address on an
ipoib interface doesn't increment the usage count of the
ib_ipoib.ko module:
ip a l dev ib0
14: ib0: mtu 65520 qdisc pfifo_fast state UP
qlen 256
link/infiniband 80:00:02:d4:fe:80:00:00:00:00:00:00:e4:1d:2d:03:00:00:f8:31
b
On 06/06/2016 11:05 AM, Cyrill Gorcunov wrote:
> On Wed, Jun 01, 2016 at 10:52:57AM +0300, Nikolay Borisov wrote:
>> This patch adds the necessary members to user_struct. The idea behind
>> the solution is really simple - user the userns pointers as keys into
>> a hash
On 06/03/2016 11:41 PM, Eric W. Biederman wrote:
> Nikolay Borisov writes:
>
>> On 06/02/2016 07:58 PM, Eric W. Biederman wrote:
>>>
>>> Nikolay please see my question for you at the end.
> [snip]
>>> All of that said there is definitely a pra
On 06/02/2016 07:58 PM, Eric W. Biederman wrote:
>
> Nikolay please see my question for you at the end.
>
> Jan Kara writes:
>
>> On Wed 01-06-16 11:00:06, Eric W. Biederman wrote:
>>> Cc'd the containers list.
>>>
>>> Nikolay Borisov wri
On 06/01/2016 07:00 PM, Eric W. Biederman wrote:
> Cc'd the containers list.
>
>
> Nikolay Borisov writes:
>
>> Currently the inotify instances/watches are being accounted in the
>> user_struct structure. This means that in setups where multiple
>> u
Signed-off-by: Nikolay Borisov
---
fs/notify/inotify/inotify_fsnotify.c | 14 +-
fs/notify/inotify/inotify_user.c | 23 +++
include/linux/sched.h| 2 --
3 files changed, 28 insertions(+), 11 deletions(-)
diff --git a/fs/notify/inotify
it's needed so that building the kernel
with !CONFIG_INOTIFY_USER doesn't fail (with patch 1 being applied).
However, fdinfo.c doesn't really need inotify.h
Nikolay Borisov (4):
inotify: Add infrastructure to account inotify limits per-namespace
inotify: Convert inotify limits t
This change is required since the inotify-per-namespace code added
hashtable.h to the include list of sched.h. This in turn causes
compiler warnings since HASH_SIZE is being defined in multiple
locations
Signed-off-by: Nikolay Borisov
---
fs/logfs/dir.c | 6
Signed-off-by: Nikolay Borisov
---
fs/notify/fdinfo.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/notify/fdinfo.c b/fs/notify/fdinfo.c
index fd98e5100cab..62068f89d144 100644
--- a/fs/notify/fdinfo.c
+++ b/fs/notify/fdinfo.c
@@ -13,7 +13,10 @@
#include
#include
+#ifdef
scenarios such as a single mapped user in a
container deplete the inotify resources for all other users, which
map to the exact same real user.
Signed-off-by: Nikolay Borisov
---
fs/notify/inotify/inotify.h | 68
fs/notify/inotify/inotify_user.c | 36
On Wed, Mar 16, 2016 at 7:07 PM, Hannes Frederic Sowa
wrote:
> Hello,
Hi,
>
> On 16.03.2016 16:29, Nikolay Borisov wrote:
>>
>> I have stack traces which do show this sequence of events, so my
>> questions now are:
>>
>> 1. What's the difference bet
Hello Dave,
I've been chasing a rather strange problem and I saw you were the person
that authored most of the code involved so I'm addresing you, but will
be happy to receive assistance from any one feeling knowledgeable enough
on the issue.
Basically I have an infiniband card on which I want to
On 02/17/2016 09:15 PM, Eric W. Biederman wrote:
> Nikolay Borisov writes:
>
>> This series make the inet_peer ttl sysctls to be namespace aware.
>>
>> Patch 1 adds a namespace association to the inet_peer_base struct,
>> which in turn is used to make th
Signed-off-by: Nikolay Borisov
---
include/net/ip.h | 1 -
include/net/netns/ipv4.h | 1 +
net/ipv4/inetpeer.c| 2 +-
net/ipv4/sysctl_net_ipv4.c | 15 ---
4 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/include/net/ip.h b/include/net/ip.h
index
Signed-off-by: Nikolay Borisov
---
include/net/ip.h | 3 ---
include/net/netns/ipv4.h | 1 +
net/ipv4/inetpeer.c| 11 ---
net/ipv4/sysctl_net_ipv4.c | 17 +
4 files changed, 14 insertions(+), 18 deletions(-)
diff --git a/include/net/ip.h b/include
This series make the inet_peer ttl sysctls to be namespace aware.
Patch 1 adds a namespace association to the inet_peer_base struct,
which in turn is used to make the sysctls namespace aware. The
rest of the patches are straightforward.
Nikolay Borisov (4):
inetpeer: Add net namespace
Signed-off-by: Nikolay Borisov
---
include/net/ip.h | 1 -
include/net/netns/ipv4.h | 2 ++
net/ipv4/inetpeer.c| 2 +-
net/ipv4/sysctl_net_ipv4.c | 15 ---
4 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/include/net/ip.h b/include/net/ip.h
index
This is required so that the inet_peer_* sysctls can be
namespacified
Signed-off-by: Nikolay Borisov
---
include/net/inetpeer.h | 1 +
net/ipv4/route.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/include/net/inetpeer.h b/include/net/inetpeer.h
index 235c7811a86a..287bb54cda58
;
> -#endif
> }
> spin_unlock_bh(&pmc->lock);
> return err;
> @@ -2711,13 +2691,10 @@ static int igmp_mc_seq_show(struct seq_file *seq,
> void *v)
> char *querier;
> long delta;
>
> -#ifdef CONFIG_IP_MULTICAST
> - querier = IGMP_V1_SEEN(state->in_dev) ? "V1" :
> + querier = !IS_ENABLED(CONFIG_IP_MULTICAST) ? "NONE" :
> + IGMP_V1_SEEN(state->in_dev) ? "V1" :
> IGMP_V2_SEEN(state->in_dev) ? "V2" :
> "V3";
> -#else
> - querier = "NONE";
> -#endif
>
> if (rcu_access_pointer(state->in_dev->mc_list) == im) {
> seq_printf(seq, "%d\t%-10s: %5d %7s\n",
>
Reviewed-by: Nikolay Borisov
Signed-off-by: Nikolay Borisov
---
include/net/ip.h | 3 ---
include/net/netns/ipv4.h | 2 ++
net/ipv4/af_inet.c | 10 ++
net/ipv4/sysctl_net_ipv4.c | 15 ---
4 files changed, 12 insertions(+), 18 deletions(-)
diff --git a/include/net/ip.h b/include/net
Signed-off-by: Nikolay Borisov
---
include/net/netns/ipv4.h | 1 +
include/net/route.h | 5 ++---
net/bridge/netfilter/nft_reject_bridge.c | 8 +---
net/ipv4/ip_output.c | 3 ---
net/ipv4/ip_sockglue.c | 5
Signed-off-by: Nikolay Borisov
---
include/net/inet_frag.h | 1 +
net/ipv4/ip_fragment.c | 25 +
2 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/include/net/inet_frag.h b/include/net/inet_frag.h
index 12aac0fd6ee7..909972aa3acd 100644
--- a/include/net
When igmp related sysctl were namespacified their initializatin was
erroneously put into the tcp socket namespace constructor. This
patch moves the relevant code into the igmp namespace constructor to
keep things consistent.
Also sprinkle some #ifdefs to silence warnings
Signed-off-by: Nikolay
Signed-off-by: Nikolay Borisov
---
include/net/ip.h | 3 ---
include/net/netns/ipv4.h | 1 +
net/ipv4/ip_input.c| 5 +
net/ipv4/sysctl_net_ipv4.c | 15 ---
net/ipv6/ip6_input.c | 2 +-
5 files changed, 11 insertions(+), 15 deletions(-)
diff --git a
Now that all the ip fragmentation related sysctls are namespaceified
there is no reason to hide them anymore from "root" users inside
containers.
Signed-off-by: Nikolay Borisov
---
net/ipv4/ip_fragment.c | 4
1 file changed, 4 deletions(-)
diff --git a/net/ipv4/ip_fragment.c
guards to
silence compilation warnings.
Finally, patch 5 exposes the ip fragmentation related sysctls
since all of the knobs are namespaced.
Nikolay Borisov (6):
ipv4: Namespaceify ip_default_ttl sysctl knob
igmp: net: Move igmp namespace init to correct file
ipv4: Namespacify ip_dynaddr
On 02/15/2016 04:09 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the net-next tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> net/ipv4/igmp.c: In function 'igmp_group_added':
> net/ipv4/igmp.c:1227:14: warning: unused variable 'net' [-Wunused-vari
From: Nikolay Borisov
This was initially introduced in df2cf4a78e488d26 ("IGMP: Inhibit
reports for local multicast groups") by defining the sysctl in the
ipv4_net_table array, however it was never implemented to be
namespace aware. Fix this by changing the code accordingly.
---
Signed-off-by: Nikolay Borisov
---
include/linux/igmp.h | 2 --
include/net/netns/ipv4.h | 1 +
net/ipv4/igmp.c| 29 +
net/ipv4/sysctl_net_ipv4.c | 20 ++--
net/ipv4/tcp_ipv4.c| 1 +
5 files changed, 29 insertions(+), 24
alise
the respective sysctl) so I don't think this is a huge loss.
The third patch however, converts igmp_llm_reports which was
already defined in the ipv4_net_table but wasn't using any of
the net namespace infrastructure.
Nikolay Borisov (4):
igmp: Namespaceify igmp_max_membersh
Signed-off-by: Nikolay Borisov
---
include/linux/igmp.h | 1 -
include/net/netns/ipv4.h | 1 +
net/ipv4/igmp.c| 5 +
net/ipv4/ip_sockglue.c | 5 +++--
net/ipv4/sysctl_net_ipv4.c | 14 +++---
net/ipv4/tcp_ipv4.c| 1 +
6 files changed, 13 insertions
This was initially introduced in commit df2cf4a78e48 ("IGMP: Inhibit
reports for local multicast groups") by defining the sysctl in the
ipv4_net_table array, however it was never implemented to be
namespace aware. Fix this by changing the code accordingly.
Signed-off-by: Nikol
Signed-off-by: Nikolay Borisov
---
include/linux/igmp.h | 1 -
include/net/netns/ipv4.h | 2 ++
net/ipv4/igmp.c| 4 +---
net/ipv4/sysctl_net_ipv4.c | 14 +++---
net/ipv4/tcp_ipv4.c| 2 ++
5 files changed, 12 insertions(+), 11 deletions(-)
diff --git a
it is required to tune the
tcp settings for each independently of the host node.
I've split the patches to be per-sysctl but after
the review if the outcome is positive I'm happy
to either send it in one big blob or just.
Nikolay Borisov (9):
ipv4: Namespaceify tcp syn retries sys
Signed-off-by: Nikolay Borisov
---
include/net/netns/ipv4.h| 1 +
include/net/tcp.h | 1 -
net/ipv4/inet_connection_sock.c | 7 ++-
net/ipv4/sysctl_net_ipv4.c | 14 +++---
net/ipv4/tcp_ipv4.c | 1 +
net/ipv4/tcp_timer.c| 3
Signed-off-by: Nikolay Borisov
---
include/net/netns/ipv4.h | 2 ++
include/net/tcp.h | 1 -
net/ipv4/sysctl_net_ipv4.c | 18 +-
net/ipv4/tcp.c | 3 ++-
net/ipv4/tcp_ipv4.c| 2 ++
net/ipv4/tcp_timer.c | 4 ++--
6 files changed, 17
Signed-off-by: Nikolay Borisov
---
include/net/netns/ipv4.h | 2 +-
include/net/tcp.h | 4 +++-
net/ipv4/sysctl_net_ipv4.c | 14 +++---
net/ipv4/tcp.c | 2 +-
net/ipv4/tcp_input.c | 12 ++--
net/ipv4/tcp_ipv4.c| 2 +-
net/ipv4
Signed-off-by: Nikolay Borisov
---
include/net/netns/ipv4.h | 2 ++
include/net/tcp.h | 1 -
net/ipv4/syncookies.c | 4 +---
net/ipv4/sysctl_net_ipv4.c | 18 +-
net/ipv4/tcp_input.c | 10 ++
net/ipv4/tcp_ipv4.c| 3 ++-
net/ipv4
Signed-off-by: Nikolay Borisov
---
include/net/netns/ipv4.h | 1 +
include/net/tcp.h | 1 -
net/ipv4/sysctl_net_ipv4.c | 16
net/ipv4/tcp_ipv4.c| 1 +
net/ipv4/tcp_timer.c | 8
5 files changed, 14 insertions(+), 13 deletions(-)
diff --git a
Signed-off-by: Nikolay Borisov
---
include/net/netns/ipv4.h | 1 +
include/net/tcp.h | 1 -
net/ipv4/sysctl_net_ipv4.c | 14 +++---
net/ipv4/tcp_ipv4.c| 1 +
net/ipv4/tcp_output.c | 3 ++-
net/ipv4/tcp_timer.c | 5 ++---
6 files changed, 13 insertions
Signed-off-by: Nikolay Borisov
---
include/net/netns/ipv4.h | 1 +
include/net/tcp.h | 4 ++--
net/ipv4/sysctl_net_ipv4.c | 14 +++---
net/ipv4/tcp_ipv4.c| 1 +
net/ipv4/tcp_output.c | 3 ---
5 files changed, 11 insertions(+), 12 deletions(-)
diff --git a
Signed-off-by: Nikolay Borisov
---
include/net/netns/ipv4.h | 1 +
include/net/tcp.h | 1 -
net/ipv4/sysctl_net_ipv4.c | 14 +++---
net/ipv4/tcp_ipv4.c| 1 +
net/ipv4/tcp_timer.c | 3 +--
5 files changed, 10 insertions(+), 10 deletions(-)
diff --git a
Signed-off-by: Nikolay Borisov
---
include/net/netns/ipv4.h | 1 +
include/net/tcp.h | 3 +--
net/ipv4/sysctl_net_ipv4.c | 14 +++---
net/ipv4/tcp.c | 7 +++
net/ipv4/tcp_ipv4.c| 1 +
5 files changed, 13 insertions(+), 13 deletions(-)
diff --git a
Different net namespaces might have different requirements as to
the keepalive time of tcp sockets. This might be required in cases
where different firewall rules are in place which require tcp
timeout sockets to be increased/decreased independently of the host.
Signed-off-by: Nikolay Borisov
On 12/07/2015 02:29 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 12/07/2015 01:13 PM, Nikolay Borisov wrote:
>
>> Commit 3bfe049807c2403 ('netfilter: nfnetlink_{log,queue}:
>
>Double quotes please, that's what scripts/checkpatch.pl enforces now.
&g
pernet_subsys wasn't cleaned in case
nfnetlink_subsys_register failed. This patch adds the necessary
cleanup routine call.
Fixes: 3bfe049807c2403 ('netfilter: nfnetlink_{log,queue}: Register
pernet in first place')
Signed-off-by:
Hello,
Recently I observed 2 crashes on one of my server with the following backtraces:
[22751.889645] [ cut here ]
[22751.889660] WARNING: CPU: 38 PID: 12807 at net/core/skbuff.c:3498
skb_try_coalesce+0x34b/0x360()
[22751.889661] Modules linked in: tcp_diag inet_diag xt_L
allocation type to GFP_ATOMIC, to
correctly reflect that it is occuring in an atomic context.
Fixes: 00590fdd5be0 ("netfilter: ipset: Introduce RCU locking in list type")
Acked-by: Jozsef Kadlecsik
Signed-off-by: Nikolay Borisov
---
Changes since v2:
* Massaged the changelog to r
On Thu, Oct 15, 2015 at 9:46 PM, Eric Dumazet wrote:
> On Thu, 2015-10-15 at 20:25 +0200, Jozsef Kadlecsik wrote:
>
>> Nikolay answered this pretty well: we wouldn't need the spinlock at all,
>> because all commands are serialized anyway with the netlink mutex. But the
>> garbage collector is call
On 10/15/2015 05:32 PM, Eric Dumazet wrote:
> On Thu, 2015-10-15 at 16:41 +0300, Nikolay Borisov wrote:
>>
>> On 10/15/2015 04:32 PM, Eric Dumazet wrote:
>>> On Thu, 2015-10-15 at 13:56 +0300, Nikolay Borisov wrote:
>>>> Commit 00590fdd5be0 introduced RCU lo
On 10/15/2015 04:32 PM, Eric Dumazet wrote:
> On Thu, 2015-10-15 at 13:56 +0300, Nikolay Borisov wrote:
>> Commit 00590fdd5be0 introduced RCU locking in list type and in
>> doing so introduced a memory allocation in list_set_add, which
>> results in the following splat
TOMIC, to
correctly reflect that it is occuring in an atomic context.
Fixes: 00590fdd5be0 ("netfilter: ipset: Introduce RCU locking in list type")
Acked-by: Jozsef Kadlecsik
Signed-off-by: Nikolay Borisov
---
Changes since V1:
* Added acked-by
* Fixed patch header
net/netfilter/ipset/ip
EL allows initiating direct reclaim thus
potentially sleeping in the allocation path, this leads to the
aforementioned splat.
To fix it change that particular allocation type to GFP_ATOMIC, to
correctly reflect that it is happening in an atomic context.
Signed-off-by: Nikolay Borisov
---
Even th
64 matches
Mail list logo
