hile at it, use pm_runtime_put() instead of pm_runtime_put_sync(), as
> there is no reason to do a synchronous power down.
>
> Fixes: 7fa2955ff70ce453 ("sh_eth: Fix sleeping function called from invalid
> context")
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Niklas Söderlund
ned-off-by: Niklas Söderlund
---
drivers/net/ethernet/renesas/ravb_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/renesas/ravb_main.c
b/drivers/net/ethernet/renesas/ravb_main.c
index 54a6265da7a06460..68f122140966d4de 100644
--- a/drivers/net/ethernet/renesas/ravb_ma
Allow for changing the MTU within the limit of the maximum size of a
descriptor (2048 bytes). Add the callback to change MTU from user-space
and take the configurable MTU into account when configuring the
hardware.
Signed-off-by: Niklas Söderlund
---
drivers/net/ethernet/renesas/ravb.h
Hi Sergei,
Thanks for your feedback.
On 2018-02-14 14:34:09 +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 02/13/2018 04:12 PM, Niklas Söderlund wrote:
>
> >> On 02/12/2018 11:00 PM, Niklas Söderlund wrote:
> >>
> >>> Allow for chancing the MTU
Hi Sergei,
Thanks for your feedback.
On 2018-02-13 13:01:04 +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 02/12/2018 11:00 PM, Niklas Söderlund wrote:
>
> > Allow for chancing the MTU within the limit of the maximum size of a
>
>Changing. :-)
Yes :-)
>
>
Allow for chancing the MTU within the limit of the maximum size of a
descriptor (2048 bytes). Add the callback to change MTU from user-space
and take the configurable MTU into account when configuring the
hardware.
Signed-off-by: Niklas Söderlund
---
drivers/net/ethernet/renesas/ravb.h
cks during resume"), the workaround is no longer needed.
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Niklas Söderlund
> ---
> drivers/net/ethernet/renesas/ravb_main.c | 27 ++-
> 1 file changed, 2 insertions(+), 25 deletions(-)
>
>
Hi Geert,
On 2017-10-20 09:15:50 +0200, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> On Fri, Oct 20, 2017 at 1:32 AM, Niklas Söderlund
> wrote:
> > Commit 9cab88726929605 ("net: ethtool: Add back transceiver type")
> > restores the transceiver type t
Hi Geert,
On 2017-10-20 09:15:50 +0200, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> On Fri, Oct 20, 2017 at 1:32 AM, Niklas Söderlund
> wrote:
> > Commit 9cab88726929605 ("net: ethtool: Add back transceiver type")
> > restores the transceiver type t
/tx
Fixes: 19cab88726929605 ("net: ethtool: Add back transceiver type")
Signed-off-by: Niklas Söderlund
---
net/core/ethtool.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
Hi,
The commit 9cab88726929605 ("net: ethtool: Add back transceiver type")
itself is not enough to trigg
Hi Geert,
Grate patch!
Reviewed-by: Niklas Söderlund
On 2017-10-12 10:24:53 +0200, Geert Uytterhoeven wrote:
> The module clock is used for two purposes:
> - Wake-on-LAN (WoL), which is optional,
> - gPTP Timer Increment (GTI) configuration, which is mandatory.
>
> As the
the clock usage
count it won't reach 0 and be switched off.
Signed-off-by: Niklas Söderlund
---
drivers/net/ethernet/renesas/ravb.h | 2 +
drivers/net/ethernet/renesas/ravb_main.c | 108 +--
2 files changed, 106 insertions(+), 4 deletions(-)
diff --git a/dr
first place this was a bug in v1.
Niklas Söderlund (2):
ravb: add wake-on-lan support via magic packet
ravb: add workaround for clock when resuming with WoL enabled
drivers/net/ethernet/renesas/ravb.h | 2 +
drivers/net/ethernet/renesas/ravb_main.c | 131 +
this PSCI sleep behavior.
Signed-off-by: Niklas Söderlund
---
drivers/net/ethernet/renesas/ravb_main.c | 27 +--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/renesas/ravb_main.c
b/drivers/net/ethernet/renesas/ravb_main.c
index
Hi Sergei,
Thanks for your feedback!
On 2017-07-31 22:47:12 +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 07/30/2017 05:06 PM, Niklas Söderlund wrote:
>
> > WoL is enabled in the suspend callback by setting MagicPacket detection
> > and disabling all interrupts ex
Hi Andrew,
On 2017-07-30 22:07:31 +0200, Andrew Lunn wrote:
> On Sun, Jul 30, 2017 at 09:51:54PM +0200, Niklas Söderlund wrote:
> > Hi Andrew,
> >
> > On 2017-07-30 19:07:38 +0200, Andrew Lunn wrote:
> > > Hi Niklas
> > >
> > > >
s only needed to
support WoL, I though it best to not change behavior here. Try to get
the clock, if we can great we can do WoL if not then user-space will be
prevented from enabling WoL and nothing in the current behavior changes.
>
> Andrew
--
Regards,
Niklas Söderlund
the clock usage
count it won't reach 0 and be switched off.
Signed-off-by: Niklas Söderlund
---
drivers/net/ethernet/renesas/ravb.h | 2 +
drivers/net/ethernet/renesas/ravb_main.c | 130 ++-
2 files changed, 128 insertions(+), 4 deletions(-)
Changes from v1
Hi Geert,
On 2017-05-18 10:52:25 +0200, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> On Tue, May 16, 2017 at 2:16 PM, Niklas Söderlund
> wrote:
> > On 2017-05-16 13:36:21 +0200, Geert Uytterhoeven wrote:
> >> On Tue, May 16, 2017 at 1:01 PM, Simon Horman wrote:
> &g
Hi Geert,
On 2017-05-30 12:29:24 +0200, Niklas Söderlund wrote:
> Hi Geert,
>
> Thanks for the report. I did run a 200+ loop suspend/resume without
> issues so this error is probably hard to reproduce or something changed
> since v4.11-rc1 which if IIRC was the base I used
The hardware supports the MTU to be changed and the driver it self is
somewhat prepared to support this. This patch hooks up the callbacks to
be able to change the MTU from user-space.
Signed-off-by: Niklas Söderlund
Acked-by: Sergei Shtylyov
---
Based on v4.12-rc1 and tested on Renesas R-Car
On 2017-06-09 22:32:15 +0200, Niklas Söderlund wrote:
> The hardware supports the MTU to be changed and the driver it self is
> somewhat prepared to support this. This patch hooks up the callbacks to
> be able to change the MTU from user-space.
>
> Signed-off-by: Niklas Söderl
The hardware supports the MTU to be changed and the driver it self is
somewhat prepared to support this. This patch hooks up the callbacks to
be able to change the MTU from user-space.
Signed-off-by: Niklas Söderlund
Acked-by: Sergei Shtylyov
---
Based on v4.12-rc1 and tested on Renesas R-Car
Hi Sergei,
Thanks for your feedback.
On 2017-06-09 19:31:09 +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 06/09/2017 06:30 PM, Niklas Söderlund wrote:
>
> > The hardware supports the MTU to be changed and the driver it self is
> > somewhat prepared to support this.
The hardware supports the MTU to be changed and the driver it self is
somewhat prepared to support this. This patch hooks up the callbacks to
be able to change the MTU from user-space.
Signed-off-by: Niklas Söderlund
---
Based on v4.12-rc1 and tested on Renesas R-Car Koelsch M2.
Test procedure
t Uytterhoeven -- There's lots of Linux beyond ia32 --
> ge...@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
--
Regards,
Niklas Söderlund
Hi,
On 2017-05-16 13:36:21 +0200, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Tue, May 16, 2017 at 1:01 PM, Simon Horman wrote:
> > On Tue, May 16, 2017 at 11:07:34AM +0200, Geert Uytterhoeven wrote:
> >> On Tue, May 16, 2017 at 11:02 AM, Niklas Söderlund
> >>
Hi Geert,
Thanks for your feedback.
On 2017-05-16 09:48:51 +0200, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> On Fri, May 12, 2017 at 11:12 PM, Niklas Söderlund
> wrote:
> > On 2017-05-12 16:43:55 +0200, Geert Uytterhoeven wrote:
> >> On Fri, May 12, 2017 a
Hi Geert,
On 2017-05-12 16:43:55 +0200, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> On Fri, May 12, 2017 at 4:32 PM, Niklas Söderlund
> wrote:
> > On 2017-05-12 14:58:53 +0200, Niklas Söderlund wrote:
> >> On 2017-05-12 14:47:53 +0200, Geert Uytterhoeven wrote:
> &
Hi Geert,
On 2017-05-12 14:58:53 +0200, Niklas Söderlund wrote:
> Hi Geert,
>
> Thanks for testing.
>
> On 2017-05-12 14:47:53 +0200, Geert Uytterhoeven wrote:
> > Hi Niklas,
> >
> > On Fri, May 12, 2017 at 12:27 AM, Niklas Söderlund
> > wrote:
> >
Hi Geert,
Thanks for testing.
On 2017-05-12 14:47:53 +0200, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> On Fri, May 12, 2017 at 12:27 AM, Niklas Söderlund
> wrote:
> > WoL is enabled in the suspend callback by setting MagicPacket detection
> > and disabling all interrupt
the clock usage
count it won't reach 0 and be switched off.
Signed-off-by: Niklas Söderlund
---
Tested on Salvator-X H3 and M3-W.
drivers/net/ethernet/renesas/ravb.h | 2 +
drivers/net/ethernet/renesas/ravb_main.c | 108 +--
2 files changed, 106 insertions(
On 2017-02-01 12:54:41 -0500, David Miller wrote:
> From: Niklas Söderlund
> Date: Wed, 1 Feb 2017 15:41:53 +0100
>
> > This series contain two fixes for MagicPacket handling. It's based on
> > top of net-next and is tested on Koelsch.
>
> Series applied, th
If a link change interrupt happens along side the MagicPacket interrupt
and the link change interrupt is ignored the interrupt handler will
return and the wakeup event is not register. Fix this by moving the
MagicPacket check before the link change check.
Signed-off-by: Niklas Söderlund
Reported
To be consistent with the rest of the driver when setting bits using
sh_eth_modify() the same bit should also be cleared. This have no
functional change and should have been done from the start.
Signed-off-by: Niklas Söderlund
Suggested-by: Sergei Shtylyov
---
drivers/net/ethernet/renesas
Hi,
This series contain two fixes for MagicPacket handling. It's based on
top of net-next and is tested on Koelsch.
Niklas Söderlund (2):
sh_eth: align usage of sh_eth_modify() with rest of driver
sh_eth: fix wakeup event reporting from MagicPacket
drivers/net/ethernet/renesas/sh_
This bit was wrongly named due to a typo, Sergei checked the SH7734/63
manuals and this bit should be named MPDE.
Suggested-by: Sergei Shtylyov
Signed-off-by: Niklas Söderlund
---
drivers/net/ethernet/renesas/sh_eth.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
Geert Uytterhoeven reported WoL worked on his Armadillo board.
Signed-off-by: Niklas Söderlund
Tested-by: Geert Uytterhoeven
---
drivers/net/ethernet/renesas/sh_eth.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/renesas/sh_eth.c
b/drivers/net/ethernet/renesas
This is based on public datasheet for sh7734 which shows it has the
same behavior and registers for WoL as other versions of sh_eth.
Signed-off-by: Niklas Söderlund
---
drivers/net/ethernet/renesas/sh_eth.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/renesas
Tested on Gen2 r8a7791/Koelsch.
Signed-off-by: Niklas Söderlund
Tested-by: Geert Uytterhoeven
---
drivers/net/ethernet/renesas/sh_eth.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/renesas/sh_eth.c
b/drivers/net/ethernet/renesas/sh_eth.c
index
This is based on public datasheet for sh7763 which shows it has the
same behavior and registers for WoL as other versions of sh_eth.
Signed-off-by: Niklas Söderlund
---
drivers/net/ethernet/renesas/sh_eth.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/renesas
switched off by Runtime PM. To keep the clock alive the
suspend callback need to call clk_enable() directly to increase the
usage count of the clock. Then when Runtime PM decreases the clock usage
count it won't reach 0 and be switched off.
Signed-off-by: Niklas Söderlund
---
driver
possible gaps due to alignment restrictions.
- Make wol_enabled in sh_eth_private part of the already existing
bitfield instead of a bool.
- Do not initiate mdp->wol_enabled to 0, the struct is kzalloc'ed so
it's already set to 0.
Niklas Söderlund (6):
sh_eth: use correct
Hi Sergei,
On 2016-12-18 00:50:59 +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 12/12/2016 07:09 PM, Niklas Söderlund wrote:
>
>Not the complete review yet, just some superficial comments.
>
> > Add generic functionality to support Wake-on-Lan using Magic
Hi Sergei,
Thanks for the spelling feedback, will include your suggestions in v3.
Which I hope to post once rc1 is released and netdev opens, as you
suggested to me previously.
On 2016-12-18 23:26:11 +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 12/12/2016 07:09 PM, Niklas Söderl
Hi Geert,
Thanks for feedback and testing!
On 2016-12-13 14:03:52 +0100, Geert Uytterhoeven wrote:
> CC linux-pm
I think you forgot to CC linux-pm :-)
>
> On Mon, Dec 12, 2016 at 5:09 PM, Niklas Söderlund
> wrote:
> > Add generic functionality to support Wake-on-Lan using
switched off by Runtime PM. To keep the clock alive the
suspend callback need to call clk_enable() directly to increase the
usage count of the clock. Then when Runtime PM decreases the clock usage
count it won't reach 0 and be switched off.
Signed-off-by: Niklas Söderlund
---
drivers/net/eth
Tested on Gen2 r8a7791/Koelsch.
Signed-off-by: Niklas Söderlund
---
drivers/net/ethernet/renesas/sh_eth.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/renesas/sh_eth.c
b/drivers/net/ethernet/renesas/sh_eth.c
index 87640b9..348ed22 100644
--- a
This is based on public datasheet for sh7763 which shows it have the
same behavior and registers for WoL as other versions of sh_eth.
Signed-off-by: Niklas Söderlund
---
drivers/net/ethernet/renesas/sh_eth.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/renesas
mdp->wol_enabled to 0, the struct is kzalloc'ed so
it's already set to 0.
Niklas Söderlund (5):
sh_eth: add generic wake-on-lan support via magic packet
sh_eth: enable wake-on-lan for Gen2 devices
sh_eth: enable wake-on-lan for r8a7740/armadillo
sh_eth: enable wake-on-lan for sh7743
This is based on public datasheet for sh7743 which shows it have the
same behavior and registers for WoL as other versions of sh_eth.
Signed-off-by: Niklas Söderlund
---
drivers/net/ethernet/renesas/sh_eth.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/renesas
Geert Uytterhoeven reported WoL worked on his Armadillo board.
Signed-off-by: Niklas Söderlund
---
drivers/net/ethernet/renesas/sh_eth.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/renesas/sh_eth.c
b/drivers/net/ethernet/renesas/sh_eth.c
index 348ed22..fafde6f
Hi Sergei,
Thanks for your feedback.
On 2016-12-11 00:25:41 +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 12/08/2016 05:56 PM, Niklas Söderlund wrote:
>
> > > You only enable the WOL support fo the R-Car gen2 chips but never say
> > > that
> > > expl
I will follow Sergies advice and Geerts testing to enable Gen2
family and r8a7740/armadillo in two separate patches. Then if we later
can confirm it works on other models we can enable them in separate
patches by setting the magic flag in struct sh_eth_cpu_data for those
models. Do you agree this is the best way to handle this?
--
Regards,
Niklas Söderlund
Hi Sergei,
Thanks for your feedback.
On 2016-12-08 15:28:48 +0300, Sergei Shtylyov wrote:
> Hello!
>
>Good to see that somebody cares still about this driver, one more task
> off my back. :-)
>
> On 12/07/2016 07:28 PM, Niklas Söderlund wrote:
>
> You only enabl
Hi Geert,
Thanks for testing and your feedback.
On 2016-12-07 19:14:40 +0100, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> On Wed, Dec 7, 2016 at 5:28 PM, Niklas Söderlund
> wrote:
> > Signed-off-by: Niklas Söderlund
>
> Thanks, works fine on r8a7791/koelsch!
>
>
Signed-off-by: Niklas Söderlund
---
drivers/net/ethernet/renesas/sh_eth.c | 120 +++---
drivers/net/ethernet/renesas/sh_eth.h | 4 ++
2 files changed, 116 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/renesas/sh_eth.c
b/drivers/net/ethernet
On 2016-08-10 13:40:51 +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 8/3/2016 4:56 PM, Niklas Söderlund wrote:
>
> > The interface would not function after the system had been woken up
> > after have been suspended (echo mem > /sys/power/state) cycle. The
> > r
The patch 'ravb: add sleep PM suspend/resume support' used incorrect
function names containing 'runtime' for the suspend and resume
functions.
Reported-by: Sergei Shtylyov
Signed-off-by: Niklas Söderlund
---
drivers/net/ethernet/renesas/ravb_main.c | 6 +++---
1 file c
On 2016-08-04 15:33:18 +0200, Geert Uytterhoeven wrote:
> On Wed, Aug 3, 2016 at 3:56 PM, Niklas Söderlund
> wrote:
> > Use macro to define the runtime PM operations.
> >
> > Signed-off-by: Niklas Söderlund
>
> Duplicate of commit 524c6f691b99065577b245b250e
Use macro to define the runtime PM operations.
Signed-off-by: Niklas Söderlund
---
drivers/net/ethernet/renesas/ravb_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/renesas/ravb_main.c
b/drivers/net/ethernet/renesas/ravb_main.c
index 867caf6
wer/state'
4. Wake up system
5. Verify network is still working
Niklas Söderlund (2):
ravb: use SET_RUNTIME_PM_OPS macro
ravb: add sleep PM suspend/resume support
drivers/net/ethernet/renesas/ravb_main.c | 75 +++-
1 file changed, 65 insertions(+), 10 deletions(-)
--
2.9.0
was running when the system was suspended) or when the
interface is opened by a user at a later time.
Signed-off-by: Niklas Söderlund
---
drivers/net/ethernet/renesas/ravb_main.c | 72
1 file changed, 64 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ether
63 matches
Mail list logo
