On Fri, 6 Nov 2020, David Laight wrote:
> From: Nicolas Pitre
> > Sent: 06 November 2020 15:06
> >
> > On Fri, 6 Nov 2020, David Laight wrote:
> >
> > > From: Jakub Kicinski
> > > > Sent: 05 November 2020 22:47
> > > >
On Fri, 6 Nov 2020, David Laight wrote:
> From: Jakub Kicinski
> > Sent: 05 November 2020 22:47
> >
> > On Wed, 4 Nov 2020 16:48:57 +0100 Andrew Lunn wrote:
> > > - buf = (char*)((u32)skb->data & ~0x3);
> > > - len = (skb->len + 3 + ((u32)skb->data & 3)) & ~0x3;
> > > - cmdA = (((u32)skb->data &
On Fri, 9 Oct 2020, ira.we...@intel.com wrote:
> From: Ira Weiny
>
> The kmap() calls in this FS are localized to a single thread. To avoid
> the over head of global PKRS updates use the new kmap_thread() call.
>
> Cc: Nicolas Pitre
> Signed-off-by: Ira Weiny
Ac
On Wed, 14 Mar 2018, Arnd Bergmann wrote:
> The m32r architecture is getting removed, so this part can be
> cleaned up as well.
>
> Signed-off-by: Arnd Bergmann
Acked-by: Nicolas Pitre
> ---
> drivers/net/ethernet/smsc/Kconfig | 4 ++--
> drivers/net/ethern
e anyway.
>
> Fixes: baa73d9e478f ("posix-timers: Make them configurable")
> Cc: Nicolas Pitre
> Cc: sta...@vger.kernel.org
> Signed-off-by: Arnd Bergmann
Acked-by: Nicolas Pitre
> ---
> v2: use 'depends on' instead of 'select' as suggested by Nico.
>
On Mon, 13 Mar 2017, Nicolas Pitre wrote:
> So unless I'm mistaken I don't see any problem using "depends on
> PTP_1588_CLOCK" here.
Furthermore that wouldn't be a first. See for example
PTP_1588_CLOCK_GIANFAR, PTP_1588_CLOCK_IXP46X, DP83640_PHY, etc.
Nicolas
On Mon, 13 Mar 2017, Arnd Bergmann wrote:
> On Mon, Mar 13, 2017 at 9:09 PM, Nicolas Pitre
> wrote:
> > On Mon, 13 Mar 2017, Arnd Bergmann wrote:
> >
> >> With posix timers having become optional, we get a build error with
> >> the cpts time sync option of th
1588_CLOCK' but instead
> add a dependency on POSIX_TIMERS. Adding 'depends on PTP_1588_CLOCK'
> might also work, but has the risk of circular dependencies when
> mixed with other drivers using 'imply'.
Could you elaborate on that risk please?
> Fixes: baa73d9
':
(.text+0x40e5e1): undefined reference to `pps_register_source'
drivers/built-in.o: In function `ptp_clock_register':
(.text+0x40e62c): undefined reference to `posix_clock_register'
drivers/built-in.o: In function `ptp_clock_register':
(.text+0x40e68d): undefined reference t
On Fri, 16 Dec 2016, Arnd Bergmann wrote:
> With posix timers having become optional, we get a build error with
> the cpts time sync option of the CPSW driver:
>
> drivers/net/ethernet/ti/cpts.c: In function 'cpts_find_ts':
> drivers/net/ethernet/ti/cpts.c:291:23: error: implicit declaration of
On Mon, 5 Dec 2016, David Miller wrote:
> From: Nicolas Pitre
> Date: Mon, 5 Dec 2016 10:44:32 -0500 (EST)
>
> > On Sat, 3 Dec 2016, David Miller wrote:
> >
> >> From: Arnd Bergmann
> >> Date: Sat, 3 Dec 2016 00:04:32 +0100
> >>
> >&g
On Sat, 3 Dec 2016, David Miller wrote:
> From: Arnd Bergmann
> Date: Sat, 3 Dec 2016 00:04:32 +0100
>
> > ptp now depends on the optional POSIX_TIMERS setting and fails to build
> > if we select it without that:
> >
> > warning: (LIQUIDIO_VF && TI_CPTS) selects PTP_1588_CLOCK which has unmet
> is a result of the combination. Changing the new option to 'imply'
> as well fixes it.
>
> Fixes: 111fc64a237f ("liquidio CN23XX: VF registration")
> Fixes: d1cbfd771ce8 ("ptp_clock: Allow for it to be optional")
> Signed-off-by: Arnd Bergmann
Signed-off-by: Nicolas Pitre
---
scripts/kconfig/zconf.hash.c_shipped | 30 +-
scripts/kconfig/zconf.tab.c_shipped | 1581 --
2 files changed, 753 insertions(+), 858 deletions(-)
diff --git a/scripts/kconfig/zconf.hash.c_shipped
b/scripts/kconfig
SUBSYSTEM_X
tristate
This is much cleaner, and way more flexible than "select". SUBSYSTEM_X
can still be configured out, and it can be set as a module when none of
the drivers are configured in or all of them are modular.
Signed-off-by: Nicolas Pitre
Reviewed-by: Josh Tr
only which should cover the vast
majority of use cases with very little code.
Signed-off-by: Nicolas Pitre
Reviewed-by: Josh Triplett
Acked-by: Richard Cochran
Acked-by: Thomas Gleixner
---
arch/alpha/kernel/osf_sys.c | 8 +++
drivers/char/Kconfig| 1 +
drivers/ptp/Kconfig
relies on extra code in
drivers/ptp/ptp_pch.c. Therefore we let the make process descend into
drivers/ptp/ even if PTP_1588_CLOCK is unselected.
Signed-off-by: Nicolas Pitre
Reviewed-by: Josh Triplett
Acked-by: Richard Cochran
Acked-by: Edward Cree
Acked-by: Thomas Gleixner
---
d
There is no logical relation between add_device_randomness() and
posix_cpu_timers_exit(). Let's move the former to where the later
is called. This way, when posix-cpu-timers.c is compiled out, there
is no need to worry about not losing a call to add_device_randomness().
Signed-off-by: Ni
Many embedded systems don't need the full POSIX timer support.
Configuring them out provides a nice kernel image size reduction.
When POSIX timers are configured out, the PTP clock subsystem should be
left out as well. However a bunch of ethernet drivers currently *select*
the later in their Kconf
Move the only user of alarm_setitimer to itimer.c where it is defined.
This allows for making alarm_setitimer static, and dropping it from the
build when __ARCH_WANT_SYS_ALARM is not defined.
Signed-off-by: Nicolas Pitre
---
include/linux/time.h | 2 --
kernel/time/itimer.c | 15
On Tue, 8 Nov 2016, John Stultz wrote:
> One spot of concern is that the
> tools/testing/selftests/timers/posix_timers.c test hangs testing
> virtual itimers. Looking through the code I'm not seeing where an
> error case is missed.
>
> The strace looks like:
> ...
> write(1, "Testing posix timers
On Mon, 7 Nov 2016, Josh Triplett wrote:
> [snipping large patch]
>
> One suggestion that might make this patch easier to review: you might
> consider first regenerating the unchanged parser with Bison 3.0.4, then
> regenerating it again after the "imply" change. I think that'd
> eliminate quite
On Mon, 7 Nov 2016, Nicolas Pitre wrote:
> Many embedded systems don't need the full POSIX timer support.
> Configuring them out provides a nice kernel image size reduction.
>
> When POSIX timers are configured out, the PTP clock subsystem should be
> left out as well
Signed-off-by: Nicolas Pitre
---
scripts/kconfig/zconf.hash.c_shipped | 30 +-
scripts/kconfig/zconf.tab.c_shipped | 1581 --
2 files changed, 753 insertions(+), 858 deletions(-)
diff --git a/scripts/kconfig/zconf.hash.c_shipped
b/scripts/kconfig
vast
majority of use cases with very little code.
Signed-off-by: Nicolas Pitre
Reviewed-by: Josh Triplett
Acked-by: Richard Cochran
---
drivers/ptp/Kconfig | 2 +-
include/linux/posix-timers.h | 28 +-
include/linux/sched.h| 10
init/Kconfig | 17
relies on extra code in
drivers/ptp/ptp_pch.c. Therefore we let the make process descend into
drivers/ptp/ even if PTP_1588_CLOCK is unselected.
Signed-off-by: Nicolas Pitre
Reviewed-by: Josh Triplett
Acked-by: Richard Cochran
---
drivers/Makefile| 2 +-
drivers/n
SUBSYSTEM_X
tristate
This is much cleaner, and way more flexible than "select". SUBSYSTEM_X
can still be configured out, and it can be set as a module when none of
the drivers are configured in or all of them are modular.
Signed-off-by: Nicolas Pitre
Reviewed-by: Josh Triplett
Many embedded systems don't need the full POSIX timer support.
Configuring them out provides a nice kernel image size reduction.
When POSIX timers are configured out, the PTP clock subsystem should be
left out as well. However a bunch of ethernet drivers currently *select*
the later in their Kconf
On Sat, 29 Oct 2016, Paul Bolle wrote:
> On Tue, 2016-10-25 at 22:28 -0400, Nicolas Pitre wrote:
> > When POSIX timers are configured out, the PTP clock subsystem should be
> > left out as well. However a bunch of ethernet drivers currently *select*
> > the later in
On Fri, 28 Oct 2016, Paul Bolle wrote:
> On Thu, 2016-10-27 at 23:10 -0400, Nicolas Pitre wrote:
> > On Fri, 28 Oct 2016, Paul Bolle wrote:
> > > What happens when a tristate symbol is implied by a symbol set to 'y'
> > > and by a symbol set to 'm&#x
On Fri, 28 Oct 2016, Paul Bolle wrote:
> On Tue, 2016-10-25 at 22:28 -0400, Nicolas Pitre wrote:
> > The "imply" keyword is a weak version of "select" where the target
> > config symbol can still be turned off, avoiding those pitfalls that come
> > wi
On Thu, 27 Oct 2016, Paul Bolle wrote:
> On Tue, 2016-10-25 at 22:28 -0400, Nicolas Pitre wrote:
> > Similar to "imply" but with no added restrictions on the target symbol's
> > value. Useful for providing a default value to another symbol.
> >
> > Sug
On Thu, 27 Oct 2016, Paul Bolle wrote:
> On Tue, 2016-10-25 at 22:28 -0400, Nicolas Pitre wrote:
> > SUBSYSTEM_X can still be configured out, and it can be set as a
> > module when none of the drivers are selected or all of them are also
> > modular.
>
> Short not
On Thu, 27 Oct 2016, Paul Bolle wrote:
> On Tue, 2016-10-25 at 22:28 -0400, Nicolas Pitre wrote:
> > From: Nicolas Pitre
> > Subject: [PATCH v2 0/5] make POSIX timers optional with some Kconfig help
>
> This doesn't work. I received this message with an empty subjec
On Wed, 26 Oct 2016, Richard Cochran wrote:
> On Wed, Oct 26, 2016 at 09:56:13AM -0400, Nicolas Pitre wrote:
> > So if my Fedora usage doesn't need them, we can infer that
> > the number of embedded systems also not needing them might tend towards
> > a high percent
On Wed, 26 Oct 2016, Richard Cochran wrote:
> On Tue, Oct 25, 2016 at 10:28:51PM -0400, Nicolas Pitre wrote:
> > +config POSIX_TIMERS
> > + bool "Posix Clocks & timers" if EXPERT
> > + default y
> > + help
> > + This includes native support
Signed-off-by: Nicolas Pitre
---
scripts/kconfig/zconf.hash.c_shipped | 228 ++---
scripts/kconfig/zconf.tab.c_shipped | 1631 --
2 files changed, 888 insertions(+), 971 deletions(-)
diff --git a/scripts/kconfig/zconf.hash.c_shipped
b/scripts/kconfig
vast
majority of use cases with very little code.
Signed-off-by: Nicolas Pitre
Reviewed-by: Josh Triplett
---
drivers/ptp/Kconfig | 2 +-
include/linux/posix-timers.h | 28 +-
include/linux/sched.h| 10
init/Kconfig | 17 +++
kernel/signal.c
tristate
This is much cleaner, and way more flexible than "select". SUBSYSTEM_X
can still be configured out, and it can be set as a module when none of
the drivers are selected or all of them are also modular.
Signed-off-by: Nicolas Pitre
Reviewed-by: Josh Triplett
---
Documentatio
relies on extra code in
drivers/ptp/ptp_pch.c. Therefore we let the make process descend into
drivers/ptp/ even if PTP_1588_CLOCK is unselected.
Signed-off-by: Nicolas Pitre
Reviewed-by: Josh Triplett
---
drivers/Makefile| 2 +-
drivers/net/ether
Similar to "imply" but with no added restrictions on the target symbol's
value. Useful for providing a default value to another symbol.
Suggested by Edward Cree.
Signed-off-by: Nicolas Pitre
---
Documentation/kbuild/kconfig-language.txt | 6 ++
scripts
From: Nicolas Pitre
Subject: [PATCH v2 0/5] make POSIX timers optional with some Kconfig help
Many embedded systems don't need the full POSIX timer support.
Configuring them out provides a nice kernel image size reduction.
When POSIX timers are configured out, the PTP clock subsystem shou
On Thu, 20 Oct 2016, Nicolas Pitre wrote:
> On Thu, 20 Oct 2016, Edward Cree wrote:
>
> > I'm interpreting "imply" as being more a way of saying "if you want FOO you
> > probably want BAZ as well". But maybe that should be yet another new
> >
On Thu, 20 Oct 2016, Edward Cree wrote:
> On 20/10/16 19:29, Nicolas Pitre wrote:
> > On Thu, 20 Oct 2016, Edward Cree wrote:
> >> But the desire is a property of the user, not of the driver. If you're
> >> willing to add CONFIG_FOO_BAZ to every combination
On Thu, 20 Oct 2016, Thomas Gleixner wrote:
> On Wed, 19 Oct 2016, Nicolas Pitre wrote:
> > Therefore this series also includes kconfig changes to implement a new
> > keyword to express some reverse dependencies like "select" does, named
> > "imply",
On Thu, 20 Oct 2016, Edward Cree wrote:
> On 20/10/16 18:04, Nicolas Pitre wrote:
> > On Thu, 20 Oct 2016, Edward Cree wrote:
> >> Also, I don't think having any FOO=y should preclude BAZ=m. Suppose both
> >> FOO and FOO2 imply BAZ, FOO=y and FOO2=m.
> > Som
On Thu, 20 Oct 2016, Thomas Gleixner wrote:
> On Wed, 19 Oct 2016, Nicolas Pitre wrote:
> > The pch_gbe driver is a bit special as it relies on extra code in
> > drivers/ptp/ptp_pch.c. Therefore we let the make process descend into
> > drivers/ptp/ even if PTP_1588_CLOCK is
On Thu, 20 Oct 2016, Edward Cree wrote:
> On 20/10/16 00:42, Nicolas Pitre wrote:
> > diff --git a/Documentation/kbuild/kconfig-language.txt
> > b/Documentation/kbuild/kconfig-language.txt
> > index 069fcb3eef..c96127f648 100644
> > --- a/Documentation/kbuild/kco
On Thu, 20 Oct 2016, Richard Cochran wrote:
> On Wed, Oct 19, 2016 at 07:42:52PM -0400, Nicolas Pitre wrote:
> > +static inline void ptp_clock_event(struct ptp_clock *ptp,
> > + struct ptp_clock_event *event)
> > +{ (void)event; }
>
> Ju
On Thu, 20 Oct 2016, Richard Cochran wrote:
> On Wed, Oct 19, 2016 at 07:42:53PM -0400, Nicolas Pitre wrote:
> > +config POSIX_TIMERS
> > + bool "Posix Clocks & timers" if EXPERT
> > + default y
> > + help
> > + This includes native support
tristate
This is much cleaner, and way more flexible than "select". SUBSYSTEM_X
can still be configured out, and it can be set as a module when none of
the drivers are selected or all of them are also modular.
Signed-off-by: Nicolas Pitre
---
Documentation/kbuild/kconfi
relies on extra code in
drivers/ptp/ptp_pch.c. Therefore we let the make process descend into
drivers/ptp/ even if PTP_1588_CLOCK is unselected.
Signed-off-by: Nicolas Pitre
---
drivers/Makefile| 2 +-
drivers/net/ethernet/adi/Kconfig| 2 +-
drive
Signed-off-by: Nicolas Pitre
---
scripts/kconfig/zconf.hash.c_shipped | 30 +-
scripts/kconfig/zconf.tab.c_shipped | 1581 --
2 files changed, 753 insertions(+), 858 deletions(-)
diff --git a/scripts/kconfig/zconf.hash.c_shipped
b/scripts/kconfig
ff-by: Nicolas Pitre
---
drivers/ptp/Kconfig | 2 +-
include/linux/posix-timers.h | 28 +-
include/linux/sched.h| 10
init/Kconfig | 17 +++
kernel/signal.c | 4 ++
kernel/time/Makefile | 10 +++-
kernel/time/posix-st
Many embedded systems don't need the full POSIX timer support.
Configuring them out provides a nice kernel image size reduction.
When POSIX timers are configured out, the PTP clock subsystem should be
left out as well. However a bunch of ethernet drivers currently *select*
the later in their Kconf
W.
>
> Signed-off-by: Giuseppe Cavallaro
> Cc: Alexandre TORGUE
> Cc: Rayagond Kokatanur
> Cc: Dan Carpenter
> Cc: Nicolas Pitre
Acked-by: Nicolas Pitre
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 +-
> drivers/net/ethernet/stmicro/stmmac/stmmac_ma
Hello,
I noticed a recently added commit 7086605a6a ("stmmac: fix error check
when init ptp") to the mainline linux tree from you. This commit is
wrong. The affected code now reads as:
int stmmac_ptp_register(struct stmmac_priv *priv)
{
spin_lock_init(&priv->ptp_lock);
priv->pt
Drivers must be ready to accept NULL from ptp_clock_register() if the
PTP clock subsystem is configured out.
This patch documents that and ensures that all drivers cope well
with a NULL return.
Signed-off-by: Nicolas Pitre
Reviewed-by: Eugenia Emantayev
---
Let's have the basics merge
On Tue, 20 Sep 2016, Thomas Gleixner wrote:
> I think the whole approach is wrong because it makes the PTP split at the
> wrong level.
>
> Currently we have:
>
> DRIVER_X
> tristate "Driver X"
> select PTP
>
> In order to make POSIX_CLOCK configurable we should have
>
>
On Tue, 20 Sep 2016, Richard Cochran wrote:
> On Tue, Sep 20, 2016 at 10:25:56PM +0200, Richard Cochran wrote:
> > After this series, if I don't pay enough attention to dmesg, then I
> > have lost functionality that I had in step #1. That sucks, and it has
> > nothing to do with the tinification
On Tue, 20 Sep 2016, Richard Cochran wrote:
> On Tue, Sep 20, 2016 at 03:56:38PM -0400, Nicolas Pitre wrote:
> > - Add a warning for the case where PTP clock subsystem is modular and a
> > driver providing a clock is built-in rather than silently ignoring it.
> > S
pch_gbe driver is a bit special as it relies on extra code in
drivers/ptp/ptp_pch.c. Therefore we let the make process descend into
drivers/ptp/ even if PTP_1588_CLOCK is unselected.
Signed-off-by: Nicolas Pitre
Acked-by: Richard Cochran
Reviewed-by: Eugenia Emantayev
---
drivers/Makefile
d-off-by: Nicolas Pitre
---
drivers/ptp/Kconfig | 2 +-
include/linux/posix-timers.h | 28 +-
include/linux/sched.h| 10
init/Kconfig | 17 +++
kernel/signal.c | 4 ++
kernel/time/Kconfig | 1 +
kernel/time/Mak
Many embedded systems don't need the full POSIX timer support.
Configuring them out provides a nice kernel image size reduction.
When POSIX timers are configured out, the PTP clock subsystem should be
left out as well. However a bunch of ethernet drivers currently *select*
it in their Kconfig entr
On Mon, 19 Sep 2016, Josh Triplett wrote:
> But it does seem unfortunate that this can't happen at build time via
> Kconfig. CCing linux-kbuild in case someone has an idea for how to fix
> this.
I hoped something like this could work:
config FOO
prompt "Blah-blah"
tristate if (B
On Mon, 19 Sep 2016, Jiri Benc wrote:
> On Sun, 18 Sep 2016 23:51:09 -0400, Nicolas Pitre wrote:
> > And to make it possible for PTP to be configured out, the select statement
> > in the Kconfig entry for those ethernet drivers is changed from selecting
> &
d-off-by: Nicolas Pitre
---
drivers/ptp/Kconfig | 2 +-
include/linux/posix-timers.h | 28 +-
include/linux/sched.h| 10
init/Kconfig | 17 +++
kernel/signal.c | 4 ++
kernel/time/Kconfig | 1 +
kernel/time/Mak
Many embedded systems don't need the full POSIX timer support.
Configuring them out provides a nice kernel image size reduction.
When POSIX timers are configured out, the PTP clock subsystem should be
left out as well. However a bunch of ethernet drivers currently *select*
it in their Kconfig entr
pch_gbe driver is a bit special as it relies on extra code in
drivers/ptp/ptp_pch.c. Therefore we let the make process descend into
drivers/ptp/ even if PTP_1588_CLOCK is unselected.
Signed-off-by: Nicolas Pitre
Acked-by: Richard Cochran
---
drivers/Makefile | 2
On Wed, 31 Aug 2016, Sudip Mukherjee wrote:
> The build of m32r was giving warning:
>
> In file included from drivers/net/ethernet/smsc/smc91x.c:92:0:
> drivers/net/ethernet/smsc/smc91x.h:448:0: warning: "SMC_inb" redefined
> #define SMC_inb(ioaddr, reg) ({ BUG(); 0; })
>
> drivers/net/ethern
91x hack to assert the enable signal
>
> This results in the platform specific includes being removed from the
> SMC91x driver.
>
> Please ack these changes; due to the dependencies, I wish to merge
> them through my tree. Thanks.
Looks nice to me.
Acked-by: Nicolas Pitre
On Thu, 25 Aug 2016, Arnd Bergmann wrote:
> The ARM specific I/O operations are almost the same as the generic
> ones, with the exception of the SMC_outw macro that works around
> a problem of some platforms that cannot write to 16-bit registers
> at an address that is not 32-bit aligned.
>
> By
On Thu, 25 Aug 2016, Arnd Bergmann wrote:
> As Russell King found out the hard way, a change I did to fix multiplatform
> builds with this driver broke the old Assabet/Neponset platform: It turns
> out that while the driver is runtime configurable in principle, the
> runtime configuration does not
s in the only file
> that shows the behavior, by marking the il_adjust_beacon_interval
> function as noinline, which convinces gcc to use the unoptimized
> do_div() all the time.
>
> Signed-off-by: Arnd Bergmann
Acked-by: Nicolas Pitre
>
> diff --git a/drivers/net/wire
On Fri, 22 Feb 2008, Magnus Damm wrote:
> Removes superh board specific configuration from the header file. These boards
> will instead be configured using platform data.
>
> Signed-off-by: Magnus Damm <[EMAIL PROTECTED]>
Acked-by: Nicolas Pitre <[EMAIL PROTECTED]>
t;[EMAIL PROTECTED]>
Acked-by: Nicolas Pitre <[EMAIL PROTECTED]>
> ---
>
> drivers/net/smc91x.h |2 ++
> 1 file changed, 2 insertions(+)
>
> --- 0003/drivers/net/smc91x.h
> +++ work/drivers/net/smc91x.h 2008-02-22 15:25:39.0 +0900
> @@ -476,6
Signed-off-by: Magnus Damm <[EMAIL PROTECTED]>
Acked-by: Nicolas Pitre <[EMAIL PROTECTED]>
> ---
>
> drivers/net/smc91x.c | 34
> drivers/net/smc91x.h | 57
> +---
> include/linu
ument name from "priv" to "lp".
>
> Signed-off-by: Magnus Damm <[EMAIL PROTECTED]>
Acked-by: Nicolas Pitre <[EMAIL PROTECTED]>
> ---
>
> drivers/net/smc91x.c | 301
> +-
> drivers/net/s
On Thu, 21 Feb 2008, Magnus Damm wrote:
> On Thu, Feb 21, 2008 at 12:42 AM, Nicolas Pitre <[EMAIL PROTECTED]> wrote:
> > On Wed, 20 Feb 2008, Magnus Damm wrote:
> >
> > > Pass a private data pointer to macros and functions. This makes it easy
> > > to
On Thu, 21 Feb 2008, Magnus Damm wrote:
> On Thu, Feb 21, 2008 at 12:58 AM, Nicolas Pitre <[EMAIL PROTECTED]> wrote:
> > On Wed, 20 Feb 2008, Magnus Damm wrote:
> >
> > > This patch introduces struct smc91x_platdata and modifies the driver so
> > > bus
On Wed, 20 Feb 2008, Magnus Damm wrote:
> This patch introduces struct smc91x_platdata and modifies the driver so
> bus width is checked during run time using SMC_nBIT() instead of
> SMC_CAN_USE_nBIT.
>
> Signed-off-by: Magnus Damm <[EMAIL PROTECTED]>
> ---
NAK.
The SMC91C111 (for example) is o
On Wed, 20 Feb 2008, Magnus Damm wrote:
> This patch makes sure SMC_insw()/SMC_outsw() are defined for the
> default configuration. Without this change BUG()s will be triggered
> when using 16-bit only platform data and the default configuration.
>
> Signed-off-by: Magnus Damm <[EMAIL PROTECTED]>
On Wed, 20 Feb 2008, Magnus Damm wrote:
> Pass a private data pointer to macros and functions. This makes it easy
> to later on make run time decisions. This patch does not change any logic.
> These changes should be optimized away during compilation.
>
> Signed-off-by: Magnus Damm <[EMAIL PROTEC
On Wed, 20 Feb 2008, Magnus Damm wrote:
> These patches make it possible to request bus width in the platform data.
>
> Instead of keep on updating smc91x.h with board specific configuration,
> use platform data to pass along bus width and irq flags to the driver.
> This change is designed to be
n 'is_polling' flags, and doesn't trigger the spurious
> warning when in polling mode.
>
> Signed-off-by: Kevin Hilman <[EMAIL PROTECTED]>
> Signed-off-by: Nicolas Pitre <[EMAIL PROTECTED]>
NAK
Kevin: you sent the wrong patch !
Nicolas
--
To unsubscribe fro
rt zylonite along with all
> other PXA boards with a single binary of smc91x driver, but it looks
> quite difficult for the moment, so ugly #ifdef is still used here.
>
> Signed-off-by: Aleksey Makarov <[EMAIL PROTECTED]>
> Acked-by: eric miao <[EMAIL PROTECTED]>
Ac
gt; Nico - please review and ack if you think the patch is correct.
The lock validator is rightfully complaining and the patch is correct.
Acked-by: Nicolas Pitre <[EMAIL PROTECTED]>
Nicolas
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a mes
On Tue, 28 Mar 2006, Lennert Buytenhek wrote:
> This patch adds support for the smc91x on the LogicPD PXA270 to
> the smc91x driver.
>
> Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]>
Signed-off-by: Nicolas Pitre <[EMAIL PROTECTED]>
> Index: linux-
aner and
easier to understand, and ultimately allowing people to define
configuration symbols in terms of variables if they really want to
dynamically support multiple bus configurations at the same time (with
the unavoidable performance cost).
Signed-off-by: Nicolas Pitre <[EMAIL PROTECTED]&
it cleaner and
easier to understand, and ultimately allowing people to define
configuration symbols in terms of variables if they really want to
dynamically support multiple bus configurations at the same time (with
the unavoidable performance cost).
Signed-off-by: Nicolas Pitre <[EMAIL PROTE
On Mon, 9 Jan 2006, Jeff Garzik wrote:
> Nicolas Pitre wrote:
> > All accessor's different methods are now selected with C code and unused
> > ones statically optimized away at compile time instead of being selected
> > with #if's and #ifdef's. This has
it cleaner and
easier to understand, and ultimately allowing people to define
configuration symbols in terms of variables if they really want to
dynamically support multiple bus configurations at the same time (with
the unavoidable performance cost).
Signed-off-by: Nicolas Pitre <[EMAIL PROTE
ECTED]>
Signed-off-by: Nicolas Pitre <[EMAIL PROTECTED]>
--- a/drivers/net/smc91x.c Fri Nov 11 21:20:10 2005
+++ b/drivers/net/smc91x.c Fri Nov 18 17:33:10 2005
@@ -1207,6 +1207,7 @@ static void smc_phy_configure(void *data
smc_phy_check_media(dev, 1);
clean usage of the max IRQ loop count value).
Signed-off-by: Nicolas Pitre <[EMAIL PROTECTED]>
diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c
index c91e2e8..1021108 100644
--- a/drivers/net/smc91x.c
+++ b/drivers/net/smc91x.c
@@ -155,6 +155,12 @@ MODULE_LICENSE("GPL");
#de
94 matches
Mail list logo
