Re: [PATCH net 000/117] net: avoid to remove module when its debugfs is being used

Taehee Yoo writes: > On Fri, 9 Oct 2020 at 01:14, Johannes Berg wrote: > On Thu, 2020-10-08 at 15:59 +, David Laight wrote: > >> From: Taehee Yoo >> > Sent: 08 October 2020 16:49 >> > >> > When debugfs file is opened, its module should not be removed until >> > it's closed. >> > Because debu

Re: [PATCH net 000/117] net: avoid to remove module when its debugfs is being used

Johannes Berg writes: > On Thu, 2020-10-08 at 15:59 +, David Laight wrote: >> From: Taehee Yoo >> > Sent: 08 October 2020 16:49 >> > >> > When debugfs file is opened, its module should not be removed until >> > it's closed. >> > Because debugfs internally uses the module's data. >> > So, it

[PATCH v2] net: ipv4: emulate READ_ONCE() on ->hdrincl bit-field in raw_sendmsg()

E(hdrincl); This breaks the chain in the sense that the compiler is not allowed to replace subsequent reads from hdrincl with reloads from inet->hdrincl. Fixes: 8f659a03a0ba ("net: ipv4: fix for a race condition in raw_sendmsg") Signed-off-by: Nicolai Stange --- Compile-tested onl

Re: [PATCH] net: ipv4: emulate READ_ONCE() on ->hdrincl bit-field in raw_sendmsg()

Hi Stefano, Stefano Brivio writes: > On Tue, 2 Jan 2018 17:30:20 +0100 > Nicolai Stange wrote: > >> [...] >> >> diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c >> index 5b9bd5c33d9d..e84290c28c0c 100644 >> --- a/net/ipv4/raw.c >> +++ b/net/i

[PATCH] net: ipv4: emulate READ_ONCE() on ->hdrincl bit-field in raw_sendmsg()

int hdrincl = READ_ONCE(__hdrincl); This breaks the chain in the sense that the compiler is not allowed to replace subsequent reads from hdrincl with reloads from inet->hdrincl. Fixes: 8f659a03a0ba ("net: ipv4: fix for a race condition in raw_sendmsg") Signed-off-by: Nicolai S

Re: [PATCH net-next 10/13] debugfs: constify argument to debugfs_real_fops()

marked as such. > make parameter to debugfs_real_fops() const. > > CC: Nicolai Stange > CC: Christian Lamparter > Signed-off-by: Jakub Kicinski > --- > include/linux/debugfs.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/linux

Re: [PATCH v2] net, socket, socket_wq: fix missing initialization of flags

David Miller writes: > From: Nicolai Stange > Date: Tue, 29 Dec 2015 13:29:55 +0100 > >> Fixes: ceb5d58b2170 ("net: fix sock_wake_async() rcu protection") >> >> Commit ceb5d58b2170 ("net: fix sock_wake_async() rcu protection") from >> the cu

Re: Linux 4.4-rc4 regression, bisected to "net: fix sock_wake_async() rcu protection"

Andy Lutomirski writes: > On recent v4.4-rc releases, I can't run emacs. No, really, running > "emacs" in a GNOME 3 session makes gnome-shell think that emacs is > running, but no window is drawn, and the overall system UI is a bit > weird when the invisible emacs window is focused. > > This is

[PATCH v2] net, socket, socket_wq: fix missing initialization of flags

inode() set the newly created struct socket_wq's ->flags member to zero. Signed-off-by: Nicolai Stange --- Changes to V1 (only commit message changes): - Uhm, I misread sock_wake_async(). The meaning of the flags is actually inverted. My Ghostmacs wasn't waiting for free send sp

[PATCH] net, socket, socket_wq: fix missing initialization of flags

ake sock_alloc_inode() set the newly created struct socket_wq's ->flags member to zero. Signed-off-by: Nicolai Stange --- net/socket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/socket.c b/net/socket.c index 29822d6..d730ef9 100644 --- a/net/socket.c +++ b/net/sock

Re: [PATCH] lib: test_bpf: purge CPP register redefinitions

Richard Weinberger writes: > While riding the bus to my office I've materialized that idea. > Nicolai, can you please give the attached patch a try? W/o my test_bpf patch applied, w/ your patch applied: - linux mainline: um compiles - linux-next: um compiles up to this mfd/syscon issue communica

Re: [PATCH] isdn: disable HiSax NetJet driver on microblaze arch

Jean Delvare writes: > Le Sunday 21 June 2015 à 19:59 +0200, Nicolai Stange a écrit : >> David Miller writes: >>> Applied, but we're long overdue for an across-the-board-available >>> endianness Kconfig option that can flat out be used in these situations. >&g

[PATCH] lib: test_bpf: purge CPP register redefinitions

from lib/test_bpf.c:19: arch/x86/include/uapi/asm/ptrace-abi.h:42:0: note: this is the location of the previous definition #define R8 72 Get rid of the #define Rx BPF_REG_x defines by substituting the Rx macros with their BPF_REG_x expansion in test_bpf.c. Signed-off-by: Nico

Re: [PATCH] isdn: disable HiSax NetJet driver on microblaze arch

David Miller writes: >> Note that endianess on microblaze is not determined through Kconfig, >> but by means of a compiler provided CPP macro, namely __MICROBLAZEEL__. >> However, gcc defaults to big endianess on that platform. > Applied, but we're long overdue for an across-the-board-available >

Re: [PATCH] isdn: disable HiSax NetJet driver on microblaze arch

> Acked-by: Jean Delvare Jean, thank you very much for your prompt reaction! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] isdn: disable HiSax NetJet driver on microblaze arch

form. Signed-off-by: Nicolai Stange --- The maintainer tree listed under "ISDN SUBSYSTEM" in MAINTAINERS does not exist anymore. I created the diff against the Linus tree. drivers/isdn/hisax/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/isdn/hisa