Add support for programmable MAC impedance configuration
Signed-off-by: Mugunthan V N
---
drivers/net/phy/dp83867.c | 28
1 file changed, 28 insertions(+)
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index 91177a4..1b63924 100644
--- a/drivers
nrent implementation.
* Corrected the phy delay timings to the optimal value.
[1] - http://www.ti.com/lit/ds/symlink/dp83867ir.pdf
[2] - http://pastebin.ubuntu.com/23343139/
[3] - git://git.ti.com/~mugunthanvnm/ti-linux-kernel/linux.git dp83867-v4
Mugunthan V N (4):
net: phy: dp83867: Add document
The default impedance settings of the phy is not the optimal
value, due to this the second ethernet is not working. Fix it
with correct values which makes the second ethernet port to work.
Signed-off-by: Mugunthan V N
---
arch/arm/boot/dts/dra72-evm-revc.dts | 2 ++
1 file changed, 2 insertions
Add documention of ti,min-output-impedance and ti,max-output-impedance
which can be used to correct MAC impedance mismatch using phy extended
registers.
Signed-off-by: Mugunthan V N
---
Documentation/devicetree/bindings/net/ti,dp83867.txt | 12
1 file changed, 12 insertions
The current delay settings of the phy are not the optimal value,
fix it with correct values.
Signed-off-by: Mugunthan V N
---
arch/arm/boot/dts/dra72-evm-revc.dts | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/dra72-evm-revc.dts
b/arch/arm/boot
On Monday 10 October 2016 06:48 PM, Rob Herring wrote:
> On Thu, Oct 06, 2016 at 10:43:52AM +0530, Mugunthan V N wrote:
>> Add documention of ti,impedance-control which can be used to
>
> Needs updating.
Oops, will update this in next version.
>
>> correct MAC impe
Add documention of ti,impedance-control which can be used to
correct MAC impedance mismatch using phy extended registers.
Signed-off-by: Mugunthan V N
---
Documentation/devicetree/bindings/net/ti,dp83867.txt | 12
1 file changed, 12 insertions(+)
diff --git a/Documentation
timal value.
[1] - http://www.ti.com/lit/ds/symlink/dp83867ir.pdf
[2] - http://pastebin.ubuntu.com/23283056/
[3] - git://git.ti.com/~mugunthanvnm/ti-linux-kernel/linux.git dp83867-v3
Mugunthan V N (4):
net: phy: dp83867: Add documentation for optional impedance control
net: phy: dp83867
Add support for programmable MAC impedance configuration
Signed-off-by: Mugunthan V N
---
drivers/net/phy/dp83867.c | 28
1 file changed, 28 insertions(+)
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index 91177a4..1b63924 100644
--- a/drivers
The current delay settings of the phy are not the optimal value,
fix it with correct values.
Signed-off-by: Mugunthan V N
---
arch/arm/boot/dts/dra72-evm-revc.dts | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/dra72-evm-revc.dts
b/arch/arm/boot
The default impedance settings of the phy is not the optimal
value, due to this the second ethernet is not working. Fix it
with correct values which makes the second ethernet port to work.
Signed-off-by: Mugunthan V N
---
arch/arm/boot/dts/dra72-evm-revc.dts | 2 ++
1 file changed, 2 insertions
On Tuesday 04 October 2016 06:41 PM, Lokesh Vutla wrote:
>
> On Tuesday 04 October 2016 06:26 PM, Mugunthan V N wrote:
>> > The default impedance settings of the phy is not the optimal
>> > value, due to this the second ethernet is not working. Fix it
>> > wi
min-output-imepdance"))
>
> Did you really test this? Or did you make the same typos in your device
> tree file?
>
I have tested this and attached the log in cover letter. Since there is
a typo error on both dts and driver it worked as expected. Will send a
v3 ASAP.
Regards
Mugunthan V N
Add support to enable CPSW RGMII internal delay (id mode) bits
when rgmii internal delay is configured in phy.
Signed-off-by: Mugunthan V N
---
drivers/net/ethernet/ti/cpsw-phy-sel.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/net/ethernet/ti/cpsw-phy-sel.c
b
mlink/dp83867ir.pdf
[2] - http://pastebin.ubuntu.com/23274616/
[3] - git://git.ti.com/~mugunthanvnm/ti-linux-kernel/linux.git dp83867-v2
Mugunthan V N (4):
net: phy: dp83867: Add documentation for optional impedance control
net: phy: dp83867: add support for MAC impedance configuration
ARM: dts:
Add support for programmable MAC impedance configuration
Signed-off-by: Mugunthan V N
---
drivers/net/phy/dp83867.c | 28
1 file changed, 28 insertions(+)
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index 91177a4..795ae17 100644
--- a/drivers
The current delay settings of the phy are not the optimal value,
fix it with correct values.
Signed-off-by: Mugunthan V N
---
arch/arm/boot/dts/dra72-evm-revc.dts | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/dra72-evm-revc.dts
b/arch/arm/boot
The default impedance settings of the phy is not the optimal
value, due to this the second ethernet is not working. Fix it
with correct values which makes the second ethernet port to work.
Signed-off-by: Mugunthan V N
---
arch/arm/boot/dts/dra72-evm-revc.dts | 2 ++
1 file changed, 2 insertions
Add documention of ti,impedance-control which can be used to
correct MAC impedance mismatch using phy extended registers.
Signed-off-by: Mugunthan V N
---
Documentation/devicetree/bindings/net/ti,dp83867.txt | 12
1 file changed, 12 insertions(+)
diff --git a/Documentation
another, let every channel to have its
> own piece of pool.
>
> Signed-off-by: Ivan Khoronzhuk
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
> Signed-off-by: Ivan Khoronzhuk
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
's with single-queue default mode.
>
> The statistic for every channel can be read with:
> $ ethtool -S ethX
>
> Signed-off-by: Ivan Khoronzhuk
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
roses only for internal use.
>
> Signed-off-by: Ivan Khoronzhuk
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
On Tuesday 16 August 2016 04:55 AM, Ivan Khoronzhuk wrote:
> These ops allow to control number of channels driver is allowed to
> work with at cpdma level. The maximum number of channels is 8 for
> rx and 8 for tx. In dual_emac mode the h/w channels are shared
> between two interfaces and changing
is stopping while not all packets were handled
> with NAPIs.
>
> Signed-off-by: Ivan Khoronzhuk
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
by: Mugunthan V N
Regards
Mugunthan V N
mber of irqs to 2, as anyway, driver is using only 2,
> at least for now.
>
> Signed-off-by: Ivan Khoronzhuk
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
On Wednesday 10 August 2016 04:52 AM, Ivan Khoronzhuk wrote:
> The napi structs are common for both net devices in dual_emac
> mode, In order to not hold duplicate links to them, move to
> cpsw_common.
>
> Signed-off-by: Ivan Khoronzhuk
> ---
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
ich belongs to DEV MMIO space. Kmemleak does not scan IO
> memory and so reports memory leaks.
>
> Hence, mark allocated sk buffers as false positive explicitly.
>
> Cc: Catalin Marinas
> Signed-off-by: Grygorii Strashko
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
k
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
On Wednesday 10 August 2016 04:52 AM, Ivan Khoronzhuk wrote:
> These data are common for net devs in dual_emac mode. No need to hold
> it for every priv instance, so move them under cpsw_common.
>
> Signed-off-by: Ivan Khoronzhuk
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
On Wednesday 10 August 2016 04:52 AM, Ivan Khoronzhuk wrote:
> This patch simply create holder for common data and as a start moves
> pdev var to it.
>
> Signed-off-by: Ivan Khoronzhuk
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
On Wednesday 10 August 2016 04:52 AM, Ivan Khoronzhuk wrote:
> No need to hold pdev link when only dev is needed.
> This allows to simplify a bunch of cpsw->pdev->dev now and farther.
>
> Signed-off-by: Ivan Khoronzhuk
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
On Wednesday 10 August 2016 04:52 AM, Ivan Khoronzhuk wrote:
> The pointers on h/w registers are common for every cpsw_private
> instance, so no need to hold them for every ndev.
>
> Signed-off-by: Ivan Khoronzhuk
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
DMA has been
> switched to use genalloc, and may get wrong values on SMP.
>
> Hence, remove used_desc from struct cpdma_desc_pool.
>
> Signed-off-by: Grygorii Strashko
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
be
> moved out of the critical section.
>
> Signed-off-by: Uwe Kleine-König
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
On Saturday 06 August 2016 04:18 PM, Ivan Khoronzhuk wrote:
> No need to check const slave num in runtime for every packet,
> and ndev for slaves w/o ndev is anyway NULL. So remove redundant
> check.
>
> Signed-off-by: Ivan Khoronzhuk
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
On Saturday 06 August 2016 04:18 PM, Ivan Khoronzhuk wrote:
> There is no need to hold link to clk, it's used only once
> while probe.
>
> Signed-off-by: Ivan Khoronzhuk
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
On Saturday 06 August 2016 04:18 PM, Ivan Khoronzhuk wrote:
> There is no need in priv here.
>
> Signed-off-by: Ivan Khoronzhuk
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
On Saturday 06 August 2016 04:18 PM, Ivan Khoronzhuk wrote:
> No need to check number of handled packets, when in most cases (> 99%)
> it's not 0. It can be 0 only in rare cases, even in this case
> it's not bad to print just 0.
>
> Signed-off-by: Ivan Khoronzhuk
On Saturday 06 August 2016 04:18 PM, Ivan Khoronzhuk wrote:
> As second net dev is created only in case of dual_emac mode, port
> number can be figured out in simpler way. Also no need to pass
> redundant ndev struct.
>
> Signed-off-by: Ivan Khoronzhuk
Reviewed-by: Muguntha
+omap ML
On Monday 01 August 2016 12:32 PM, Peter Chen wrote:
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Signed-off-by: Peter Chen
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
hy %s\n",
>>> priv->phy_node->full_name);
>>>
>>
>> phy_node is accessed in case of of_phy_connect() returns error, so it has to
>> be
>> moved after the dev_err log
>>
>
> Yeah, you are right. I will change it, thanks.
>
I see one more problem, when you stop and open the interface there is no
way to get the phy_node and interface will be unusable, so of_node_put()
should be moved to remove()
Regards
Mugunthan V N
ure that all steps done in
> of_platform_populate() are reverted, including cleaning up of
> OF_POPULATED flag.
>
> Signed-off-by: Grygorii Strashko
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
ces are down.
>
> Hence, ensure that CPSW powered up by PM runtime before performing any
> deinitialization actions which require CPSW registers access. In case
> of PM runtime error just leave cpsw_remove() as we can't do anything
> anymore.
>
> Signed-off-by: Grygorii
rnet: ti: cpsw: use destroy ctlr to destroy channels") was merged.
>
> Signed-off-by: Grygorii Strashko
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
t; dev_err(emac_dev, "could not connect to phy %s\n",
> priv->phy_node->full_name);
>
phy_node is accessed in case of of_phy_connect() returns error, so it
has to be moved after the dev_err log
Regards
Mugunthan V N
Rob,
On Friday 22 July 2016 02:44 AM, Rob Herring wrote:
> On Thu, Jul 21, 2016 at 11:52:36AM +0530, Sekhar Nori wrote:
>> Nishanth,
>>
>> On Wednesday 20 July 2016 09:03 PM, Nishanth Menon wrote:
>>> On 07/20/2016 09:56 AM, Mugunthan V N wrote:
>>>> Add
Add documention of ti,impedance-control which can be used to
correct MAC impedance mismatch using phy extended registers.
Signed-off-by: Mugunthan V N
---
Documentation/devicetree/bindings/net/ti,dp83867.txt | 7 +++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree
Second ethernet of cpsw is not working, make it work by adding
impedance configuration.
Signed-off-by: Mugunthan V N
---
arch/arm/boot/dts/dra72-evm-revc.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/dra72-evm-revc.dts
b/arch/arm/boot/dts/dra72-evm-revc.dts
index
Add support for programmable MAC impedance configuration
Signed-off-by: Mugunthan V N
---
drivers/net/phy/dp83867.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index 91177a4..ace3558 100644
--- a/drivers/net
Add support for configurable impedance control for TI dp83867
phy via devicetree. More documentation in [1]
CPSW second ethernet is not working, fix it by enabling
impedance configuration on the phy.
Public Datasheet - http://www.ti.com/lit/ds/symlink/dp83867ir.pdf
Mugunthan V N (3):
net: phy
ed
> - davinci_mdio DT updated with proper description of allowed compatible
> strings
> combinations
>
> Link on v1:
> https://lkml.org/lkml/2016/6/15/362
For the series.
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
>
> Grygorii Strashko (15):
> drivers: ne
loc_coherent()). Hence, switch to using genalloc and add
> desc_num property for each channel for limitation of max number of
> allowed descriptors for each CPDMA channel. This patch do not affect
> on net throuput.
>
> Tested-by: Ivan Khoronzhuk
> Signed-off-by: Grygorii Strashko
Ack
\
>> } while (0)
>>
>> +static void cpdma_desc_pool_destroy(struct cpdma_desc_pool *pool)
>> +{
>> +if (!pool)
>> +return;
>> +
>> +WARN_ON(pool->used_desc);
>> +if (pool->cpumap) {
>> +dma_free_coherent(
loc_coherent()). Hence, switch to using genalloc and add
> desc_num property for each channel for limitation of max number of
> allowed descriptors for each CPDMA channel. This patch do not affect
> on net throuput.
>
> Cc: Ivan Khoronzhuk
> Signed-off-by: Grygorii Strashko
Ack
.
>
> Based on
> git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
> master
>
> Since v2:
> - add declaration of buf_num in correct order
>
> Since v1:
> - separate device tree and driver patches
> - return number of rx buffers from cpdma driver
&g
On Tuesday 14 June 2016 06:08 PM, Ivan Khoronzhuk wrote:
>
>
> On 13.06.16 18:19, Andrew F. Davis wrote:
>> On 06/13/2016 03:22 AM, Mugunthan V N wrote:
>>> On Saturday 11 June 2016 04:34 AM, Schuyler Patton wrote:
>>>>
>>>>
&g
umber of rx descs
>> and throughput
>> split between channels
>
> With gigabit networks 64 or 128 rx descriptors is not going to enough to
> fix the
> DMA overrun problem. Usually we set this number to an arbitrarily large
> 2000
> descriptors in external DDR to demonstrate it is possible to not drop
> packets. All
> this does is move the problem higher up so that the drops occur in network
> stack if the ARM is overloaded. With the high speed networks I would like
> to propose that the descriptor pool or pools are moved to DDR by
> default. It would
> be nice to have some reconfigurability or set a pool size that reduces
> or eliminates
> the DMA issue that is seen in these types of applications.
>
> This test gets used a lot, which is to send very short UDP packets. If I
> have the math
> right, a 52 byte (64 byte with the inter-frame gap) UDP packet the
> default 64
> descriptors gets consumed in roughly 33uS. There are the switch fifos
> which will also
> allow some headroom, but a user was dropping packets at the switch when
> they
> were bursting 360 packets at the processor on a gigabit link
>
I too agree that rx-descs can be derived from the pool size and
descriptor size in driver itself. The current driver uses bd_ram_size to
set the pool size when the descriptors are placed in DDR which is wrong.
Here I propose an idea to solve Schuyler's concern to keep the
descriptors in DDR when a system need more rx descriptors for lossless
UDB performance.
The DT property rx-descs can be removed and add a new DT property
*pool_size* to add support for descriptors memory size in DDR and define
a pool size which the system needs for a network to have lossless UDP
transfers.
So based on no_bd_ram DT entry, the driver can decide whether it can use
internal BD-ram or DDR to initialize the cpdma driver.
Regards
Mugunthan V N
kb_padto(skb, CPSW_MIN_PACKET_SIZE)) {
> cpsw_err(priv, tx_err, "packet pad failed\n");
for cpsw
Acked-by: Mugunthan V N
Regards
Mugunthan V N
deprecated, as phy-handle should be
> used instead.
>
> Signed-off-by: David Rivshin
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
uot;net: davinci_emac: Add support for fixed-link PHY")
> Signed-off-by: Neil Armstrong
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
llowing [1]:
> - emac0 with phy_id and emac1 with fixed phy
> - emac0 with phy-handle and emac1 with fixed phy
> - emac0 with fixed phy and emac1 with fixed phy
>
>
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
as the reviewer.
>
> Cc: "David S. Miller"
> Cc: Tony Lindgren
> Cc: Mugunthan V N
> Cc: Richard Cochran
> Signed-off-by: Grygorii Strashko
Acked-by: Mugunthan V N
Regards
Mugunthan V N
changed, 21 insertions(+), 31 deletions(-)
>
Reviewed-by: Mugunthan V N
Regards
Mugunthan V N
On Friday 01 April 2016 05:39 PM, Grygorii Strashko wrote:
> On 03/31/2016 10:52 AM, Yegor Yefremov wrote:
>> On Thu, Mar 31, 2016 at 8:37 AM, Mugunthan V N wrote:
>>> On Thursday 31 March 2016 01:17 AM, Peter Korsgaard wrote:
>>>>>>>>> "
On Thursday 31 March 2016 01:22 PM, Yegor Yefremov wrote:
> On Thu, Mar 31, 2016 at 8:37 AM, Mugunthan V N wrote:
>> On Thursday 31 March 2016 01:17 AM, Peter Korsgaard wrote:
>>>>>>>> "Mugunthan" == Mugunthan V N writes:
>>>
>>>
On Thursday 31 March 2016 01:17 AM, Peter Korsgaard wrote:
>>>>>> "Mugunthan" == Mugunthan V N writes:
>
> Hi,
>
> > You had received these packets as tcpdump will enable promiscuous mode
> > so that you receive all the packets from the wire.
On Wednesday 30 March 2016 02:05 PM, Yegor Yefremov wrote:
> On Wed, Mar 30, 2016 at 7:33 AM, Mugunthan V N wrote:
>> On Tuesday 29 March 2016 06:14 PM, Grygorii Strashko wrote:
>>> On 03/29/2016 03:35 PM, Yegor Yefremov wrote:
>>>> On Tue, Mar 29, 2016 at 1:05 PM,
On Tuesday 29 March 2016 06:14 PM, Grygorii Strashko wrote:
> On 03/29/2016 03:35 PM, Yegor Yefremov wrote:
>> On Tue, Mar 29, 2016 at 1:05 PM, Grygorii Strashko
>> wrote:
>>> On 03/29/2016 08:21 AM, Yegor Yefremov wrote:
>>>> Hi Mugunthan,
>>>>
>
ve and send multicast packets via VLAN.
Are you trying multicast tx/rx on eth1 or eth1.100?
>
> This setup was tested with both 3.18.21 and 4.5 kernels.
>
> Any idea?
>
> [1] https://pymotw.com/2/socket/multicast.html
>
--
Regards
Mugunthan V N
ovide a
> breadcrumb to follow.
>
> Cc: Mugunthan V N
> Signed-off-by: David Rivshin
Acked-by: Mugunthan V N
Regards
Mugunthan V N
> Let's fix the issue by adding handling for dm814x.
>
> Cc: Mugunthan V N
> Signed-off-by: Tony Lindgren
Acked-by: Mugunthnan V N
Regards
Mugunthan V N
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to major
On Wednesday 04 November 2015 02:39 AM, Markus Brunner wrote:
> Add support for a fixed-link devicetree sub-node in case the the
> cpsw MAC is directly connected to a non-mdio PHY/device.
>
> Signed-off-by: Markus Brunner
Looks good to me.
Acked-by: Mugunthan V N
Regards
M
On Friday 09 October 2015 03:36 PM, Mugunthan V N wrote:
> cpdma is capable of placing the dma descriptors in ddr using
> dma_alloc_coherent() when the internal bd ram size is not enough.
> To utilize this feature pass the DT parameter "no_bd_ram" and
> increase bd_ram
cpdma is capable of placing the dma descriptors in ddr using
dma_alloc_coherent() when the internal bd ram size is not enough.
To utilize this feature pass the DT parameter "no_bd_ram" and
increase bd_ram_size and number of rx descriptors.
Signed-off-by: Mugunthan V N
---
drivers/ne
There are 2 MACIDs stored in the control module of the dra7.
These are read by the cpsw driver if no valid MACID was found
in the devicetree.
Signed-off-by: Mugunthan V N
---
arch/arm/boot/dts/dra7.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm
There are 2 MACIDs stored in the control module of the am4372.
These are read by the cpsw driver if no valid MACID was found
in the devicetree.
Signed-off-by: Mugunthan V N
---
arch/arm/boot/dts/am4372.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch
Did a boot test on dra7-evm [1] and am437x-gp-evm [2].
Pushed a branch [3] for others to test the patch.
[1]: http://pastebin.ubuntu.com/12513420/
[2]: http://pastebin.ubuntu.com/12513428/
[3]: git://git.ti.com/~mugunthanvnm/ti-linux-kernel/linux.git
cpsw-macid-read-support
Mugunthan V N (4
Moving mac address reading from ethernet driver to common
file for better maintenance and for code reusable.
Signed-off-by: Mugunthan V N
---
drivers/net/ethernet/ti/cpsw-common.c | 58 --
drivers/net/ethernet/ti/cpsw.c | 11 +++
drivers/net/ethernet
Adding support for reading mac address using syscon driver for
dra7 and am437x platforms
Signed-off-by: Mugunthan V N
---
drivers/net/ethernet/ti/cpsw-common.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/ethernet/ti/cpsw-common.c
b/drivers/net/ethernet/ti/cpsw
in DT when gpio
based muxing is required. This will throw a warning when gpio
get fails and returns probe defer. When gpio-pcf857x module is
installed, cpsw probes again and ethernet becomes functional.
Verified this on DRA72x with pcf as module and ramdisk.
Signed-off-by: Mugunthan V N
---
in DT when gpio
based muxing is required. This will throw a warning when gpio
get fails and returns probe defer. When gpio-pcf857x module is
installed, cpsw probes again and ethernet becomes functional.
Verified this on DRA72x with pcf as module and ramdisk.
Signed-off-by: Mugunthan V N
---
Chang
On Tuesday 01 September 2015 09:06 PM, Tony Lindgren wrote:
> * Mugunthan V N [150901 04:28]:
>> --- a/Documentation/devicetree/bindings/net/cpsw.txt
>> +++ b/Documentation/devicetree/bindings/net/cpsw.txt
>> @@ -26,6 +26,9 @@ Optional properties:
>> - dual_emac
uot; in DT when
gpio based muxing is required. This will through a warning when
vgpio get fails and returns probe defer. When gpio-pcf857x module
is installed, cpsw probes again and ethernet becomes functional.
Verified this on DRA72x with pcf as module and ramdisk [1]
Signed-off-by: Mugunthan
On Monday 24 August 2015 03:34 PM, Sekhar Nori wrote:
> Hi Mugunthan,
>
> On Wednesday 12 August 2015 03:22 PM, Mugunthan V N wrote:
>> > +static const struct of_device_id cpsw_of_mtable[] = {
>> > + { .compatible = "ti,cpsw", .data = &cpsw_devtype[CPS
inter
device timeout to HZ (which is 1S).
Signed-off-by: Mugunthan V N
---
net/ipv4/ipconfig.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index 8e7328c..ed4ef09 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c
@@ -94,7
CPSW driver has been updated with compatibles for enabling errata
workarounds. So updating cpsw compatibles.
Signed-off-by: Mugunthan V N
---
arch/arm/boot/dts/am33xx.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts
pending and CPU is struck in ISR, the
workaround is to disable the interrupts in ARM irq controller.
[1] http://www.ti.com/lit/er/sprz360f/sprz360f.pdf
Signed-off-by: Mugunthan V N
---
drivers/net/ethernet/ti/cpsw.c | 83 +++---
1 file changed, 77 insertions
controller for AM335x SoC
in addition to the masking of interrupts in CPSW.
Mugunthan V N (3):
drivers: net: cpsw: add am335x errata workarround for interrutps
ARM: dts: dra7: update cpsw compatible
ARM: dts: am33xx: update cpsw compatible
arch/arm/boot/dts/am33xx.dtsi | 2 +-
arch/arm/boo
CPSW driver has been updated with compatibles for enabling errata
workarounds. So updating cpsw compatibles.
Signed-off-by: Mugunthan V N
---
arch/arm/boot/dts/dra7.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
ommandline: console=ttyO0,115200n8 console=ttyO0,115200n8 ip=dhcp
> root=/dev/nfs nfsroot=$IP:$NFS_EXPORT,v3,tcp
>
I am already looking into it. Will submit a fix soon. The issue is with
AM335x PG1.0 as there is a errata in CPSW interrupts, PG2.x and other
SoCs are working fine.
Regards
M
/* Inter-device timeout: 1/2
>> > second */
>> > +#define CONF_INTER_TIMEOUT(HZ)/* Inter-device timeout: 1/2
>> > second */
> You should update comment as well at least.
Will update in next version.
Regards
Mugunthan V N
--
To unsubscribe from this list: sen
inter
device timeout to HZ (which is 1S).
Signed-off-by: Mugunthan V N
---
net/ipv4/ipconfig.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index 8e7328c..bdb8cb5 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c
@@ -94,7
Since interrupt is shared between the two ethernet interface and
in isr only one napi is scheduled at an instance so having two
napis doesn't make any difference. So making napi also as a
common resource for the dual ethernet interfaces.
Signed-off-by: Mugunthan V N
---
drivers/net/ethern
CPSW interrupts can be disabled by masking CPSW interrupts and
clearing interrupt by writing appropriate EOI. So removing all
disable_irq/enable_irq as discussed in [1]
[1] http://patchwork.ozlabs.org/patch/492741/
Signed-off-by: Mugunthan V N
---
drivers/net/ethernet/ti/cpsw.c | 27
Instead of processing tx events in isr adding separate napi for
tx which improves performance by ~180Mbps with
omap2plus_defconfig on DRA74x platform. Also cleaning up rx napis
by renaming to napi_rx for better understanding the code.
Signed-off-by: Mugunthan V N
---
drivers/net/ethernet/ti
both interface and only one napi is
scheduled for each interrupt.
Mugunthan V N (3):
drivers: net: cpsw: remove disable_irq/enable_irq as irq can be
masked from cpsw itself
drivers: net: cpsw: dual_emac: simplify napi usage
drivers: net: cpsw: add separate napi for tx
drivers/net
On Thursday 30 July 2015 04:27 AM, Francois Romieu wrote:
> Mugunthan V N :
>> On Wednesday 29 July 2015 04:00 AM, Francois Romieu wrote:
>>> Mugunthan V N :
>>>> On Tuesday 28 July 2015 02:52 AM, Francois Romieu wrote:
> [...]
>>>>> cpsw_ndo_stop
On Wednesday 29 July 2015 04:00 AM, Francois Romieu wrote:
> Mugunthan V N :
>> On Tuesday 28 July 2015 02:52 AM, Francois Romieu wrote:
>>> Mugunthan V N :
> [...]
>>>> @@ -752,13 +753,22 @@ static irqreturn_t cpsw_tx_interrupt(int irq, void
>>>
1 - 100 of 114 matches
Mail list logo
