Hello,
>net/ieee802154/nl802154.c: In function 'nl802154_list_associations':
> >> net/ieee802154/nl802154.c:1778:15: error: implicit declaration of function
> >> 'nl802154_prepare_wpan_dev_dump' [-Werror=implicit-function-declaration]
> 1778 | err = nl802154_prepare_wpan_dev_dum
Hi Alexander,
aahri...@redhat.com wrote on Mon, 18 Sep 2023 19:01:14 -0400:
> Hi,
>
> On Mon, Sep 18, 2023 at 10:15 AM Miquel Raynal
> wrote:
> >
> > Hi Alexander,
> >
> >
> > > > > > > +// SPDX-License-Identifier: GPL-2.0
> &g
maximum number of associations, which will lead to an
access denied error status returned to the peers trying to associate.
Signed-off-by: Miquel Raynal
---
include/net/cfg802154.h | 1 +
net/ieee802154/core.c | 2 ++
net/mac802154/cfg.c | 1 +
net/mac802154/scan.c| 33
Hi Alexander,
> > > > > +// SPDX-License-Identifier: GPL-2.0
> > > > > +/*
> > > > > + * IEEE 802.15.4 PAN management
> > > > > + *
> > > > > + * Copyright (C) 2021 Qorvo US, Inc
> > &g
itself disassociated anyway.
Signed-off-by: Miquel Raynal
---
net/ieee802154/pan.c | 2 +
net/mac802154/cfg.c | 100 +++
net/mac802154/ieee802154_i.h | 4 ++
net/mac802154/scan.c | 60 +
4 files changed, 166 insertions
the short address allocated for
the peer and expecting it to be ack'ed.
If anything fails during this procedure, the peer is considered not
associated.
Signed-off-by: Miquel Raynal
---
include/net/cfg802154.h | 7 ++
include/net/ieee802154_netdev.h | 6 ++
net/ieee802154/c
Introduce structures to describe peer devices in a PAN as well as a few
related helpers. We basically care about:
- Our unique parent after associating with a coordinator.
- Peer devices, children, which successfully associated with us.
Signed-off-by: Miquel Raynal
---
include/net/cfg802154.h
epted or not.
Signed-off-by: Miquel Raynal
---
include/net/cfg802154.h | 8
include/net/nl802154.h| 2 ++
net/ieee802154/core.c | 1 +
net/ieee802154/nl802154.c | 28
net/ieee802154/pan.c | 8
5 files changed, 47 insertions(+)
Soon association and disassociation will be implemented, which will
require to be able to either change the PAN ID from 0x to a real
value when association succeeded, or to reset the PAN ID to 0x upon
disassociation. Let's allow to do that manually for now.
Signed-off-by: Miquel R
en allocating a child short address: it must be
different than ours.
* Rebased on top of v6.5.
Miquel Raynal (11):
ieee802154: Let PAN IDs be reset
ieee802154: Internal PAN management
ieee802154: Add support for user association requests
mac802154: Handle associating
ieee802154: Add s
Users may decide to associate with a peer, which becomes our parent
coordinator. Let's add the necessary netlink support for this.
Signed-off-by: Miquel Raynal
---
include/net/cfg802154.h | 4 +++
include/net/ieee802154_netdev.h | 38 +
include/net/nl8
Upon request, we must be able to provide to the user the list of
associations currently in place. Let's add a new netlink command and
attribute for this purpose.
Signed-off-by: Miquel Raynal
---
include/net/nl802154.h| 18 ++-
net/ieee802154/nl802154.c
A device may decide at some point to disassociate from a PAN, let's
introduce a netlink command for this purpose.
Signed-off-by: Miquel Raynal
---
include/net/cfg802154.h | 3 +++
include/net/ieee802154_netdev.h | 11 +
include/net/nl802154.h | 1 +
net/ieee8
tures.
Signed-off-by: Miquel Raynal
---
net/mac802154/ieee802154_i.h | 2 ++
net/mac802154/rx.c | 8 ++
net/mac802154/scan.c | 52
3 files changed, 62 insertions(+)
diff --git a/net/mac802154/ieee802154_i.h b/net/mac802154/ieee802154_i.h
association response contains the association status, eventually a
reason if the association was unsuccessful, and finally a short address
that we should use for intra-PAN communication from now on, if we
required one (which is the default, and not yet configurable).
Signed-off-by: Miquel Raynal
th a coordinator: for now only the extended address of the
> coordinator is relevant so this is the only address we care about.
> * Drop a useless NULL check before a kfree() call.
> * Add a check when allocating a child short address: it must be
> different than ours.
> * Rebased on
Hello,
aahri...@redhat.com wrote on Sun, 17 Sep 2023 07:50:55 -0400:
> Hi,
>
> On Sat, Sep 16, 2023 at 11:39 AM Stefan Schmidt
> wrote:
> >
> > Hello Miquel.
> >
> > On 01.09.23 19:04, Miquel Raynal wrote:
> > > Introduce structures to de
Hi Stefan,
> > +static int
> > +mac802154_send_association_resp_locked(struct ieee802154_sub_if_data
> > *sdata,
> > + struct ieee802154_pan_device *target,
> > + struct ieee802154_assoc_resp_pl
> > *assoc_resp_pl)
> > +{
> > +
Hi Stefan,
ste...@datenfreihafen.org wrote on Sat, 16 Sep 2023 17:36:41 +0200:
> Hello Miquel.
>
> On 01.09.23 19:05, Miquel Raynal wrote:
> > Upon request, we must be able to provide to the user the list of
> > associations currently in place. Let's add a new netlink
Hi Thomas,
Thomas Bogendoerfer wrote on Tue, 5 Jan
2021 15:02:51 +0100:
> CPU support for TX49xx is getting removed, so remove MTD support for it.
>
> Signed-off-by: Thomas Bogendoerfer
If the removal happens, you may take this patch through the mips tree.
Acked-by: Miquel Ray
Hi Joe,
For MTD:
> drivers/mtd/nand/raw/nandsim.c| 2 +-
Reviewed-by: Miquel Raynal
Thanks,
Miquèl
Hi Vivien,
Vivien Didelot wrote on Tue, 5 Feb 2019
11:28:57 -0500:
> Hi Miquel,
>
> On Tue, 5 Feb 2019 12:07:28 +0100, Miquel Raynal
> wrote:
>
> > +/* There is no suspend to RAM support at DSA level yet, the switch
> > configuration
> > + * would be lost
to recover reliably the
switch configuration.
To avoid the kernel to freeze when suspending with a switch driven by
the mv88e6xxx driver, we choose to prevent the driver suspension and
in the same way, the whole platform.
Signed-off-by: Miquel Raynal
---
Changes since v1/v2
Hi Andrew,
Andrew Lunn wrote on Fri, 1 Feb 2019 15:08:31 +0100:
> On Fri, Feb 01, 2019 at 12:01:19PM +0100, Miquel Raynal wrote:
> > Hi Vivien,
> >
> > Vivien Didelot wrote on Wed, 30 Jan 2019
> > 19:46:08 -0500:
> >
> > > Hi Miquèl,
> > >
Hi Vivien,
Vivien Didelot wrote on Wed, 30 Jan 2019
19:46:08 -0500:
> Hi Miquèl,
>
> On Wed, 30 Jan 2019 10:46:06 +0100, Miquel Raynal
> wrote:
>
> > > > > Today, there is no S2RAM support for switches. First, I proposed to
> > > > > add
> &
Hi Vivien & Andrew,
Vivien Didelot wrote on Tue, 29 Jan 2019
10:46:13 -0500:
> Hi Miquèl,
>
> On Tue, 29 Jan 2019 15:51:57 +0100, Andrew Lunn wrote:
>
> > > Today, there is no S2RAM support for switches. First, I proposed to add
> > > suspend/resume callbacks to the mv88e6xxx driver - just en
Hi Andrew,
Andrew Lunn wrote on Mon, 28 Jan 2019 18:42:46 +0100:
> On Mon, Jan 28, 2019 at 04:57:49PM +0100, Miquel Raynal wrote:
> > Hi Andrew,
> >
> > Thanks for helping!
> >
> > Andrew Lunn wrote on Mon, 28 Jan 2019 15:44:17 +0100:
> >
&g
Hi Andrew,
Thanks for helping!
Andrew Lunn wrote on Mon, 28 Jan 2019 15:44:17 +0100:
> > I don't see where VLAN and bridge information are cached, can you point
> > me to the relevant locations?
>
> Miquèl
>
> The bridge should have all that information. You need to ask it to
> enumerate th
Hi Florian,
Florian Fainelli wrote on Fri, 25 Jan 2019
10:37:38 -0800:
> Hi Miquel,
>
> On 1/25/19 1:55 AM, Miquel Raynal wrote:
> > The user might apply a specific switch configuration, with specific
> > forwarding rules, VLAN, bridges, etc.
> >
> > Durin
correctly, please let me know if
you spot anything else that is missing.
Thanks,
Miquèl
Miquel Raynal (2):
net: dsa: mv88e6xxx: Save switch rules
net: dsa: mv88e6xxx: Add suspend to RAM support
drivers/net/dsa/mv88e6xxx/chip.c | 359 ---
drivers/net/dsa/mv88e6xxx
)
To avoid recursion problems when replaying the rules, the content of
the above *_add()/*_join() callbacks has been moved in separate
helpers with a '_' prefix. Hence, each callback just calls the
corresponding helper and the corresponding *_add_xxx_rule().
Signed-off-by: Miquel Rayna
Bring S2RAM support to the mv88e6xxx DSA driver.
The content of the *_irq_poll() helper is moved in *_do_irq_poll() so
that that the function can be called from the ->resume() callback
without using the *work pointer.
Signed-off-by: Miquel Raynal
---
Changes since v1:
=
* Ad
Hi Andrew,
Andrew Lunn wrote on Tue, 22 Jan 2019 14:20:05 +0100:
> > I am not sure to understand what is lost. On my setup ethtool shows
> > that everything is fine after resume but maybe I fall into a "default"
> > working case.
>
> Hi Miquèl
>
> Is the power removed from the switch? If so,
Hi Florian,
Florian Fainelli wrote on Thu, 17 Jan 2019
10:00:46 -0800:
> On 1/17/19 7:50 AM, Miquel Raynal wrote:
> > Hi Andrew, Vivien,
> >
> > Vivien Didelot wrote on Thu, 17 Jan 2019
> > 10:46:41 -0500:
> >
> >> Hi,
> >>
> >
Hi Andrew, Vivien,
Vivien Didelot wrote on Thu, 17 Jan 2019
10:46:41 -0500:
> Hi,
>
> On Wed, 16 Jan 2019 23:23:29 +0100, Andrew Lunn wrote:
> > Hi Florian
> >
> > > A possible approach could be to call the port_disable, port_enable
> > > callbacks from dsa_slave_suspend() and dsa_slave_res
Bring S2RAM support to the mv88e6xxx DSA driver.
The content of the *_irq_poll() helper is moved in *_do_irq_poll() so
that that the function can be called from the ->resume() callback
without using the *work pointer.
Signed-off-by: Miquel Raynal
---
drivers/net/dsa/mv88e6xxx/chip.c |
he dma resource acquisition, using the more
> generic function dma_request_slave_channel().
>
> Signed-off-by: Signed-off-by: Daniel Mack
> Signed-off-by: Robert Jarzmik
> ---
> drivers/mtd/nand/raw/marvell_nand.c | 17 +
> 1 file changed, 1 insertion(+),
Hi Boris,
On Tue, 13 Feb 2018 09:17:14 +0100, Boris Brezillon
wrote:
> On Tue, 13 Feb 2018 08:42:46 +0100
> Miquel Raynal wrote:
>
> > Hi Boris,
> >
> > Just a few comments about the form.
> >
> > Otherwise:
> > Reviewed-by: Miquel Raynal
>
Hi Boris,
Just a few comments about the form.
Otherwise:
Reviewed-by: Miquel Raynal
> diff --git a/drivers/mtd/devices/lart.c b/drivers/mtd/devices/lart.c
> index 555b94406e0b..3d6c8ffd351f 100644
> --- a/drivers/mtd/devices/lart.c
> +++ b/drivers/mtd/devices/lart.c
> @
stoping it
when the port is up or down will be fine, while minimizing unnecessary
CPU usage.
Fixes: 118d6298f6f0 ("net: mvpp2: add ethtool GOP statistics")
Reported-by: Stefan Chulski
Signed-off-by: Miquel Raynal
---
Hi David,
This is the required fix for 118d6298f6f0 ("net: mvpp2:
Hi David,
> > On Wed, Nov 08, 2017 at 01:54:56PM +0900, David Miller wrote:
> >> From: Miquel Raynal
> >> Date: Mon, 6 Nov 2017 22:56:53 +0100
> >>
> >> > Add ethtool statistics support by reading the GOP statistics
> >> > from th
Add ethtool statistics support by reading the GOP statistics from the
hardware counters. Also implement a workqueue to gather the statistics
every second or some 32-bit counters could overflow.
Suggested-by: Stefan Chulski
Signed-off-by: Miquel Raynal
Reviewed-by: Andrew Lunn
---
Hi,
Stefan
Hi Stefan,
+David Miller/Net ML
> > @@ -6844,6 +7023,10 @@ static int mvpp2_open(struct net_device
> > *dev)
> >
> > mvpp2_start_dev(port);
> >
> > + /* Start hardware statistics gathering */
> > + queue_delayed_work(priv->stats_queue, &priv->stats_work,
> > + MVPP2
Add ethtool statistics support by reading the GOP statistics from the
hardware counters. Also implement a workqueue to gather the statistics
every second or some 32-bit counters could overflow.
Suggested-by: Stefan Chulski
Signed-off-by: Miquel Raynal
---
Changes since v2:
- Use netdev_name
Hi Andrew,
> > Here I do have a problem: I choose the IDA solution because it was
> > quite straightforward but I agree it would be better to use an
> > unique name. Unfortunately, on the Armada-8040-DB that instantiate
> > this driver twice, the node name is not unique. There are two CP
> > (mast
Hi Andrew,
On Fri, 3 Nov 2017 16:19:06 +0100
Andrew Lunn wrote:
> > @@ -817,6 +856,12 @@ struct mvpp2 {
> >
> > /* Maximum number of RXQs per port */
> > unsigned int max_port_rxqs;
> > +
> > + /* Workqueue to gather hardware statistics with its lock */
> > + struct mutex gather_st
On Fri, 3 Nov 2017 12:04:25 +0100
Miquel Raynal wrote:
> Add ethtool statistics support by reading the GOP statistics from the
> hardware counters. Also implement a workqueue to gather the statistics
> every second or some 32-bit counters could overflow.
>
> Suggested-by:
Add ethtool statistics support by reading the GOP statistics from the
hardware counters. Also implement a workqueue to gather the statistics
every second or some 32-bit counters could overflow.
Suggested-by: Stefan Chulski
Signed-off-by: Miquel Raynal
---
drivers/net/ethernet/marvell/mvpp2.c
Hi Florian,
> > +static u64 mvpp2_read_count(struct mvpp2_port *port, unsigned int
> > offset) +{
> > + bool reg_is_64b =
> > + (offset == MVPP2_MIB_GOOD_OCTETS_RCVD_LOW) ||
> > + (offset == MVPP2_MIB_GOOD_OCTETS_SENT_LOW);
>
> This does not scale very well, put that in yo
Hi Andrew,
Thanks for the review, I forgot to mention this is for net-next, I'll
fix the subject line when sending the v2.
> > +static struct mvpp2_ethtool_statistics mvpp2_ethtool_stats[] = {
>
> This can probably be const, and save a few bytes of RAM.
Absolutely.
>
> > + { MVPP2_MIB_GOO
Add ethtool statistics support by reading the GOP statistics from the
hardware counters. Also implement a workqueue to gather the statistics
every second or some 32-bit counters could overflow.
Suggested-by: Stefan Chulski
Signed-off-by: Miquel Raynal
---
drivers/net/ethernet/marvell/mvpp2.c
51 matches
Mail list logo
