Re: [PATCH] net: refactor icmp_global_allow to improve readability and performance.

2016-01-01 Thread Mike Danese
Yes, I completely missed the purpose of that. As a new year's resolution, I resolve to read the comments. Thanks for the review! On Fri, Jan 1, 2016 at 3:07 PM, Eric Dumazet wrote: > On Thu, 2015-12-31 at 23:58 -0800, Mike Danese wrote: >> We can reduce the number of operation

[PATCH] net: refactor icmp_global_allow to improve readability and performance.

2015-12-31 Thread Mike Danese
en bucket) and "cbr" (token bucket can be refilled) at the beginning of the routine, we reduce the number of repeated calculations of these two variables. There should be no functional difference. Signed-off-by: Mike Danese --- net/ipv4/icmp.c | 17 - 1 file changed, 8 i