> From: Jonas Bonn
> To: Paolo Abeni ,
> "netdev@vger.kernel.org" ,
> LKML ,
> "David S . Miller" ,
> John Fastabend
> Subject: Re: Packet gets stuck in NOLOCK pfifo_fast qdisc
> Date: Fri, 11 Oct 2019 02:39:48 +0200
> Message-ID: <465a540e-5296-32e7-f6a6-79942dfe2...@netr
Use constants provided by ethtool.h for speed and duplex values
instead of raw integer constants to increase code readability.
thunder_bgx already uses SPEED_UNKNOWN and DUPLEX_UNKNOWN constants,
also provided by ethtool.h.
Signed-off-by: Michael Zhivich
---
drivers/net/ethernet/cavium/thunder
t.
Signed-off-by: Michael Zhivich
---
include/uapi/linux/ethtool.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
index 3652b239..d473e5e 100644
--- a/include/uapi/linux/ethtool.h
+++ b/include/uapi/linux/ethtool.h
resulting in value truncation and thus failure to test against
SPEED_UNKNOWN correctly.
This revised series addresses several feedback comments:
- split up the patch in to series
- do not unnecessarily change drivers that use "int" storage
for speed values
Michael Zhivich (3):
e
ED_UNKNOWN)
printf("True");
else
printf("False");
Change storage of speed to use u32 to avoid this issue.
Signed-off-by: Michael Zhivich
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/e
ED_UNKNOWN)
printf("True");
else
printf("False");
Change storage of speed to use u32 to avoid this issue.
Signed-off-by: Michael Zhivich
---
drivers/net/ethernet/broadcom/tg3.c | 8
drivers/net/ethernet/broadcom/tg3.h | 4 ++--
2 fil
infiniband/ulp/ipoib/ipoib_ethtool.c.
Signed-off-by: Michael Zhivich
---
drivers/infiniband/ulp/ipoib/ipoib_ethtool.c | 7 ---
drivers/net/dsa/mv88e6xxx/chip.c | 5 +++--
drivers/net/dsa/mv88e6xxx/serdes.c| 2 +-
drivers/net/ethernet/alacrit
