Re: [PATCHv4 net-next 16/16] sctp: enable udp tunneling socks

2020-10-22 Thread Michael Tuexen
`On 22. Oct 2020, at 05:12, Xin Long wrote: > > On Wed, Oct 21, 2020 at 5:13 PM Michael Tuexen wrote: >> >>> On 21. Oct 2020, at 06:16, Xin Long wrote: >>> >>> On Wed, Oct 21, 2020 at 5:23 AM Marcelo Ricardo Leitner >>> wrote: >>>

Re: [PATCHv4 net-next 16/16] sctp: enable udp tunneling socks

2020-10-21 Thread Michael Tuexen
> On 21. Oct 2020, at 06:16, Xin Long wrote: > > On Wed, Oct 21, 2020 at 5:23 AM Marcelo Ricardo Leitner > wrote: >> >> On Tue, Oct 20, 2020 at 11:15:26PM +0200, Michael Tuexen wrote: >>>> On 20. Oct 2020, at 23:11, Marcelo Ricardo Leitner >>>>

Re: [PATCHv4 net-next 16/16] sctp: enable udp tunneling socks

2020-10-20 Thread Michael Tuexen
> On 20. Oct 2020, at 23:11, Marcelo Ricardo Leitner > wrote: > > On Tue, Oct 20, 2020 at 05:12:06PM +0800, Xin Long wrote: >> On Tue, Oct 20, 2020 at 6:15 AM Marcelo Ricardo Leitner >> wrote: >>> >>> On Mon, Oct 19, 2020 at 08:25:33PM +0800, Xin Long wrote: --- a/Documentation/networking

Re: [PATCHv3 net-next 16/16] sctp: enable udp tunneling socks

2020-10-15 Thread Michael Tuexen
> On 15. Oct 2020, at 23:23, David Laight wrote: > > From: Marcelo Ricardo Leitner >> Sent: 15 October 2020 18:43 >> >> Actually.. >> >> On Tue, Oct 13, 2020 at 03:27:41PM +0800, Xin Long wrote: >> ... >>> Also add sysctl udp_port to allow changing the listening >>> sock's port by users. > > I

Re: [PATCH net-next 11/15] sctp: add udphdr to overhead when udp_port is set

2020-10-05 Thread Michael Tuexen
> On 5. Oct 2020, at 21:01, Marcelo Ricardo Leitner > wrote: > > On Sat, Oct 03, 2020 at 08:24:34PM +0800, Xin Long wrote: >> On Sat, Oct 3, 2020 at 7:23 PM Xin Long wrote: >>> >>> On Sat, Oct 3, 2020 at 4:12 PM Xin Long wrote: On Sat, Oct 3, 2020 at 12:08 PM Marcelo Ricardo Leitne

Re: [PATCH net-next 00/15] sctp: Implement RFC6951: UDP Encapsulation of SCTP

2020-09-29 Thread Michael Tuexen
> On 29. Sep 2020, at 15:48, Xin Long wrote: > > Description From the RFC: > > The Main Reasons: > > o To allow SCTP traffic to pass through legacy NATs, which do not > provide native SCTP support as specified in [BEHAVE] and > [NATSUPP]. > > o To allow SCTP to be implemented

Re: packed structures used in socket options

2020-06-08 Thread Michael Tuexen
> On 8. Jun 2020, at 18:18, David Laight wrote: > > From: Ivan Skytte Jørgensen >> Sent: 07 June 2020 22:35 > ... contains: struct sctp_paddrparams { sctp_assoc_tspp_assoc_id; struct sockaddr_storage spp_address;

Re: [PATCH v2 0/2] net/sctp: Avoid allocating high order memory with kmalloc()

2018-08-03 Thread Michael Tuexen
> On 3. Aug 2018, at 22:30, Marcelo Ricardo Leitner > wrote: > > On Fri, Aug 03, 2018 at 04:43:28PM +, David Laight wrote: >> From: Konstantin Khorenko >>> Sent: 03 August 2018 17:21 >>> >>> Each SCTP association can have up to 65535 input and output streams. >>> For each stream type an

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-29 Thread Michael Tuexen
> On Sat, May 26, 2018 at 5:42 PM, Michael Tuexen >>>> wrote: >>>>>> On 25. May 2018, at 21:13, Neil Horman wrote: >>>>>> >>>>>> On Sat, May 26, 2018 at 01:41:02AM +0800, Xin Long wrote: >>>>>>> syzbot reported

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-27 Thread Michael Tuexen
> On 26. May 2018, at 17:50, Dmitry Vyukov wrote: > > On Sat, May 26, 2018 at 5:42 PM, Michael Tuexen > wrote: >>> On 25. May 2018, at 21:13, Neil Horman wrote: >>> >>> On Sat, May 26, 2018 at 01:41:02AM +0800, Xin Long wrote: >>>> syzbot re

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-26 Thread Michael Tuexen
> On 25. May 2018, at 21:13, Neil Horman wrote: > > On Sat, May 26, 2018 at 01:41:02AM +0800, Xin Long wrote: >> syzbot reported a rcu_sched self-detected stall on CPU which is caused >> by too small value set on rto_min with SCTP_RTOINFO sockopt. With this >> value, hb_timer will get stuck there

Re: [PATCH net-next] sctp: add support for SCTP_REUSE_PORT sockopt

2018-05-21 Thread Michael Tuexen
> On 21. May 2018, at 15:48, Neil Horman wrote: > > On Mon, May 21, 2018 at 02:16:56PM +0200, Michael Tuexen wrote: >>> On 21. May 2018, at 13:39, Neil Horman wrote: >>> >>> On Sun, May 20, 2018 at 10:54:04PM -0300, Marcelo Ricardo Leitner wrote: >>&

Re: [PATCH net-next] sctp: add support for SCTP_REUSE_PORT sockopt

2018-05-21 Thread Michael Tuexen
> On 21. May 2018, at 13:39, Neil Horman wrote: > > On Sun, May 20, 2018 at 10:54:04PM -0300, Marcelo Ricardo Leitner wrote: >> On Sun, May 20, 2018 at 08:50:59PM -0400, Neil Horman wrote: >>> On Sat, May 19, 2018 at 03:44:40PM +0800, Xin Long wrote: This feature is actually already supporte

Re: [RFC PATCH net-next 0/3] sctp: add GSO support

2016-01-29 Thread Michael Tuexen
> On 29 Jan 2016, at 12:26, Marcelo Ricardo Leitner > wrote: > > On Fri, Jan 29, 2016 at 11:57:46AM +0100, Michael Tuexen wrote: >>> On 29 Jan 2016, at 02:18, Marcelo Ricardo Leitner >>> wrote: >>> >>> On Fri, Jan 29, 2016 at 12:36:05AM +0

Re: [RFC PATCH net-next 0/3] sctp: add GSO support

2016-01-29 Thread Michael Tuexen
> On 29 Jan 2016, at 02:18, Marcelo Ricardo Leitner > wrote: > > On Fri, Jan 29, 2016 at 12:36:05AM +0100, Michael Tuexen wrote: >> >>> On 28 Jan 2016, at 22:03, Marcelo Ricardo Leitner >>> wrote: >>> >>> On Thu, Jan 28, 2016 at 06:54:

Re: [RFC PATCH net-next 0/3] sctp: add GSO support

2016-01-28 Thread Michael Tuexen
> On 28 Jan 2016, at 22:03, Marcelo Ricardo Leitner > wrote: > > On Thu, Jan 28, 2016 at 06:54:06PM +0100, Michael Tuexen wrote: >>> On 28 Jan 2016, at 14:51, David Laight wrote: >>> >>> From: Marcelo Ricardo Leitner >>>> Sent: 27 January 20

Re: [RFC PATCH net-next 0/3] sctp: add GSO support

2016-01-28 Thread Michael Tuexen
> On 28 Jan 2016, at 14:51, David Laight wrote: > > From: Marcelo Ricardo Leitner >> Sent: 27 January 2016 17:07 >> This patchset is merely a RFC for the moment. There are some >> controversial points that I'd like to discuss before actually proposing >> the patches. > > You also need to look at

Re: [PATCH net] net: sctp: stop spamming klog with rfc6458, 5.3.2. deprecation warnings

2015-07-22 Thread Michael Tuexen
i.e. due to point 1) I really fail to see the benefit of a warning. > So just revert that for now, the issue was reported up Jamal. > > [1] http://thread.gmane.org/gmane.linux.network/321960/ Looks good to me. Best regards Michael > > Reported-by: Jamal Hadi Salim > Signe

Re: [RFC net-next 1/1] : sctp: denoise deprecation log on SCTP_EVENTS

2015-07-22 Thread Michael Tuexen
> On 22 Jul 2015, at 14:04, Daniel Borkmann wrote: > > On 07/22/2015 01:48 PM, David Laight wrote: >> From: Jamal Hadi Salim >>> Sent: 09 July 2015 11:38 >>> >>> In the newer kernels this message is extremely noisy. After a quick >>> discussion with Daniel it seems to me it will be very hard to

Re: [RFC PATCH net-next] sctp: fix src address selection if using secondary addresses

2015-07-09 Thread Michael Tuexen
> On 09 Jul 2015, at 18:54, Marcelo Ricardo Leitner wrote: > > Cc'ing Michael too. I'm not familiar with the Linux kernel code, so I can't comment on it. But making sure to use a source address belonging to the emitting interface makes sense for me. Best regards Michael > > On Tue, Jul 07, 2015

Re: [Lksctp-developers] [PATCH] SCTP: drop SACK if ctsn is not less than the next tsn of assoc

2007-08-01 Thread Michael Tuexen
Hi Wei, see my comments in-line. Best regards Michael On Aug 1, 2007, at 3:06 AM, Wei Yongjun wrote: On Tue, 2007-07-31 at 07:37 -0400, Neil Horman wrote: On Tue, Jul 31, 2007 at 12:44:27PM +0800, Wei Yongjun wrote: If SCTP data sender received a SACK which contains Cumulative TSN Ack