Re: [PATCH 0/2] net: phy: dp83867: Configure LED modes via device tree

2021-03-22 Thread Michael Tretter
On Fri, 19 Mar 2021 22:19:44 +0100, Andrew Lunn wrote: > On Fri, Mar 19, 2021 at 04:57:08PM +0100, Michael Tretter wrote: > > The dp83867 has 4 LED pins, which can be multiplexed with different > > functions > > of the phy. > > > > This series adds a de

Re: [PATCH 2/2] net: phy: dp83867: add support for changing LED modes

2021-03-19 Thread Michael Tretter
On Fri, 19 Mar 2021 16:57:10 +0100, Michael Tretter wrote: > From: Thomas Haemmerle > > The DP83867 supports four configurable LEDs. Several functions can be > multiplexed to these LEDs. The multiplexing can be configured in the > LEDCR1 register. > > Add support for chan

[PATCH 0/2] net: phy: dp83867: Configure LED modes via device tree

2021-03-19 Thread Michael Tretter
, the binding is specific to the dp83867, but I guess that the binding could be made more generic and used for other phys, too. Let me know, what you think. Michael Michael Tretter (1): dt-bindings: dp83867: Add binding for LED mode configuration Thomas Haemmerle (1): net: phy: dp83867: add

[PATCH 2/2] net: phy: dp83867: add support for changing LED modes

2021-03-19 Thread Michael Tretter
-by: Michael Tretter --- drivers/net/phy/dp83867.c | 57 +++ 1 file changed, 57 insertions(+) diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index 9bd9a5c0b1db..dfcac95941f3 100644 --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867

[PATCH 1/2] dt-bindings: dp83867: Add binding for LED mode configuration

2021-03-19 Thread Michael Tretter
The DP83867 supports four configurable LED pins. Describe the multiplexing of functions to the LEDs via device tree. Signed-off-by: Michael Tretter --- .../devicetree/bindings/net/ti,dp83867.yaml | 24 +++ include/dt-bindings/net/ti-dp83867.h | 16 + 2

[PATCH] net: macb: simplify clk_init with dev_err_probe

2021-03-17 Thread Michael Tretter
: Michael Tretter --- drivers/net/ethernet/cadence/macb_main.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index e7c123aadf56..f56f3dbbc015 100644 --- a/drivers/net

Re: [PATCH v2] net: phy: dp83867: support Wake on LAN

2019-10-22 Thread Michael Tretter
On Tue, 22 Oct 2019 13:06:35 +, Thomas Hämmerle wrote: > From: Thomas Haemmerle > > This adds WoL support on TI DP83867 for magic, magic secure, unicast and > broadcast. > > Signed-off-by: Thomas Haemmerle Reviewed-by: Michael Tretter > --- > drivers

[PATCH] macb: propagate errors when getting optional clocks

2019-10-18 Thread Michael Tretter
firmware driver has been probed. Use devm_clk_get_optional() in instead of devm_clk_get() to get the optional clock and propagate all errors to the calling function. Signed-off-by: Michael Tretter --- drivers/net/ethernet/cadence/macb_main.c | 12 ++-- 1 file changed, 6 insertions(+), 6