Re: [PATCH net v3] net: phy: rename Asix Electronics PHY driver

2019-06-07 Thread Michael Schmitz
Am 08.06.2019 um 01:00 schrieb Andrew Lunn: On Fri, Jun 07, 2019 at 05:37:34PM +1200, Michael Schmitz wrote: [Resent to net instead of net-next - may clash with Anders Roxell's patch series addressing duplicate module names] Commit 31dd83b96641 ("net-next: phy: new Asix Elect

Re: [PATCH 6/8] drivers: net: phy: fix warning same module names

2019-06-06 Thread Michael Schmitz
Hi Andrew, Am 07.06.2019 um 13:59 schrieb Andrew Lunn: On Fri, Jun 07, 2019 at 12:34:47PM +1200, Michael Schmitz wrote: Hi Andew, Anders, sorry I dropped the ball on that one - I've got a patch for the ax88796b PHY driver that I just forgot to resend. It'll clash with your pat

[PATCH net v3] net: phy: rename Asix Electronics PHY driver

2019-06-06 Thread Michael Schmitz
pre-existiting driver (drivers/net/usb/asix.c). The PHY driver is used by the X-Surf 100 ethernet card driver, and loaded by that driver via its PHY ID. A rename of the driver looks unproblematic. Rename PHY driver to ax88796b.c in order to resolve name conflict. Signed-off-by: Michael Sch

Re: [PATCH 6/8] drivers: net: phy: fix warning same module names

2019-06-06 Thread Michael Schmitz
Hi Andew, Anders, sorry I dropped the ball on that one - I've got a patch for the ax88796b PHY driver that I just forgot to resend. It'll clash with your patch, Anders - are you happy to drop the CONFIG_ASIX_PHY from your series? Cheers,     Michael On 7/06/19 12:58 AM, Andrew Lunn wrote

Re: [PATCH v2] net: phy: rename Asix Electronics PHY driver

2019-05-18 Thread Michael Schmitz
Hi Andrew, Am 19.05.2019 um 02:20 schrieb Andrew Lunn: On Sat, May 18, 2019 at 01:14:55PM +1200, Michael Schmitz wrote: Commit 31dd83b96641 ("net-next: phy: new Asix Electronics PHY driver") introduced a new PHY driver drivers/net/phy/asix.c that causes a module name conflict

Re: [PATCH 0/3] resolve module name conflict for asix PHY and USB modules

2019-05-17 Thread Michael Schmitz
Thanks Andrew, makes perfect sense - patch resent. Cheers, Michael Am 18.05.2019 um 09:20 schrieb Andrew Lunn: On Sat, May 18, 2019 at 08:25:15AM +1200, Michael Schmitz wrote: Haven't heard back in a while, so here goes: Commit 31dd83b96641 ("net-next: phy: new Asix Elect

[PATCH v2] net: phy: rename Asix Electronics PHY driver

2019-05-17 Thread Michael Schmitz
ed by that driver via its PHY ID. A rename of the driver looks unproblematic. Rename PHY driver to ax88796b.c in order to resolve name conflict. Signed-off-by: Michael Schmitz Fixes: 31dd83b96641 ("net-next: phy: new Asix Electronics PHY driver") --- Changes from v1: - merge into single

[PATCH 0/3] resolve module name conflict for asix PHY and USB modules

2019-05-17 Thread Michael Schmitz
d by the X-Surf 100 ethernet card driver, and loaded by that driver via its PHY ID. A rename of the driver looks unproblematic. Rename PHY driver to ax88796b.c in order to resolve name conflict. Fixes: 31dd83b96641 ("net-next: phy: new Asix Electronics PHY driver") Michael Sch

[PATCH 2/3] net: 8390: switch X-Surf 100 driver to use ax88796b PHY

2019-05-17 Thread Michael Schmitz
The asix.c driver name causes a module name conflict with a driver of the same name in drivers/net/usb. Select the new ax88796b PHY driver when X-SURF 100 support is configured. Signed-off-by: Michael Schmitz Fixes: 31dd83b96641 ("net-next: phy: new Asix Electronics PHY driver") --- d

[PATCH 3/3] net: phy: remove old Asix Electronics PHY driver

2019-05-17 Thread Michael Schmitz
The asix.c driver name causes a module name conflict with a driver of the same name in drivers/net/usb. Now that a new ax88796b.c driver has been added, remove drivers/net/phy/asix.c. Signed-off-by: Michael Schmitz Fixes: 31dd83b96641 ("net-next: phy: new Asix Electronics PHY d

[PATCH 1/3] net: phy: new ax88796b.c Asix Electronics PHY driver

2019-05-17 Thread Michael Schmitz
The asix.c driver name causes a module name conflict with a driver of the same name in drivers/net/usb. Add new ax88796b.c driver to prepare for removal of drivers/net/phy/asix.c later. Signed-off-by: Michael Schmitz Fixes: 31dd83b96641 ("net-next: phy: new Asix Electronics PHY d

Re: [PATCH] net: phy: Fixup GPLv2+ SPDX tags based on license text

2019-01-21 Thread Michael Schmitz
For the asix.c patch: Acked-by: Michael Schmitz On 22/01/19 7:08 AM, Andrew Lunn wrote: A few PHY drivers have the GPLv2+ license text. They then either have a MODULE_LICENSE() of GPLv2 only, or an SPDX tag of GPLv2 only. Since the license text is much easier to understand than either the

Re: [v4,1/9] net-next: phy: new Asix Electronics PHY driver

2019-01-21 Thread Michael Schmitz
orrect SPDX tag was added in response to checkpath complaints. So 2.0+ would be correct. Thomas: does that suit your purpose? Cheers,     Michael On 21/01/19 6:43 AM, Andrew Lunn wrote: On Fri, Jan 18, 2019 at 11:22:39AM +0100, Thomas Gleixner wrote: Michael, On Thu, 19 Apr 2018, Michae

Re: [PATCH net-next] Amiga PCMCIA 100 MBit card support

2019-01-03 Thread Michael Schmitz
Hi Andrew, On 31/12/18 11:47 PM, Andrew Lunn wrote: Having so many front end drivers for a chipset should be done in a more modular manner, so that in fact they could all coexist if necessary. Not sure I follow your meaning ... are you suggesting to allow the back end driver to use run-time sel

Re: [PATCH net-next] Amiga PCMCIA 100 MBit card support

2018-12-31 Thread Michael Schmitz
Hi Dave, Am 29.12.2018 um 09:43 schrieb David Miller: From: Michael Schmitz Date: Sat, 22 Dec 2018 10:30:58 +1300 Am 21.12.2018 um 13:10 schrieb David Miller: And in particular this huge complicated Kconfig construct is not maintainable at all. We can trim this down a bit (for reasons

Re: [PATCH net-next] Amiga PCMCIA 100 MBit card support

2018-12-21 Thread Michael Schmitz
Dave, Am 21.12.2018 um 13:10 schrieb David Miller: From: ALeX Kazik Date: Wed, 19 Dec 2018 23:24:32 +0100 + bool "PCMCIA NE2000 100MBit support" + default n + depends on ARM_ETHERH=n && AX88796=n && HYDRA=n && MAC8390=n + depends on MCF8390=n && NE2000=n && NE2K_PCI=n

Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread Michael Schmitz
Am 01.12.2018 um 09:12 schrieb Jens Axboe: On 11/30/18 12:56 PM, Davidlohr Bueso wrote: On Fri, 30 Nov 2018, Kees Cook wrote: On Fri, Nov 30, 2018 at 11:27 AM Jarkko Sakkinen wrote: In order to comply with the CoC, replace with a hug. I hope this is some kind of joke. How would anyon

Re: [PATCH net] macmace: Set platform device coherent_dma_mask

2018-05-11 Thread Michael Schmitz
Hi Finn, Am 11.05.2018 um 22:06 schrieb Finn Thain: >> You would have to be careful not to overwrite a pdev->dev.dma_mask and >> pdev->dev.dma_coherent_mask that might have been set in a platform >> device passed via platform_device_register here. Coldfire is the only >> m68k platform currently

Re: [PATCH net] macmace: Set platform device coherent_dma_mask

2018-05-11 Thread Michael Schmitz
Hi Finn, Am 11.05.2018 um 17:28 schrieb Finn Thain: > On Fri, 11 May 2018, Michael Schmitz wrote: > >> >> I'm afraid using platform_device_register() (which you already use for >> the SCC devices) is the only option handling this on a per-device basis >>

Re: [PATCH net] macmace: Set platform device coherent_dma_mask

2018-05-10 Thread Michael Schmitz
Hi Finn, Am 11.05.2018 um 15:28 schrieb Finn Thain: > On Fri, 11 May 2018, Michael Schmitz wrote: > >>>> Which begs the question: why can' you set up all Nubus bus devices' >>>> DMA masks in nubus_device_register(), or nubus_add_board()? >>> &g

Re: [PATCH net] macmace: Set platform device coherent_dma_mask

2018-05-10 Thread Michael Schmitz
Hi Finn, On Fri, May 11, 2018 at 11:55 AM, Finn Thain wrote: >> > What's worse, if you do pass a dma_mask in struct >> > platform_device_info, you end up with this problem in >> > platform_device_register_full(): >> > >> > if (pdevinfo->dma_mask) { >> > /* >> >

Re: [PATCH net] macmace: Set platform device coherent_dma_mask

2018-05-10 Thread Michael Schmitz
Hi Finn, On Thu, May 10, 2018 at 1:25 PM, Finn Thain wrote: > On Thu, 3 May 2018, Geert Uytterhoeven wrote: > >> >> Perhaps you can add a new helper >> (platform_device_register_simple_dma()?) that takes the DMA mask, too? [...] > To actually hoist the dma mask setup out of existing platform driv

Re: [PATCH net] macmace: Set platform device coherent_dma_mask

2018-05-04 Thread Michael Schmitz
Hi Geert, Am 04.05.2018 um 19:24 schrieb Geert Uytterhoeven: > Hi Michael, > >>> Yes, that would be useful. The other assumption could be that >>> platform devices always allow an all-0xff dma mask. >> >> That's not always true (Atari NCR5380 SCSI and floppy would use a 24 >> bit DMA mask). We u

Re: [PATCH net] macmace: Set platform device coherent_dma_mask

2018-05-03 Thread Michael Schmitz
Hi Christoph, On Thu, May 3, 2018 at 8:51 PM, Christoph Hellwig wrote: > On Thu, May 03, 2018 at 10:46:56AM +0200, Geert Uytterhoeven wrote: >> Perhaps you can add a new helper (platform_device_register_simple_dma()?) >> that takes the DMA mask, too? >> With people setting the mask to kill the WA

Re: [PATCH v4 00/10] New network driver for Amiga X-Surf 100 (m68k)

2018-04-19 Thread Michael Schmitz
Thanks Dave! And many thanks to all the reviewers and testers! Cheers, Michael On Fri, Apr 20, 2018 at 8:11 AM, David Miller wrote: > From: Michael Schmitz > Date: Thu, 19 Apr 2018 14:05:17 +1200 > >> This patch series adds support for the Individual Computers X-Surf 100

Re: [PATCH v4 00/10] New network driver for Amiga X-Surf 100 (m68k)

2018-04-18 Thread Michael Schmitz
Hi, messed up the subject there, sorry - this was meant to be [PATCH v4 0/9] net-next: New network driver for Amiga X-Surf 100 (m68k) Cheers, Michael Am 19.04.2018 um 14:05 schrieb Michael Schmitz: > [This is a resend of my v3 series which was based on the wrong version and >

[PATCH v4 8/9] net-next: ax88796: release platform device drvdata on probe error and module remove

2018-04-18 Thread Michael Schmitz
The net device struct pointer is stored as platform device drvdata on module probe - clear the drvdata entry on probe fail there, as well as when unloading the module. Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions

[PATCH v4 2/9] net-next: ax88796: Fix MAC address reading

2018-04-18 Thread Michael Schmitz
From: Michael Karcher To read the MAC address from the (virtual) SAprom, the remote DMA unit needs to be set up like for every other process access to card-local memory. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |6 ++ 1

[PATCH v4 6/9] net-next: ax88796: add interrupt status callback to platform data

2018-04-18 Thread Michael Schmitz
y: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c | 23 +-- include/net/ax88796.h |5 + 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/8390/ax88796.c b/drivers/net/eth

[PATCH v4 7/9] net-next: ax88796: set IRQF_SHARED flag when IRQ resource is marked as shareable

2018-04-18 Thread Michael Schmitz
From: Michael Karcher On the Amiga X-Surf100, the network card interrupt is shared with many other interrupt sources, so requires the IRQF_SHARED flag to register. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |3 +++ 1 files

[PATCH v4 1/9] net-next: phy: new Asix Electronics PHY driver

2018-04-18 Thread Michael Schmitz
Signed-off-by: Michael Schmitz --- Changes in v4: Andrew Lunn: - don't duplicate genphy_soft_reset, just call after writing zero to control register --- drivers/net/phy/Kconfig |6 drivers/net/phy/Makefile |1 + drivers/net/phy/asix.c |

[PATCH v4 00/10] New network driver for Amiga X-Surf 100 (m68k)

2018-04-18 Thread Michael Schmitz
[This is a resend of my v3 series which was based on the wrong version and tree. Only substantial change is to Asix AX99796B PHY driver.] This patch series adds support for the Individual Computers X-Surf 100 network card for m68k Amiga, a network adapter based on the AX88796 chip set. The driver

[PATCH v4 9/9] net-next: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

2018-04-18 Thread Michael Schmitz
From: Michael Karcher Add platform device driver to populate the ax88796 platform data from information provided by the XSurf100 zorro device driver. The ax88796 module will be loaded through this module's probe function. Signed-off-by: Michael Karcher Signed-off-by: Michael Sc

[PATCH v4 3/9] net-next: ax88796: Attach MII bus only when open

2018-04-18 Thread Michael Schmitz
From: Michael Karcher Call ax_mii_init in ax_open(), and unregister/remove mdiobus resources in ax_close(). This is needed to be able to unload the module, as the module is busy while the MII bus is attached. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz Reviewed-by: Andrew

[PATCH v4 5/9] net-next: ax88796: Add block_input/output hooks to ax_plat_data

2018-04-18 Thread Michael Schmitz
From: Michael Karcher Add platform specific hooks for block transfer reads/writes of packet buffer data, superseding the default provided ax_block_input/output. Currently used for m68k Amiga XSurf100. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- Changes in v3

[PATCH v4 4/9] net-next: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-18 Thread Michael Schmitz
es: 82533ad9a1c (net: ethernet: ax88796: don't call free_irq without request_irq first) Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz Reviewed-by: Geert Uytterhoeven --- drivers/net/ethernet/8390/ax88796.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff

Re: [PATCH v3 1/9] net: phy: new Asix Electronics PHY driver

2018-04-18 Thread Michael Schmitz
Hi Andrew, I agree, that's much better. I had something like that in mind before I got distracted... /me looking for brown paper bag now. Cheers, Michael On Thu, Apr 19, 2018 at 12:13 AM, Andrew Lunn wrote: >> + >> +/** >> + * asix_soft_reset - software reset the PHY via BMCR_RESET bit >>

Re: [PATCH v3 00/10] New network driver for Amiga X-Surf 100 (m68k)

2018-04-18 Thread Michael Schmitz
Hi Andrew, sorry, my mistake. I didn't realize how fast DaveM's tree diverges from Linus' (and Geert's) once the merge window opens. Cheers, Michael On Thu, Apr 19, 2018 at 12:19 AM, Andrew Lunn wrote: > On Wed, Apr 18, 2018 at 05:10:45PM +1200, Michael Schmitz wr

Re: [PATCH v3 00/10] New network driver for Amiga X-Surf 100 (m68k)

2018-04-18 Thread Michael Schmitz
Hi Finn, thanks for the feedback! On Wed, Apr 18, 2018 at 5:45 PM, Finn Thain wrote: >> > 1/9 net: phy: new Asix Electronics PHY driver >> > 2/9 net: ax88796: Fix MAC address reading >> > 3/9 net: ax88796: Attach MII bus only when open >> > 4/9 net: ax88796: Do not free IRQ in ax_remove() (alrea

Re: [PATCH v3 00/10] New network driver for Amiga X-Surf 100 (m68k)

2018-04-17 Thread Michael Schmitz
All, just noticed belatedly that the Makefile hunk of patch 9 does no longer apply cleanly in 4.17-rc1, sorry. My series was based on 4.16. I'll resend that one, OK? Cheers, Michael On Wed, Apr 18, 2018 at 4:26 PM, Michael Schmitz wrote: > This patch series adds support for the In

Re: [PATCH 10/10] net: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

2018-04-17 Thread Michael Schmitz
Hi Geert, On Wed, Apr 18, 2018 at 1:53 AM, Geert Uytterhoeven wrote: >> --- /dev/null >> +++ b/drivers/net/ethernet/8390/xsurf100.c >> @@ -0,0 +1,411 @@ >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#define ZORRO_PROD_INDIVIDUAL_COMPUTERS_X_SURF100 \

[PATCH v3 1/9] net: phy: new Asix Electronics PHY driver

2018-04-17 Thread Michael Schmitz
code duplication. Signed-off-by: Michael Schmitz --- drivers/net/phy/Kconfig |6 drivers/net/phy/Makefile |1 + drivers/net/phy/asix.c | 65 ++ drivers/net/phy/phy_device.c |3 +- include/linux/phy.h |1 + 5

[PATCH v3 00/10] New network driver for Amiga X-Surf 100 (m68k)

2018-04-17 Thread Michael Schmitz
This patch series adds support for the Individual Computers X-Surf 100 network card for m68k Amiga, a network adapter based on the AX88796 chip set. The driver was originally written for kernel version 3.19 by Michael Karcher (see CC:), and adapted to 4.16 for submission to netdev by me. Questions

[PATCH v3 9/9] net: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

2018-04-17 Thread Michael Schmitz
From: Michael Karcher Add platform device driver to populate the ax88796 platform data from information provided by the XSurf100 zorro device driver. The ax88796 module will be loaded through this module's probe function. Signed-off-by: Michael Karcher Signed-off-by: Michael Sc

[PATCH v3 4/9] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-17 Thread Michael Schmitz
es: 82533ad9a1c (net: ethernet: ax88796: don't call free_irq without request_irq first) Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz Reviewed-by: Geert Uytterhoeven --- drivers/net/ethernet/8390/ax88796.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff

[PATCH v3 5/9] net: ax88796: Add block_input/output hooks to ax_plat_data

2018-04-17 Thread Michael Schmitz
From: Michael Karcher Add platform specific hooks for block transfer reads/writes of packet buffer data, superseding the default provided ax_block_input/output. Currently used for m68k Amiga XSurf100. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- Changes in v3

[PATCH v3 3/9] net: ax88796: Attach MII bus only when open

2018-04-17 Thread Michael Schmitz
From: Michael Karcher Call ax_mii_init in ax_open(), and unregister/remove mdiobus resources in ax_close(). This is needed to be able to unload the module, as the module is busy while the MII bus is attached. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz Reviewed-by: Andrew

[PATCH v3 6/9] net: ax88796: add interrupt status callback to platform data

2018-04-17 Thread Michael Schmitz
y: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c | 23 +-- include/net/ax88796.h |5 + 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/8390/ax88796.c b/drivers/net/eth

[PATCH v3 8/9] net: ax88796: release platform device drvdata on probe error and module remove

2018-04-17 Thread Michael Schmitz
The net device struct pointer is stored as platform device drvdata on module probe - clear the drvdata entry on probe fail there, as well as when unloading the module. Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions

[PATCH v3 7/9] net: ax88796: set IRQF_SHARED flag when IRQ resource is marked as shareable

2018-04-17 Thread Michael Schmitz
From: Michael Karcher On the Amiga X-Surf100, the network card interrupt is shared with many other interrupt sources, so requires the IRQF_SHARED flag to register. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |3 +++ 1 files

[PATCH v3 2/9] net: ax88796: Fix MAC address reading

2018-04-17 Thread Michael Schmitz
From: Michael Karcher To read the MAC address from the (virtual) SAprom, the remote DMA unit needs to be set up like for every other process access to card-local memory. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |6 ++ 1

Re: [PATCH 04/10] net: ax88796: Add block_input/output hooks to ax_plat_data

2018-04-17 Thread Michael Schmitz
Hi Finn, On Wed, Apr 18, 2018 at 1:23 PM, Finn Thain wrote: > On Wed, 18 Apr 2018, Michael Schmitz wrote: > >> I think this is a false positive - we're encouraged to provide the >> full parameter list for functions, so the sreuct sk_buff* can't be >> avoided.

Re: [PATCH 04/10] net: ax88796: Add block_input/output hooks to ax_plat_data

2018-04-17 Thread Michael Schmitz
2018 at 1:19 PM, Andrew Lunn wrote: > On Wed, Apr 18, 2018 at 12:53:21PM +1200, Michael Schmitz wrote: >> I think this is a false positive - we're encouraged to provide the >> full parameter list for functions, so the sreuct sk_buff* can't be >> avoided. > > Hi Micha

Re: [PATCH 04/10] net: ax88796: Add block_input/output hooks to ax_plat_data

2018-04-17 Thread Michael Schmitz
omething to improve: > > [auto build test WARNING on v4.16] > [cannot apply to net-next/master net/master v4.17-rc1 next-20180417] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux

Re: [PATCH v2 8/8] net: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

2018-04-17 Thread Michael Schmitz
Hi Andrew, On Wed, Apr 18, 2018 at 1:26 AM, Andrew Lunn wrote: > On Tue, Apr 17, 2018 at 02:08:15PM +1200, Michael Schmitz wrote: >> Add platform device driver to populate the ax88796 platform data from >> information provided by the XSurf100 zorro device driver. >> This d

Re: [PATCH 10/10] net: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

2018-04-17 Thread Michael Schmitz
Hi Geert, thanks for your suggestions! On Wed, Apr 18, 2018 at 1:53 AM, Geert Uytterhoeven wrote: > Hi Michael, > > Thanks for your patch! > > On Tue, Apr 17, 2018 at 12:04 AM, Michael Schmitz > wrote: >> Add platform device driver to populate the ax88796 platform

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-17 Thread Michael Schmitz
Hi Andrew, thanks, that's what I was looking for. The next version will have all but one patch correctly attributed to Michael Karcher. Cheers, Michael On Wed, Apr 18, 2018 at 9:13 AM, Andrew Lunn wrote: > On Wed, Apr 18, 2018 at 08:32:25AM +1200, Michael Schmitz wrote: >

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-17 Thread Michael Schmitz
Thanks Geert, I'll fix that. I see my v2 series shows up as new series on patchwork - do I need to do something different when tagging the next version, Dave? Cheers, Michael On Wed, Apr 18, 2018 at 1:51 AM, David Miller wrote: > From: Geert Uytterhoeven > Date: Tue, 17 Apr 2018 10:20:25 +

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-17 Thread Michael Schmitz
Hi Adrian, On Tue, Apr 17, 2018 at 11:40 PM, John Paul Adrian Glaubitz wrote: > On 04/17/2018 04:08 AM, Michael Schmitz wrote: >> >> From: John Paul Adrian Glaubitz > > This should be: > > From: Michael Karcher I haven't found a way to change that in my tree

Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

2018-04-17 Thread Michael Schmitz
Thanks Florian, I'll keep the Asix PHY driver separate from ax88796 for now. Mainly to simplify testing. Let's see whether it can be used by any other MAC - can still fold it into ax88796 later. Cheers, Michael On Wed, Apr 18, 2018 at 6:08 AM, Florian Fainelli wrote: > On 04/17/2018 06:01 A

[PATCH v2 0/8] New network driver for Amiga X-Surf 100 (m68k)

2018-04-16 Thread Michael Schmitz
This patch series adds support for the Individual Computers X-Surf 100 network card for m68k Amiga, a network adapter based on the AX88796 chip set. The driver was originally written for kernel version 3.19 by Michael Karcher (see CC:), and adapted to 4.16 for submission to netdev by me. Questions

[PATCH v2 4/8] net: ax88796: Add block_input/output hooks to ax_plat_data

2018-04-16 Thread Michael Schmitz
Add platform specific hooks for block transfer reads/writes of packet buffer data, superseding the default provided ax_block_input/output. Currently used for m68k Amiga XSurf100. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c | 10

[PATCH v2 2/8] net: ax88796: Attach MII bus only when open

2018-04-16 Thread Michael Schmitz
From: Michael Karcher Call ax_mii_init in ax_open(), and unregister/remove mdiobus resources in ax_close(). This is needed to be able to unload the module, as the module is busy while the MII bus is attached. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net

[PATCH v2 7/8] net: ax88796: release platform device drvdata on probe error and module remove

2018-04-16 Thread Michael Schmitz
The net device struct pointer is stored as platform device drvdata on module probe - clear the drvdata entry on probe fail there, as well as when unloading the module. Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions

[PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-16 Thread Michael Schmitz
From: John Paul Adrian Glaubitz This complements the fix in 82533ad9a1c that removed the free_irq call in the error path of probe, to also not call free_irq when remove is called to revert the effects of probe. Signed-off-by: Michael Karcher --- drivers/net/ethernet/8390/ax88796.c |1 - 1

[PATCH v2 6/8] net: ax88796: set IRQF_SHARED flag when IRQ resource is marked as shareable

2018-04-16 Thread Michael Schmitz
From: John Paul Adrian Glaubitz On the Amiga X-Surf100, the network card interrupt is shared with many other interrupt sources, so requires the IRQF_SHARED flag to register. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |3 +++ 1

[PATCH v2 5/8] net: ax88796: add interrupt status callback to platform data

2018-04-16 Thread Michael Schmitz
ned-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c | 23 +-- include/net/ax88796.h |5 + 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/8390/ax88796.c b/drivers/net/ethernet/8390/ax88796.c ind

[PATCH v2 1/8] net: ax88796: Fix MAC address reading

2018-04-16 Thread Michael Schmitz
From: Michael Karcher To read the MAC address from the (virtual) SAprom, the remote DMA unit needs to be set up like for every other process access to card-local memory. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |6 ++ 1

[PATCH v2 8/8] net: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

2018-04-16 Thread Michael Schmitz
Add platform device driver to populate the ax88796 platform data from information provided by the XSurf100 zorro device driver. This driver will have to be loaded before loading the ax88796 module, or compiled as built-in. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz

Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

2018-04-16 Thread Michael Schmitz
Hi Andrew, On Tue, Apr 17, 2018 at 11:12 AM, Andrew Lunn wrote: > On Tue, Apr 17, 2018 at 10:04:43AM +1200, Michael Schmitz wrote: >> From: John Paul Adrian Glaubitz >> >> The AX88796B as installed on the X-Surf-100 does not recognize a MII reset >> request if th

Re: [PATCH 02/10] net: ax88796: Attach MII bus only when open

2018-04-16 Thread Michael Schmitz
Hi Andrew, thank you for reviewing this series! On Tue, Apr 17, 2018 at 10:59 AM, Andrew Lunn wrote: > On Tue, Apr 17, 2018 at 10:04:37AM +1200, Michael Schmitz wrote: >> From: Michael Karcher >> >> Call ax_mii_init in ax_open(), and unregister/remove mdiobus res

[PATCH 07/10] net: ax88796: unregister mdiobus on ax_mii_init() fail

2018-04-16 Thread Michael Schmitz
From: Michael Schmitz Unregister and free up mdiobus resources if ax_mii_init() failed. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet

[PATCH 04/10] net: ax88796: Add block_input/output hooks to ax_plat_data

2018-04-16 Thread Michael Schmitz
Add platform specific hooks for block transfer reads/writes of packet buffer data, superseding the default provided ax_block_input/output. Currently used for m68k Amiga XSurf100. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c | 10

[PATCH 02/10] net: ax88796: Attach MII bus only when open

2018-04-16 Thread Michael Schmitz
From: Michael Karcher Call ax_mii_init in ax_open(), and unregister/remove mdiobus resources in ax_close(). This is needed to be able to unload the module, as the module is busy while the MII bus is attached. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net

[PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

2018-04-16 Thread Michael Schmitz
From: John Paul Adrian Glaubitz The AX88796B as installed on the X-Surf-100 does not recognize a MII reset request if the previous write to the MII control register also was a reset request. So a dummy write to the control register makes the soft reset in the PHY initialization code work. Signed

[PATCH 06/10] net: ax88796: set IRQF_SHARED flag when IRQ resource is marked as shareable

2018-04-16 Thread Michael Schmitz
From: John Paul Adrian Glaubitz On the Amiga X-Surf100, the network card interrupt is shared with many other interrupt sources, so requires the IRQF_SHARED flag to register. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |3 +++ 1

[PATCH 09/10] net: ax88796: release platform device drvdata on probe error and module remove

2018-04-16 Thread Michael Schmitz
The net device struct pointer is stored as platform device drvdata on module probe - clear the drvdata entry on probe fail there, as well as when unloading the module. Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions

[PATCH 05/10] net: ax88796: add interrupt status callback to platform data

2018-04-16 Thread Michael Schmitz
ned-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c | 23 +-- include/net/ax88796.h |5 + 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/8390/ax88796.c b/drivers/net/ethernet/8390/ax88796.c ind

[PATCH 01/10] net: ax88796: Fix MAC address reading

2018-04-16 Thread Michael Schmitz
From: Michael Karcher To read the MAC address from the (virtual) SAprom, the remote DMA unit needs to be set up like for every other process access to card-local memory. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |6 ++ 1

[PATCH 00/10] New network driver for Amiga X-Surf 100 (m68k)

2018-04-16 Thread Michael Schmitz
/ethernet/8390/xsurf100.c | 411 ++ include/net/ax88796.h| 14 +- 5 files changed, 495 insertions(+), 11 deletions(-) Cheers, Michael Schmitz

[PATCH 03/10] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-16 Thread Michael Schmitz
From: John Paul Adrian Glaubitz This complements the fix in 82533ad9a1c that removed the free_irq call in the error path of probe, to also not call free_irq when remove is called to revert the effects of probe. Signed-off-by: Michael Karcher --- drivers/net/ethernet/8390/ax88796.c |1 - 1

[PATCH 10/10] net: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

2018-04-16 Thread Michael Schmitz
Add platform device driver to populate the ax88796 platform data from information provided by the XSurf100 zorro device driver. This driver will have to be loaded before loading the ax88796 module, or compiled as built-in. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz