Re: Fw: [Bug 205215] New: Amiga X5000 Cyrus board DPAA network driver issue

2019-10-18 Thread Maxim Uvarov
t; In this troubleshooting document similar issues and errors are being shown > with > possible troubleshooting steps. > > It would be great if someone could point us into the right direction and has a > clue what could be changed within the kernel to get the Ethernet adapter > working. > > Dave > > -- > You are receiving this mail because: > You are the assignee for the bug. -- Best regards, Maxim Uvarov

Re: [PATCH 2/3] net:phy:dp83867: increase SGMII autoneg timer duration

2019-05-24 Thread Maxim Uvarov
пт, 24 мая 2019 г. в 20:24, Heiner Kallweit : > > On 24.05.2019 12:25, Max Uvarov wrote: > > After reset SGMII Autoneg timer is set to 2us (bits 6 and 5 are 01). > > That us not enough to finalize autonegatiation on some devices. > > Increase this timer duration to maximum supported 16ms. > > > > S

Re: [PATCH] net:phy:dp83867: set up rgmii tx delay

2019-05-24 Thread Maxim Uvarov
пт, 24 мая 2019 г. в 17:37, Florian Fainelli : > > > > On 5/24/2019 3:35 AM, Max Uvarov wrote: > > PHY_INTERFACE_MODE_RGMII_RXID is less then TXID > > so code to set tx delay is never called. > > > > Signed-off-by: Max Uvarov > > Could you provide an appropriate Fixes: tag for this as well as fix

Re: [PATCH 1/3] net:phy:dp83867: fix speed 10 in sgmii mode

2019-05-24 Thread Maxim Uvarov
omething is wrong with mdio bus. I.e. write returned error. And it's more likely hardware bug which needs to be fixed. Once I used to not print this error on each ifconfig up/down. Max. > > > + return ret; > > + } > > + } > > + > > /* Enable Interrupt output INT_OE in CFG3 register */ > > if (phy_interrupt_is_valid(phydev)) { > > val = phy_read(phydev, DP83867_CFG3); > > > -- Best regards, Maxim Uvarov

Re: regression from: net: phy: marvell: Avoid unnecessary soft reset

2019-03-20 Thread Maxim Uvarov
's ok for you I'd submit a patch. > > >> > >> diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index > >> 3ccba37bd6dd..6a1ea4c2042a 100644 > >> --- a/drivers/net/phy/marvell.c > >> +++ b/drivers/net/phy/marvell.c > >> @@ -448,6 +448,10 @@ static int m88e1121_config_aneg(struct phy_device > >> *phydev) > >> err = m88e1121_config_aneg_rgmii_delays(phydev); > >> if (err < 0) > >> return err; > >> + > >> + err = genphy_soft_reset(phydev); > >> + if (err < 0) > >> + return err; > >> } > >> > >> err = marvell_set_polarity(phydev, phydev->mdix_ctrl); > >> > > > -- Best regards, Maxim Uvarov

Re: [PATCH v1 net] net: dsa: mv88x6xxx: mv88e6390 errata

2019-01-09 Thread Maxim Uvarov
port.h > @@ -251,6 +251,16 @@ > /* Offset 0x19: Port IEEE Priority Remapping Registers (4-7) */ > #define MV88E6095_PORT_IEEE_PRIO_REMAP_45670x19 > > +/* Offset 0x1a: Magic undocumented errata register */ > +#define PORT_RESERVED_1A 0x1a > +#define PORT_RESERVED_1A_BUSY BIT(15) > +#define PORT_RESERVED_1A_WRITE BIT(14) > +#define PORT_RESERVED_1A_READ 0 > +#define PORT_RESERVED_1A_PORT_SHIFT5 > +#define PORT_RESERVED_1A_BLOCK (0xf << 10) > +#define PORT_RESERVED_1A_CTRL_PORT 4 > +#define PORT_RESERVED_1A_DATA_PORT 5 > + > int mv88e6xxx_port_read(struct mv88e6xxx_chip *chip, int port, int reg, > u16 *val); > int mv88e6xxx_port_write(struct mv88e6xxx_chip *chip, int port, int reg, > -- > 2.19.1 > -- Best regards, Maxim Uvarov

Re: [PATCH] dp83867: fix speed 10 in sgmii mode

2018-12-06 Thread Maxim Uvarov
пт, 26 окт. 2018 г. в 02:06, Andrew Lunn : > > On Thu, Oct 25, 2018 at 02:05:30PM +0300, Max Uvarov wrote: > > Hi Max > > > For support 10Mps sped in SGMII mode DP83867_10M_SGMII_RATE_ADAPT bit > > speed. > > > of DP83867_10M_SGMII_CFG register has to be cleared by software. > > That does not affec

Re: [PATCH 3/4] cpsw_switchdev: add switchdev support files

2018-05-24 Thread Maxim Uvarov
truct cpsw_priv *priv = netdev_priv(ndev); > + int err = 0; > + > + switch (obj->id) { > + case SWITCHDEV_OBJ_ID_PORT_VLAN: > + err = cpsw_port_vlans_del(priv, vlan); > + break; > + case SWITCHDEV_OBJ_ID_PORT_MDB: > + err = cpsw_port_mdb_del(priv, SWITCHDEV_OBJ_PORT_MDB(obj)); > + break; > + default: > + err = -EOPNOTSUPP; > + break; > + } > + > + return err; > +} > + > +static const struct switchdev_ops cpsw_port_switchdev_ops = { > + .switchdev_port_attr_set= cpsw_port_attr_set, > + .switchdev_port_attr_get= cpsw_port_attr_get, > + .switchdev_port_obj_add = cpsw_port_obj_add, > + .switchdev_port_obj_del = cpsw_port_obj_del, > +}; > + > +void cpsw_port_switchdev_init(struct net_device *ndev) > +{ > + ndev->switchdev_ops = &cpsw_port_switchdev_ops; > +} > diff --git a/drivers/net/ethernet/ti/cpsw_switchdev.h > b/drivers/net/ethernet/ti/cpsw_switchdev.h > new file mode 100644 > index 000..4940462 > --- /dev/null > +++ b/drivers/net/ethernet/ti/cpsw_switchdev.h > @@ -0,0 +1,4 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#include > + > +void cpsw_port_switchdev_init(struct net_device *ndev); > -- > 2.7.4 > -- Best regards, Maxim Uvarov

Re: phy: micrel.c: Support ksz9031 energy-detect power-down mode

2018-02-27 Thread Maxim Uvarov
CC netdev 2018-02-27 13:12 GMT+03:00 Maxim Uvarov : > It migth be reason to reconsider of unconditionally enable power-down mode. > v1 of patch and code here: > https://lkml.org/lkml/2016/10/3/199 > > I see that 9031 just lock ups with start from -40C just after > swtiching

Re: [PATCH v1 RFC 1/1] Add Microchip KSZ8795 DSA driver

2017-10-09 Thread Maxim Uvarov
Hello Tristram, in previous version I see that transit traffic (ping) goes to cpu, then from cpu back to destination port. I.e. it works but with cpu involving. Is this version supposed to work like that? Thank you, Maxim. 2017-10-06 23:33 GMT+03:00 : > From: Tristram Ha > > Add Microchip KSZ8

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

2017-09-14 Thread Maxim Uvarov
never do anything different if a debugfs call succeeds or >> fails. > > Thank for your interesting review! I'll cleanup my out-of-tree patches. > > > Vivien -- Best regards, Maxim Uvarov

Re: [PATCH RFC] Update documentation for KSZ DSA drivers so that new drivers can be added

2017-09-11 Thread Maxim Uvarov
2017-09-08 22:48 GMT+03:00 : >> -Original Message- >> From: Maxim Uvarov [mailto:muva...@gmail.com] >> Sent: Friday, September 08, 2017 12:00 PM >> To: Florian Fainelli >> Cc: Tristram Ha - C24268; Andrew Lunn; Pavel Machek; Nathan Conrad; Vivien

Re: [PATCH RFC] Update documentation for KSZ DSA drivers so that new drivers can be added

2017-09-08 Thread Maxim Uvarov
>> label = "lan4"; >> - >> }; >> - >> port@4 { >> - >> reg = <4>; >> - >> label = "lan5"; >> - >> }; >> - >> port@5 { >> - >> reg = <5>; >> - >> label = "cpu"; >> - >> ethernet = <ð0>; >> - >> fixed-link { >> - >> speed = <1000>; >> - >> full-duplex; >> - >> }; >> - >> }; >> - }; >> - }; >> - }; >> > > > -- > Florian -- Best regards, Maxim Uvarov

Re: [PATCH RFC] Update documentation for KSZ DSA drivers so that new drivers can be added

2017-09-08 Thread Maxim Uvarov
>> port@5 { >> - >> reg = <5>; >> - >> label = "cpu"; >> - >> ethernet = <ð0>; >> - >> fixed-link { >> - >> speed = <1000>; >> - >> full-duplex; >> - >> }; >> - >> }; >> - }; >> - }; >> - }; > > This part however is a nice cleanup. You can submit this patch as a > separate patch, once netdev has opened again in about 10 days time. > > Andrew -- Best regards, Maxim Uvarov

Re: [PATCH] DSA support for Micrel KSZ8895

2017-09-06 Thread Maxim Uvarov
8895 driver will be submitted right after that. You > should have no problem using the driver right away. > Hello Tristram, is there any update for that driver? Maxim. > Tristram Ha > Principal Software Engineer > Microchip Technology Inc. > -- Best regards, Maxim Uvarov

Re: DSA mv88e6xxx RX frame errors and TCP/IP RX failure

2017-08-31 Thread Maxim Uvarov
for the maximum receive buffer size. The > driver is already allocating a receive SKB of 2048 bytes, so this > change should not have any significant effects. > > Tested on imx51, imx6, vf610. > > Signed-off-by: Andrew Lunn > Signed-off-by: David S. Miller > > > However, this is was of an all/nothing problem. All frames with the > full MTU were getting dropped, where as i think you are only seeing a > few dropped? > > Anyway, try cherry picking that patch and see if it helps. > > Andrew -- Best regards, Maxim Uvarov

Re: [PATCH] DSA support for Micrel KSZ8895

2017-08-30 Thread Maxim Uvarov
_link; return phydev; } Where is bus is: bus = mdiobus_alloc(); bus->read = ksz_mii_read; (spi read function) bus->write = ksz_mii_write; Then just generic reads: .config_aneg= genphy_config_aneg, .read_status= genphy_read_status, Maxim. >> >> Pointers would be welcome at this point. >> >> Thanks, >> Pavel >> > > > -- > Florian -- Best regards, Maxim Uvarov

Re: [PATCH] DSA support for Micrel KSZ8895

2017-08-28 Thread Maxim Uvarov
are library. Both driver and DSA driver. Driver has to work with some minor fixups related to your kernel version. But I think they are don't care about up-streaming that code. So you can take their code as a reference. -- Best regards, Maxim Uvarov

Re: port mirror on dsa switches?

2017-03-16 Thread Maxim Uvarov
2017-03-16 19:47 GMT+03:00 Florian Fainelli : > Hi, > > On 03/16/2017 03:32 AM, Maxim Uvarov wrote: >> Hello, >> >> Some dsa switches can support port mirror in hardware. Does somebody >> have any idea how to >> work with it from linux side in generic way?

port mirror on dsa switches?

2017-03-16 Thread Maxim Uvarov
S set up on dsa switch ports. -- Best regards, Maxim Uvarov

Adding vlan to DSA port causes lockdep splat

2017-02-21 Thread Maxim Uvarov
0x38) [ 37.510171] r7:1002 r6: r5:dd4fd800 r4:dc1f3000 [ 37.515856] [] (dsa_slave_set_rx_mode) from [] (__dev_set_rx_mode+0x64/0x9c) -- Best regards, Maxim Uvarov