[PATCH 1/1] net: dsa: Fix type was not set for devlink port

2021-03-29 Thread Maxim Kochetkov
/devlink.c:8097 0xc083f9d8 We should unregister the devlink port as a user port and re-register it as an unused port before executing "continue" in case of dsa_port_setup error. Fixes: 86f8b1c01a0a ("net: dsa: Do not make user port errors fatal") Signed-off-by: Maxim Kochetkov ---

[PATCH net-next] fsl/fman: Add MII mode support.

2021-01-11 Thread Maxim Kochetkov
Set proper value to IF_MODE register for MII mode. Signed-off-by: Maxim Kochetkov --- drivers/net/ethernet/freescale/fman/fman_memac.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c b/drivers/net/ethernet/freescale/fman/fman_memac.c

[PATCH] fsl/fman: Add MII mode support.

2020-12-26 Thread Maxim Kochetkov
Set proper value to IF_MODE register for MII mode. Signed-off-by: Maxim Kochetkov --- drivers/net/ethernet/freescale/fman/fman_memac.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c b/drivers/net/ethernet/freescale/fman/fman_memac.c

[PATCH v4] net: dsa: seville: the packet buffer is 2 megabits, not megabytes

2020-10-18 Thread Maxim Kochetkov
The VSC9953 Seville switch has 2 megabits of buffer split into 4360 words of 60 bytes each. 2048 * 1024 is 2 megabytes instead of 2 megabits. 2 megabits is (2048 / 8) * 1024 = 256 * 1024. Signed-off-by: Maxim Kochetkov Reviewed-by: Vladimir Oltean Fixes: a63ed92d217f ("net: dsa: seville

[PATCH v3 1/1] net: dsa: seville: the packet buffer is 2 megabits, not megabytes

2020-10-16 Thread Maxim Kochetkov
The VSC9953 Seville switch has 2 megabits of buffer split into 4360 words of 60 bytes each. 2048 * 1024 is 2 megabytes instead of 2 megabits. 2 megabits is (2048 / 8) * 1024 = 256 * 1024. Signed-off-by: Maxim Kochetkov Reviewed-by: Vladimir Oltean Fixes: a63ed92d217f ("net: dsa: seville

[PATCH v3 1/2] net: dsa: seville: the packet buffer is 2 megabits, not megabytes

2020-10-15 Thread Maxim Kochetkov
The VSC9953 Seville switch has 2 megabits of buffer split into 4360 words of 60 bytes each. 2048 * 1024 is 2 megabytes instead of 2 megabits. 2 megabits is (2048 / 8) * 1024 = 256 * 1024. Signed-off-by: Maxim Kochetkov Reviewed-by: Vladimir Oltean Fixes: a63ed92d217f ("net: dsa: seville

[PATCH v2 1/1] net: dsa: seville: the packet buffer is 2 megabits, not megabytes

2020-10-14 Thread Maxim Kochetkov
The VSC9953 Seville switch has 2 megabits of buffer split into 4360 words of 60 bytes each. 2048 * 1024 is 2 megabytes instead of 2 megabits. 2 megabits is (2048 / 8) * 1024 = 256 * 1024. Signed-off-by: Maxim Kochetkov Fixes: a63ed92d217f ("net: dsa: seville: fix buffer size of the queue s

[PATCH] net: mscc: ocelot: Allow using without PCI on t1040 SoC

2020-10-13 Thread Maxim Kochetkov
There is no need to select FSL_ENETC_MDIO on t1040 SoC (ppc). Signed-off-by: Maxim Kochetkov --- drivers/net/dsa/ocelot/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/ocelot/Kconfig b/drivers/net/dsa/ocelot/Kconfig index 2d23ccef7d0e

[PATCH 1/1] net: dsa: seville: fix buffer size of the queue system

2020-10-13 Thread Maxim Kochetkov
The VSC9953 Seville switch has 2 megabits of buffer split into 4360 words of 60 bytes each. 2048 * 1024 is 2 megabytes instead of 2 megabytes. 2 megabytes is (2048 / 8) * 1024 = 256 * 1024. Signed-off-by: Maxim Kochetkov Fixes: a63ed92d217f ("net: dsa: seville: fix buffer size of the

Re: [PATCH v2 devicetree 0/2] Add Seville Ethernet switch to T1040RDB

2020-09-29 Thread Maxim Kochetkov
Reviewed-by: Maxim Kochetkov 29.09.2020 14:32, Vladimir Oltean пишет: Seville is a DSA switch that is embedded inside the T1040 SoC, and supported by the mscc_seville DSA driver inside drivers/net/dsa/ocelot. This series adds this switch to the SoC's dtsi files and to the T1040RDB board

Re: [PATCH v2 devicetree 2/2] powerpc: dts: t1040rdb: add ports for Seville Ethernet switch

2020-09-29 Thread Maxim Kochetkov
Reviewed-by: Maxim Kochetkov 29.09.2020 14:32, Vladimir Oltean пишет: From: Vladimir Oltean Define the network interface names for the switch ports and hook them up to the 2 QSGMII PHYs that are onboard. A conscious decision was taken to go along with the numbers that are written on the

Re: [PATCH v2 devicetree 1/2] powerpc: dts: t1040: add bindings for Seville Ethernet switch

2020-09-29 Thread Maxim Kochetkov
Reviewed-by: Maxim Kochetkov 29.09.2020 14:32, Vladimir Oltean пишет: Add the description of the embedded L2 switch inside the SoC dtsi file for NXP T1040. Signed-off-by: Vladimir Oltean --- Changes in v2: Make switch node disabled by default. arch/powerpc/boot/dts/fsl/t1040si-post.dtsi

[PATCH] gianfar: Use random MAC address when none is given

2020-07-14 Thread Maxim Kochetkov
If there is no valid MAC address in the device tree, use a random MAC address. Signed-off-by: Maxim Kochetkov --- drivers/net/ethernet/freescale/gianfar.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet

Re: 88E6176 dsa switch on ls1021a (GIANFAR)

2020-07-13 Thread Maxim Kochetkov
Sorry that was my mistake. That was my own custom patch for bridge (for some old board). Thank you very much! 13.07.2020 14:20, Vladimir Oltean wrote: This call path is interesting. How does br_fdb_update() end up calling dsa_legacy_fdb_add(), which is only accessible through .ndo_fdb_add? The

88E6176 dsa switch on ls1021a (GIANFAR)

2020-07-13 Thread Maxim Kochetkov
I connected 88E6176 switch to ls1021a based board. DSA works fine. But I found a problem. 1) Set IP on lan0 (switch port 0). 2) Create bridge br0. 3) Add lan3 (switch port3) to br0. 4) Set lan3 up. 5) Set IP on br0. [ 1530.97

[PATCH net-next v3 1/3] net: phy: marvell: use a single style for referencing functions

2020-06-22 Thread Maxim Kochetkov
The kernel in general does not use &func referencing format. Signed-off-by: Maxim Kochetkov Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli --- drivers/net/phy/marvell.c | 222 +++--- 1 file changed, 111 insertions(+), 111 deletions(-) diff --g

[PATCH net-next v3 3/3] net: phy: marvell: Add Marvell 88E1548P support

2020-06-22 Thread Maxim Kochetkov
Add support for this new phy ID. Signed-off-by: Maxim Kochetkov Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli --- drivers/net/phy/marvell.c | 23 +++ include/linux/marvell_phy.h | 1 + 2 files changed, 24 insertions(+) diff --git a/drivers/net/phy/marvell.c b

[PATCH net-next v3 0/3] Add Marvell 88E1340S, 88E1548P support

2020-06-22 Thread Maxim Kochetkov
This patch series add new PHY id support. Russell King asked to use single style for referencing functions. Maxim Kochetkov (3): net: phy: marvell: use a single style for referencing functions net: phy: marvell: Add Marvell 88E1340S support net: phy: marvell: Add Marvell 88E1548P support

[PATCH net-next v3 2/3] net: phy: marvell: Add Marvell 88E1340S support

2020-06-22 Thread Maxim Kochetkov
Add support for this new phy ID. Signed-off-by: Maxim Kochetkov Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli --- drivers/net/phy/marvell.c | 23 +++ include/linux/marvell_phy.h | 1 + 2 files changed, 24 insertions(+) diff --git a/drivers/net/phy/marvell.c b

[PATCH net-next v2 3/3] net: phy: marvell: Add Marvell 88E1548P support

2020-06-21 Thread Maxim Kochetkov
Add support for this new phy ID. Signed-off-by: Maxim Kochetkov --- drivers/net/phy/marvell.c | 23 +++ include/linux/marvell_phy.h | 1 + 2 files changed, 24 insertions(+) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index 0842deb33085

[PATCH net-next v2 1/3] net: phy: marvell: use a single style for referencing functions

2020-06-21 Thread Maxim Kochetkov
The kernel in general does not use &func referencing format. Signed-off-by: Maxim Kochetkov --- drivers/net/phy/marvell.c | 222 +++--- 1 file changed, 111 insertions(+), 111 deletions(-) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c i

[PATCH net-next v2 0/3] Add Marvell 88E1340S, 88E1548P support

2020-06-21 Thread Maxim Kochetkov
This patch series add new PHY id support. Russell King asked to use single style for referencing functions. Maxim Kochetkov (3): net: phy: marvell: use a single style for referencing functions net: phy: marvell: Add Marvell 88E1340S support net: phy: marvell: Add Marvell 88E1548P support

[PATCH net-next v2 2/3] net: phy: marvell: Add Marvell 88E1340S support

2020-06-21 Thread Maxim Kochetkov
Add support for this new phy ID. Signed-off-by: Maxim Kochetkov --- drivers/net/phy/marvell.c | 23 +++ include/linux/marvell_phy.h | 1 + 2 files changed, 24 insertions(+) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index ee9c352f67ab

[PATCH 1/3] net: phy: marvell: use a single style for referencing functions

2020-06-19 Thread Maxim Kochetkov
The kernel in general does not use &func referencing format. Signed-off-by: Maxim Kochetkov --- drivers/net/phy/marvell.c | 222 +++--- 1 file changed, 111 insertions(+), 111 deletions(-) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c i

[PATCH 2/3] net: phy: marvell: Add Marvell 88E1340S support

2020-06-19 Thread Maxim Kochetkov
Add support for this new phy ID. Signed-off-by: Maxim Kochetkov --- drivers/net/phy/marvell.c | 23 +++ include/linux/marvell_phy.h | 1 + 2 files changed, 24 insertions(+) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index db5257f3b362

[PATCH 3/3] net: phy: marvell: Add Marvell 88E1548P support

2020-06-19 Thread Maxim Kochetkov
Add support for this new phy ID. Signed-off-by: Maxim Kochetkov --- drivers/net/phy/marvell.c | 24 include/linux/marvell_phy.h | 1 + 2 files changed, 25 insertions(+) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index de6bd07a5983

[PATCH 0/3] Add Marvell 88E1340S, 88E1548P support

2020-06-19 Thread Maxim Kochetkov
This patch series add new PHY id support. Russell King asked to use single style for referencing functions. Maxim Kochetkov (3): net: phy: marvell: use a single style for referencing functions net: phy: marvell: Add Marvell 88E1340S support net: phy: marvell: Add Marvell 88E1548P support

Re: [PATCH v2 01/02] net: phy: marvell: Add Marvell 88E1340 support

2020-06-17 Thread Maxim Kochetkov
I just copied this part from another marvell PHY description. I can remove &-style reference for all marvell PHY's at next patch. 17.06.2020 11:47, Russell King - ARM Linux admin wrote: On Wed, Jun 17, 2020 at 07:52:45AM +0300, Maxim Kochetkov wrote: Add Marvell 88E1340 support Sign

[PATCH v2 01/02] net: phy: marvell: Add Marvell 88E1340 support

2020-06-16 Thread Maxim Kochetkov
Add Marvell 88E1340 support Signed-off-by: Maxim Kochetkov --- drivers/net/phy/marvell.c | 23 +++ include/linux/marvell_phy.h | 1 + 2 files changed, 24 insertions(+) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index 7fc8e10c5f33..4cc4e25fed2d

[PATCH v2 02/02] net: phy: marvell: Add Marvell 88E1548 support

2020-06-16 Thread Maxim Kochetkov
Add Marvell 88E1548 support Signed-off-by: Maxim Kochetkov --- drivers/net/phy/marvell.c | 24 include/linux/marvell_phy.h | 1 + 2 files changed, 25 insertions(+) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index 4cc4e25fed2d..f0d4ca87e4bc

Re: [PATCH 01/02] net: phy: marvell: Add Marvell 88E1340 support

2020-06-16 Thread Maxim Kochetkov
Yes. This is 88E1340S. My mistake. 16.06.2020 17:54, Andrew Lunn wrote: On Tue, Jun 16, 2020 at 10:01:11AM +0300, Maxim Kochetkov wrote: Add Marvell 88E1340 support Hi Maxim Are you sure this is an 88E1340, not a 88E1340S? Marvells DSDT SDK has: MAD_88E1340S = 0x1C,/* 88E1340S

[PATCH 01/02] net: phy: marvell: Add Marvell 88E1340 support

2020-06-16 Thread Maxim Kochetkov
Add Marvell 88E1340 support Signed-off-by: Maxim Kochetkov --- drivers/net/phy/marvell.c | 23 +++ include/linux/marvell_phy.h | 1 + 2 files changed, 24 insertions(+) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index 7fc8e10c5f33..4cc4e25fed2d

[PATCH 02/02] net: phy: marvell: Add Marvell 88E1548 support

2020-06-16 Thread Maxim Kochetkov
Add Marvell 88E1548 support Signed-off-by: Maxim Kochetkov --- drivers/net/phy/marvell.c | 24 include/linux/marvell_phy.h | 1 + 2 files changed, 25 insertions(+) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index 4cc4e25fed2d..f0d4ca87e4bc