e759cda51b ("l2tp: use standard API for warning log messages")
Signed-off-by: Matthias Schiffer
---
v2:
- Add counter for invalid packets
- Reduce loglevel of more messages that can be abused for log spam
include/uapi/linux/l2tp.h | 1 +
net/l2tp/l
On 2/23/21 10:47 AM, Tom Parkin wrote:
On Mon, Feb 22, 2021 at 14:31:38 -0800, Jakub Kicinski wrote:
On Mon, 22 Feb 2021 17:40:16 +0100 Matthias Schiffer wrote:
This will not be sufficient for my usecase: To stay compatible with older
versions of fastd, I can't set the T flag in the
On 2/22/21 12:49 PM, Tom Parkin wrote:
On Sat, Feb 20, 2021 at 10:56:33 +0100, Matthias Schiffer wrote:
On 2/19/21 9:12 PM, Tom Parkin wrote:
On Fri, Feb 19, 2021 at 20:06:15 +0100, Matthias Schiffer wrote:
Before commit 5ee759cda51b ("l2tp: use standard API for warning log
messages&
Hi Tom,
On 2/19/21 9:12 PM, Tom Parkin wrote:
Hi Matthias,
Thanks for your patch!
On Fri, Feb 19, 2021 at 20:06:15 +0100, Matthias Schiffer wrote:
Before commit 5ee759cda51b ("l2tp: use standard API for warning log
messages"), it was possible for userspace applications to use
2TP version are checked
before the T flag.
Reduce all warnings debug level when packets are passed to userspace.
Fixes: 5ee759cda51b ("l2tp: use standard API for warning log messages")
Signed-off-by: Matthias Schiffer
---
I'm unsure what to do about the pr_warn_ratelimited() i
Z8795 driver (which completely broke probing, as the CPU port
index was always failing the num_ports check).
Fixes: af199a1a9cb0 ("net: dsa: microchip: set the correct number of
ports")
Signed-off-by: Matthias Schiffer
---
drivers/net/dsa/microchip/ksz8795.c | 2 +-
1 file changed, 1
On Thu, 2020-09-10 at 17:00 +0200, Andrew Lunn wrote:
> > I propose that at least these HW modes should be available (and
> > documented) for ethernet PHY controlled LEDs:
> > mode to determine link on:
> > - `link`
> > mode for activity (these should blink):
> > - `activity` (both rx a
On Mon, 2020-08-03 at 07:44 +0200, Michael Grzeschik wrote:
> Add KSZ88X3 driver support. We add support for the KXZ88X3 three port
> switches using the Microchip SMI Interface. They are supported using
> the
> MDIO-Bitbang Interface.
>
> Signed-off-by: Michael Grzeschik
>
> ---
> v1 -> v2: - t
On Mon, 2020-08-03 at 07:44 +0200, Michael Grzeschik wrote:
> This series adds support for the ksz88x3 driver family to the dsa
> based ksz
> drivers. The driver is making use of the already available ksz8795
> driver and
> moves it to an generic driver for the ksz8 based chips which have
> similar
On Tue, 2020-07-28 at 17:05 +0200, Marek Behún wrote:
> Hi,
>
> this is v4 of my RFC adding support for LEDs connected to Marvell
> PHYs.
>
> Please note that if you want to test this, you still need to first
> apply
> the patch adding the LED private triggers support from Pavel's tree.
>
https:
On Sat, 2020-08-22 at 18:08 +0200, Andrew Lunn wrote:
> On Fri, Aug 21, 2020 at 09:21:46AM +0200, Matthias Schiffer wrote:
> > These DT bindings are already in use by the imx7-mba7 DTS, but they
> > were
> > not supported by the PHY driver so far.
> >
> >
These DT bindings are already in use by the imx7-mba7 DTS, but they were
not supported by the PHY driver so far.
Signed-off-by: Matthias Schiffer
---
drivers/net/phy/dp83867.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/drivers/net/phy/dp83867.c b/drivers
.
Signed-off-by: Matthias Schiffer
---
.../devicetree/bindings/net/ti,dp83867.yaml | 18 ++
include/dt-bindings/net/ti-dp83867.h | 60 +++
2 files changed, 78 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.yaml
b/Documentation/devicetree
disabling all.accept_ra would preclude users from explicitly enabling
accept_ra on individual interfaces.
Signed-off-by: Matthias Schiffer
---
net/ipv6/Kconfig| 12
net/ipv6/addrconf.c | 2 +-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/net/ipv6/Kconfig b/net
disabling all.accept_ra would preclude users from explicitly enabling
accept_ra on individual interfaces.
Signed-off-by: Matthias Schiffer
---
net/ipv6/Kconfig| 12
net/ipv6/addrconf.c | 2 +-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/net/ipv6/Kconfig b/net
Leaving a variable with a generic name such as TARGETS undefined would lead
to Make picking up its value from the environment. Avoid this by always
defining TARGETS in the Makefiles.
Signed-off-by: Matthias Schiffer
---
I also noticed that many Makefiles refer to a variable LIBS, which is
On 12/14/2017 01:31 AM, Stefano Brivio wrote:
> On Thu, 14 Dec 2017 01:25:40 +0100
> Matthias Schiffer wrote:
>
>> On 12/14/2017 01:10 AM, Stefano Brivio wrote:
>>> On Thu, 14 Dec 2017 00:57:32 +0100
>>> Matthias Schiffer wrote:
>>>
>>>
On 12/14/2017 01:10 AM, Stefano Brivio wrote:
> On Thu, 14 Dec 2017 00:57:32 +0100
> Matthias Schiffer wrote:
>
>> As you note, there is another occurrence of this calculation in
>> vxlan_config_apply():
>>
>>
>> [...]
>> if (lowerdev) {
&
On 12/13/2017 11:37 PM, Stefano Brivio wrote:
> Commit a985343ba906 ("vxlan: refactor verification and
> application of configuration") introduced a change in the
> behaviour of initial MTU setting: earlier, the MTU for a link
> created on top of a given lower device, without an initial MTU
> speci
Signed-off-by: Matthias Schiffer
---
drivers/net/wireless/ath/ath9k/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/Makefile
b/drivers/net/wireless/ath/ath9k/Makefile
index 36a40ffdce15..90e4a341076c 100644
--- a/drivers/net/wireless
th10k hardware.
Signed-off-by: Matthias Schiffer
---
checkpatch.pl wants me to write a more meaningful description for
ATH10K_SPECTRAL, but I don't actually know enough about the spectral scan
feature to do so...
drivers/net/wireless/ath/ath10k/Kconfig| 9 -
drivers/net/wi
routers, where we'd rather like to avoid the code size and RAM usage of the
relay support.
Signed-off-by: Matthias Schiffer
---
drivers/net/wireless/ath/ath9k/Kconfig | 14 ++
drivers/net/wireless/ath/ath9k/Makefile | 4 ++--
drivers/net/wireless/ath/ath9k/c
On 08/11/2017 06:19 PM, Roopa Prabhu wrote:
> On Thu, Aug 10, 2017 at 2:16 PM, Girish Moodalbail
> wrote:
>>
>> if (!is_valid_ether_addr(nla_data(tb[IFLA_ADDRESS]))) {
>> - pr_debug("invalid all zero ethernet address\n");
>> + NL_SET_ERR_
t;
> Fixes: a985343ba906 ("vxlan: refactor verification and application of
> configuration")
> Signed-off-by: Sabrina Dubroca
Thanks for fixing this up, I really didn't expect dev_net() not to return
the correct net in setup().
Reviewed-by: Matthias Schiffer
> -
icast addresses), and
add messages for the remaining attributes.
Signed-off-by: Matthias Schiffer
---
drivers/net/vxlan.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index fd0ff97e3d81..01957e39f2cd 100644
When refactoring the vxlan config validation, some kernel log messages were
removed. This brings them back using the new netlink_ext_ack support, and
adds some more in the recently added code handling link-local IPv6
addresses.
Signed-off-by: Matthias Schiffer
---
drivers/net/vxlan.c | 43
The access to the wrong variable could lead to a NULL dereference and
possibly other invalid memory reads in vxlan newlink/changelink requests
with a IFLA_MTU attribute.
Fixes: a985343ba906 "vxlan: refactor verification and application of
configuration"
Signed-off-by: Matthia
On 06/26/2017 03:33 PM, David Ahern wrote:
> On 6/26/17 2:43 AM, Matthias Schiffer wrote:
>> On 06/26/2017 06:08 AM, David Ahern wrote:
>>> On 6/25/17 10:04 PM, David Ahern wrote:
>>>> On 6/25/17 3:56 PM, Matthias Schiffer wrote:
>>>>> Add support for
On 06/26/2017 06:08 AM, David Ahern wrote:
> On 6/25/17 10:04 PM, David Ahern wrote:
>> On 6/25/17 3:56 PM, Matthias Schiffer wrote:
>>> Add support for extended error reporting.
>>>
>>> Signed-off-by: Matthias Schiffer
>>> ---
>>
>>
>&g
Add support for extended error reporting.
Signed-off-by: Matthias Schiffer
---
drivers/infiniband/ulp/ipoib/ipoib_netlink.c | 3 ++-
drivers/net/bonding/bond_netlink.c | 3 ++-
drivers/net/caif/caif_hsi.c | 3 ++-
drivers/net/can/dev.c| 3
Same changes as http://patchwork.ozlabs.org/patch/780351/ , split into
separate patches for each rtnl_link_ops field as requested.
Matthias Schiffer (5):
net: add netlink_ext_ack argument to rtnl_link_ops.newlink
net: add netlink_ext_ack argument to rtnl_link_ops.changelink
net: add
Add support for extended error reporting.
Signed-off-by: Matthias Schiffer
---
drivers/net/bonding/bond_netlink.c | 3 ++-
drivers/net/can/dev.c | 3 ++-
drivers/net/dummy.c| 3 ++-
drivers/net/geneve.c | 3 ++-
drivers/net/gtp.c | 3
Add support for extended error reporting.
Signed-off-by: Matthias Schiffer
---
include/net/rtnetlink.h | 3 ++-
net/core/rtnetlink.c| 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/net/rtnetlink.h b/include/net/rtnetlink.h
index baf99e173dca..abe6b733d473
Add support for extended error reporting.
Signed-off-by: Matthias Schiffer
---
drivers/net/bonding/bond_netlink.c | 3 ++-
include/net/rtnetlink.h| 3 ++-
net/bridge/br_netlink.c| 3 ++-
net/core/rtnetlink.c | 3 ++-
4 files changed, 8 insertions(+), 4
Add support for extended error reporting.
Signed-off-by: Matthias Schiffer
---
drivers/infiniband/ulp/ipoib/ipoib_netlink.c | 7 ---
drivers/net/bonding/bond_netlink.c | 7 ---
drivers/net/caif/caif_hsi.c | 3 ++-
drivers/net/can/dev.c
The following functions are extended with a netlink_ext_ack argument to
allow extended error reporting:
* validate
* newlink
* changelink
* slave_validate
* slave_changelink
Signed-off-by: Matthias Schiffer
---
Checkpatch is unhappy about the long lines in include/net/rtnetlink.h, but
I guess
On 06/23/2017 12:23 PM, Johannes Berg wrote:
> On Fri, 2017-06-23 at 12:13 +0200, Matthias Schiffer wrote:
>>
>> I was told the extended netlink error facilities were not ready yet,
>> has that changed since the last release?
>
> Yes, the facility is in the kernel tree
On 06/23/2017 10:52 AM, Jiri Benc wrote:
> This patchset looks good overall (would send my Acked-by for most of
> this but I'm late).
>
> On Mon, 19 Jun 2017 10:03:55 +0200, Matthias Schiffer wrote:
>> Log messages in these
>> functions are removed, as it is gener
is very unusual
for errors in netlink requests to be printed to the kernel log.) The commit
message of patch 5 has been extended to add a note about IPv4.
Matthias Schiffer (6):
vxlan: refactor verification and application of configuration
vxlan: get rid of redundant vxlan_dev.flags
vxlan
fault port as other VXLAN sockets instead of the intended IANA-assigned
4790.
Signed-off-by: Matthias Schiffer
---
Notes:
v2: new patch
v3: remove kernel log messages
drivers/net/vxlan.c | 208
1 file changed, 111 insertions(+), 97 d
There is no good reason to keep the flags twice in vxlan_dev and
vxlan_config.
Signed-off-by: Matthias Schiffer
---
Notes:
v2: new patch
v3: rebase
drivers/net/vxlan.c | 76 +--
include/net/vxlan.h | 1 -
net/openvswitch
to respect the ifindex when link-local IPv6
addresses are used, so using the same VNI on multiple interfaces can
actually work.
Signed-off-by: Matthias Schiffer
---
Notes:
v2: use VXLAN_F_IPV6_LINKLOCAL in vxlan_vs_find_vni; rebase
v3: rebase
drivers/net/vxlan.c | 68
Address families of source and destination addresses must match, and
changelink operations can't change the address family.
In addition, always use the VXLAN_F_IPV6 to check if a VXLAN device uses
IPv4 or IPv6.
Signed-off-by: Matthias Schiffer
---
Notes:
v2: new patch
v3: r
s are used for the
follow-up patches that actually make VXLAN over link-local IPv6 work.
Signed-off-by: Matthias Schiffer
---
Notes:
v2: was "vxlan: don't allow link-local IPv6 local/remote addresses without
interface" before. v2 does a lot more checks and adds the
VX
;t as well defined as for IPv6, and there doesn't seem to
be much interest in having the support, it's not implemented for now.
Signed-off-by: Matthias Schiffer
---
Notes:
v2: use u32 instead of __u32
v3: rebase, add note about IPv4 to commit message
drivers/n
On 04/16/2017 05:15 PM, Matthias Schiffer wrote:
> On 04/14/2017 07:38 PM, Stephen Hemminger wrote:
>> On Fri, 14 Apr 2017 18:44:46 +0200
>> Matthias Schiffer wrote:
>>
>>> As link-local addresses are only valid for a single interface, we can allow
>>> to us
On 04/14/2017 07:38 PM, Stephen Hemminger wrote:
> On Fri, 14 Apr 2017 18:44:46 +0200
> Matthias Schiffer wrote:
>
>> As link-local addresses are only valid for a single interface, we can allow
>> to use the same VNI for multiple independent VXLANs, as long as the used
>&
On 04/14/2017 07:36 PM, Stephen Hemminger wrote:
> On Fri, 14 Apr 2017 18:44:44 +0200
> Matthias Schiffer wrote:
>
>> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
>> index 07f89b037681..95a71546e8f2 100644
>> --- a/drivers/net/vxlan.c
>> +++ b/d
On 04/14/2017 07:27 PM, Sergei Shtylyov wrote:
> On 04/14/2017 07:44 PM, Matthias Schiffer wrote:
>
>> * Multicast addresses are never valid as local address
>> * Link-local IPv6 unicast addresses may only be used as remote when the
>> local address is link-local as we
Address families of source and destination addresses must match, and
changelink operations can't change the address family.
In addition, always use the VXLAN_F_IPV6 to check if a VXLAN device uses
IPv4 or IPv6.
Signed-off-by: Matthias Schiffer
---
v2: new patch
drivers/net/vxlan.c
There is no good reason to keep the flags twice in vxlan_dev and
vxlan_config.
Signed-off-by: Matthias Schiffer
---
v2: new patch
drivers/net/vxlan.c | 76 +--
include/net/vxlan.h | 1 -
net/openvswitch/vport-vxlan.c | 4 +--
3
over IPv6 link-local
work, and allow multiple VXLANs wit the same VNI and port, as long as
link-local addresses on different interfaces are used. As suggested, I now
store in the flags field if the VXLAN uses link-local addresses or not.
Matthias Schiffer (6):
vxlan: refactor verification and
s are used for the
follow-up patches that actually make VXLAN over link-local IPv6 work.
Signed-off-by: Matthias Schiffer
---
v2: was "vxlan: don't allow link-local IPv6 local/remote addresses without
interface" before. v2 does a lot more checks and adds the
VXLAN_F_IPV6_LINKLOCAL
to respect the ifindex when link-local IPv6
addresses are used, so using the same VNI on multiple interfaces can
actually work.
Signed-off-by: Matthias Schiffer
---
v2: use VXLAN_F_IPV6_LINKLOCAL in vxlan_vs_find_vni; rebase.
drivers/net/vxlan.c | 73
If VXLAN is run over link-local IPv6 addresses, it is necessary to store
the ifindex in the FDB entries. Otherwise, the used interface is undefined
and unicast communication will most likely fail.
Signed-off-by: Matthias Schiffer
---
v2: use u32 instead of __u32
drivers/net/vxlan.c | 20
set in vxlan_setup before. This caused VXLAN-GPE to use the same
default port as other VXLAN sockets instead of the intended IANA-assigned
4790.
Signed-off-by: Matthias Schiffer
---
v2: new patch
drivers/net/vxlan.c | 202 +---
1 file chang
On 03/15/2017 04:22 PM, Jiri Benc wrote:
> On Wed, 15 Mar 2017 15:29:29 +0100, Matthias Schiffer wrote:
>> While ensuring that the destination address is link-local iff the source
>> address is would also be an option, it didn't seem too useful as the
>> destination a
On 03/14/2017 04:28 PM, Jiri Benc wrote:
> On Fri, 10 Mar 2017 23:39:44 +0100, Matthias Schiffer wrote:
>> @@ -233,17 +234,30 @@ static struct vxlan_dev *vxlan_vs_find_vni(struct
>> vxlan_sock *vs, __be32 vni)
>> vni = 0;
>>
>> hlist_for_each_
If VXLAN is run over link-local IPv6 addresses, it is necessary to store
the ifindex in the FDB entries. Otherwise, the used interface is undefined
and unicast communication will most likely fail.
Signed-off-by: Matthias Schiffer
---
drivers/net/vxlan.c | 20 +++-
1 file changed
laces.
The final patch lifts the limitation of not allowing multiple VXLANs with
the same VNI and port, as long as link-local IPv6 addresses are used and
different interfaces are specified. Again, this brings VXLAN a bit closer
to VLANs feature-wise.
Matthias Schiffer (3):
vxlan: don't allow
Signed-off-by: Matthias Schiffer
---
drivers/net/vxlan.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index e375560cc74e..cc0ace73d02e 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -2922,6 +2922,18 @@ static int
to respect the ifindex when link-local IPv6
addresses are used, so using the same VNI on multiple interfaces can
actually work.
Signed-off-by: Matthias Schiffer
---
drivers/net/vxlan.c | 88 -
1 file changed, 60 insertions(+), 28 deletions
The incorrect check caused an off-by-one error: the maximum VID 0xff
was unusable.
Fixes: d342894c5d2f ("vxlan: virtual extensible lan")
Signed-off-by: Matthias Schiffer
---
v2: check against VXLAN_N_VID instead of changing operator
drivers/net/vxlan.c | 2 +-
1 file changed, 1
The incorrect check caused an off-by-one error: the maximum VID 0xff
was unusable.
Fixes: d342894c5d2f ("vxlan: virtual extensible lan")
Signed-off-by: Matthias Schiffer
---
drivers/net/vxlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vxlan.c
On 03/25/2016 11:10 PM, Andrew Collins wrote:
> On 03/25/2016 02:43 PM, Matthias Schiffer wrote:
>> We've tried your patch, and it changes the symptoms a bit, but doesn't fix
>> the panic. I've attached kernel logs of the crash both before and after
>> applying
On 02/23/2016 11:29 PM, Andrew Collins wrote:
> I'm running into a relatively easily reproducible kernel panic related to
> the all_adj_list handling for netdevs
> in recent kernels.
>
> The following sequence of commands will reproduce the issue:
>
> ip link add link eth0 name eth0.100 type vlan
with rt->rt6i_table == NULL in these cases, making the kernel
crash.
Signed-off-by: Matthias Schiffer
---
v2: remove now unused variable net
net/ipv6/route.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 946880a..cc88a73 100
with rt->rt6i_table == NULL in these cases, making the kernel
crash.
Signed-off-by: Matthias Schiffer
---
This bug exists pretty much forever, please queue up for all -stable
kernels.
net/ipv6/route.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/route.c b/
On 06/22/2015 07:58 AM, Steven Barth wrote:
> On 22.06.2015 00:35, Matthias Schiffer wrote:
>> Could you explain in detail what you mean with "If you want specific SA,
>> add same route with higher metric and/or (more) specific src match."?
>> Routes aren't bo
On 06/22/2015 12:05 AM, Markus Stenberg wrote:
> Prefsrc is essentially historic non IPv6 construct. IPv6 SAS is based on dst,
> src, metric ordered lookup just like the routing is too ( lookup rfc, some
> src specific routing drafts for details ).
>
> Therefore I do not see a problem. If you w
On 05/05/2015 12:36 PM, Markus Stenberg wrote:
> If there are only IPv6 source specific default routes present, the
> host gets -ENETUNREACH on e.g. connect() because ip6_dst_lookup_tail
> calls ip6_route_output first, and given source address any, it fails,
> and ip6_route_get_saddr is never calle
71 matches
Mail list logo
