Re: [PATCH v2] brcmfmac: expose firmware config files through modinfo

2020-11-20 Thread Matthias Brugger
On 20/11/2020 11:05, Dmitry Osipenko wrote: 20.11.2020 12:52, matthias@kernel.org пишет: From: Matthias Brugger Apart from a firmware binary the chip needs a config file used by the FW. Add the config files to modinfo so that they can be read by userspace. Signed-off-by: Matthias

Re: [PATCH net-next v5 0/6] net-next: dsa: mt7530: add support for MT7531

2020-09-21 Thread Matthias Brugger
On 15/09/2020 01:32, David Miller wrote: From: Landen Chao Date: Fri, 11 Sep 2020 21:48:50 +0800 This patch series adds support for MT7531. MT7531 is the next generation of MT7530 which could be found on Mediatek router platforms such as MT7622 or MT7629. It is also a 7-ports switch with

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Matthias Brugger
default: dev_err_ratelimited(dev->dev, "tx urb failed: %d\n", urb->status); - fallthrough; - case 0: break; } Reviewed-by: Matthias Brugger

Re: [PATCH] brcmfmac: expose firmware config files through modinfo

2020-07-03 Thread Matthias Brugger
On 02/07/2020 20:00, Hans de Goede wrote: > Hi, > > On 7/1/20 5:46 PM, Matthias Brugger wrote: >> Hi Hans, >> >> On 01/07/2020 17:38, Hans de Goede wrote: >>> Hi, >>> >>> On 7/1/20 5:31 PM, matthias@kernel.org wrote: >>>>

Re: [PATCH] brcmfmac: expose firmware config files through modinfo

2020-07-01 Thread Matthias Brugger
Hi Hans, On 01/07/2020 17:38, Hans de Goede wrote: > Hi, > > On 7/1/20 5:31 PM, matthias@kernel.org wrote: >> From: Matthias Brugger >> >> Apart from a firmware binary the chip needs a config file used by the >> FW. Add the config files to modinfo so that

Re: [PATCH v5 00/11] mediatek: add support for MediaTek Ethernet MAC

2020-05-23 Thread Matthias Brugger
On 5/22/20 11:36 PM, David Miller wrote: > From: Matthias Brugger > Date: Fri, 22 May 2020 23:31:50 +0200 > >> >> >> On 22/05/2020 23:20, David Miller wrote: >>> From: Bartosz Golaszewski >>> Date: Fri, 22 May 2020 14:06:49 +0200 >>&g

Re: [PATCH v5 00/11] mediatek: add support for MediaTek Ethernet MAC

2020-05-22 Thread Matthias Brugger
On 22/05/2020 23:20, David Miller wrote: > From: Bartosz Golaszewski > Date: Fri, 22 May 2020 14:06:49 +0200 > >> This series adds support for the STAR Ethernet Controller present on MediaTeK >> SoCs from the MT8* family. > > Series applied to net-next, thank you. > If you say "series appli

Re: [PATCH v5 06/11] net: ethernet: mtk-star-emac: new driver

2020-05-22 Thread Matthias Brugger
On 22/05/2020 14:06, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This adds the driver for the MediaTek STAR Ethernet MAC currently used > on the MT8* SoC family. For now we only support full-duplex. MT85** SoC family, AFAIU it's not used on MT81** devices. Correct? > > Signed

Re: [PATCH net-next v4 3/3] dt-bindings: net: ethernet: Update mt7622 docs and dts to reflect the new phylink API

2019-08-29 Thread Matthias Brugger
On 28/08/2019 21:56, David Miller wrote: > From: Matthias Brugger > Date: Wed, 28 Aug 2019 11:29:45 +0200 > >> Thanks for taking this patch. For the next time, please make sure that dts[i] >> patches are independent from the binding description, as dts[i] should go &

Re: [PATCH net-next v4 3/3] dt-bindings: net: ethernet: Update mt7622 docs and dts to reflect the new phylink API

2019-08-28 Thread Matthias Brugger
Hi David, On 25/08/2019 19:43, René van Dorst wrote: > This patch the removes the recently added mediatek,physpeed property. > Use the fixed-link property speed = <2500> to set the phy in 2.5Gbit. > See mt7622-bananapi-bpi-r64.dts for a working example. > > Signed-off-by: René van Dorst > -- > v

Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread Matthias Brugger
On 30/11/2018 20:40, Kees Cook wrote: > On Fri, Nov 30, 2018 at 11:27 AM Jarkko Sakkinen > wrote: >> >> In order to comply with the CoC, replace with a hug. > > Heh. I support the replacement of the stronger language, but I find > "hug", "hugged", and "hugging" to be very weird replacemen

[PATCH] net: hns: Fix ethtool private flags

2018-03-15 Thread Matthias Brugger
The driver implementation returns support for private flags, while no private flags are present. When asked for the number of private flags it returns the number of statistic flag names. Fix this by returning EOPNOTSUPP for not implemented ethtool flags. Signed-off-by: Matthias Brugger

Re: [PATCH] net: ethernet: mediatek: add NULL check on of_match_device() return value

2017-07-07 Thread Matthias Brugger
On 07/07/2017 09:11 AM, Gustavo A. R. Silva wrote: Check return value from call to of_match_device() in order to prevent a NULL pointer dereference. In case of NULL print error message and return -ENODEV Signed-off-by: Gustavo A. R. Silva --- Reviewed-by: Matthias Brugger drivers/net

Re: [PATCH net-next v5 1/2] net: hns: support deferred probe when can not obtain irq

2017-04-28 Thread Matthias Brugger
deferred probe. Signed-off-by: lipeng Reviewed-by: Yisen Zhuang Reviewed-by: Matthias Brugger Looks good now, so you can keep my Reviewed-by. --- change log: V4 -> V5: 1. Float on net-next; V3 -> V4: 1. Delete redundant commit message; 2. add Reviewed-by: Matthias Brugger ; V2 -&

Re: [PATCH net v4 1/3] net: hns: support deferred probe when can not obtain irq

2017-04-27 Thread Matthias Brugger
deferred probe. Signed-off-by: lipeng Reviewed-by: Yisen Zhuang Reviewed-by: Matthias Brugger --- change log: V3 -> V4: 1. Delete redundant commit message; 2. add Reviewed-by: Matthias Brugger ; V2 -> V3: 1. Check return value when platform_get_irq in hns_rcb_get_cfg; --- drivers/net/et

Re: [PATCH net v3 2/3] net: hns: support deferred probe when no mdio

2017-04-26 Thread Matthias Brugger
, so we not init DSAF when there is no mdio, and free all resource, to later learn that we need to defer the probe. Signed-off-by: lipeng Reviewed-by: Yisen Zhuang Reviewed-by: Matthias Brugger --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 39 +++ 1 file

Re: [PATCH net v3 1/3] net: hns: support deferred probe when can not obtain irq

2017-04-26 Thread Matthias Brugger
deferred probe. We check for probe deferral in the hw layer probe, so we not probe into the main layer and memories, etc., to later learn that we need to defer the probe. This paragraph does not hold any more and should be deleted. Other then this: Reviewed-by: Matthias Brugger Signed-off-by

Re: [PATCH net v2 1/3] net: hns: support deferred probe when can not obtain irq

2017-04-24 Thread Matthias Brugger
On 24/04/17 13:43, lipeng (Y) wrote: On 2017/4/24 18:28, Matthias Brugger wrote: On 21/04/17 09:44, Yankejian wrote: From: lipeng In the hip06 and hip07 SoCs, the interrupt lines from the DSAF controllers are connected to mbigen hw module. The mbigen module is probed with module_init

Re: [PATCH net v2 1/3] net: hns: support deferred probe when can not obtain irq

2017-04-24 Thread Matthias Brugger
On 21/04/17 09:44, Yankejian wrote: From: lipeng In the hip06 and hip07 SoCs, the interrupt lines from the DSAF controllers are connected to mbigen hw module. The mbigen module is probed with module_init, and, as such, is not guaranteed to probe before the HNS driver. So we need to support defe

Re: [PATCH net-next 2/3] net: hns: support deferred probe when no mdio

2017-04-20 Thread Matthias Brugger
On 18/04/17 12:12, Yankejian wrote: From: lipeng In the hip06 and hip07 SoCs, phy connect to mdio bus.The mdio module is probed with module_init, and, as such, is not guaranteed to probe before the HNS driver. So we need to support deferred probe. We check for probe deferral in the mac init, s

Re: [PATCH 1/2] Documentation: devicetree: change the mediatek ethernet compatible string

2017-01-25 Thread Matthias Brugger
Crispin --- sounds reasonable to me: Reviewed-by: Matthias Brugger Documentation/devicetree/bindings/net/mediatek-net.txt |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt b/Documentation/devicetree/bindings/net

Re: [PATCH 0/5] net: thunderx: Miscellaneous fixes

2016-11-14 Thread Matthias Brugger
On 11/14/2016 06:32 PM, David Miller wrote: From: Matthias Brugger Date: Mon, 14 Nov 2016 13:01:25 +0100 On 14/11/16 11:54, sunil.kovv...@gmail.com wrote: From: Sunil Goutham This patchset includes fixes for incorrect LMAC credits, unreliable driver statistics, memory leak upon

Re: [PATCH 0/5] net: thunderx: Miscellaneous fixes

2016-11-14 Thread Matthias Brugger
On 14/11/16 11:54, sunil.kovv...@gmail.com wrote: From: Sunil Goutham This patchset includes fixes for incorrect LMAC credits, unreliable driver statistics, memory leak upon interface down e.t.c Are these fixes relevant to for older kernels as well? If so, please add "Cc: sta...@vger.kerne

Re: [PATCH v3 2/5] drivers: net: xgene: Backward compatibility with older firmware

2016-06-08 Thread Matthias Brugger
ement, in the case of backward compatibility. Also, some code clean up done around mdio configuration/remove. IMHO code clean up should be part of a different patch. Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le Tested-by: Matthias Brugger --- driver

Re: [PATCH v3 3/5] drivers: net: phy: Add MDIO driver

2016-06-08 Thread Matthias Brugger
I and SGMII based 1G interfaces, so adding this driver to manage MDIO bus. This driver registers the mdio bus and registers the PHYs connected to it. Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le Tested-by: Matthias Brugger --- drivers/net/ethernet/apm/xgene/Kc

Re: [PATCH v3 1/5] drivers: net: xgene: MAC and PHY configuration changes

2016-06-08 Thread Matthias Brugger
on pdata->mdio_driver flag Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le Tested-by: Matthias Brugger --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 190 +- drivers/net/ethernet/apm/xgene/xgene_enet_hw.h| 5 + drivers/net/et

Re: [PATCH v1 5/6] dtb: xgene: Remove clock nodes

2016-05-30 Thread Matthias Brugger
On 27/05/16 09:22, Iyappan Subramanian wrote: Since the MDIO will be responsible for clock reset, removing the clock nodes from shadowcat xge0 and storm sgenet1. Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le --- arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 1

Re: [PATCH v1 1/6] drivers: net: xgene: MAC and PHY configuration changes

2016-05-27 Thread Matthias Brugger
On 27/05/16 09:22, Iyappan Subramanian wrote: This patch fixes MAC configuration to support 10/100GbE for SGMII and link_state call back. It also sets pdata->mdio_driver flag based on ethernet mdio subnode and prepare for MDIO driver support. In summary, following are the changes, - Added set_s

Re: [PATCH v1 0/6] drivers: net: xgene: Fix 1G hot-plug and module support

2016-05-27 Thread Matthias Brugger
can add Tested-by: Matthias Brugger But I think the way the series is split in different patches is not correct. Patch 1 on its own won't compile and get fixed in patch 2. Although I think backward compatibility to older firmware should be part of the changes which provide support for th

[PATCH] drivers: net: xgene: Fix error handling

2016-05-03 Thread Matthias Brugger
When probe bails out with an error, we try to unregister the netdev before we have even registered it. Fix the goto statements for that. Signed-off-by: Matthias Brugger --- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] net: mediatek: fix checking for NULL instead of IS_ERR() in .probe

2016-03-23 Thread Matthias Brugger
Zapolskiy --- Reviewed-by: Matthias Brugger drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index 7f2126b..e0b68af 100644 --- a/drivers/ne