On Sun, Dec 04, 2016 at 03:19:31PM +0200, Netanel Belgazal wrote:
... because? (they turned out to be too aggressive, I believe.)
> Signed-off-by: Netanel Belgazal
> ---
> drivers/net/ethernet/amazon/ena/ena_com.c| 4 ++--
> drivers/net/ethernet/amazon/ena/ena_netdev.h | 7 ---
> 2 file
On Sun, Dec 04, 2016 at 03:19:26PM +0200, Netanel Belgazal wrote:
> The ENA device can update the ena driver about the desire timeouts.
> The hardware hints are transmitted as Asynchronous event to the driver.
This is really a new feature, not a bugfix - correct? If it is a new
feature, submit it
On Sun, Dec 04, 2016 at 03:19:24PM +0200, Netanel Belgazal wrote:
> If for some reason the device stop responding and the device reset failed
> to recover the device, the mmio register read datastructure will not be
> reinitialized.
If for some reason the device stops responding, and the device re
On Sun, Dec 04, 2016 at 03:19:23PM +0200, Netanel Belgazal wrote:
> ENA default hash configure IPv4_frag hash twice instead of
configure -> configures. You may want to include "erroneously". What
is the consequence of this bug?
> configure non ip packets.
configuring non-IP packets.
--msw
> Si
On Sun, Dec 04, 2016 at 03:19:22PM +0200, Netanel Belgazal wrote:
> ena_flow_data_to_flow_hash and ena_flow_hash_to_flow_type
> treat the ena_flow_hash_to_flow_type enum as power of two values.
>
> Change the values of ena_admin_flow_hash_fields to be power of two values.
Then I generally prefer
ible_cpus(), num_online_cpus().
> Signed-off-by: Netanel Belgazal
Reviewed-by: Matt Wilson
> ---
> drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> b/d
d 75 columns.
> Signed-off-by: Netanel Belgazal
Reviewed-by: Matt Wilson
> ---
> drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> b/drivers/net/ethernet/amazon/ena/ena_netdev.
On Sun, Dec 04, 2016 at 03:19:19PM +0200, Netanel Belgazal wrote:
> Remove NETIF_F_NTUPLE from netdev->features.
> The ENA device driver does not support ntuple filtering.
>
> Signed-off-by: Netanel Belgazal
Reviewed-by: Matt Wilson
> ---
> drivers/net/ethernet/amazon
On Sun, Dec 04, 2016 at 09:37:43PM -0500, David Miller wrote:
>
> It is not appropriate to submit so many patches at one time.
Indeed, https://www.kernel.org/doc/Documentation/SubmittingPatches
recommends submitting no more than 15 or so at once.
> Please keep your patch series to no more than a
On Thu, Jul 14, 2016 at 09:08:03AM -0700, Benjamin Poirier wrote:
> On 2016/07/14 08:22, Matt Wilson wrote:
> [...]
> >
> > Dave and Benjamin,
> >
> > Do you want to see the interrupt moderation extensions to ethtool and
> > the sysfs nodes removed befo
On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote:
> This is a driver for the ENA family of networking devices.
>
> Signed-off-by: Netanel Belgazal
> ---
>
> Notes:
> Changes in v3:
> - Fix compilation warning for 32bit systems. [kbuild test rebot]
> - Replace netdev->
On Thu, Jun 16, 2016 at 07:06:52PM +0100, Ben Hutchings wrote:
> On Thu, 2016-06-16 at 10:55 -0700, Benjamin Poirier wrote:
> > On 2016/06/13 11:46, Netanel Belgazal wrote:
> [...]
> > > +static ssize_t ena_show_small_copy_len(struct device *dev,
> > > + struct device
On Thu, Jun 16, 2016 at 10:46:23PM +0200, Francois Romieu wrote:
> Netanel Belgazal :
> [...]
>
> Very limited review below.
I'll comment on the documentation (since I edited it heavily) but will
leave some the other parts for Netanel to answer.
> > diff --git a/Documentation/networking/ena.txt
end emails as plain
text only. Have a look at [1] for how to set up a mailer like mutt
with Gmail.
--msw
[1] https://www.kernel.org/doc/Documentation/email-clients.txt
> On 15 June 2016 at 21:22, Matt Wilson wrote:
>
> > On Wed, Jun 15, 2016 at 11:07:17AM -0700, Matt Wilson wrote:
>
On Wed, Jun 15, 2016 at 11:07:17AM -0700, Matt Wilson wrote:
>
> You also had a few typos in the email addresses on the Cc: line that
> I've corrected (d...@avemeloft.net -> da...@davemeloft.net,
Argh, and of course I typo'ed the correction. -> da...@davemloft.net.
--msw
On Mon, Jun 13, 2016 at 11:46:13AM +0300, Netanel Belgazal wrote:
> This is a driver for the forthcoming ENA family of networking devices.
>
> Signed-off-by: Netanel Belgazal
[...]
> +
> +struct ena_napi {
> + struct napi_struct napi cacheline_aligned;
> + struct ena_ring *tx_ring;
On Tue, Jun 14, 2016 at 11:27:09PM -0700, David Miller wrote:
> From: Matt Wilson
> Date: Tue, 14 Jun 2016 23:23:36 -0700
>
> > Point taken, though existing drivers (even fairly popular ones) also
> > aren't as clean as you might like. A quick look around...
>
>
On Tue, Jun 14, 2016 at 10:25:16PM -0700, David Miller wrote:
> From: Netanel Belgazal
> Date: Mon, 13 Jun 2016 11:46:13 +0300
>
> > +#define ena_trc_dbg(format, arg...) \
> > + pr_debug("[ENA_COM: %s] " format, __func__, ##arg)
> > +#define ena_trc_info(format, arg...) \
> > + pr_info("[ENA_
On Mon, Jun 13, 2016 at 11:46:13AM +0300, Netanel Belgazal wrote:
> This is a driver for the forthcoming ENA family of networking devices.
Reviewed-by: Matt Wilson
> Signed-off-by: Netanel Belgazal
> ---
> Documentation/networking/00-INDEX |2 +
> Documenta
On Tue, Mar 15, 2016 at 01:19:07PM -0500, Dan Williams wrote:
> On Tue, 2016-03-15 at 12:50 +0200, Netanel Belgazal wrote:
> > +
> > +The ENA driver supports industry standard TCP/IP offload features
> > such
> > +as checksum offload and TCP transmit segmentation offload (TSO).
> > +
> > +Receive-s
On Tue, Mar 15, 2016 at 12:50:06PM +0200, Netanel Belgazal wrote:
[...]
> diff --git a/drivers/net/ethernet/amazon/Kconfig
> b/drivers/net/ethernet/amazon/Kconfig
> new file mode 100644
> index 000..bc4f240d
> --- /dev/null
> +++ b/drivers/net/ethernet/amazon/Kconfig
> @@ -0,0 +1,27 @@
> +#
>
Hi Netanel,
Looks like the last round of internal review went to {lkml,netdev,etc},
so this should be considered a RFC patch.
The description still needs work.
On Tue, Mar 15, 2016 at 12:50:06PM +0200, Netanel Belgazal wrote:
> This is a driver for the Amazon ethernet ENA family.
ethernet -> Et
22 matches
Mail list logo
