Re: [BUG] bad address in twothirdsMD4Transform

2008-02-11 Thread Matt Mackall
On Mon, 2008-02-11 at 20:29 +0100, Jiri Slaby wrote: > Hi, > > I get this with 32 bit Firefox 3b2 and java 1.6.0_03 on 64 bit: > > BUG: unable to handle kernel paging request at 8102366213f8 > IP: [] twothirdsMD4Transform+0xc4/0x3b0 You should mention what kernel you're using. This bug is on

Re: [PATCH] [RESENDING] netconsole: register cmdline netconsole configs to configfs

2008-02-11 Thread Matt Mackall
On Mon, 2008-02-11 at 18:08 +0900, Joonwoo Park wrote: > This patch intorduces cmdline netconsole configs to register to > configfs > with dynamic netconsole. Satyam Sharma who designed shiny dynamic > reconfiguration for netconsole, mentioned about this issue already. > (http://lkml.org/lkml/2007

Re: [2.6.24-mm1] TCP/IPv6 connect() oopses at twothirdsMD4Transform()

2008-02-04 Thread Matt Mackall
> err, Matt? random: revert braindamage that snuck into checkpatch cleanup Signed-off-by: Matt Mackall <[EMAIL PROTECTED]> diff -r 50a6e531a9f2 drivers/char/random.c --- a/drivers/char/random.c Mon Feb 04 20:23:02 2008 -0600 +++ b/drivers/char/random.c Mon Feb 04 20:28:08 2008 -

Re: [1/4] dst: Distributed storage documentation.

2007-12-02 Thread Matt Mackall
On Thu, Nov 29, 2007 at 03:53:23PM +0300, Evgeniy Polyakov wrote: > > Distributed storage documentation. > > Algorithms used in the system, userspace interfaces > (sysfs dirs and files), design and implementation details > are described here. Can you give us a summary of how this differs from us

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-24 Thread Matt Mackall
Simon, can you test this patch? I think it's the most straightforward 2.6.24 fix. diff -r c60016ba6237 net/core/netpoll.c --- a/net/core/netpoll.cTue Nov 13 09:09:36 2007 -0800 +++ b/net/core/netpoll.cFri Nov 23 13:10:28 2007 -0600 @@ -203,6 +203,12 @@ static void refill_skbs(void)

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Matt Mackall
On Fri, Nov 23, 2007 at 10:54:11PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 23, 2007 at 01:41:39PM -0600, Matt Mackall ([EMAIL PROTECTED]) > wrote: > > Here's another thought: move all this logic into the networking core, > > unify it with current softirq zapper, the

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Matt Mackall
On Fri, Nov 23, 2007 at 10:32:22PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 23, 2007 at 01:11:20PM -0600, Matt Mackall ([EMAIL PROTECTED]) > wrote: > > On Fri, Nov 23, 2007 at 09:59:06PM +0300, Evgeniy Polyakov wrote: > > > On Fri, Nov 23, 2007 at 09:51:01PM +0300, Evg

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Matt Mackall
On Fri, Nov 23, 2007 at 10:15:24PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 23, 2007 at 12:59:43PM -0600, Matt Mackall ([EMAIL PROTECTED]) > wrote: > > So I'd be surprised if that was a problem. But I can imagine having > > problems for skbs without destructors which r

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Matt Mackall
On Fri, Nov 23, 2007 at 09:59:06PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 23, 2007 at 09:51:01PM +0300, Evgeniy Polyakov ([EMAIL > PROTECTED]) wrote: > > On Fri, Nov 23, 2007 at 09:48:51PM +0300, Evgeniy Polyakov ([EMAIL > > PROTECTED]) wrote: > > > Stop, we are trying to free skb without d

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Matt Mackall
On Fri, Nov 23, 2007 at 08:57:57PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 23, 2007 at 11:07:56AM -0600, Matt Mackall ([EMAIL PROTECTED]) > wrote: > > On Fri, Nov 23, 2007 at 01:55:19PM +0300, Evgeniy Polyakov wrote: > > > On Fri, Nov 23, 2007 at 12:21:57AM -0800,

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Matt Mackall
On Fri, Nov 23, 2007 at 01:55:19PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 23, 2007 at 12:21:57AM -0800, Andrew Morton ([EMAIL PROTECTED]) > wrote: > > > [2059664.615816] __iptables__: init4 IN=ppp0 OUT=ppp0 WARNING: at > > > kernel/softirq.c:139 local_bh_enable() > > > [2059664.620535] [<8

Re: Netconsole and logging everything from /dev/console

2007-11-16 Thread Matt Mackall
On Fri, Nov 16, 2007 at 06:43:15PM +0100, Martin Michlmayr wrote: > I'm supporting a number of consumer devices (e.g. small NAS devices) > in Debian. They typically don't export the serial console and don't > have any other output devices. We perform the installation via SSH > on such devices and

Re: [patch] net: avoid race between netpoll and network fast path

2007-10-29 Thread Matt Mackall
On Mon, Oct 29, 2007 at 09:26:11PM -0700, David Miller wrote: > From: Tina Yang <[EMAIL PROTECTED]> > Date: Tue, 16 Oct 2007 22:46:30 -0700 > > > The precise race is > > 1) net_rx_action get the dev from poll_list > > 2) at the same time, netpoll poll_napi() get a hold of the poll lock

Re: [RFC] remove netpoll receive code

2007-10-22 Thread Matt Mackall
[annoyed as ever about never being cc:ed on this stuff] On Wed, Oct 17, 2007 at 01:21:31PM -0700, Stephen Hemminger wrote: > The netpoll receive code is: > 1. Not used by any in-tree features, it is used by kgdb-over-ether. And various crashdump over network tools. > 2. A nice hook for people do

Re: netconsole problems

2007-10-04 Thread Matt Mackall
On Thu, Oct 04, 2007 at 10:59:38AM -0700, Tina Yang wrote: > We recently run into a few problems with netconsole > in at least 2.6.9, 2.6.18 and 2.6.23. It either panicked > at netdevice.h:890 or hung the system, and sometimes depending > on which NIC we are using, the following console message, >

Re: 2.6.23-rc8: cannot make netconsole work

2007-09-28 Thread Matt Mackall
On Fri, Sep 28, 2007 at 01:27:55PM +0400, Andrey Borzenkov wrote: > I finally decided to try netconsole in attempt to get some more information > why my system does not resume (but that is different story). But I cannot > make it work - it does load but I see no traffic flowing ever. This is > n

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-02 Thread Matt Mackall
On Thu, Aug 02, 2007 at 11:00:08AM +0200, Jarek Poplawski wrote: > On Wed, Aug 01, 2007 at 09:02:19PM -0500, Matt Mackall wrote: > > On Wed, Aug 01, 2007 at 11:59:21AM +0200, Jarek Poplawski wrote: > > > On Tue, Jul 31, 2007 at 05:05:00PM +0200, Gabriel C wrote: > > &

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-01 Thread Matt Mackall
On Wed, Aug 01, 2007 at 11:59:21AM +0200, Jarek Poplawski wrote: > On Tue, Jul 31, 2007 at 05:05:00PM +0200, Gabriel C wrote: > > Jarek Poplawski wrote: > > > On Tue, Jul 31, 2007 at 12:14:36PM +0200, Gabriel C wrote: > > >> Jarek Poplawski wrote: > > >>> On 28-07-2007 20:42, Gabriel C wrote: > > >

Re: [PATCH v2 (updated) -mm 4/9] netconsole: Add some useful tips to documentation

2007-07-13 Thread Matt Mackall
igh priority > messages only) on the sender. > > Cc: Matt Mackall <[EMAIL PROTECTED]> > Cc: Jesper Juhl <[EMAIL PROTECTED]> > Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> Thanks. Acked-by: Matt Mackall <[EMAIL PROTECTED]> -- Mathematics is the supreme nos

Re: [2.6.23 PATCH 13/18] dm: netlink

2007-07-12 Thread Matt Mackall
On Wed, Jul 11, 2007 at 02:27:12PM -0700, Andrew Morton wrote: > On Wed, 11 Jul 2007 22:01:37 +0100 > Alasdair G Kergon <[EMAIL PROTECTED]> wrote: > > > From: Mike Anderson <[EMAIL PROTECTED]> > > > > This patch adds a dm-netlink skeleton support to the Makefile, and the dm > > directory. > > >

Re: [PATCH v2 -mm 4/9] netconsole: Add some useful tips to documentation

2007-07-10 Thread Matt Mackall
t; Cc: Keiichi Kii <[EMAIL PROTECTED]> Acked-by: Matt Mackall <[EMAIL PROTECTED]> As long as we're on the subject, I've been meaning to add a note telling people to set their console log level to something useful, as having that set too low is the most common problem people e

Re: [PATCH v2 -mm 3/9] netconsole: Simplify boot/module option setup logic

2007-07-10 Thread Matt Mackall
On Tue, Jul 10, 2007 at 02:49:36PM +0530, Satyam Sharma wrote: > From: Satyam Sharma <[EMAIL PROTECTED]> > > [3/9] netconsole: Simplify boot/module option setup logic Acked-by: Matt Mackall <[EMAIL PROTECTED]> -- Mathematics is the supreme nostalgia of our time. - To unsub

Re: [PATCH v2 -mm 2/9] netconsole: Remove bogus check

2007-07-10 Thread Matt Mackall
s loaded. This is because netpoll_setup() grabs > a reference for us on that dev. So let's remove the pointless check. > > Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> > Cc: Keiichi Kii <[EMAIL PROTECTED]> Acked-by: Matt Mackall <[EMAIL PROTECTED]> -- Mathema

Re: [PATCH v2 -mm 1/9] netconsole: Cleanups, codingstyle, prettyfication

2007-07-10 Thread Matt Mackall
ingstyle and prettification stuff. I don't much like what you've done in (3) because I personally think tabs should never appear anywhere but at the beginning of a line. Which is why we consistently ask for people not to mix codingstyle bits with substantive changes. But what the h

Re: [PATCH -mm 6/9] netconsole: Update documentation for multiple target support

2007-07-04 Thread Matt Mackall
On Wed, Jul 04, 2007 at 04:38:09PM +0530, Satyam Sharma wrote: > From: Satyam Sharma <[EMAIL PROTECTED]> > > [6/9] netconsole: Update documentation for multiple target support > > ... and add a few useful general purpose tips as well while we're at it. The tips are fine and should go in their ow

Re: [PATCH -mm 4/9] netconsole: Introduce netconsole_netdev_notifier

2007-07-04 Thread Matt Mackall
On Wed, Jul 04, 2007 at 04:37:59PM +0530, Satyam Sharma wrote: > From: Satyam Sharma <[EMAIL PROTECTED]> > > [4/9] netconsole: Introduce netconsole_netdev_notifier > > To update fields of underlying netpoll structure at runtime on > corresponding NETDEV_CHANGEADDR or NETDEV_CHANGENAME notificatio

Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member

2007-07-04 Thread Matt Mackall
On Wed, Jul 04, 2007 at 04:38:04PM +0530, Satyam Sharma wrote: > From: Satyam Sharma <[EMAIL PROTECTED]> > > [5/9] netconsole: Introduce dev_status member > > Introduce a new member in netconsole_target that tracks the status (up or > down) of the underlying interface network device that the spec

Re: [PATCH -mm 2/9] netconsole: Code simplification

2007-07-04 Thread Matt Mackall
On Wed, Jul 04, 2007 at 04:37:49PM +0530, Satyam Sharma wrote: > From: Satyam Sharma <[EMAIL PROTECTED]> > > [2/9] netconsole: Code simplification > > (1) Extract netpoll_parse_options() out of option_setup(), and into > init_netconsole() itself. So "configured" variable is redundant and > can be

Re: [PATCH 07/12] use a dynamic pool of sk_buffs to keep up with fast targets

2007-07-03 Thread Matt Mackall
On Mon, Jul 02, 2007 at 09:40:36PM -0700, David Miller wrote: > From: Andrew Morton <[EMAIL PROTECTED]> > Date: Mon, 2 Jul 2007 21:36:36 -0700 > > > My initial thought is that if there is a legitimate need for this > > new capability then it should be made available to other parts of > > the kerne

Re: [RFC][PATCH -mm take5 1/7] marking __init

2007-06-13 Thread Matt Mackall
On Wed, Jun 13, 2007 at 07:25:55PM +0900, Keiichi KII wrote: > From: Keiichi KII <[EMAIL PROTECTED]> > > This patch contains the following cleanups. > - add __init for initialization functions(option_setup() and >init_netconsole()). > > Acked-by: Matt Mackall &

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread Matt Mackall
On Wed, May 30, 2007 at 03:29:39PM -0700, David Miller wrote: > From: Matt Mackall <[EMAIL PROTECTED]> > Date: Wed, 30 May 2007 17:10:39 -0500 > > > Are you agreeing that "it seems wasteful to add per-packet overhead"? > > This patch is not doing that. >

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread Matt Mackall
On Wed, May 30, 2007 at 12:55:51PM -0700, David Miller wrote: > From: Patrick McHardy <[EMAIL PROTECTED]> > Date: Wed, 30 May 2007 20:42:32 +0200 > > > Stephen Hemminger wrote: > > >>>Index: linux-2.6.22-rc-mm/net/sched/sch_generic.c > > >>>=

Re: [PATCH repost] netpoll: trapping fix/cleanup

2007-04-28 Thread Matt Mackall
On Sat, Apr 28, 2007 at 04:56:23PM +0400, Sergei Shtylyov wrote: > Hello. > > Matt Mackall wrote: > > >>CONFIG_NETPOLL_TRAP causes the TX queue controls to be completely > >>bypassed in > >>the netpoll's "trapped" mode which easily causes

Re: [PATCH repost] netpoll: trapping fix/cleanup

2007-04-27 Thread Matt Mackall
On Fri, Apr 27, 2007 at 11:44:00PM +0400, Sergei Shtylyov wrote: > CONFIG_NETPOLL_TRAP causes the TX queue controls to be completely bypassed in > the netpoll's "trapped" mode which easily causes overflows in the drivers with > short TX queues (most notably, in 8139too with its 4-deep queue). > Mak

Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-20 Thread Matt Mackall
On Fri, Apr 20, 2007 at 11:15:26AM -0700, Andrew Morton wrote: > On Fri, 20 Apr 2007 18:51:13 +0900 > Keiichi KII <[EMAIL PROTECTED]> wrote: > > > > I started to do some cleanups and fixups here, but abandoned it when it > > > was > > > all getting a bit large. > > > > > > Here are some fixes ag

Re: [BUG] netconsole hangs machine 2.6.20

2007-04-16 Thread Matt Mackall
[cc:ed to netdev] On Sun, Apr 15, 2007 at 10:45:37PM -0700, Mike Mattie wrote: > Hello, > > netconsole is hanging my box during IDE init. > > I am running 2.6.20.7, config is attached from /proc > > Without using netconsole the kernel boots fine. I am writing this message > from it. > > When

Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

2007-03-20 Thread Matt Mackall
On Tue, Mar 20, 2007 at 03:08:19PM -0800, Zachary Amsden wrote: > Matt Mackall wrote: > >I don't know that you need an xchg there. If you're still on the same > >CPU, it should all be nice and causal even across an interrupt handler. > >So it could be: > > >

Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

2007-03-20 Thread Matt Mackall
On Tue, Mar 20, 2007 at 09:31:58AM -0700, Jeremy Fitzhardinge wrote: > Linus Torvalds wrote: > > On Tue, 20 Mar 2007, Eric W. Biederman wrote: > > > >> If that is the case. In the normal kernel what would > >> the "the oops, we got an interrupt code do?" > >> I assume it would leave interrupts

Re: [RFC][PATCH -mm take3 1/6][resend] marking __init

2007-03-20 Thread Matt Mackall
urn 1; > @@ -99,7 +99,7 @@ static int option_setup(char *opt) > > __setup("netconsole=", option_setup); > > -static int init_netconsole(void) > +static int __init init_netconsole(void) > { > int err; This is fine. Acked-by: Matt Mackall <[EMAIL PROTECTED]>

Re: netconsole system freeze when cable unplugged

2007-03-10 Thread Matt Mackall
On Fri, Mar 09, 2007 at 09:42:43PM +0100, Francois Romieu wrote: > Simon Arlott <[EMAIL PROTECTED]> : > > When I unplug the cable the system just stops responding to anything, > > at all. No message is printed to the console when the cable is plugged > > back in. > > rtl8139_interrupt (spin_lock

Re: [RFC: net-2.6.20 patch] remove unused exports

2007-03-07 Thread Matt Mackall
On Wed, Mar 07, 2007 at 11:40:59PM +0100, Adrian Bunk wrote: > This patch removes the following not or no longer used exports: > - drivers/char/random.c: secure_tcp_sequence_number This part looks reasonable. Acked-by: Matt Mackall <[EMAIL PROTECTED]> -- Mathematics is the supreme

Re: [2.6.21 patch] unconditionally enable SYSFS_DEPRECATED

2007-03-05 Thread Matt Mackall
On Mon, Mar 05, 2007 at 08:03:50PM -0800, Greg KH wrote: > On Mon, Mar 05, 2007 at 09:39:47PM -0600, Matt Mackall wrote: > > On Mon, Mar 05, 2007 at 06:48:50PM -0800, Greg KH wrote: > > > If so, can you disable the option and strace it to see what program is > > > trying

Re: [2.6.21 patch] unconditionally enable SYSFS_DEPRECATED

2007-03-05 Thread Matt Mackall
On Mon, Mar 05, 2007 at 06:48:50PM -0800, Greg KH wrote: > If so, can you disable the option and strace it to see what program is > trying to access what? That will put the > HAL/NetworkManager/libsysfs/distro script finger pointing to rest pretty > quickly :) Ok, I've got straces of both good an

Re: [2.6.21 patch] unconditionally enable SYSFS_DEPRECATED

2007-03-05 Thread Matt Mackall
On Mon, Mar 05, 2007 at 06:48:50PM -0800, Greg KH wrote: > Wait, have confirmed that if you enable this config option, > NetworkManager starts back up again and works properly? Yep, probably should have mentioned that. > If so, can you disable the option and strace it to see what program is > t

Re: [2.6.21 patch] unconditionally enable SYSFS_DEPRECATED

2007-03-05 Thread Matt Mackall
On Mon, Mar 05, 2007 at 04:07:22PM -0800, Greg KH wrote: > On Tue, Mar 06, 2007 at 12:40:52AM +0100, Adrian Bunk wrote: > > On Mon, Mar 05, 2007 at 10:58:13AM -0800, Greg KH wrote: > > > > > > Ok, how about the following patch. Is it acceptable to everyone? > > > > > > thanks, > > > > > > greg

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-05 Thread Matt Mackall
On Mon, Mar 05, 2007 at 04:46:09PM +0100, Tomasz Torcz wrote: > > That's not the point. The point is that Debian/unstable as of _this > > morning_ doesn't work. For reference, I'm running both the latest > > releases of both hal (0.5.8.1-6.1) and network-manager (0.6.4-6). And > > there are people

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-05 Thread Matt Mackall
On Mon, Mar 05, 2007 at 10:58:13AM -0800, Greg KH wrote: > Ok, how about the following patch. Is it acceptable to everyone? > > - If you are using a distro that was released in 2006 or later, > - it should be safe to say N here. > + If you are using an OpenSuSE, Gentoo, Ubuntu,

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-04 Thread Matt Mackall
On Sun, Mar 04, 2007 at 11:02:48PM -0800, Greg KH wrote: > On Mon, Mar 05, 2007 at 12:42:29AM -0600, Matt Mackall wrote: > > On Sun, Mar 04, 2007 at 05:16:25PM -0800, Greg KH wrote: > > > On Sun, Mar 04, 2007 at 04:08:57PM -0600, Matt Mackall wrote: > > > > Recent ke

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-04 Thread Matt Mackall
On Sun, Mar 04, 2007 at 05:16:25PM -0800, Greg KH wrote: > On Sun, Mar 04, 2007 at 04:08:57PM -0600, Matt Mackall wrote: > > Recent kernels are having troubles with wireless for me. Two seemingly > > related problems: > > > > a) NetworkManager seems oblivious to the ex

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-04 Thread Matt Mackall
On Mon, Mar 05, 2007 at 12:39:24AM +0100, Johannes Berg wrote: > [adding linux-wireless to CC] > > On Sun, 2007-03-04 at 16:08 -0600, Matt Mackall wrote: > > Recent kernels are having troubles with wireless for me. Two seemingly > > related problems: > > I don't

Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-04 Thread Matt Mackall
Recent kernels are having troubles with wireless for me. Two seemingly related problems: a) NetworkManager seems oblivious to the existence of my IPW2200 b) Manual iwconfig waits for 60s and then reports: Error for wireless request "Set Encode" (8B2A) : SET failed on device eth1 ; Operation n

Re: [RFC][PATCH 2.6.19 take2 1/5] marking __init and remove drop initialization

2006-12-21 Thread Matt Mackall
On Thu, Dec 21, 2006 at 07:03:23PM +0900, Keiichi KII wrote: > - remove "drop" initialization in the netpoll structure. Why? -- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] Mor

Re: [PATCH 0/4] e1000: fixes for 7.1.9-k2

2006-07-14 Thread Matt Mackall
t. Otherwise, looks good. Signed-off-by: Matt Mackall <[EMAIL PROTECTED]> -- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/4] e1000: fixes for 7.1.9-k2

2006-07-14 Thread Matt Mackall
On Fri, Jul 14, 2006 at 04:24:52PM -0700, Kok, Auke wrote: > > Jeff, > > Please pull the following patches from > > git://lost.foo-projects.org/~ahkok/git/netdev-2.6 upstream-fixes-jgarzik > (based on 22e1170310ec6afa41e0dc7ac9dfac735d82dcab) > > To receive the following fixes for e1000: > > [

Re: 2.6.17: networking bug??

2006-06-13 Thread Matt Mackall
On Tue, Jun 13, 2006 at 05:49:21PM -0400, Mark Lord wrote: > > > David Miller wrote: > >.. > >First, you are getting window scaling by default with the older > >kernel too. It's just a smaller window scale, using a shift > >value of say 1 or 2. > > > >What these broken middle boxes do is ignore

Re: [PATCH RFC] netpoll: don't spin forever sending to stopped queues

2006-06-12 Thread Matt Mackall
On Mon, Jun 12, 2006 at 01:57:58PM -0700, Jeremy Fitzhardinge wrote: > Matt Mackall wrote: > >On Thu, Jun 08, 2006 at 07:15:50PM -0700, Jeremy Fitzhardinge wrote: > > > >>Here's a patch. I haven't tested it beyond compiling it, and I don't > >>k

Re: [PATCH] netpoll: break recursive loop in netpoll rx path

2006-06-12 Thread Matt Mackall
On Mon, Jun 12, 2006 at 11:40:29AM -0400, Neil Horman wrote: > Hey there- > the netpoll system currently has a rx to tx path via: > netpoll_rx > __netpoll_rx > arp_reply >netpoll_send_skb > dev->hard_start_tx > > This rx->tx loop places network drivers at risk of > inadverte

Re: [PATCH RFC] netpoll: don't spin forever sending to stopped queues

2006-06-11 Thread Matt Mackall
On Thu, Jun 08, 2006 at 07:15:50PM -0700, Jeremy Fitzhardinge wrote: > Matt Mackall wrote: > >That's odd. Netpoll holds a reference to the device, of course, but so > >does a normal "up" interface. So that shouldn't be the problem. > >Another possibility

Re: Using netconsole for debugging suspend/resume

2006-06-09 Thread Matt Mackall
On Fri, Jun 09, 2006 at 07:50:25AM +0200, Andi Kleen wrote: > On Friday 09 June 2006 07:23, David Miller wrote: > > From: Auke Kok <[EMAIL PROTECTED]> > > Date: Thu, 08 Jun 2006 22:13:48 -0700 > > > > > netconsole should retry. There is no timeout programmed here since that > > > might > > > lose

Re: Using netconsole for debugging suspend/resume

2006-06-08 Thread Matt Mackall
On Thu, Jun 08, 2006 at 10:50:57AM -0700, Jeremy Fitzhardinge wrote: > I've been trying to get suspend/resume working well on my new laptop. > In general, netconsole has been pretty useful for extracting oopses and > other messages, but it is of more limited help in debugging the actual > suspe

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-07 Thread Matt Mackall
27;re now observing. I'll let the e1000 guys comment on the particulars of the driver change. > Signed-off-by: Neil Horman <[EMAIL PROTECTED]> Signed-off-by: Matt Mackall <[EMAIL PROTECTED]> -- Mathematics is the supreme nostalgia of our time. - To unsubscribe fr

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-06 Thread Matt Mackall
On Tue, Jun 06, 2006 at 01:42:59PM -0400, Jeff Moyer wrote: > ==> Regarding Re: [PATCH 1/2] e1000: fix netpoll with NAPI; Auke Kok <[EMAIL > PROTECTED]> adds: > > auke-jan.h.kok> Jeff Moyer wrote: > >> ==> Regarding Re: [PATCH 1/2] e1000: fix netpoll with NAPI; Auke Kok > >> <[EMAIL PROTECTED]>

Re: [2.6 patch] drivers/char/random.c: unexport secure_ipv6_port_ephemeral

2006-04-09 Thread Matt Mackall
On Sun, Apr 09, 2006 at 05:58:22PM +0200, Adrian Bunk wrote: > This patch removes the unused EXPORT_SYMBOL(secure_ipv6_port_ephemeral). > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Matt Mackall <[EMAIL PROTECTED]> Adrian appears to be correct that this doesn&#x

Re: netconsole: no IP address for eth0, aborting

2006-03-14 Thread Matt Mackall
On Tue, Mar 14, 2006 at 09:31:08AM -0800, Randy.Dunlap wrote: > On Mon, 13 Mar 2006 22:29:12 -0600 Matt Mackall wrote: > > > On Sun, Mar 12, 2006 at 04:27:51PM -0800, Randy.Dunlap wrote: > > > > > > hardware: e1000 NIC in ThinkPad T42 > > > kernel: 2

Re: netconsole: no IP address for eth0, aborting

2006-03-14 Thread Matt Mackall
On Sun, Mar 12, 2006 at 04:27:51PM -0800, Randy.Dunlap wrote: > > hardware: e1000 NIC in ThinkPad T42 > kernel: 2.6.16-rc5-mm3 > > I always get $subject message. I changed the delay in > net/core/netpoll.c from 4 seconds to 9 seconds, but it > doesn't matter, the e1000 always finds Link is Up i

Re: [RFC][PATCH 0/3] TCP/IP Critical socket communication mechanism

2005-12-14 Thread Matt Mackall
On Wed, Dec 14, 2005 at 09:23:09PM -0800, David S. Miller wrote: > From: Matt Mackall <[EMAIL PROTECTED]> > Date: Wed, 14 Dec 2005 21:02:50 -0800 > > > There needs to be two rules: > > > > iff global memory critical flag is set > > - allocate from the

Re: [RFC][PATCH 0/3] TCP/IP Critical socket communication mechanism

2005-12-14 Thread Matt Mackall
On Wed, Dec 14, 2005 at 08:30:23PM -0800, David S. Miller wrote: > From: Matt Mackall <[EMAIL PROTECTED]> > Date: Wed, 14 Dec 2005 19:39:37 -0800 > > > I think we need a global receive pool and per-socket send pools. > > Mind telling everyone how you plan to make use o

Re: [RFC][PATCH 0/3] TCP/IP Critical socket communication mechanism

2005-12-14 Thread Matt Mackall
On Wed, Dec 14, 2005 at 09:55:45AM -0800, Sridhar Samudrala wrote: > On Wed, 2005-12-14 at 10:22 +0100, Andi Kleen wrote: > > > I would appreciate any feedback or comments on this approach. > > > > Maybe I'm missing something but wouldn't you need an own critical > > pool (or at least reservation)

Re: Netconsole Patches

2005-11-22 Thread Matt Mackall
On Tue, Nov 22, 2005 at 09:53:08PM +0100, Michael Frank wrote: > Hi Matt, > > I sent 3 patches to you and cc to netdev@vger.kernel.org but > the patches did not show up on netdev. > > Have you received them? No, but I got two copies of this email. -- Mathematics is the supreme nostalgia of ou

Re: [2.6 patch] move some code to net/ipx/af_ipx.c

2005-11-18 Thread Matt Mackall
On Fri, Nov 18, 2005 at 06:22:52AM +0100, Adrian Bunk wrote: > > > > This patch isn't bad, but looking closer we could move the contents of > > p8023.c as well as the contents of at least p8022.c and pe2.c into > > af_ipx.c. > > > > Is the contents of any of these three files expected to be use

Re: [BUG] netpoll is unable to handle skb's using packet split

2005-11-14 Thread Matt Mackall
On Mon, Nov 14, 2005 at 09:41:30PM -0800, David S. Miller wrote: > From: "David S. Miller" <[EMAIL PROTECTED]> > Date: Mon, 14 Nov 2005 21:39:22 -0800 (PST) > > > From: Matt Mackall <[EMAIL PROTECTED]> > > Date: Mon, 14 Nov 2005 21:23:58 -0800 > &

Re: [BUG] netpoll is unable to handle skb's using packet split

2005-11-14 Thread Matt Mackall
On Mon, Nov 14, 2005 at 01:15:38PM -0800, Jeff Kirsher wrote: > When using packet split, netpoll times out when doing a netdump. What is "packet split" in this context? You ought to cc: the netdump people as well, as it's not part of the mainline kernel. -- Mathematics is the supreme nostalgia o

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-07 Thread Matt Mackall
On Wed, Sep 07, 2005 at 12:17:01PM -0700, Ben Greear wrote: > Francois Romieu wrote: > >Stephen Hemminger <[EMAIL PROTECTED]> : > >[...] > > > >>It really sounds like netconsole needs to have a different device hook > >>instead of start_xmit. It also probably doesn't want to have allocate > >>an s

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-07 Thread Matt Mackall
On Wed, Sep 07, 2005 at 11:19:42AM -0700, Stephen Hemminger wrote: > On Wed, 7 Sep 2005 10:19:33 -0700 > Matt Mackall <[EMAIL PROTECTED]> wrote: > > > On Tue, Sep 06, 2005 at 09:02:42PM -0700, Eugene Surovegin wrote: > > > I don't quite understand, you _a

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-07 Thread Matt Mackall
On Wed, Sep 07, 2005 at 07:16:03PM +0200, Patrick McHardy wrote: > Matt Mackall wrote: > > If we move to softirq-only processing, it will not be a serial cable > > replacement. It won't capture the tricky oopses you normally need a > > serial cable for and it won'

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-07 Thread Matt Mackall
On Tue, Sep 06, 2005 at 09:02:42PM -0700, Eugene Surovegin wrote: > I don't quite understand, you _already_ have deferred processing in > netpoll (btw, how good this will work with kgdboe?). Yes, it exists as a last ditch fallback for cases where we can detect deadlock. And it works not at all fo

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-07 Thread Matt Mackall
On Tue, Sep 06, 2005 at 08:42:39PM -0700, David S. Miller wrote: > You'll need to find a way to do netpoll without disabling hw IRQs > during these driver methods. Then netpoll would be universally > usable, as it would even work with drivers which are software tunnels > and which feed packets bac

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Matt Mackall
On Tue, Sep 06, 2005 at 08:37:36PM -0700, Eugene Surovegin wrote: > On Tue, Sep 06, 2005 at 08:22:25PM -0700, Matt Mackall wrote: > > Which would I rather have: > > > > "netconsole never catches my oopses, it's useless." > > > > "netconsol

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Matt Mackall
On Tue, Sep 06, 2005 at 08:19:34PM -0700, David S. Miller wrote: > From: Matt Mackall <[EMAIL PROTECTED]> > Date: Tue, 6 Sep 2005 20:08:10 -0700 > > > Think upon the kgdb-over-ethernet case, please. The kernel hits a > > breakpoint, the kgdb stub stops everyt

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Matt Mackall
On Tue, Sep 06, 2005 at 07:32:38PM -0700, Eugene Surovegin wrote: > On Tue, Sep 06, 2005 at 07:19:21PM -0700, Matt Mackall wrote: > > > or a') make this a per-driver feature (e.g. NETIF_F_NETPOLL_CHALENGED) > > > > > > In this case, even if driver

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Matt Mackall
On Tue, Sep 06, 2005 at 07:37:45PM -0700, David S. Miller wrote: > From: Matt Mackall <[EMAIL PROTECTED]> > Date: Tue, 6 Sep 2005 18:03:38 -0700 > > > Option c) is obviously a big project but maybe we can get from here to > > there. One possible step in that di

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Matt Mackall
On Tue, Sep 06, 2005 at 06:37:40PM -0700, Eugene Surovegin wrote: > On Tue, Sep 06, 2005 at 06:03:38PM -0700, Matt Mackall wrote: > > On Tue, Sep 06, 2005 at 04:01:24PM -0700, David S. Miller wrote: > > > So you cannot call into these drivers with HW interrupts disabled or > &

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Matt Mackall
On Tue, Sep 06, 2005 at 04:01:24PM -0700, David S. Miller wrote: > So you cannot call into these drivers with HW interrupts disabled or > even worse from HW interrupt context. These drivers use locking > strategies which are perfectly legal and work until you add netpoll. And again, I agree. Wha

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Matt Mackall
On Tue, Sep 06, 2005 at 03:42:07PM -0700, David S. Miller wrote: > Mentioning the latency of the serial console, in support of > netpoll's interrupt disabling, is quite a straw man. No, it's exactly to the point: latency is a secondary concern when we're printing an oops or other diagnostic. Other

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Matt Mackall
On Tue, Sep 06, 2005 at 03:36:27PM -0700, David S. Miller wrote: > From: Eugene Surovegin <[EMAIL PROTECTED]> > Date: Tue, 6 Sep 2005 15:04:17 -0700 > > > David, correct me if I'm wrong, but I think there is a major problem > > with current netconsole/netpoll approach. > > You're preaching to the

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Matt Mackall
On Tue, Sep 06, 2005 at 02:47:14PM -0700, David S. Miller wrote: > From: Eugene Surovegin <[EMAIL PROTECTED]> > Date: Tue, 6 Sep 2005 00:40:01 -0700 > > > According to Documentation/networking/netdevices.txt > > dev->hard_start_xmit must be called with interrupts *enabled*. > > > > Unfortunately

Re: [PATCH] netpoll can lock up on low memory.

2005-08-06 Thread Matt Mackall
On Sat, Aug 06, 2005 at 05:57:20AM -0400, Steven Rostedt wrote: > On Sat, 2005-08-06 at 02:46 -0700, David S. Miller wrote: > > Can you guys stop peeing your pants over this, put aside > > your differences, and work on a mutually acceptable fix > > for these bugs? > > > > Much appreciated, thanks

Re: [PATCH] netpoll can lock up on low memory.

2005-08-06 Thread Matt Mackall
On Sat, Aug 06, 2005 at 09:58:27AM +0200, Ingo Molnar wrote: > > btw., the current NR_SKBS 32 in netpoll.c seems quite low, especially > e1000 can have a whole lot more skbs queued at once. Might be more > robust to increase it to 128 or 256? Not sure that the card's queueing really makes a dif

Re: [PATCH] netpoll can lock up on low memory.

2005-08-05 Thread Matt Mackall
On Fri, Aug 05, 2005 at 08:23:55PM -0400, Steven Rostedt wrote: > On Fri, 2005-08-05 at 14:28 -0700, Matt Mackall wrote: > > > > Netpoll generally must assume it won't get a second chance, as it's > > being called by things like oops() and panic() and used by t

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Matt Mackall
On Sat, Aug 06, 2005 at 01:51:22AM +0200, Andi Kleen wrote: > > But why are we in a hurry to dump the backlog on the floor? Why are we > > worrying about the performance of netpoll without the cable plugged in > > at all? We shouldn't be optimizing the data loss case. > > Because a system shouldn'

Re: [PATCH] netpoll can lock up on low memory.

2005-08-05 Thread Matt Mackall
On Fri, Aug 05, 2005 at 11:51:18PM +0200, Andi Kleen wrote: > > > If that was the policy it would be a quite dumb one and make netpoll > > > totally unsuitable for production use. I hope it is not. > > > > Suggest you rip __GFP_NOFAIL out of JBD before complaining about this. > > So you're sugges

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Matt Mackall
On Fri, Aug 05, 2005 at 11:56:50PM +0200, Andi Kleen wrote: > > I still don't like this fix. Yes, you're right, it should eventually > > give up. But here it gives up way too easily - 5 could easily > > translate to 5 microseconds. This is analogous to giving up on serial > > transmit if CTS is dow

Re: [PATCH] netpoll can lock up on low memory.

2005-08-05 Thread Matt Mackall
On Fri, Aug 05, 2005 at 11:26:10PM +0200, Andi Kleen wrote: > On Fri, Aug 05, 2005 at 01:01:57PM -0700, Matt Mackall wrote: > > The netpoll philosophy is to assume that its traffic is an absolute > > priority - it is better to potentially hang trying to deliver a panic > > me

Re: [PATCH] netpoll can lock up on low memory.

2005-08-05 Thread Matt Mackall
On Fri, Aug 05, 2005 at 04:57:00PM -0400, Steven Rostedt wrote: > On Fri, 2005-08-05 at 13:01 -0700, Matt Mackall wrote: > > On Fri, Aug 05, 2005 at 10:36:31AM -0400, Steven Rostedt wrote: > > > Looking at the netpoll routines, I noticed that the find_skb could > > >

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Matt Mackall
On Fri, Aug 05, 2005 at 01:45:55PM +0200, Andi Kleen wrote: > John B?ckstrand <[EMAIL PROTECTED]> writes: > > > I've been trying to hunt down a hard lockup issue with some hardware > > of mine, but I've possibly hit a kernel bug instead. When using > > netconsole on my e1000, if I unplug the cable

Re: [PATCH] netpoll can lock up on low memory.

2005-08-05 Thread Matt Mackall
On Fri, Aug 05, 2005 at 10:36:31AM -0400, Steven Rostedt wrote: > Looking at the netpoll routines, I noticed that the find_skb could > lockup if the memory is low. This is because the allocations are > called with GFP_ATOMIC (since this is in interrupt context) and if > it fails, it will continue t

Re: atheros driver (1/8)

2005-08-04 Thread Matt Mackall
Some initial comments: - you should include a description of each patch in the message - you should use more descriptive subjects, eg [PATCH 1/8] atheros: Kconfig bits -- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: Netconsole Driver

2005-07-29 Thread Matt Mackall
On Fri, Jul 29, 2005 at 12:13:06PM -0500, Paul Vinson wrote: > >> > Are you sure eth1 is an e1000? From e1000_main.c: > >> > > >> > #ifdef CONFIG_NET_POLL_CONTROLLER > >> > netdev->poll_controller = e1000_netpoll; > >> > #endif > >> > > >> > That's been there for 17 months. > >> > >> Yep, i

Re: [2.6 patch] NETCONSOLE must depend on INET

2005-07-27 Thread Matt Mackall
On Wed, Jul 27, 2005 at 01:19:00PM -0700, David S. Miller wrote: > From: Matt Mackall <[EMAIL PROTECTED]> > Date: Tue, 26 Jul 2005 19:36:37 -0700 > > > # HG changeset patch > > # User [EMAIL PROTECTED] > > # Node ID 6cdd6f36d53678a016cf

Re: [2.6 patch] NETCONSOLE must depend on INET

2005-07-26 Thread Matt Mackall
[sch added to cc: as I think he's the effective pktgen maintainer] On Tue, Jul 26, 2005 at 05:03:49PM -0700, David S. Miller wrote: > From: Matt Mackall <[EMAIL PROTECTED]> > Date: Tue, 26 Jul 2005 16:58:24 -0700 > > > On Tue, Jul 26, 2005 at 04:32:02PM -0700, David S

  1   2   >