[PATCH v3 0/4] new ethernet address manipulation checks

ADDR_EQUAL Replace memcmp(foo, bar, ETH_ALEN) with ether_addr_equal*() 2) PREFER_ETH_ZERO_ADDR Replace memset(foo, 0, ETH_ALEN) with eth_zero_addr() 3) PREFER_ETH_BROADCAST_ADDR Replace memset(foo, 0xFF, ETH_ALEN) with eth_broadcast_addr() Mateusz Kulikowski (4): checkpatch: suggest using ether_

[PATCH v3 4/4] checkpatch: Add multi-line handling for PREFER_ETHER_ADDR_COPY

Handle multi-line memcpy() properly. Signed-off-by: Mateusz Kulikowski --- scripts/checkpatch.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c05befe..6311950 100755 --- a/scripts/checkpatch.pl +++ b/scripts

[PATCH v3 2/4] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr()

Suggest using eth_zero_addr() or eth_broadcast_addr() instead of memset(). Signed-off-by: Mateusz Kulikowski --- scripts/checkpatch.pl | 23 +++ 1 file changed, 23 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 0a511b7..263e831 100755 --- a

[PATCH v3 1/4] checkpatch: suggest using ether_addr_equal*()

Check if memcmp() is used to compare ethernet addresses and suggest using ether_addr_equal() or ether_addr_equal_unaligned() Signed-off-by: Mateusz Kulikowski --- scripts/checkpatch.pl | 8 1 file changed, 8 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl

[PATCH v3 3/4] checkpatch: Fix processing of MEMSET issues

Remove 's' modifier to avoid reporting the same warning several times. Signed-off-by: Mateusz Kulikowski --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 263e831..c05befe 100755 ---

Re: [PATCH v2 2/2] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr()

On 22.04.2015 00:27, Joe Perches wrote: > On Tue, 2015-04-21 at 23:44 +0200, Mateusz Kulikowski wrote: >> On 21.04.2015 23:22, Joe Perches wrote: >>> On Tue, 2015-04-21 at 22:57 +0200, Mateusz Kulikowski wrote: >> (...) (...) >> True, True; If you prefer $line and ab

Re: [PATCH v2 2/2] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr()

On 21.04.2015 23:22, Joe Perches wrote: > On Tue, 2015-04-21 at 22:57 +0200, Mateusz Kulikowski wrote: (...) >> >> Perhaps it would be smarter to use (for both patches) $stat instead. >> This applies also to existing checks (like PREFER_ETHER_ADDR_COPY) >> so we can

Re: [PATCH v2 2/2] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr()

Hi Joe, On 20.04.2015 03:13, Joe Perches wrote: > On Mon, 2015-04-20 at 00:16 +0200, Mateusz Kulikowski wrote: >> Suggest using eth_zero_addr() or eth_broadcast_addr() instead of memset(). > > Hi again Mateusz > >> diff --git a/scripts/checkpatch.pl b/scripts/checkpat

Re: [PATCH] etherdevice: Add ether_addr_copy_unaligned

On 20.04.2015 20:19, David Miller wrote: (...) > I'd rather see something like this submitted in a patch series alongside > some actual uses. > > So I'm tossing this for now. > Ok; I'll add it to a series where I need it (rtl8192e) Regards, Mateusz -- To unsubscribe from this list: send the lin

[PATCH v2 1/2] checkpatch: suggest using ether_addr_equal*()

Check if memcmp() is used to compare ethernet addresses and suggest using ether_addr_equal() or ether_addr_equal_unaligned() Signed-off-by: Mateusz Kulikowski --- scripts/checkpatch.pl | 7 +++ 1 file changed, 7 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index

[PATCH v2 0/2] checkpatch: new ethernet address manipulation checks

) with ether_addr_equal*() 2) PREFER_ETH_ZERO_ADDR Replace memset(foo, 0, ETH_ALEN) with eth_zero_addr() 3) PREFER_ETH_BROADCAST_ADDR Replace memset(foo, 0xFF, ETH_ALEN) with eth_broadcast_addr() Mateusz Kulikowski (2): checkpatch: suggest using ether_addr_equal*() checkpatch: suggest using

[PATCH v2 2/2] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr()

Suggest using eth_zero_addr() or eth_broadcast_addr() instead of memset(). Signed-off-by: Mateusz Kulikowski --- scripts/checkpatch.pl | 16 1 file changed, 16 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index b9ea436..aee6d43 100755 --- a/scripts

Re: [PATCH 2/2] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr()

Hi Joe, On 19.04.2015 22:20, Joe Perches wrote: (...) >> +# check for memset(foo, 0xFF, ETH_ALEN) that could be eth_broadcast_addr >> +if ($^V && $^V ge 5.10.0 && >> +$line =~ >> /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/s) { > > Plea

[PATCH] etherdevice: Add ether_addr_copy_unaligned

Some drivers require copying unaligned ethernet addresses. Using memcpy() causes checkpatch warnings and may cause regressions (someone will "fix" alignment of packed structure) Signed-off-by: Mateusz Kulikowski --- include/linux/etherdevice.h | 16 1 file c

[PATCH 0/2] checkpatch: new ethernet address manipulation checks

() Mateusz Kulikowski (2): checkpatch: suggest using ether_addr_equal*() checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr() scripts/checkpatch.pl | 23 +++ 1 file changed, 23 insertions(+) -- 1.8.4.1 -- To unsubscribe from this list: send the line "unsubs

[PATCH 2/2] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr()

Suggest using eth_zero_addr() or eth_broadcast_addr() if memset is used instead. Signed-off-by: Mateusz Kulikowski --- scripts/checkpatch.pl | 16 1 file changed, 16 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3a1a01e..1fc0819 100755 --- a

[PATCH 1/2] checkpatch: suggest using ether_addr_equal*()

Check if memcmp() is used to compare ethernet addresses and suggest using ether_addr_equal() or ether_addr_equal_unaligned() Signed-off-by: Mateusz Kulikowski --- scripts/checkpatch.pl | 7 +++ 1 file changed, 7 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index