Re: [PATCH net] bareudp: Disallow udp port 0.

2020-07-30 Thread Martin Varghese
On Thu, Jul 30, 2020 at 04:20:30PM -0700, Jakub Kicinski wrote: > On Thu, 30 Jul 2020 22:33:51 +0530 Martin Varghese wrote: > > From: Martin Varghese > > > > Kernel does not support udp destination port 0 on wire. Hence > > bareudp device with udp destinatio

[PATCH net] bareudp: Disallow udp port 0.

2020-07-30 Thread Martin Varghese
From: Martin Varghese Kernel does not support udp destination port 0 on wire. Hence bareudp device with udp destination port 0 must be disallowed. Fixes: 571912c69f0e ("net: UDP tunnel encapsulation module for tunnelling different protocols like MPLS, IP, NSH etc.") Signed-off-

[PATCH net] Documentation: bareudp: Corrected description of bareudp module.

2020-07-28 Thread Martin Varghese
From: Martin Varghese Removed redundant words. Fixes: 571912c69f0e ("net: UDP tunnel encapsulation module for tunnelling different protocols like MPLS, IP, NSH etc.") Signed-off-by: Martin Varghese --- Documentation/networking/bareudp.rst | 5 ++--- 1 file changed, 2 insert

[PATCH net-next] net: Removed the device type check to add mpls support for devices

2020-07-27 Thread Martin Varghese
From: Martin Varghese MPLS has no dependency with the device type of underlying devices. Hence the device type check to add mpls support for devices can be avoided. Signed-off-by: Martin Varghese --- net/mpls/af_mpls.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions

[PATCH net-next] net: Enabled MPLS support for devices of type ARPHRD_NONE.

2020-07-22 Thread Martin Varghese
From: Martin Varghese This change enables forwarding of MPLS packets from bareudp tunnel device which is of type ARPHRD_NONE. Signed-off-by: Martin Varghese --- net/mpls/af_mpls.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c

[PATCH net-next v3] bareudp: Reverted support to enable & disable rx metadata collection

2020-07-16 Thread Martin Varghese
From: Martin Varghese The commit fe80536acf83 ("bareudp: Added attribute to enable & disable rx metadata collection") breaks the the original(5.7) default behavior of bareudp module to collect RX metadadata at the receive. It was added to avoid the crash at the kernel neighbour

[PATCH net-next v2] bareudp: Reverted support to enable & disable rx metadata collection

2020-07-16 Thread Martin Varghese
From: Martin Varghese The commit fe80536acf83 ("bareudp: Added attribute to enable & disable rx metadata collection") breaks the the original(5.7) default behavior of bareudp module to collect RX metadadata at the receive. It was added to avoid the crash at the kernel neighbour

Re: [PATCH net-next] bareudp: Reverted support to enable & disable rx metadata collection

2020-07-15 Thread Martin Varghese
On Wed, Jul 15, 2020 at 01:43:47PM -0700, Jakub Kicinski wrote: > On Wed, 15 Jul 2020 08:42:40 +0530 Martin Varghese wrote: > > From: Martin Varghese > > > > The commit fe80536acf83 ("bareudp: Added attribute to enable & disable > > rx metadata collection&qu

[PATCH net-next] bareudp: Reverted support to enable & disable rx metadata collection

2020-07-14 Thread Martin Varghese
From: Martin Varghese The commit fe80536acf83 ("bareudp: Added attribute to enable & disable rx metadata collection") breaks the the original(5.7) default behavior of bareudp module to collect RX metadadata at the receive. It was added to avoid the crash at the kernel neighbour

[PATCH net] net: Added pointer check for dst->ops->neigh_lookup in dst_neigh_lookup_skb

2020-07-05 Thread Martin Varghese
From: Martin Varghese The packets from tunnel devices (eg bareudp) may have only metadata in the dst pointer of skb. Hence a pointer check of neigh_lookup is needed in dst_neigh_lookup_skb Kernel crashes when packets from bareudp device is processed in the kernel neighbour subsytem

Re: [PATCH iproute2] ip link: initial support for bareudp devices

2020-07-02 Thread Martin Varghese
On Thu, Jul 02, 2020 at 07:32:31PM +0200, Guillaume Nault wrote: > On Thu, Jul 02, 2020 at 10:41:03PM +0530, Martin Varghese wrote: > > On Thu, Jul 02, 2020 at 07:03:53PM +0200, Guillaume Nault wrote: > > > On Thu, Jul 02, 2020 at 09:32:21PM +0530, Martin Varghese wrote: >

Re: [PATCH iproute2] ip link: initial support for bareudp devicesy

2020-07-02 Thread Martin Varghese
On Thu, Jul 02, 2020 at 11:57:46AM +0200, Guillaume Nault wrote: > On Thu, Jul 02, 2020 at 02:45:39PM +0530, Martin Varghese wrote: > > On Wed, Jul 01, 2020 at 09:45:04PM +0200, Guillaume Nault wrote: > > > + } else if (matches(*argv, "ethertype") == 0) { >

Re: [PATCH iproute2] ip link: initial support for bareudp devices

2020-07-02 Thread Martin Varghese
On Thu, Jul 02, 2020 at 07:03:53PM +0200, Guillaume Nault wrote: > On Thu, Jul 02, 2020 at 09:32:21PM +0530, Martin Varghese wrote: > > On Wed, Jul 01, 2020 at 09:45:04PM +0200, Guillaume Nault wrote: > > > > I couldnt apply the patch to master.Could you please confirm if i

Re: [PATCH iproute2] ip link: initial support for bareudp devices

2020-07-02 Thread Martin Varghese
On Wed, Jul 01, 2020 at 09:45:04PM +0200, Guillaume Nault wrote: > Bareudp devices provide a generic L3 encapsulation for tunnelling > different protocols like MPLS, IP, NSH, etc. inside a UDP tunnel. > > This patch is based on original work from Martin Varghese: > https://lore.ke

Re: [PATCH iproute2] ip link: initial support for bareudp devicesy

2020-07-02 Thread Martin Varghese
On Wed, Jul 01, 2020 at 09:45:04PM +0200, Guillaume Nault wrote: > Bareudp devices provide a generic L3 encapsulation for tunnelling > different protocols like MPLS, IP, NSH, etc. inside a UDP tunnel. > > This patch is based on original work from Martin Varghese: > https://lore.ke

[PATCH net-next] bareudp: Added attribute to enable & disable rx metadata collection

2020-06-28 Thread Martin Varghese
From: Martin Metadata need not be collected in receive if the packet from bareudp device is not targeted to openvswitch. Signed-off-by: Martin --- Documentation/networking/bareudp.rst | 6 -- drivers/net/bareudp.c| 23 +-- include/net/bareudp.h

Re: [PATCH net v2] bareudp: Fixed multiproto mode configuration

2020-06-17 Thread Martin Varghese
On Wed, Jun 17, 2020 at 09:21:37AM -0700, Jakub Kicinski wrote: > On Wed, 17 Jun 2020 10:01:39 +0530 Martin Varghese wrote: > > From: Martin > > > > Code to handle multiproto configuration is missing. > > > > Signed-off-by: Martin > > No Fixes tag on

[PATCH net v3] bareudp: Fixed multiproto mode configuration

2020-06-17 Thread Martin Varghese
From: Martin Code to handle multiproto configuration is missing. Fixes: 4b5f67232d95 ("net: Special handling for IP & MPLS") Signed-off-by: Martin --- Changes in v2: - Initialization of conf structure is removed as that change is included in another patch. Changes in v3: - Fix

[PATCH net v2] bareudp: Fixed multiproto mode configuration

2020-06-16 Thread Martin Varghese
From: Martin Code to handle multiproto configuration is missing. Signed-off-by: Martin --- Changes in v2: - Initialization of conf structure is removed as that change is included in another patch. drivers/net/bareudp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers

[PATCH net] bareudp: Fixed configuration to avoid having garbage values

2020-06-15 Thread Martin Varghese
From: Martin Code to initialize the conf structure while gathering the configuration of the device was missing. Fixes: 571912c69f0e ("net: UDP tunnel encapsulation module for tunnelling different protocols like MPLS, IP, NSH etc.") Signed-off-by: Martin --- drivers/net/bareudp.c | 2 ++ 1 fil

[PATCH net] bareudp: Fixed multiproto mode configuration

2020-06-14 Thread Martin Varghese
From: Martin Code to handle multiproto configuration is missing. Fixes: 4b5f67232d95 ("net: Special handling for IP & MPLS") Signed-off-by: Martin --- drivers/net/bareudp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/bareudp.c b/drivers/net/bareudp.c index efd1a1d..3dd

Re: [PATCH v2] Change in Openvswitch to support MPLS label depth of 3 in ingress direction

2019-10-22 Thread Martin Varghese
On Tue, Oct 22, 2019 at 08:59:46PM -0700, Pravin Shelar wrote: > On Tue, Oct 22, 2019 at 8:29 AM Martin Varghese > wrote: > > > > On Tue, Oct 22, 2019 at 12:03:49AM -0700, Pravin Shelar wrote: > > > On Sun, Oct 20, 2019 at 7:12 AM Martin Varghese > > >

Re: [PATCH net-next 1/2] UDP tunnel encapsulation module for tunnelling different protocols like MPLS,IP,NSH etc.

2019-10-22 Thread Martin Varghese
On Fri, Oct 18, 2019 at 10:59:47AM -0400, Willem de Bruijn wrote: > On Fri, Oct 18, 2019 at 4:20 AM Martin Varghese > wrote: > > > > On Thu, Oct 17, 2019 at 04:48:26PM -0400, Willem de Bruijn wrote: > > > On Thu, Oct 17, 2019 at 9:20 AM Martin Varghese > > > w

Re: [PATCH v2] Change in Openvswitch to support MPLS label depth of 3 in ingress direction

2019-10-22 Thread Martin Varghese
On Tue, Oct 22, 2019 at 12:03:49AM -0700, Pravin Shelar wrote: > On Sun, Oct 20, 2019 at 7:12 AM Martin Varghese > wrote: > > > > From: Martin Varghese > > > > The openvswitch was supporting a MPLS label depth of 1 in the ingress > > direction though the use

Re: [PATCH v2] Change in Openvswitch to support MPLS label depth of 3 in ingress direction

2019-10-22 Thread Martin Varghese
On Tue, Oct 22, 2019 at 12:03:49AM -0700, Pravin Shelar wrote: > On Sun, Oct 20, 2019 at 7:12 AM Martin Varghese > wrote: > > > > From: Martin Varghese > > > > The openvswitch was supporting a MPLS label depth of 1 in the ingress > > direction though the use

Re: [ovs-dev] [PATCH] Change in openvswitch kernel module to support MPLS label depth of 3 in ingress direction.

2019-10-20 Thread Martin Varghese
On Sun, Oct 20, 2019 at 12:07:06PM -0700, Ben Pfaff wrote: > On Sun, Oct 20, 2019 at 07:55:32PM +0530, Martin Varghese wrote: > > From: Martin Varghese > > > > The openvswitch kernel module was supporting a MPLS label depth of 1 > > in the ingress direction though t

[PATCH] Change in openvswitch kernel module to support MPLS label depth of 3 in ingress direction.

2019-10-20 Thread Martin Varghese
From: Martin Varghese The openvswitch kernel module was supporting a MPLS label depth of 1 in the ingress direction though the userspace OVS supports a max depth of 3 labels. This change enables openvswitch module to support a max depth of 3 labels in the ingress. Signed-off-by: Martin Varghese

[PATCH v2] Change in Openvswitch to support MPLS label depth of 3 in ingress direction

2019-10-20 Thread Martin Varghese
From: Martin Varghese The openvswitch was supporting a MPLS label depth of 1 in the ingress direction though the userspace OVS supports a max depth of 3 labels. This change enables openvswitch module to support a max depth of 3 labels in the ingress. Signed-off-by: Martin Varghese --- Changes

Re: [PATCH net-next 1/2] UDP tunnel encapsulation module for tunnelling different protocols like MPLS,IP,NSH etc.

2019-10-18 Thread Martin Varghese
On Thu, Oct 17, 2019 at 04:48:26PM -0400, Willem de Bruijn wrote: > On Thu, Oct 17, 2019 at 9:20 AM Martin Varghese > wrote: > > > > On Tue, Oct 08, 2019 at 12:28:23PM -0400, Willem de Bruijn wrote: > > > On Tue, Oct 8, 2019 at 5:51 AM Martin Varghese > > >

Re: [PATCH net-next 1/2] UDP tunnel encapsulation module for tunnelling different protocols like MPLS,IP,NSH etc.

2019-10-17 Thread Martin Varghese
On Tue, Oct 08, 2019 at 12:28:23PM -0400, Willem de Bruijn wrote: > On Tue, Oct 8, 2019 at 5:51 AM Martin Varghese > wrote: > > > > From: Martin > > > > The Bareudp tunnel module provides a generic L3 encapsulation > > tunnelling module for tunnelling diffe

Re: [PATCH net-next] Change in Openvswitch to support MPLS label depth of 3 in ingress direction

2019-10-15 Thread Martin Varghese
On Tue, Oct 15, 2019 at 12:03:35AM -0700, Pravin Shelar wrote: > On Mon, Oct 14, 2019 at 9:06 AM Martin Varghese > wrote: > > > > On Sat, Oct 12, 2019 at 01:08:26PM -0700, Pravin Shelar wrote: > > > On Wed, Oct 9, 2019 at 9:31 PM Martin Varghese > > > wrote:

Re: [PATCH net-next] Change in Openvswitch to support MPLS label depth of 3 in ingress direction

2019-10-14 Thread Martin Varghese
On Sat, Oct 12, 2019 at 01:08:26PM -0700, Pravin Shelar wrote: > On Wed, Oct 9, 2019 at 9:31 PM Martin Varghese > wrote: > > > > On Wed, Oct 09, 2019 at 08:29:51AM -0700, Pravin Shelar wrote: > > > On Mon, Oct 7, 2019 at 9:41 PM Martin Varghese > > > wrote: &

Re: [PATCH net-next] Change in Openvswitch to support MPLS label depth of 3 in ingress direction

2019-10-10 Thread Martin Varghese
On Wed, Oct 09, 2019 at 08:29:51AM -0700, Pravin Shelar wrote: > On Mon, Oct 7, 2019 at 9:41 PM Martin Varghese > wrote: > > > > From: Martin Varghese > > > > The openvswitch was supporting a MPLS label depth of 1 in the ingress > > direction though the use

Re: [PATCH net-next] Change in Openvswitch to support MPLS label depth of 3 in ingress direction

2019-10-09 Thread Martin Varghese
On Wed, Oct 09, 2019 at 08:29:51AM -0700, Pravin Shelar wrote: > On Mon, Oct 7, 2019 at 9:41 PM Martin Varghese > wrote: > > > > From: Martin Varghese > > > > The openvswitch was supporting a MPLS label depth of 1 in the ingress > > direction though the use

Re: [PATCH net-next 2/2] Special handling for IP & MPLS.

2019-10-09 Thread Martin Varghese
On Tue, Oct 08, 2019 at 12:09:49PM -0400, Willem de Bruijn wrote: > On Tue, Oct 8, 2019 at 5:52 AM Martin Varghese > wrote: > > > > From: Martin > > > > This commit would need a commit message. > > > Signed-off-by: Martin Varghese

Re: [PATCH net-next 1/2] UDP tunnel encapsulation module for tunnelling different protocols like MPLS,IP,NSH etc.

2019-10-09 Thread Martin Varghese
On Tue, Oct 08, 2019 at 12:28:23PM -0400, Willem de Bruijn wrote: > On Tue, Oct 8, 2019 at 5:51 AM Martin Varghese > wrote: > > > > From: Martin > > > > The Bareudp tunnel module provides a generic L3 encapsulation > > tunnelling module for tunnelling diffe

[PATCH iproute2] Bareudp device support

2019-10-08 Thread Martin Varghese
From: Martin The Bareudp device provides a generic L3 encapsulation for tunnelling different protocols like MPLS,IP,NSH, etc. inside a UDP tunnel. Signed-off-by: Martin Varghese --- include/uapi/linux/if_link.h | 12 ip/Makefile | 2 +- ip/iplink_bareudp.c

[PATCH net-next] Selftests for bareudp module

2019-10-08 Thread Martin Varghese
Signed-off-by: Martin Varghese --- tools/testing/selftests/net/test_bareudp.sh | 221 1 file changed, 221 insertions(+) create mode 100755 tools/testing/selftests/net/test_bareudp.sh diff --git a/tools/testing/selftests/net/test_bareudp.sh b/tools/testing

[PATCH net-next 2/2] Special handling for IP & MPLS.

2019-10-08 Thread Martin Varghese
From: Martin Signed-off-by: Martin Varghese Signed-off-by: Martin Varghese --- Documentation/networking/bareudp.txt | 18 drivers/net/bareudp.c| 82 +--- include/net/bareudp.h| 1 + include/uapi/linux/if_link.h

[PATCH net-next 1/2] UDP tunnel encapsulation module for tunnelling different protocols like MPLS,IP,NSH etc.

2019-10-08 Thread Martin Varghese
From: Martin The Bareudp tunnel module provides a generic L3 encapsulation tunnelling module for tunnelling different protocols like MPLS, IP,NSH etc inside a UDP tunnel. Signed-off-by: Martin Varghese --- Documentation/networking/bareudp.txt | 23 + drivers/net/Kconfig

[PATCH net-next 0/2] Bareudp Tunnel Module

2019-10-08 Thread Martin Varghese
There are various L3 encapsulation standards using UDP being discussed to leverage the UDP based load balancing capability of different networks. MPLSoUDP (https://tools.ietf.org/html/rfc7510)is one among them. The Bareudp tunnel module provides a generic L3 encapsulation tunnelling support for tu

[PATCH net-next] Change in Openvswitch to support MPLS label depth of 3 in ingress direction

2019-10-07 Thread Martin Varghese
From: Martin Varghese The openvswitch was supporting a MPLS label depth of 1 in the ingress direction though the userspace OVS supports a max depth of 3 labels. This change enables openvswitch module to support a max depth of 3 labels in the ingress. Signed-off-by: Martin Varghese --- net