Re: [PATH bpf-next 09/13] s390: bpf: implement jitting of JMP32

2018-12-19 Thread Martin Schwidefsky
On Wed, 19 Dec 2018 17:44:16 -0500 Jiong Wang wrote: > This patch implements code-gen for new JMP32 instructions on s390. > > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Signed-off-by: Jiong Wang > --- > arch/s390/net/bpf_jit_comp.c | 12 > 1 file cha

Re: [PATCH net-next 3/4] s390/diag: add diag26c support

2017-06-21 Thread Martin Schwidefsky
Hi Dave, On Mon, 19 Jun 2017 13:37:43 -0400 (EDT) David Miller wrote: > From: Martin Schwidefsky > Date: Mon, 19 Jun 2017 17:34:25 +0200 > > > We (as in the s390 guys) tend to add __packed to hardware and hypervisor > > structures even if the attribute is not strictly n

Re: [PATCH net-next 3/4] s390/diag: add diag26c support

2017-06-19 Thread Martin Schwidefsky
Hi Dave, On Mon, 19 Jun 2017 10:47:26 -0400 (EDT) David Miller wrote: > From: Julian Wiedmann > Date: Mon, 19 Jun 2017 13:22:24 +0200 > > > +#define DIAG26C_GET_MAC0x > > +struct diag26c_mac_req { > > + u32 resp_buf_len; > > + u32 resp_version; > > + u16 op_code; > >

Re: 2.6.23-mm1 s390 driver problem

2007-10-19 Thread Martin Schwidefsky
On Fri, 2007-10-19 at 13:17 +0200, Cedric Le Goater wrote: > > please cc netdev on network issues. > > yes. > > >> Bringing up interface eth0: Ý cut here ¨ > >> Kernel BUG at 0002 Ýverbose debug info unavailable¨ > >> illegal operation: 0001 Ý#1¨ > > > >

Re: s390x: getting ipv6 bugs on mainline since 2.6.23-git3

2007-10-18 Thread Martin Schwidefsky
On Thu, 2007-10-18 at 11:43 +0200, Patrick McHardy wrote: > Andy Whitcroft wrote: > > Seems we are getting some kind of bug out of our s390x partition (lnxabat1) > > when booting latest mainline releases, specifically since 2.6.23-git3. > > > > Kernel BUG at 0002 Ýverbose debug info u

Re: [PATCH] make atomic_t volatile on all architectures

2007-08-12 Thread Martin Schwidefsky
On Sat, 2007-08-11 at 23:09 -0700, Linus Torvalds wrote: > Segher, how about you just accept that Linux uses gcc as per reality, and > that sometimes the reality is different from your expectations? > > "+m" works. We use it. It's better than the alternatives. Pointing to > stale documentation

Re: [PATCH] make atomic_t volatile on all architectures

2007-08-12 Thread Martin Schwidefsky
On Sun, 2007-08-12 at 07:53 +0200, Segher Boessenkool wrote: > > Yes, though I would use "=m" on the output list and "m" on the input > > list. The reason is that I've seen gcc fall on its face with an ICE on > > s390 due to "+m". The explanation I've got from our compiler people was > > quite esot

Re: [PATCH] make atomic_t volatile on all architectures

2007-08-09 Thread Martin Schwidefsky
On Thu, 2007-08-09 at 10:55 -0700, Linus Torvalds wrote: > > You can use this forget() macro to make the compiler reread a variable: > > > > #define forget(var) asm volatile ("" : "=m"(var)) > > No. That will also make the compiler "forget" any previous writes to it, > so it changes behaviour. >

Re: [PATCH] make atomic_t volatile on all architectures

2007-08-09 Thread Martin Schwidefsky
On Thu, 2007-08-09 at 13:36 -0400, Chuck Ebbert wrote: > > Fair enough. Casting to (volatile int *) will give us the behavior > > people expect when using atomic_t without needing to use inefficient > > barriers. > > > > You can use this forget() macro to make the compiler reread a > variable: >

Re: [PATCH 16/24] make atomic_read() behave consistently on s390

2007-08-09 Thread Martin Schwidefsky
On Thu, 2007-08-09 at 10:06 -0400, Chris Snook wrote: > From: Chris Snook <[EMAIL PROTECTED]> > > Make atomic[64]_read() volatile on s390, to ensure memory is actually read > each time. > > Signed-off-by: Chris Snook <[EMAIL PROTECTED]> Acked-by: Martin Schwidefsky

Re: [patch] ipvs: force read of atomic_t in while loop

2007-08-09 Thread Martin Schwidefsky
On Thu, 2007-08-09 at 08:40 -0400, Chris Snook wrote: > > #define reload_var(x) __asm__ __volatile__ (whatever, x) > > > > I don't know inline assembly that much, but isn't it possible > > with that to kind of "fake-touch" the variable, so the compiler > > must reload it (and only it) to make sure

Re: link error : 2.6.21-rc6-mm1 for s390

2007-04-11 Thread Martin Schwidefsky
On 4/11/07, Andrew Morton <[EMAIL PROTECTED]> wrote: On Tue, 10 Apr 2007 22:11:01 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: I think this means that if CONFIG_32BIT=y, s390 networking gets the whizzy assembly version and if CONFIG_32BIT=n, it gets to use the generic version. Possibly th

Re: s390 allmodconfig

2007-03-02 Thread Martin Schwidefsky
standard drivers/Kconfig. The downside of these patches is that I have to add a lot of "depends on !S390" all over the place. > > OK, I'll try that, thanks. > > Not that it'll actually help get the compile through... bcm43xx will > drop fail and bluetooth probably

Re: [PATCH 0/59] Cleanup sysctl

2007-01-17 Thread Martin Schwidefsky
Kernels boots and the system controls are still working. I had to add an #include to ipc/ipc_sysctl.c to get the kernel compiled. That include should be added to patch #51. Acked-by: Martin Schwidefsky <[EMAIL PROTECTED]> for: [PATCH 33/59] sysctl: s390 move sysctl definitions to sysctl.h

Re: [patch 1/6] s390: minor claw driver fix

2006-03-22 Thread Martin Schwidefsky
On 3/22/06, Frank Pavlic <[EMAIL PROTECTED]> wrote: > [patch 1/6] s390: minor claw driver fix > > From: Frank Pavlic <[EMAIL PROTECTED]> > > use CONFIG_ARCH_S390X instead of CONFIG_64BIT in function dumpit . Nack. CONFIG_ARCH_S390X doesn't exists anymore. It has been replaced by CONFIG_64B