Re: Top 9 kernel oopses/warnings for the week of December 29th, 2007

2007-12-29 Thread Martin Josefsson
On Sat, 29 Dec 2007, Linus Torvalds wrote: Ahh, it seems to be a alpine bug. Probably brought on by alpine trying to highlight the web addresses. It doesn't always happen - between Rank 3 and Rank 4, you have an empty line, and alpine reacted correctly to that one, but the "empty" line between

Re: [RFT] sky2: receive hang check

2007-09-17 Thread Martin Josefsson
On Wed, 12 Sep 2007, Stephen Hemminger wrote: -/* Check for lost IRQ once a second */ +static void sky2_rx_check(struct net_device *dev) +{ + struct sky2_port *sky2 = netdev_priv(dev); + struct sky2_hw *hw = sky2->hw; + unsigned port = sky2->port; + unsigned rxq = rxqaddr

Re: [patch 11/11] netfilter warning fix

2007-02-06 Thread Martin Josefsson
On Mon, 5 Feb 2007, David Miller wrote: > Let's audit NF_CT_STAT_INC() usage to make sure :-) > > net/netfilter/nf_conntrack_core.c: > > destroy_conntrack: Inside write_{lock,unlock}_bh(). > death_by_timeout: Ditto. > __nf_conntrack_find: Inside read_{lock,unlock}_bh() via caller

Re: gratuitous arp

2006-11-25 Thread Martin Josefsson
On Sat, 2006-11-25 at 18:31 -0800, dean gaudet wrote: > but there's no gratuitous arp for any eth0:N aliased interfaces... and the > cisco ARP cache on this ISP router seems to be set to a long timeout. i > could reach eth0:N from local net, but couldn't get outside local net from > eth0:N. C

Re: [PATCH 4/6] net neighbour: convert to RCU

2006-08-29 Thread Martin Josefsson
On Tue, 2006-08-29 at 11:22 -0700, Stephen Hemminger wrote: > > Probably, you should do atomic_inc_and_test() here and restart lookup, > > if it fails. > > > > Alexey > > atomic_inc_and_test is true iff result is zero, so that won't work. Wouldn't atomic_inc_not_zero() do what you want? -- /M

Re: [RESEND 3/5] [NET]: Protocol Independant Policy Routing Rules Framework

2006-07-29 Thread Martin Josefsson
On Sat, 2006-07-29 at 03:40 +0200, Patrick McHardy wrote: > Martin Josefsson wrote: > > As a somewhat related note, I've just digged a bit through RCU land, > > talked to dipankar and mckenney, and discovered that rcu_read_lock() / > > rcu_read_unlock() aren't st

Re: [RESEND 3/5] [NET]: Protocol Independant Policy Routing Rules Framework

2006-07-28 Thread Martin Josefsson
On Fri, 2006-07-28 at 00:58 +0200, Patrick McHardy wrote: > > +int fib_rules_lookup(struct fib_rules_ops *ops, struct flowi *fl, > > +int flags, struct fib_lookup_arg *arg) > > +{ > > + struct fib_rule *rule; > > + int err; > > + > > + rcu_read_lock(); > > + > > + list_for_

Re: [PATCH] ip multicast route bug fix

2006-07-24 Thread Martin Josefsson
On Wed, 2006-07-19 at 14:57 -0700, Stephen Hemminger wrote: > This should fix the problem reported in > http://bugzilla.kernel.org/show_bug.cgi?id=6186 > where the skb is used after freed. The code in IP multicast route. > > Code was reusing an skb which could lead to use after free or double fre

Re: [PATCH] e1000: supply interface speed / duplex when no link-beat

2005-11-21 Thread Martin Josefsson
On Mon, 2005-11-21 at 10:12 -0800, Jesse Brandeburg wrote: > Hi, thanks for the input. I have a couple of questions. Hi Jesse > Why do you need this? Basically this was a design decision in our > driver to not report link when we haven't had a chance to initialize > it (when the interface is b

[PATCH] e1000: supply interface speed / duplex when no link-beat

2005-11-18 Thread Martin Josefsson
Currently the e1000 driver only supplies the active link speed / duplex when a link-beat is present to ethtool. This patch adds support for supplying the configured speed / duplex when auto-negotiation is disabled and no link-beat is present. Signed-off-by: Martin Josefsson <[EMAIL PROTEC

Re: [E1000-devel] Page Allocation Failure with e1000 using jumbo frame

2005-08-19 Thread Martin Josefsson
On Fri, 2005-08-19 at 19:02 +0200, Andi Kleen wrote: > > I guess we need to approach the memory manager guys and ask them why the > > current kernels are having so much trouble getting contiguous memory. > > Because memory fragments. > > The only long term reliable way is to not allocate buffer

Re: [RFC] Net vm deadlock fix (preliminary)

2005-08-03 Thread Martin Josefsson
On Thu, 2005-08-04 at 03:36 +1000, Daniel Phillips wrote: > I can think of two ways to deal with this: > > 1) Mindlessly include the entire maximum memory usage of the rx-ring in > the reserve requirement (e.g., (maxskbs * (MTU + k)) / PAGE_SIZE). Would be dependent on the numberof interf

Re: [RFC] Net vm deadlock fix (preliminary)

2005-08-03 Thread Martin Josefsson
On Wed, 3 Aug 2005, Daniel Phillips wrote: > Hi, > > Here is a preliminary patch, not tested at all, just to give everybody a > target to aim bricks at. > > * A new __GFP_MEMALLOC flag gives access to the memalloc reserve. > > * In dev_alloc_skb, if GFP_ATOMIC fails then try again with __GFP_M