Re: [PATCH net-next] sfc: reduce the number of requested xdp ev queues

2021-02-06 Thread Martin Habets
or 12 XDP event queues (24 other channels, max 32) > > Which in turn triggers EINVAL on XDP processing: > > sfc :86:00.0 ext0: XDP TX failed (-22) > > Signed-off-by: Ivan Babrou Acked-by: Martin Habets > --- > drivers/net/ethernet/sfc/efx_channels.c | 6 -- > 1

Re: [PATCH net-next] sfc: reduce the number of requested xdp ev queues

2020-12-16 Thread Martin Habets
or 12 XDP event queues (24 other channels, max 32) > > Which in turn triggers EINVAL on XDP processing: > > sfc :86:00.0 ext0: XDP TX failed (-22) > > Signed-off-by: Ivan Babrou Acked-by: Martin Habets > --- > drivers/net/ethernet/sfc/efx_channels.c | 6 -- > 1

Re: [PATCH v3 bpf-next 0/2] introduce xdp_init_buff/xdp_prepare_buff

2020-12-14 Thread Martin Habets
p_init_buff utility routine > net: xdp: introduce xdp_prepare_buff utility routine For changes in drivers/net/ethernet/sfc: Acked-by: Martin Habets > drivers/net/ethernet/amazon/ena/ena_netdev.c | 8 +++- > drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 7 ++- > .../net/ethernet/ca

Re: [PATCH net-next] sfc: backport XDP EV queue sharing from the out-of-tree driver

2020-12-14 Thread Martin Habets
On Sun, Dec 13, 2020 at 10:44:56AM -0800, Ivan Babrou wrote: > On Sun, Dec 13, 2020 at 4:23 AM Martin Habets > wrote: > > > > On Thu, Dec 10, 2020 at 04:18:53PM -0800, Ivan Babrou wrote: > > > Queue sharing behaviour already exists in the out-of-tree sfc dr

Re: [PATCH net-next] sfc: backport XDP EV queue sharing from the out-of-tree driver

2020-12-13 Thread Martin Habets
X_EVQ_SIZE / EFX_TXQ_MAX_ENT(efx); > n_xdp_tx = num_possible_cpus(); > - n_xdp_ev = DIV_ROUND_UP(n_xdp_tx, EFX_MAX_TXQ_PER_CHANNEL); > + n_xdp_ev = DIV_ROUND_UP(n_xdp_tx, tx_per_ev); > > vec_count = pci_msix_vec_count(efx->pci_dev); > if (vec_count < 0) > -- > 2.29.2 -- Martin Habets

[PATCH net] MAINTAINERS: Change Solarflare maintainers

2020-11-20 Thread Martin Habets
Email from solarflare.com will stop working. Update the maintainers. A replacement for linux-net-driv...@solarflare.com is not working yet, for now remove it. Signed-off-by: Martin Habets Signed-off-by: Edward Cree --- MAINTAINERS |5 ++--- 1 file changed, 2 insertions(+), 3 deletions

Re: [PATCH v4 01/10] Add auxiliary bus support

2020-11-17 Thread Martin Habets
esume callbacks. > Each auxiliary_device has a unique string based id; driver binds to > an auxiliary_device based on this id through the bus. Reviewed-by: Martin Habets > Co-developed-by: Kiran Patil > Signed-off-by: Kiran Patil > Co-developed-by: Ranjani Sridharan > Signe

Re: [PATCH net-next 0/3] sfc: further EF100 encap TSO features

2020-11-13 Thread Martin Habets
upport non-partial GSO_UDP_TUNNEL_CSUM on EF100 > sfc: support GRE TSO on EF100 Acked-by: Martin Habets

Re: [patch V2 16/36] net: sfc: Use GFP_KERNEL in efx_ef10_try_update_nic_stats()

2020-09-30 Thread Martin Habets
OMIC to GFP_KERNEL. > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Thomas Gleixner Acked-by: Martin Habets > --- > V2: Adjust to Edward's stats update split > --- > drivers/net/ethernet/sfc/ef10.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [RFC PATCH net-next] sfc: replace in_interrupt() usage

2020-09-29 Thread Martin Habets
; Reported-by: Sebastian Andrzej Siewior > Signed-off-by: Edward Cree Reviewed-by: Martin Habets > --- > Only compile-tested so far, because I'm waiting for my kernel to > finish rebuilding with CONFIG_DEBUG_ATOMIC_SLEEP which I'm hoping > is the right thing to detect t

Re: [PATCH] Convert enum pci_dev_flags to bit fields in struct pci_dev

2020-09-21 Thread Martin Habets
ed-by: Bjorn Helgaas > Signed-off-by: Krzysztof WilczyƄski For the change to drivers/net/ethernet/sfc/ef10_sriov.c: Acked-by: Martin Habets > --- > drivers/net/ethernet/atheros/alx/main.c | 2 +- > drivers/net/ethernet/sfc/ef10_sriov.c | 3 +- > drive

Re: [PATCH net] sfc: check hash is valid before using it

2020-08-18 Thread Martin Habets
Hi Ed, On Fri, Aug 14, 2020 at 01:26:22PM +0100, Edward Cree wrote: > On EF100, the RX hash field in the packet prefix may not be valid (e.g. > if the header parse failed), and this is indicated by a one-bit flag > elsewhere in the packet prefix. Only call skb_set_hash() if the > RSS_HASH_VALI

[PATCH net-next] sfc: Remove 'PCIE error reporting unavailable'

2019-07-08 Thread Martin Habets
This is only at notice level but it was pointed out that no other driver does this. Also there is no action the user can take as it is really a property of the server. Signed-off-by: Martin Habets --- drivers/net/ethernet/sfc/efx.c |6 +- 1 file changed, 1 insertion(+), 5 deletions

Re: [PATCH net] MAINTAINERS: net: update Solarflare maintainers

2019-04-01 Thread Martin Habets
On 01/04/2019 13:24, Bert Kenward wrote: > Cc: Martin Habets > Signed-off-by: Bert Kenward Acked-by: Martin Habets > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 1fdc8970e816..ade

Re: [PATCH net-next,v2] net: rename ndo_setup_tc to ndo_setup_offload

2018-07-19 Thread Martin Habets
renames ndo_setup_tc to ndo_setup_offload as a very > early initial work to prepare for follow up patch that discuss unified > flow representation for the existing offload programming APIs. > > Signed-off-by: Pablo Neira Ayuso > Acked-by: Jiri Pirko > Acked-by: Jakub Kicinski

Re: [PATCH net-next] net: rename ndo_setup_tc to ndo_setup_offload

2018-07-18 Thread Martin Habets
On 18/07/18 17:14, Pablo Neira Ayuso wrote: > One of the recurring complaints is that we do not have, as a driver > writer, a central location from which we would be fed offloading rules > into a NIC. This was brought up again during Netconf'18 in Boston. > > This patch just renames ndo_setup_tc t

[PATCH v2 net-next] sfc: stop the TX queue before pushing new buffers

2018-05-24 Thread Martin Habets
the partner queue. v2: In the error leg also push this queue if xmit_more is set Fixes: e9117e5099ea ("sfc: Firmware-Assisted TSO version 2") Reported-by: Jarod Wilson Tested-by: Jarod Wilson Signed-off-by: Martin Habets --- Dave, could you please also queue this patch up

[PATCH net-next] sfc: stop the TX queue before pushing new buffers

2018-05-23 Thread Martin Habets
the partner queue. Fixes: e9117e5099ea ("sfc: Firmware-Assisted TSO version 2") Reported-by: Jarod Wilson Signed-off-by: Martin Habets --- Dave, could you please also queue up this patch for stable? drivers/net/ethernet/sfc/tx.c | 31 +++ 1 file c

[PATCH net-next] sfc: Add ethtool -m support for QSFP modules

2017-07-18 Thread Martin Habets
This also adds support for non-QSFP modules attached to QSFP. Signed-off-by: Martin Habets --- drivers/net/ethernet/sfc/mcdi_port.c | 224 +++--- 1 file changed, 181 insertions(+), 43 deletions(-) diff --git a/drivers/net/ethernet/sfc/mcdi_port.c b/drivers/net

[PATCH net] sfc: Fix MCDI command size for filter operations

2017-06-22 Thread Martin Habets
protector. Fixes: 9b41080125176 ("sfc: insert catch-all filters for encapsulated traffic") Signed-off-by: Martin Habets Acked-by: Edward Cree Acked-by: Bert Kenward bkenw...@solarflare.com --- drivers/net/ethernet/sfc/ef10.c |8 1 file changed, 4 insertions(+), 4 deletion

Re: Getting a handle on all these new NIC features

2017-01-20 Thread Martin Habets
Hi Tom, On 17/01/17 22:05, Tom Herbert wrote: > There was some discussion about the problems of dealing with the > explosion of NIC features in the mlx directory restructuring proposal, > but I think the is a deeper issue here that should be discussed. > > It's hard not to notice that there has b

[PATCH net] sfc: push partner queue for skb->xmit_more

2015-11-02 Thread Martin Habets
also pushes the partner queue, if that also has any delayed work. Before this fix the work in the partner queue would be left for a long time and cause a netdev watchdog. Fixes: 70b33fb ("sfc: add support for skb->xmit_more") Reported-by: Jianlin Shi Signed-off-by: Martin Habets ---