Re: [PATCH mlx5-next 6/9] RDMA/mlx5: Use represntor E-Switch when getting netdev and metadata

2021-03-11 Thread Mark Bloch
On 3/11/21 7:33 PM, Jason Gunthorpe wrote: > On Wed, Mar 10, 2021 at 11:09:12PM -0800, Saeed Mahameed wrote: >> From: Mark Bloch >> >> Now that a pointer to the managing E-Switch is stored in the representor >> use it. >> >> Signed-off-by: Mark Bloch >&g

Re: [net V2 07/15] net/mlx5: Fix request_irqs error flow

2020-10-02 Thread Mark Bloch
On 10/2/2020 10:05, Saeed Mahameed wrote: > On Thu, 2020-10-01 at 16:24 -0700, Jakub Kicinski wrote: >> On Thu, 1 Oct 2020 12:52:39 -0700 sa...@kernel.org wrote: >>> - for (; i >= 0; i--) { >>> + for (--i; i >= 0; i--) { >> >> while (i--) > > while(--i) It has to be: while (i--) Case of i

Re: [PATCH mlx5-next v1 1/4] {IB/net}/mlx5: Simplify don't trap code

2020-05-08 Thread Mark Bloch
On 5/8/2020 12:58, Jason Gunthorpe wrote: > On Mon, May 04, 2020 at 08:30:09AM +0300, Leon Romanovsky wrote: >> +flow_act->action &= >> +~MLX5_FLOW_CONTEXT_ACTION_FWD_NEXT_PRIO; >> +flow_act->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST; >> +handle = _mlx5_add_flow_rules(f

Re: [PATCH mlx5-next 11/15] RDMA/mlx5: Add vport metadata matching for IB representors

2019-06-19 Thread Mark Bloch
On 6/19/19 1:12 AM, Leon Romanovsky wrote: > On Wed, Jun 19, 2019 at 07:58:51AM +0000, Mark Bloch wrote: >> >> >> On 6/19/2019 00:43, Leon Romanovsky wrote: >>> On Wed, Jun 19, 2019 at 07:26:54AM +, Mark Bloch wrote: >>>> >>>> >>>

Re: [PATCH mlx5-next 11/15] RDMA/mlx5: Add vport metadata matching for IB representors

2019-06-19 Thread Mark Bloch
On 6/19/2019 00:43, Leon Romanovsky wrote: > On Wed, Jun 19, 2019 at 07:26:54AM +0000, Mark Bloch wrote: >> >> >> On 6/18/2019 23:51, Leon Romanovsky wrote: >>> On Wed, Jun 19, 2019 at 06:40:16AM +, Jianbo Liu wrote: >>>> The 06/19/2019 13:04, L

Re: [PATCH mlx5-next 11/15] RDMA/mlx5: Add vport metadata matching for IB representors

2019-06-19 Thread Mark Bloch
match on the metadata, instead of source port. >>>>>> >>>>>> Signed-off-by: Jianbo Liu >>>>>> Reviewed-by: Roi Dayan >>>>>> Reviewed-by: Mark Bloch >>>>>> Signed-off-by: Saeed Mahameed >>>>>> --

Re: [PATCH v2] net/mlx5e: Add bonding device for indr block to offload the packet received from bonding device

2019-05-17 Thread Mark Bloch
On 5/17/2019 20:17, wenxu wrote: > > 在 2019/5/18 6:11, Mark Bloch 写道: >> >> On 5/17/19 2:17 AM, we...@ucloud.cn wrote: >>> From: wenxu >>> >>> The mlx5e support the lag mode. When add mlx_p0 and mlx_p1 to bond0. >>> packet received from mlx

Re: [PATCH v2] net/mlx5e: Add bonding device for indr block to offload the packet received from bonding device

2019-05-17 Thread Mark Bloch
On 5/17/19 2:17 AM, we...@ucloud.cn wrote: > From: wenxu > > The mlx5e support the lag mode. When add mlx_p0 and mlx_p1 to bond0. > packet received from mlx_p0 or mlx_p1 and in the ingress tc flower > forward to vf0. The tc rule can't be offloaded because there is > no indr_register_block for t

Re: [PATCH V2 mlx5-next 09/11] net/mlx5: Eswitch, enable RoCE loopback traffic

2019-04-29 Thread Mark Bloch
.org; linux- >> r...@vger.kernel.org; Maor Gottlieb ; Mark Bloch >> >> Subject: Re: [PATCH V2 mlx5-next 09/11] net/mlx5: Eswitch, enable RoCE >> loopback traffic >> >> On Mon, Apr 29, 2019 at 06:14:16PM +, Saeed Mahameed wrote: >>> From: Maor Gottlie

Re: [PATCH rdma-next 00/27] Flow actions to mutate packets

2018-07-30 Thread Mark Bloch
On 7/30/2018 10:10 AM, Jason Gunthorpe wrote: > On Sun, Jul 29, 2018 at 03:58:38PM +0300, Leon Romanovsky wrote: >> From: Leon Romanovsky >> >> Hi, >> >> This is PATCH variant of RFC posted in previous week to the ML. >> https://patchwork.ozlabs.org/cover/944184/ >> >> Changelog: >> RFC -> v0: >>

RE: [RFC PATCH rdma-next 13/18] RDMA/mlx5: Enable decap and packet reformat on flow tables

2018-07-17 Thread Mark Bloch
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Or Gerlitz > Sent: Tuesday, July 17, 2018 5:47 AM > To: Mark Bloch > Cc: Doug Ledford ; Jason Gunthorpe > ; Leon Romanovsky ; RDMA > maili

RE: [RFC PATCH mlx5-next 07/18] net/mlx5: Expose new packet reformat capabilities

2018-07-16 Thread Mark Bloch
> -Original Message- > From: Or Gerlitz [mailto:gerlitz...@gmail.com] > Sent: Monday, July 16, 2018 2:33 PM > To: Mark Bloch > Cc: Doug Ledford ; Jason Gunthorpe > ; Leon Romanovsky ; RDMA > mailing list ; Saeed Mahameed > ; linux-netdev > Subject: Re: [RFC

RE: [RFC PATCH rdma-next 13/18] RDMA/mlx5: Enable decap and packet reformat on flow tables

2018-07-16 Thread Mark Bloch
> -Original Message- > From: Or Gerlitz [mailto:gerlitz...@gmail.com] > Sent: Monday, July 16, 2018 2:24 PM > To: Mark Bloch > Cc: Doug Ledford ; Jason Gunthorpe > ; Leon Romanovsky ; RDMA > mailing list ; Saeed Mahameed > ; linux-netdev > Subject: Re: [RFC

Re: [PATCH net v2 1/2] rhashtable: Fix rhlist duplicates insertion

2018-03-04 Thread Mark Bloch
On 04/03/2018 15:26, Paul Blakey wrote: > When inserting duplicate objects (those with the same key), > current rhlist implementation messes up the chain pointers by > updating the bucket pointer instead of prev next pointer to the > newly inserted node. This causes missing elements on removal an

Re: [for-next 07/11] net/mlx5: E-Switch, Create generic header struct to be used by representors

2017-12-20 Thread Mark Bloch
On 20/12/2017 19:58, David Miller wrote: > From: Saeed Mahameed > Date: Tue, 19 Dec 2017 12:33:36 -0800 > >> +static int esw_offloads_load_reps(struct mlx5_eswitch *esw, int nvports) >> +{ >> +u8 rep_type = 0; >> +int err; >> + >> +while (rep_type < NUM_REP_TYPES) { >> +

Re: [for-next 01/11] net/mlx5: E-Switch, Refactor vport representors initialization

2017-12-20 Thread Mark Bloch
On 20/12/2017 19:57, David Miller wrote: > From: Saeed Mahameed > Date: Tue, 19 Dec 2017 12:33:30 -0800 > >> +int esw_offloads_init_reps(struct mlx5_eswitch *esw) >> +{ >> +struct mlx5_core_dev *dev = esw->dev; >> +struct mlx5_esw_offload *offloads; >> +struct mlx5_eswitch_rep *rep;

[net-next] vxlan: use a more suitable function when assigning NULL

2017-06-07 Thread Mark Bloch
When stopping the vxlan interface we detach it from the socket. Use RCU_INIT_POINTER() and not rcu_assign_pointer() to do so. Suggested-by: Stephen Hemminger Signed-off-by: Mark Bloch --- drivers/net/vxlan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net

[net,V2] vxlan: fix use-after-free on deletion

2017-06-01 Thread Mark Bloch
from vxlan_stop() to match the call from vxlan_open(). Fixes: 56ef9c909b40 ("vxlan: Move socket initialization to within rtnl scope") Acked-by: Jiri Benc Tested-by: Roi Dayan Signed-off-by: Mark Bloch --- V2: Added a Fixes tag. Added Acked-by and Tested-by from Jiri and Roi. driv

[net] vxlan: fix use-after-free on deletion

2017-06-01 Thread Mark Bloch
from vxlan_stop() to match the call from vxlan_open(). Signed-off-by: Mark Bloch --- drivers/net/vxlan.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 328b471..f6a4310 100644 --- a/drivers/net/vxlan.c

Re: vxlan: use after free error

2017-05-28 Thread Mark Bloch
Hi Roopa, On 29/05/2017 05:50, Roopa Prabhu wrote: > On Sun, May 28, 2017 at 3:49 AM, Mark Bloch wrote: >> Hi, >> >> I'm getting a KASAN (use after free) error when doing: >> >> ip link add vxlan1 type vxlan external >> ip link set vxlan1 up >

vxlan: use after free error

2017-05-28 Thread Mark Bloch
Hi, I'm getting a KASAN (use after free) error when doing: ip link add vxlan1 type vxlan external ip link set vxlan1 up ip link set vxlan1 down ip link del vxlan1 [ 600.495331] == [ 600.509678] BUG: KASAN: use-after-free in vxlan

Re: [RFC 03/11] Add support for RoCE HW init

2016-09-12 Thread Mark Bloch
On 12/09/2016 19:07, Ram Amrani wrote: > Allocate and setup RoCE resources, interrupts and completion queues. > Adds device attributes. > > Signed-off-by: Rajesh Borundia > Signed-off-by: Ram Amrani > --- > drivers/infiniband/hw/qedr/main.c | 408 +++- > drivers/infiniban

Re: [RFC 02/11] Add RoCE driver framework

2016-09-12 Thread Mark Bloch
Hi Ram, Just a few thoughts On 12/09/2016 19:07, Ram Amrani wrote: > Adds a skeletal implementation of the qed* RoCE driver - > basically the ability to communicate with the qede driver and > receive notifications from it regarding various init/exit events. > > Signed-off-by: Rajesh Borundia