Re: [PATCH net] atl1c: fix error return code in atl1c_probe()

2020-11-17 Thread Marion & Christophe JAILLET
Le 17/11/2020 à 03:55, Zhang Changzhong a écrit : Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 85eb5bc33717 ("net: atheros: switch from 'pci_' to 'dma_' API") Hi, should it have any importance, the Fixes tag is wrong

Re: [PATCH net] atl1e: fix error return code in atl1e_probe()

2020-11-17 Thread Marion & Christophe JAILLET
Le 17/11/2020 à 03:57, Zhang Changzhong a écrit : Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 85eb5bc33717 ("net: atheros: switch from 'pci_' to 'dma_' API") Hi, should it have any importance, the Fixes tag is wrong

Spurious code in commit 1bf40ada6290 ("amd-xgbe: Add support for clause 37 auto-negotiation"

2016-11-12 Thread Marion & Christophe JAILLET
Hi, in commit 1bf40ada6290 ("amd-xgbe: Add support for clause 37 auto-negotiation"), we can find: diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-common.h b/drivers/net/ethernet/amd/xgbe/xgbe-common.h index 695e982..8bcf4ef 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-common.h +++ b/drive