Re: r8169 needs CONFIG_REALTEK_PHY

2018-08-20 Thread Marc Dionne
On Mon, Aug 20, 2018 at 5:39 PM, Florian Fainelli wrote: > On 08/20/2018 12:44 PM, Marc Dionne wrote: >> The r8169 adapter in one of my machines was not working after updating >> to a current kernel from the merge window, which was fixed by enabling >> CONFIG_REALTEK_PHY. &g

r8169 needs CONFIG_REALTEK_PHY

2018-08-20 Thread Marc Dionne
The r8169 adapter in one of my machines was not working after updating to a current kernel from the merge window, which was fixed by enabling CONFIG_REALTEK_PHY. So in addition to "select PHYLIB", should CONFIG_R8169 not also be doing "select CONFIG_REALTEK_PHY" ? Marc

Re: [PATCH] net: do not allow changing SO_REUSEADDR/SO_REUSEPORT on bound sockets

2018-06-11 Thread Marc Dionne
On Mon, Jun 11, 2018 at 7:29 PM, Maciej Żenczykowski wrote: >> This change is a potential performance regression for us. Our >> networking code sets up multiple sockets used by multiple threads to >> listen on the same udp port. For the first socket, the bind is done >> before setting SO_REUSEPO

Re: [PATCH] net: do not allow changing SO_REUSEADDR/SO_REUSEPORT on bound sockets

2018-06-11 Thread Marc Dionne
On Sun, Jun 3, 2018 at 2:47 PM, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > It is not safe to do so because such sockets are already in the > hash tables and changing these options can result in invalidating > the tb->fastreuse(port) caching. > > This can have later far reaching co

Re: Multi-thread udp 4.7 regression, bisected to 71d8c47fc653

2016-07-11 Thread Marc Dionne
On Mon, Jul 11, 2016 at 1:26 PM, Pablo Neira Ayuso wrote: > On Sun, Jul 10, 2016 at 04:48:26PM -0300, Marc Dionne wrote: >> An update here since I've had some interactions with Pablo off list. >> >> Further testing shows that the underlying cause of the different test

Re: Multi-thread udp 4.7 regression, bisected to 71d8c47fc653

2016-07-10 Thread Marc Dionne
On Tue, Jul 5, 2016 at 9:28 AM, Pablo Neira Ayuso wrote: > Hi, > > On Mon, Jul 04, 2016 at 09:35:28AM -0300, Marc Dionne wrote: >> If there is no quick fix, seems like a revert should be considered: >> - Looks to me like the commit attempts to fix a long standing bug >&

Re: Multi-thread udp 4.7 regression, bisected to 71d8c47fc653

2016-07-04 Thread Marc Dionne
On Mon, Jun 27, 2016 at 2:21 PM, Marc Dionne wrote: > On Mon, Jun 27, 2016 at 12:38 PM, Florian Westphal wrote: >> Marc Dionne wrote: >>> On Mon, Jun 27, 2016 at 11:22 AM, Florian Westphal wrote: >>> > Marc Dionne wrote: >>> >> Hi, >

Re: Multi-thread udp 4.7 regression, bisected to 71d8c47fc653

2016-06-27 Thread Marc Dionne
On Mon, Jun 27, 2016 at 12:38 PM, Florian Westphal wrote: > Marc Dionne wrote: >> On Mon, Jun 27, 2016 at 11:22 AM, Florian Westphal wrote: >> > Marc Dionne wrote: >> >> Hi, > >> > hlist_nulls_for_each_entry(h, n, &nf_conntra

Re: Multi-thread udp 4.7 regression, bisected to 71d8c47fc653

2016-06-27 Thread Marc Dionne
On Mon, Jun 27, 2016 at 11:22 AM, Florian Westphal wrote: > Marc Dionne wrote: >> Hi, >> >> I've been seeing issues with 4.7-rc kernels with some of our >> multi-thread test cases. I've bisected it down to this commit: >> >> commit 71d8c47fc6

Multi-thread udp 4.7 regression, bisected to 71d8c47fc653

2016-06-27 Thread Marc Dionne
Hi, I've been seeing issues with 4.7-rc kernels with some of our multi-thread test cases. I've bisected it down to this commit: commit 71d8c47fc653711c41bc3282e5b0e605b3727956 Author: Pablo Neira Ayuso Date: Sun May 1 00:28:40 2016 +0200 netfilter: conntrack: introduce clash reso