On Wed, Mar 31, 2021 at 05:36:42AM +0100, Matthew Wilcox (Oracle) wrote:
> The XArray interface is easier for this driver to use. Also fixes a
> bug reported by the improper use of GFP_ATOMIC.
>
> Signed-off-by: Matthew Wilcox (Oracle)
Reviewed-by: Manivannan Sadhasivam
On Fri, Jun 05, 2020 at 05:00:37AM -0700, Matthew Wilcox wrote:
> From: "Matthew Wilcox (Oracle)"
>
> The XArray interface is easier for this driver to use. Also fixes a
> bug reported by the improper use of GFP_ATOMIC.
>
> Signed-off-by: Matthew Wilcox (Oracle)
Patch looks good to me. Can yo
5fdeb0d372ab ("net: qrtr: Implement outgoing flow control")
> Reported-by: syzbot+739016799a89c530b...@syzkaller.appspotmail.com
> Signed-off-by: Loic Poulain
Reviewed-by: Manivannan Sadhasivam
Thanks,
Mani
> ---
> net/qrtr/qrtr.c | 5 -
> 1 file changed, 4 insertions(+
Add MAINTAINERS entry for Qualcomm IPC Router (QRTR) driver.
Signed-off-by: Manivannan Sadhasivam
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index d92f85ca831d..441e1607db53 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14856,6
On Mon, Mar 29, 2021 at 06:55:56PM +0800, Du Cheng wrote:
> On Sun, Mar 28, 2021 at 11:04:17AM +0100, Matthew Wilcox wrote:
> > On Sun, Mar 28, 2021 at 08:56:17AM +0200, Greg Kroah-Hartman wrote:
> > > On Sat, Mar 27, 2021 at 03:51:10PM +, Matthew Wilcox wrote:
> > > > On Sat, Mar 27, 2021 at 0
On Mon, Mar 29, 2021 at 01:03:24PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Mar 29, 2021 at 04:22:36PM +0530, Manivannan Sadhasivam wrote:
> > Hi Greg,
> >
> > On Mon, Mar 29, 2021 at 11:47:12AM +0200, Loic Poulain wrote:
> > > Hi Greg,
> > >
> &g
Hi Greg,
On Mon, Mar 29, 2021 at 11:47:12AM +0200, Loic Poulain wrote:
> Hi Greg,
>
> On Sun, 28 Mar 2021 at 14:28, Greg Kroah-Hartman
> wrote:
>
> > There does not seem to be any developers willing to maintain the
> > net/qrtr/ code, so move it to drivers/staging/ so that it can be removed
> >
On Tue, Mar 16, 2021 at 11:00:37AM -0500, Alex Elder wrote:
> On 3/15/21 10:25 PM, Manivannan Sadhasivam wrote:
> > On Mon, Mar 15, 2021 at 11:50:15AM -0500, Alex Elder wrote:
> > > On 3/15/21 11:38 AM, Manivannan Sadhasivam wrote:
> > > > Hi Alex,
> > > &
t; Signed-off-by: Alex Elder
Acked-by: Manivannan Sadhasivam
Thanks,
Mani
> ---
> drivers/net/ipa/ipa_qmi_msg.c | 40 +++
> drivers/net/ipa/ipa_qmi_msg.h | 6 +-
> 2 files changed, 45 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/
field. It is an optional 32-bit enumerated type value.
>
> Finally, the hw_stats_quota_base_addr, hw_stats_quota_size, and
> hw_stats_drop_size fields are defined as enumerated types; they
> should be unsigned 4-byte values.
>
> Reported-by: Manivannan Sadhasivam
> Signed-off-by:
e value 0x12 instead. Fix this bug.
>
> Reported-by: Manivannan Sadhasivam
> Signed-off-by: Alex Elder
Acked-by: Manivannan Sadhasivam
Thanks,
Mani
> ---
> drivers/net/ipa/ipa_qmi_msg.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers
On Mon, Mar 15, 2021 at 11:50:15AM -0500, Alex Elder wrote:
> On 3/15/21 11:38 AM, Manivannan Sadhasivam wrote:
> > Hi Alex,
> >
> > On Mon, Mar 15, 2021 at 10:21:09AM -0500, Alex Elder wrote:
> > > Mani Sadhasivam discovered some errors in the definitions of some
&
Hi Alex,
On Mon, Mar 15, 2021 at 10:21:09AM -0500, Alex Elder wrote:
> Mani Sadhasivam discovered some errors in the definitions of some
> QMI messages used for IPA. This series addresses those errors,
> and extends the definition of one message type to include some
> newly-defined fields.
>
Th
On Sun, Feb 28, 2021 at 03:12:42PM +0100, Aleksander Morgado wrote:
> Hey Manivannan, Jakub & all,
>
> >
> > So please let us know the path forward on this series. We are open to
> > any suggestions but you haven't provided one till now.
> >
>
> I just found out that Sierra Wireless also provides
On Tue, Feb 09, 2021 at 08:17:44AM -0800, Jakub Kicinski wrote:
> On Tue, 9 Feb 2021 10:20:30 +0100 Aleksander Morgado wrote:
> > This may be a stupid suggestion, but would the integration look less a
> > backdoor if it would have been named "mhi_wwan" and it exposed already
> > all the AT+DIAG+QMI
On Wed, Feb 03, 2021 at 10:40:28AM -0800, Jakub Kicinski wrote:
> On Wed, 3 Feb 2021 19:28:28 +0100 Loic Poulain wrote:
> > On Wed, 3 Feb 2021 at 19:05, Jakub Kicinski wrote:
> > > On Wed, 03 Feb 2021 09:45:06 +0530 Manivannan Sadhasivam wrote:
> > > > The curr
Hi Jakub,
On 3 February 2021 9:40:08 AM IST, Jakub Kicinski wrote:
>On Tue, 2 Feb 2021 09:52:08 +0530 Manivannan Sadhasivam wrote:
>> > > I don't see the connection here, sorry.
>> >
>> > For instance USB_NET_CDC_MBIM driver creates the /dev/cdc-wdmX
+ Jakub, Dave
On Mon, Feb 01, 2021 at 05:43:22PM +0530, Manivannan Sadhasivam wrote:
> On Mon, Feb 01, 2021 at 12:15:51PM +0100, Greg KH wrote:
> > On Mon, Feb 01, 2021 at 04:25:49PM +0530, Manivannan Sadhasivam wrote:
> > > Hi Greg,
> > >
> > > On Wed, Jan 2
On Mon, Feb 01, 2021 at 12:15:51PM +0100, Greg KH wrote:
> On Mon, Feb 01, 2021 at 04:25:49PM +0530, Manivannan Sadhasivam wrote:
> > Hi Greg,
> >
> > On Wed, Jan 27, 2021 at 04:15:42PM +0100, Greg KH wrote:
> > > On Wed, Jan 13, 2021 at 08:56:25PM +0530, Manivanna
Hi Greg,
On Wed, Jan 27, 2021 at 04:15:42PM +0100, Greg KH wrote:
> On Wed, Jan 13, 2021 at 08:56:25PM +0530, Manivannan Sadhasivam wrote:
> > Hi Greg,
> >
> > On Wed, Jan 06, 2021 at 10:44:13AM -0800, Hemant Kumar wrote:
> > > This patch series adds support for
On Wed, Jan 13, 2021 at 08:02:46PM -0800, Jakub Kicinski wrote:
> On Thu, 14 Jan 2021 09:27:49 +0530 Manivannan Sadhasivam wrote:
> > On Wed, Jan 13, 2021 at 07:33:01PM -0800, Jakub Kicinski wrote:
> > > On Mon, 11 Jan 2021 19:07:40 +0100 Loic Poulain wrote:
> >
Hi Greg,
On Wed, Jan 13, 2021 at 08:56:25PM +0530, Manivannan Sadhasivam wrote:
> Hi Greg,
>
> On Wed, Jan 06, 2021 at 10:44:13AM -0800, Hemant Kumar wrote:
> > This patch series adds support for UCI driver. UCI driver enables userspace
> > clients to communicate to exte
this
> > API to know before hand if ring is full without calling queue
> > API.
> >
> > Signed-off-by: Hemant Kumar
> > Reviewed-by: Jeffrey Hugo
> > Reviewed-by: Manivannan Sadhasivam
>
> Can we apply these to net-next or does it need to be on a stable
Hi Greg,
On Wed, Jan 06, 2021 at 10:44:13AM -0800, Hemant Kumar wrote:
> This patch series adds support for UCI driver. UCI driver enables userspace
> clients to communicate to external MHI devices like modem. UCI driver probe
> creates standard character device file nodes for userspace clients to
5b97f003e ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI
> CAN")
> Signed-off-by: Qinglang Miao
Reviewed-by: Manivannan Sadhasivam
Thanks,
Mani
> ---
> drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
On Fri, Jan 08, 2021 at 04:46:49PM +0100, Loic Poulain wrote:
> Hi Mani,
>
> On Fri, 8 Jan 2021 at 16:30, Manivannan Sadhasivam <
> manivannan.sadhasi...@linaro.org> wrote:
>
> > > > > /* start channels */
> > > > > - rc = mh
On Fri, Jan 08, 2021 at 03:01:59PM +0100, Loic Poulain wrote:
> Hi Mani,
>
> On Fri, 8 Jan 2021 at 14:44, Manivannan Sadhasivam <
> manivannan.sadhasi...@linaro.org> wrote:
>
> > On Wed, Jan 06, 2021 at 02:43:43PM +0100, Loic Poulain wrote:
> > > Currentl
On Wed, Jan 06, 2021 at 02:43:43PM +0100, Loic Poulain wrote:
> Currently, the MHI controller driver defines which channels should
> have their inbound buffers allocated and queued. But ideally, this is
> something that should be decided by the MHI device driver instead,
We call them, "MHI client
On Fri, Dec 11, 2020 at 08:08:16PM -0800, Jakub Kicinski wrote:
> On Fri, 11 Dec 2020 11:37:34 -0600 Dan Williams wrote:
> > Just to re-iterate: QMI ~= AT commands ~= MBIM (not quite, but same
> > level)
> >
> > We already do QMI-over-USB, or AT-over-CDC-ACM. This is QMI-over-MHI.
>
> Why do we n
On Fri, Dec 11, 2020 at 10:40:13AM +0100, Loic Poulain wrote:
> Hi Mani,
>
> On Fri, 11 Dec 2020 at 06:38, Manivannan Sadhasivam
> wrote:
> >
> > On Thu, Dec 10, 2020 at 12:15:50PM +0100, Loic Poulain wrote:
> > > The RX queue size can be determined at runtime
Hi Greg,
On Fri, Dec 11, 2020 at 08:44:29AM +0100, Greg KH wrote:
> On Thu, Dec 10, 2020 at 11:04:11PM -0800, Hemant Kumar wrote:
> > This MHI client driver allows userspace clients to transfer
> > raw data between MHI device and host using standard file operations.
> > Driver instantiates UCI dev
On Thu, Dec 10, 2020 at 12:15:50PM +0100, Loic Poulain wrote:
> The RX queue size can be determined at runtime by retrieving the
> number of available transfer descriptors.
>
> Signed-off-by: Loic Poulain
> ---
> v2: Fixed commit message typo
>
> drivers/net/mhi_net.c | 6 +++---
> 1 file chan
On Sun, Dec 06, 2020 at 10:33:02AM +0200, Leon Romanovsky wrote:
> On Tue, Dec 01, 2020 at 09:59:53PM -0700, Jeffrey Hugo wrote:
> > On 12/1/2020 7:55 PM, Jakub Kicinski wrote:
> > > On Tue, 1 Dec 2020 13:48:36 -0700 Jeffrey Hugo wrote:
> > > > On 12/1/2020 1:03 PM, Jakub Kicinski wrote:
> > > > >
On Tue, Dec 01, 2020 at 12:03:02PM -0800, Jakub Kicinski wrote:
> On Tue, 1 Dec 2020 12:40:50 -0700 Jeffrey Hugo wrote:
> > On 12/1/2020 12:29 PM, Jakub Kicinski wrote:
> > > On Fri, 27 Nov 2020 19:26:02 -0800 Hemant Kumar wrote:
> > >> This patch series adds support for UCI driver. UCI driver
and if ring is full without calling queue
> > API.
> >
> > Signed-off-by: Hemant Kumar
> > Reviewed-by: Jeffrey Hugo
> > Reviewed-by: Manivannan Sadhasivam
>
> In case this series get new comments to address, I would suggest
> merging that patch in mhi
ndexed MHI controller name" patch, you
need to update the documentation accordingly.
> Signed-off-by: Hemant Kumar
Reviewed-by: Manivannan Sadhasivam
Thanks,
Mani
> ---
> drivers/bus/mhi/Kconfig | 13 +
> drivers/bus/mhi/Makefile | 3 +
> drivers/bus/mhi/uci.c| 6
On Thu, Nov 19, 2020 at 10:18:28PM -0800, Jakub Kicinski wrote:
> On Fri, 20 Nov 2020 11:45:12 +0530 Manivannan Sadhasivam wrote:
> > Jakub, can you please provide your ack so that I can take it?
>
> Sure:
>
> Acked-by: Jakub Kicinski
Patch applied to mhi-ath11k-immutable.
Thanks,
Mani
On Thu, Nov 19, 2020 at 09:10:46PM -0800, Jakub Kicinski wrote:
> On Wed, 18 Nov 2020 10:20:25 -0800 Bhaumik Bhatt wrote:
> > Reset MHI device channels when driver remove is called due to
> > module unload or any crash scenario. This will make sure that
> > MHI channels no longer remain enabled for
umar
One nitpick below, with that addressed:
Reviewed-by: Manivannan Sadhasivam
> ---
> Documentation/mhi/uci.rst | 32 +
> tools/testing/selftests/Makefile | 1 +
> tools/testing/selftests/drivers/.gitignore | 1 +
>
On Wed, Nov 18, 2020 at 07:55:19PM +0800, Carl Huang wrote:
> On 2020-11-18 17:31, Manivannan Sadhasivam wrote:
> > On Wed, Nov 18, 2020 at 07:43:48AM +0200, Kalle Valo wrote:
> > > Manivannan Sadhasivam writes:
> > >
> > > > From: Loic Poulain
> > &
On Wed, Nov 18, 2020 at 07:43:48AM +0200, Kalle Valo wrote:
> Manivannan Sadhasivam writes:
>
> > From: Loic Poulain
> >
> > There is really no point having an auto-start for channels.
> > This is confusing for the device drivers, some have to enable the
> >
annel) driver to manage the state
of its channels.
While at it, let's also remove the auto-start option from ath11k mhi
controller.
Signed-off-by: Loic Poulain
Reviewed-by: Manivannan Sadhasivam
[mani: clubbed ath11k change]
Signed-off-by: Manivannan Sadhasivam
---
drivers/bus/mhi/c
+ath11k list
On Mon, Sep 21, 2020 at 09:43:04AM +0200, Loic Poulain wrote:
> Start MHI device channels so that transfers can be performed.
> The MHI stack does not auto-start channels anymore.
>
> Signed-off-by: Loic Poulain
Applied to mhi-ath11k-immutable branch! This branch will get merged in
+ath11k list
On Mon, Sep 21, 2020 at 09:43:03AM +0200, Loic Poulain wrote:
> There is really no point having an auto-start for channels.
> This is confusing for the device drivers, some have to enable the
> channels, others don't have... and waste resources (e.g. pre allocated
> buffers) that may
On Tue, Nov 10, 2020 at 09:44:27AM -0800, Jakub Kicinski wrote:
> On Tue, 10 Nov 2020 10:03:29 +0100 Loic Poulain wrote:
> > On Mon, 9 Nov 2020 at 19:39, Jakub Kicinski wrote:
> > >
> > > On Mon, 9 Nov 2020 09:49:24 +0100 Loic Poulain wrote:
> > > > > Looks like patch 1 is a bug fix and patches
On 6 November 2020 9:34:45 PM IST, Jakub Kicinski wrote:
>On Fri, 6 Nov 2020 10:43:53 +0530 Manivannan Sadhasivam wrote:
>> On Thu, Nov 05, 2020 at 04:57:08PM -0800, Jakub Kicinski wrote:
>> > On Tue, 3 Nov 2020 18:23:53 +0100 Loic Poulain wrote:
>> > > This
f-by: Loic Poulain
> > Reviewed-by: Manivannan Sadhasivam
>
> Applied.
Oops. I should've mentioned this (my bad) that we should use an immutable
branch to take this change. Because, there are changes going to get merged
into the MHI tree which will introduce merge conflicts. And
On Thu, Nov 05, 2020 at 05:39:31PM +0100, Marc Kleine-Budde wrote:
> On 11/5/20 5:24 PM, Manivannan Sadhasivam wrote:
> > Hi Marc,
> >
> > On Tue, Nov 03, 2020 at 11:06:30PM +0100, Marc Kleine-Budde wrote:
> >> During debugging it turned out that some pe
; to give users feedback without the need to recompile the driver with debug
> enabled.
>
> Cc: Manivannan Sadhasivam
> Cc: Thomas Kopp
> Link: http://lore.kernel.org/r/20201019190524.1285319-15-...@pengutronix.de
> Signed-off-by: Marc Kleine-Budde
> ---
> drivers/net/ca
hi Hemant,
On Fri, Oct 30, 2020 at 06:26:38PM -0700, Hemant Kumar wrote:
> Hi Mani,
>
> On 10/30/20 3:34 AM, Manivannan Sadhasivam wrote:
> > Hi Hemant,
> >
> > On Thu, Oct 29, 2020 at 07:45:46PM -0700, Hemant Kumar wrote:
> > > This MHI client driver
Hi Hemant,
On Thu, Oct 29, 2020 at 07:45:46PM -0700, Hemant Kumar wrote:
> This MHI client driver allows userspace clients to transfer
> raw data between MHI device and host using standard file operations.
> Driver instantiates UCI device object which is associated to device
> file node. UCI devic
On Wed, Oct 28, 2020 at 05:34:58PM +0100, Loic Poulain wrote:
> This patch adds a new network driver implementing MHI transport for
> network packets. Packets can be in any format, though QMAP (rmnet)
> is the usual protocol (flow control + PDN mux).
>
> It support two MHI devices, IP_HW0 which is
On Wed, Oct 28, 2020 at 05:34:57PM +0100, Loic Poulain wrote:
> This function can be used by client driver to determine whether it's
> possible to queue new elements in a channel ring.
>
> Signed-off-by: Loic Poulain
Reviewed-by: Manivannan Sadhasivam
Thanks,
Mani
> ---
two MHI devices, IP_HW0 which is, the path to the IPA
> (IP accelerator) on qcom modem, And IP_SW0 which is the software
> driven IP path (to modem CPU).
>
This patch looks good to me. I just commented few nits inline. With those
addressed, you can have my:
Reviewed-by: Manivannan Sadhasivam
ouglas Anderson
Tested-by: Douglas Anderson
Tested-by: Alex Elder
Signed-off-by: Manivannan Sadhasivam
---
Changes in v3:
* Collected reviews from Doug and addressed couple of nitpicks
Changes in v2:
* Used radix_tree_deref_retry() and radix_tree_iter_resume() as
suggested by Doug.
net
der
Signed-off-by: Manivannan Sadhasivam
---
Changes in v2:
* Used radix_tree_deref_retry() and radix_tree_iter_resume() as
suggested by Doug.
net/qrtr/ns.c | 63 ++-
1 file changed, 57 insertions(+), 6 deletions(-)
diff --git a/net/qrtr/ns.c
Hi Doug,
On Fri, Oct 02, 2020 at 08:28:51AM -0700, Doug Anderson wrote:
> Hi,
>
> On Fri, Oct 2, 2020 at 7:15 AM Manivannan Sadhasivam
> wrote:
> >
> > The rcu_read_lock() is not supposed to lock the kernel_sendmsg() API
> > since it has the lock_sock() in qrtr_sen
)
Reported-by: Doug Anderson
Tested-by: Alex Elder
Signed-off-by: Manivannan Sadhasivam
---
net/qrtr/ns.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/net/qrtr/ns.c b/net/qrtr/ns.c
index 934999b56d60..0515433de922 100644
--- a/net/qrtr/ns.c
+++ b/net
Hi Doug,
On Thu, Oct 01, 2020 at 03:53:12PM -0700, Doug Anderson wrote:
> Hi,
>
> On Mon, Sep 28, 2020 at 4:15 PM David Miller wrote:
> >
> > From: Manivannan Sadhasivam
> > Date: Sat, 26 Sep 2020 22:26:25 +0530
> >
> > > The rcu read locks are need
g the packet).
>
> Signed-off-by: Loic Poulain
Reviewed-by: Manivannan Sadhasivam
Thanks,
Mani
> ---
> net/qrtr/ns.c | 8
> 1 file changed, 8 deletions(-)
>
> diff --git a/net/qrtr/ns.c b/net/qrtr/ns.c
> index d8252fd..d542d8f 100644
> --- a/net/qrtr/ns.c
> +++ b/n
Hi,
On Mon, Sep 28, 2020 at 06:42:30PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/net/wireless/ath/ath11k/mhi.c:27:4: error: 'struct
> mhi_channel_config' has no member named 'auto_start
On Mon, Sep 28, 2020 at 07:45:37PM +0300, Kalle Valo wrote:
> Manivannan Sadhasivam writes:
>
> > On Mon, Sep 28, 2020 at 12:34:40PM +0300, Kalle Valo wrote:
> >> Manivannan Sadhasivam writes:
> >>
> >> > On Mon, Sep 28, 2020 at 06:42:30PM +10
evice for QCA6390")
Reported-by: Stephen Rothwell
Signed-off-by: Manivannan Sadhasivam
---
drivers/net/wireless/ath/ath11k/mhi.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/mhi.c
b/drivers/net/wireless/ath/ath11k/mhi.c
index aded9a719d51..47a1ce1be
On Mon, Sep 28, 2020 at 12:34:40PM +0300, Kalle Valo wrote:
> Manivannan Sadhasivam writes:
>
> > On Mon, Sep 28, 2020 at 06:42:30PM +1000, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> After merging the mhi tree, today's linux-next build
Hi,
On Mon, Sep 28, 2020 at 06:42:30PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/net/wireless/ath/ath11k/mhi.c:27:4: error: 'struct
> mhi_channel_config' has no member named 'auto_start
On Mon, Sep 21, 2020 at 09:43:03AM +0200, Loic Poulain wrote:
> There is really no point having an auto-start for channels.
> This is confusing for the device drivers, some have to enable the
> channels, others don't have... and waste resources (e.g. pre allocated
> buffers) that may never be used.
On Mon, Sep 21, 2020 at 09:43:04AM +0200, Loic Poulain wrote:
> Start MHI device channels so that transfers can be performed.
> The MHI stack does not auto-start channels anymore.
>
> Signed-off-by: Loic Poulain
Applied to mhi-next!
Thanks,
Mani
> ---
> v2: split MHI and qrtr changes in dedic
:268
Fixes: 0c2204a4ad71 ("net: qrtr: Migrate nameservice to kernel from userspace")
Reported-and-tested-by: syzbot+0f84f6eed90503da7...@syzkaller.appspotmail.com
Signed-off-by: Manivannan Sadhasivam
---
net/qrtr/ns.c | 34 +-
1 file changed, 25 in
may never be used.
>
> This is really up to the MHI device(channel) driver to manage the state
> of its channels.
>
> Signed-off-by: Loic Poulain
Reviewed-by: Manivannan Sadhasivam
Thanks,
Mani
> ---
> v2: split MHI and qrtr changes in dedicated commits
>
On Mon, Sep 21, 2020 at 09:43:04AM +0200, Loic Poulain wrote:
> Start MHI device channels so that transfers can be performed.
> The MHI stack does not auto-start channels anymore.
>
> Signed-off-by: Loic Poulain
Reviewed-by: Manivannan Sadhasivam
Dave: I'd like to queue this
On Mon, Sep 21, 2020 at 09:43:03AM +0200, Loic Poulain wrote:
> There is really no point having an auto-start for channels.
> This is confusing for the device drivers, some have to enable the
> channels, others don't have... and waste resources (e.g. pre allocated
> buffers) that may never be used.
fe000200 ea0002237ec8 ea00029b3388 88821bb66800
> raw: 88804d8abb40 88804d8ab000 0001000b 0000
> page dumped because: kasan: bad access detected
>
> Fixes: ce57785bf91b ("net: qrtr: fix len of skb_put_padto in
> qrtr_node_enqueue"
Hi Bjorn,
On Sat, Jun 27, 2020 at 01:57:13PM -0700, syzbot wrote:
> syzbot has found a reproducer for the following crash on:
>
> HEAD commit:1590a2e1 Merge tag 'acpi-5.8-rc3' of git://git.kernel.org/..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=14b
On Thu, Jun 18, 2020 at 02:25:33PM +0530, Manivannan Sadhasivam wrote:
> Hi,
>
> On 0611, Marc Kleine-Budde wrote:
> > On 6/10/20 9:44 AM, Manivannan Sadhasivam wrote:
> > > Hello,
> > >
> > > This series adds CAN network driver support for Microchip MCP
Hi,
On 17 June 2020 12:18:06 AM IST, Qais Yousef wrote:
>Hi Manivannan, David
>
>On 02/13/20 14:44, Manivannan Sadhasivam wrote:
>
>[...]
>
>> +trace_printk("advertising new server [%d:%x]@[%d:%d]\n",
>> + srv->service, srv->in
Hi,
On 0611, Marc Kleine-Budde wrote:
> On 6/10/20 9:44 AM, Manivannan Sadhasivam wrote:
> > Hello,
> >
> > This series adds CAN network driver support for Microchip MCP25XXFD CAN
> > Controller with MCP2517FD as the target controller version. This series is
> >
Hi,
On 0611, Marc Kleine-Budde wrote:
> On 6/10/20 9:44 AM, Manivannan Sadhasivam wrote:
> > Hello,
> >
> > This series adds CAN network driver support for Microchip MCP25XXFD CAN
> > Controller with MCP2517FD as the target controller version. This series is
> >
Add MAINTAINERS entry for Microchip MCP25XXFD CAN network driver.
Signed-off-by: Manivannan Sadhasivam
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index b816a453b10e..591b6fc2d83a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10360,6
tx fifos we can: send those 7 frames in 0.33ms and then we
wait for 0.26ms so that is a 56% duty cycle.
With 24 tx fifos this changes to: 1.19ms for 24 frames and then we
wait for 0.52ms so that is a 70% duty cycle.
Signed-off-by: Martin Sperl
Signed-off-by: Manivannan Sadhasivam
---
drivers
-by: Manivannan Sadhasivam
---
.../net/can/spi/mcp25xxfd/mcp25xxfd_can_tx.c | 33 +++
1 file changed, 33 insertions(+)
diff --git a/drivers/net/can/spi/mcp25xxfd/mcp25xxfd_can_tx.c
b/drivers/net/can/spi/mcp25xxfd/mcp25xxfd_can_tx.c
index 5ea1e525e776..6f066cb95844 100644
--- a
From: Martin Sperl
Add devicetree YAML bindings for Microchip MCP25XXFD CAN controller.
Signed-off-by: Martin Sperl
[mani: converted to YAML binding]
Signed-off-by: Manivannan Sadhasivam
---
.../bindings/net/can/microchip,mcp25xxfd.yaml | 82 +++
1 file changed, 82 insertions
[mani: misc cleanups for upstream]
Signed-off-by: Manivannan Sadhasivam
---
drivers/net/can/spi/mcp25xxfd/Makefile| 3 +
.../net/can/spi/mcp25xxfd/mcp25xxfd_base.c| 6 +
drivers/net/can/spi/mcp25xxfd/mcp25xxfd_can.c | 395 ++-
drivers/net/can/spi/mcp25xxfd/mcp25xxfd_can.h
.microchip.com/downloads/en/DeviceDoc/20005678A.pdf
Errata:
*
http://ww1.microchip.com/downloads/en/DeviceDoc/MCP2517FD-Silicon-Errata-and-Data-Sheet-Clarification-DS8792A.pdf
Signed-off-by: Martin Sperl
[mani: trimmed the gpio part and done some cleanups]
Signed-off-by: Manivannan Sadhasivam
amount of
cleanups. This series has been tested on 96Boards RB3 platform by myself and
Martin has tested the previous version on Rpi3 with external MCP2517FD
controller.
Thanks,
Mani
Manivannan Sadhasivam (1):
MAINTAINERS: Add entry for Microchip MCP25XXFD CAN network driver
Martin Sperl (5):
d
tx fifos we can: send those 7 frames in 0.33ms and then we
wait for 0.26ms so that is a 56% duty cycle.
With 24 tx fifos this changes to: 1.19ms for 24 frames and then we
wait for 0.52ms so that is a 70% duty cycle.
Signed-off-by: Martin Sperl
Signed-off-by: Manivannan Sadhasivam
---
drivers
[mani: misc cleanups for upstream]
Signed-off-by: Manivannan Sadhasivam
---
drivers/net/can/spi/mcp25xxfd/Makefile| 3 +
.../net/can/spi/mcp25xxfd/mcp25xxfd_base.c| 6 +
drivers/net/can/spi/mcp25xxfd/mcp25xxfd_can.c | 395 ++-
drivers/net/can/spi/mcp25xxfd/mcp25xxfd_can.h
.microchip.com/downloads/en/DeviceDoc/20005678A.pdf
Errata:
*
http://ww1.microchip.com/downloads/en/DeviceDoc/MCP2517FD-Silicon-Errata-and-Data-Sheet-Clarification-DS8792A.pdf
Signed-off-by: Martin Sperl
[mani: trimmed the gpio part and done some cleanups]
Signed-off-by: Manivannan Sadhasivam
From: Martin Sperl
Add devicetree YAML bindings for Microchip MCP25XXFD CAN controller.
Signed-off-by: Martin Sperl
[mani: converted to YAML binding]
Signed-off-by: Manivannan Sadhasivam
---
.../bindings/net/can/microchip,mcp25xxfd.yaml | 82 +++
1 file changed, 82 insertions
-by: Manivannan Sadhasivam
---
.../net/can/spi/mcp25xxfd/mcp25xxfd_can_tx.c | 33 +++
1 file changed, 33 insertions(+)
diff --git a/drivers/net/can/spi/mcp25xxfd/mcp25xxfd_can_tx.c
b/drivers/net/can/spi/mcp25xxfd/mcp25xxfd_can_tx.c
index 5ea1e525e776..6f066cb95844 100644
--- a
Add MAINTAINERS entry for Microchip MCP25XXFD CAN network driver.
Signed-off-by: Manivannan Sadhasivam
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index b816a453b10e..591b6fc2d83a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10360,6
amount of
cleanups and also preserved the authorship of Martin for all the patches he has
posted earlier. This series has been tested on 96Boards RB3 platform by myself
and Martin has tested the previous version on Rpi3 with external MCP2517FD
controller.
Thanks,
Mani
Manivannan Sadhasivam (1):
MAINTA
work and workqueue structs are
> allocated and initialized before qrtr_ns_data_ready can be called.
>
> Fixes: 0c2204a4ad71 ("net: qrtr: Migrate nameservice to kernel from
> userspace")
> Signed-off-by: Chris Lew
Reviewed-by: Manivannan Sadhasivam
Thanks,
Mani
> --
qrtr_local_enqueue().
Fixes: bdabad3e363d ("net: Add Qualcomm IPC router")
Reported-by: kbuild test robot
Reported-by: Julia Lawall
Signed-off-by: Manivannan Sadhasivam
---
net/qrtr/qrtr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c
index 7e
anks,
Mani
Changes in v2:
* Added cover letter
* Removed casting of void pointer.
Manivannan Sadhasivam (2):
net: qrtr: Add MHI transport layer
net: qrtr: Do not depend on ARCH_QCOM
net/qrtr/Kconfig | 8 ++-
net/qrtr/Makefile | 2 +
net/qrtr/mhi.
IPC Router protocol is also used by external modems for exchanging the QMI
messages. Hence, it doesn't always depend on Qualcomm platforms. One such
instance is the QCA6390 WLAN device connected to x86 machine.
Reviewed-by: Bjorn Andersson
Signed-off-by: Manivannan Sadhasivam
---
net
MHI is the transport layer used for communicating to the external modems.
Hence, this commit adds MHI transport layer support to QRTR for
transferring the QMI messages over IPC Router.
Reviewed-by: Bjorn Andersson
Signed-off-by: Manivannan Sadhasivam
---
net/qrtr/Kconfig | 7 +++
net/qrtr
IPC Router protocol is also used by external modems for exchanging the QMI
messages. Hence, it doesn't always depend on Qualcomm platforms. One such
instance is the QCA6390 WLAN device connected to x86 machine.
Reviewed-by: Bjorn Andersson
Signed-off-by: Manivannan Sadhasivam
---
net
MHI is the transport layer used for communicating to the external modems.
Hence, this commit adds MHI transport layer support to QRTR for
transferring the QMI messages over IPC Router.
Reviewed-by: Bjorn Andersson
Signed-off-by: Manivannan Sadhasivam
---
net/qrtr/Kconfig | 7 +++
net/qrtr
Hi Dave,
On Mon, Apr 27, 2020 at 01:28:28PM +0530, Manivannan Sadhasivam wrote:
> MHI is the transport layer used for communicating to the external modems.
> Hence, this commit adds MHI transport layer support to QRTR for
> transferring the QMI messages over IPC Router.
>
Can you p
99 matches
Mail list logo
