Hi Dave,
On Fri, Nov 10, 2017 at 8:39 AM, David Miller wrote:
> From: Manish Kurup
> Date: Fri, 10 Nov 2017 07:30:09 -0500
>
>> The last version I sent out (with changes for comments), was v10, But
>> I noticed that you applied v7 (without the reverse xmas tree patch on
&g
Hi Dave,
On Fri, Nov 10, 2017 at 12:53 AM, David Miller wrote:
> From: Manish Kurup
> Date: Tue, 7 Nov 2017 08:50:00 -0500
>
>> This commit consists of 3 patches:
>>
>> patch1 (1/3):
>> The VLAN action maintains one set of stats across all cores, and uses a
&
Hi Or,
On Wed, Nov 8, 2017 at 9:20 AM, Or Gerlitz wrote:
> On Wed, Nov 8, 2017 at 9:03 PM, Manish Kurup wrote:
>> The VLAN action maintains one set of stats across all cores, and uses a
>> spinlock to synchronize updates to it from the same. Changed this to use a
>>
Hi Dave,
On Wed, Nov 8, 2017 at 6:40 AM, Manish Kurup wrote:
> Hi Dave,
>
> On Tue, Nov 7, 2017 at 7:07 PM, David Miller wrote:
>>
>> From: Alexander Duyck
>> Date: Tue, 7 Nov 2017 08:54:20 -0800
>>
>> > Are we really going to be so strict about the
functions used by other modules, to use the RCU as
opposed to directly accessing the structure.
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish Kurup
---
include/net/tc_act/tc_vlan.h | 46 ++-
net/sched/act_vlan.c | 88
Modified netronome nfp flower action to use VLAN helper functions instead
of accessing/referencing TC act_vlan private structures directly.
Reviewed-by: Pieter Jansen van Vuuren
Signed-off-by: Manish Kurup
---
drivers/net/ethernet/netronome/nfp/flower/action.c | 5 ++---
1 file changed, 2
anish Kurup
Manish Kurup (3):
act_vlan: Change stats update to use per-core stats
nfp flower action: Modified to use VLAN helper functions
act_vlan: VLAN action rewrite to use RCU lock/unlock and update
drivers/net/ethernet/netronome/nfp/flower/action.c | 5 +-
include/net/tc_act/tc_v
The VLAN action maintains one set of stats across all cores, and uses a
spinlock to synchronize updates to it from the same. Changed this to use a
per-CPU stats context instead.
This change will result in better performance.
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish
Hi Dave,
On Tue, Nov 7, 2017 at 7:07 PM, David Miller wrote:
>
> From: Alexander Duyck
> Date: Tue, 7 Nov 2017 08:54:20 -0800
>
> > Are we really going to be so strict about the reverse xmas-tree that
> > we won't allow for assignment w/ variable declaration because the
> > dependency order won'
functions used by other modules, to use the RCU as
opposed to directly accessing the structure.
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish Kurup
---
include/net/tc_act/tc_vlan.h | 46 +--
net/sched/act_vlan.c | 75
Modified netronome nfp flower action to use VLAN helper functions instead
of accessing/referencing TC act_vlan private structures directly.
Reviewed-by: Pieter Jansen van Vuuren
Signed-off-by: Manish Kurup
---
drivers/net/ethernet/netronome/nfp/flower/action.c | 5 ++---
1 file changed, 2
The VLAN action maintains one set of stats across all cores, and uses a
spinlock to synchronize updates to it from the same. Changed this to use a
per-CPU stats context instead.
This change will result in better performance.
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish
, not required when dependencies
make it difficult to implement - Alexander D
v9: Cover letter subject change - Jamal
Reviewed-by: Pieter Jansen van Vuuren
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish Kurup
Manish Kurup (3):
act_vlan: Change stats update to use per
Modified netronome nfp flower action to use VLAN helper functions instead
of accessing/referencing TC act_vlan private structures directly.
Reviewed-by: Pieter Jansen van Vuuren
Signed-off-by: Manish Kurup
---
drivers/net/ethernet/netronome/nfp/flower/action.c | 5 ++---
1 file changed, 2
The VLAN action maintains one set of stats across all cores, and uses a
spinlock to synchronize updates to it from the same. Changed this to use a
per-CPU stats context instead.
This change will result in better performance.
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish
functions used by other modules, to use the RCU as
opposed to directly accessing the structure.
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish Kurup
---
include/net/tc_act/tc_vlan.h | 46 +--
net/sched/act_vlan.c | 75
, not required when dependencies
make it difficult to implement - Alexander D
Reviewed-by: Pieter Jansen van Vuuren
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish Kurup
Manish Kurup (3):
act_vlan: Change stats update to use per-core stats
nfp flower action: Modified t
functions used by other modules, to use the RCU as
opposed to directly accessing the structure.
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish Kurup
---
include/net/tc_act/tc_vlan.h | 46 +--
net/sched/act_vlan.c | 75
Modified netronome nfp flower action to use VLAN helper functions instead
of accessing/referencing TC act_vlan private structures directly.
Reviewed-by: Pieter Jansen van Vuuren
Signed-off-by: Manish Kurup
---
drivers/net/ethernet/netronome/nfp/flower/action.c | 5 ++---
1 file changed, 2
The VLAN action maintains one set of stats across all cores, and uses a
spinlock to synchronize updates to it from the same. Changed this to use a
per-CPU stats context instead.
This change will result in better performance.
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish
ed-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish Kurup
Manish Kurup (3):
act_vlan: Change stats update to use per-core stats
nfp flower action: Modified to use VLAN helper functions
act_vlan: VLAN action rewrite to use RCU lock/unlock and update
drivers/net/eth
Using a spinlock in the VLAN action causes performance issues when the VLAN
action is used on multiple cores. Rewrote the VLAN action to use RCU read
locking for reads and updates instead.
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish Kurup
---
include/net/tc_act
Modified netronome nfp flower action to use VLAN helper functions instead
of accessing the structure directly.
Signed-off-by: Manish Kurup
---
drivers/net/ethernet/netronome/nfp/flower/action.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet
r RCU alloc - Dave Miller
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish Kurup
Manish Kurup (3):
act_vlan: Change stats update to use per-core stats
nfp flower action: Modified to use VLAN helper functions
act_vlan: VLAN action rewrite to use RCU lock/unlock and u
The VLAN action maintains one set of stats across all cores, and uses a
spinlock to synchronize updates to it from the same. Changed this to use a
per-CPU stats context instead.
This change will result in better performance.
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish
Using a spinlock in the VLAN action causes performance issues when the VLAN
action is used on multiple cores. Rewrote the VLAN action to use RCU read
locking for reads and updates instead.
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish Kurup
---
include/net/tc_act
Modified netronome nfp flower action to use VLAN helper functions instead
of accessing the structure directly.
Signed-off-by: Manish Kurup
---
drivers/net/ethernet/netronome/nfp/flower/action.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet
The VLAN action maintains one set of stats across all cores, and uses a
spinlock to synchronize updates to it from the same. Changed this to use a
per-CPU stats context instead.
This change will result in better performance.
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish
The VLAN action maintains one set of stats across all cores, and uses a
spinlock to synchronize updates to it from the same. Changed this to use a
per-CPU stats context instead.
This change will result in better performance.
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish
ed-by: Jiri Pirko
Signed-off-by: Manish Kurup
Manish Kurup (3):
act_vlan: Change stats update to use per-core stats
nfp flower action: Modified to use VLAN helper functions
act_vlan: VLAN action rewrite to use RCU lock/unlock and update
drivers/net/ethernet/netronome/nfp/flower/action.c
Using a spinlock in the VLAN action causes performance issues when the VLAN
action is used on multiple cores. Rewrote the VLAN action to use RCU read
locking for reads and updates instead.
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish Kurup
---
include/net/tc_act
Modified netronome nfp flower action to use VLAN helper functions instead
of accessing the structure directly.
Signed-off-by: Manish Kurup
---
drivers/net/ethernet/netronome/nfp/flower/action.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet
The VLAN action maintains one set of stats across all cores, and uses a
spinlock to synchronize updates to it from the same. Changed this to use a
per-CPU stats context instead.
This change will result in better performance.
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish
ffice - Cong, Jiri
v4: Modified the nfp flower action code to use the VLAN helper functions
instead of referencing the structure directly. Isolated this into a
separate patch - Pieter Jansen
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish Kurup
Manish Kurup (3):
error).
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish Kurup
---
drivers/net/ethernet/netronome/nfp/flower/action.c | 5 +-
include/net/tc_act/tc_vlan.h | 46 ---
net/sched/act_vlan.c | 65
The VLAN action maintains one set of stats across all cores, and uses a
spinlock to synchronize updates to it from the same. Changed this to use a
per-CPU stats context instead.
This change will result in better performance.
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish
hould
suffice - Cong, Jiri
v3: Fixed a build break issue with nxp flower action. Modified the NXP flower
action code to use the VLAN helper functions instead of referencing the
structure directly. Found by kbuild robot.
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish
Using a spinlock in the VLAN action causes performance issues when the VLAN
action is used on multiple cores. Rewrote the VLAN action to use RCU read
locking for reads and updates instead.
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish Kurup
---
include/net/tc_act
The VLAN action maintains one set of stats across all cores, and uses a
spinlock to synchronize updates to it from the same. Changed this to use a
per-CPU stats context instead.
This change will result in better performance.
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish Kurup
Manish Kurup (2):
net sched act_vlan: Change stats update to use per-core stats
net sched act_vlan: VLAN action rewrite to use RCU lock/unlock and
update
include/net/tc_act/tc_vlan.h | 46 ++--
Using a spinlock in the VLAN action causes performance issues when the VLAN
action is used on multiple cores. Rewrote the VLAN action to use RCU read
locking for reads and updates instead.
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish Kurup
---
include/net/tc_act
e-christmas-tree
*> Removed mismatched spin_lock()
*> Removed spin_lock_bh() in tcf_vlan_init, rtnl_dereference() should suffice.
Thanks for all the comments!
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish Kurup
Manish Kurup (2):
net sched act_vlan: Change stats u
The VLAN action maintains one set of stats across all cores, and uses a
spinlock to synchronize updates to it from the same. Changed this to use a
per-CPU stats context instead.
This change will result in better performance.
Acked-by: Jamal Hadi Salim
Acked-by: Jiri Pirko
Signed-off-by: Manish
gt; Fixed indentation, extra line nits
*> Moved rcu_head to the end of the struct
*> Converted to reverse-christmas-tree
*> Removed mismatched spin_lock()
*> Removed spin_lock_bh() in tcf_vlan_init, rtnl_dereference() should suffice.
Thanks for all the comments!
Manish Kurup (2):
Using a spinlock in the VLAN action causes performance issues when the VLAN
action is used on multiple cores. Rewrote the VLAN action to use RCU read
locking for reads and updates instead.
Signed-off-by: Manish Kurup
---
include/net/tc_act/tc_vlan.h | 46 +--
net
The VLAN action maintains one set of stats across all cores, and uses a
spinlock to synchronize updates to it from the same. Changed this to use a
per-CPU stats context instead.
This change will result in better performance.
Signed-off-by: Manish Kurup
---
net/sched/act_vlan.c | 10
Using a spinlock in the VLAN action causes performance issues when the VLAN
action is used on multiple cores. Rewrote the VLAN action to use RCU read
locking for reads and updates instead.
Signed-off-by: Manish Kurup
---
include/net/tc_act/tc_vlan.h | 21 -
net/sched/act_vlan.c
The VLAN action maintains one set of stats across all cores, and uses a
spinlock to synchronize updates to it from the same. Changed this to use a
per-CPU stats context instead.
This change will result in better performance.
Signed-off-by: Manish Kurup
---
net/sched/act_vlan.c | 10
48 matches
Mail list logo
