RE: [EXT] [PATCH 2/2] qede: Use 'skb_add_rx_frag()' instead of hand coding it

2021-04-05 Thread Manish Chopra
skb_add_rx_frag(skb, skb_shinfo(skb)->nr_frags, bd->data, > + rxq->rx_headroom, cur_size, PAGE_SIZE); > > - skb->truesize += PAGE_SIZE; > - skb->data_len += cur_size; > - skb->len += cur_size; > pkt_len -= cur_size; > } > > -- > 2.27.0 Thank you Christophe. Acked-by: Manish Chopra

RE: [EXT] [PATCH 1/2] qede: Remove a erroneous ++ in 'qede_rx_build_jumbo()'

2021-04-05 Thread Manish Chopra
age(rxq->dev, bd->mapping, > PAGE_SIZE, DMA_FROM_DEVICE); > > - skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags++, > + skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags, > bd->data, rxq->rx_headroom, cur_size); > > skb->truesize += PAGE_SIZE; > -- > 2.27.0 Acked-by: Manish Chopra

[PATCH net 1/1] netxen_nic: fix MSI/MSI-x interrupts

2021-01-07 Thread Manish Chopra
. Fixes: b37eb210c076 ("netxen_nic: Avoid mixed mode interrupts") Signed-off-by: Manish Chopra Signed-off-by: Igor Russkikh --- drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/qlo

RE: [PATCH net 1/1] qede: fix offload for IPIP tunnel packets

2020-12-24 Thread Manish Chopra
> -Original Message- > From: Manish Chopra > Sent: Monday, December 21, 2020 8:26 PM > To: da...@davemloft.net > Cc: netdev@vger.kernel.org; Ariel Elior ; Igor Russkikh > ; Sudarsana Reddy Kalluru > Subject: [PATCH net 1/1] qede: fix offload for IPIP tunnel pack

[PATCH net 1/1] qede: fix offload for IPIP tunnel packets

2020-12-21 Thread Manish Chopra
IPIP tunnels packets are unknown to device, hence these packets are incorrectly parsed and caused the packet corruption, so disable offlods for such packets at run time. Signed-off-by: Manish Chopra Signed-off-by: Sudarsana Kalluru Signed-off-by: Igor Russkikh --- drivers/net/ethernet/qlogic

net DIM (Dynamic interrupt moderation) queries

2020-11-10 Thread Manish Chopra
Hello Tal, I looked through the documentation but some of the things were not cleared, so I am looking for some fine details on this topic if you could help please - Q1- In general, can this feature be problematic or not useful if device only support time based moderation but does not suppo

ndo_xdp_xmit - on which queue to transmit the packet (if core_id >= total_xdp_queues ) ?

2019-09-06 Thread Manish Chopra
aa2 seems to be handling this case by sending the packet on the queue (= smp_processor_id() % total_num_xdp_queues) but unsure what should be the expected behavior. Regards, Manish Chopra.

[PATCH net 1/1] bnx2x: Fix VF's VLAN reconfiguration in reload.

2019-08-18 Thread Manish Chopra
ich causes vlan PING to stop. This patch clears the vlan metadata/info so that VLANs gets re-configured back in the hardware in VF's reload flow and PING/traffic continues for VLANs created over the VFs. Fixes: 04f05230c5c13 ("bnx2x: Remove configured vlans as part of unload sequence.&

RE: [EXT] [PATCH] bnx2x: Prevent load reordering in tx completion processing

2019-07-18 Thread Manish Chopra
> -Original Message- > From: Brian King > Sent: Tuesday, July 16, 2019 3:12 AM > To: GR-everest-linux-l2 > Cc: Sudarsana Reddy Kalluru ; Ariel Elior > ; netdev@vger.kernel.org; Brian King > > Subject: [EXT] [PATCH] bnx2x: Prevent load reordering in tx completion > processing > > Externa

RE: [EXT] [PATCH net-next 16/16] qlge: Refill empty buffer queues from wq

2019-06-27 Thread Manish Chopra
> -Original Message- > From: Benjamin Poirier > Sent: Monday, June 17, 2019 1:19 PM > To: Manish Chopra ; GR-Linux-NIC-Dev nic-...@marvell.com>; netdev@vger.kernel.org > Subject: [EXT] [PATCH net-next 16/16] qlge: Refill empty buffer queues from > w

RE: [PATCH net-next 11/16] qlge: Remove qlge_bq.len & size

2019-06-27 Thread Manish Chopra
> > - for (i = 0; i < qdev->rx_ring_count; i++) { > + for (i = 0; i < qdev->rss_ring_count; i++) { > struct rx_ring *rx_ring = &qdev->rx_ring[i]; > > - if (rx_ring->lbq.queue) > - ql_free_lbq_buffers(qdev, rx_ring); > - if (rx_ring

RE: [EXT] [PATCH net-next 07/16] qlge: Deduplicate rx buffer queue management

2019-06-27 Thread Manish Chopra
> while (curr_idx != clean_idx) { > - lbq_desc = &rx_ring->lbq[curr_idx]; > + struct qlge_bq_desc *lbq_desc = &rx_ring- > >lbq.queue[curr_idx]; > > if (lbq_desc->p.pg_chunk.offset == last_offset) > - pci_unmap_page(qdev->pdev, lbq_des

RE: [PATCH net-next 01/16] qlge: Remove irq_cnt

2019-06-26 Thread Manish Chopra
> In msix mode there's no need to explicitly disable completion interrupts, they > are reliably auto-masked, according to my observations. > I tested this on two QLE8142 adapters. > > Do you have reason to believe this might not always be the case? How did you check auto-masking of MSI-X interrup

RE: [EXT] [PATCH net-next 05/16] qlge: Remove rx_ring.sbq_buf_size

2019-06-26 Thread Manish Chopra
> -Original Message- > From: Benjamin Poirier > Sent: Monday, June 17, 2019 1:19 PM > To: Manish Chopra ; GR-Linux-NIC-Dev nic-...@marvell.com>; netdev@vger.kernel.org > Subject: [EXT] [PATCH net-next 05/16] qlge: Remove rx_ring.sbq_buf_size &

RE: [PATCH net-next 04/16] qlge: Remove bq_desc.maplen

2019-06-26 Thread Manish Chopra
> -Original Message- > From: Benjamin Poirier > Sent: Monday, June 17, 2019 1:19 PM > To: Manish Chopra ; GR-Linux-NIC-Dev nic-...@marvell.com>; netdev@vger.kernel.org > Subject: [PATCH net-next 04/16] qlge: Remove bq_desc.maplen > > The size of the mapping is

RE: [EXT] [PATCH net-next 03/16] qlge: Deduplicate lbq_buf_size

2019-06-26 Thread Manish Chopra
> -Original Message- > From: Benjamin Poirier > Sent: Monday, June 17, 2019 1:19 PM > To: Manish Chopra ; GR-Linux-NIC-Dev nic-...@marvell.com>; netdev@vger.kernel.org > Subject: [EXT] [PATCH net-next 03/16] qlge: Deduplicate lbq_buf_size &

RE: [PATCH net-next 02/16] qlge: Remove page_chunk.last_flag

2019-06-26 Thread Manish Chopra
> -Original Message- > From: Benjamin Poirier > Sent: Monday, June 17, 2019 1:19 PM > To: Manish Chopra ; GR-Linux-NIC-Dev nic-...@marvell.com>; netdev@vger.kernel.org > Subject: [PATCH net-next 02/16] qlge: Remove page_chunk.last_flag > > As already done in ql

RE: [PATCH net-next 01/16] qlge: Remove irq_cnt

2019-06-26 Thread Manish Chopra
> -Original Message- > From: Benjamin Poirier > Sent: Monday, June 17, 2019 1:19 PM > To: Manish Chopra ; GR-Linux-NIC-Dev nic-...@marvell.com>; netdev@vger.kernel.org > Subject: [PATCH net-next 01/16] qlge: Remove irq_cnt > > qlge uses an irq enable/disable re

RE: [PATCH net-next 10/16] qlge: Factor out duplicated expression

2019-06-25 Thread Manish Chopra
> -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Benjamin Poirier > Sent: Monday, June 24, 2019 1:22 PM > To: David Miller > Cc: Manish Chopra ; GR-Linux-NIC-Dev nic-...@marvell.com>; netdev@vger.kernel.org > Subject: Re: [PATCH net-next

RE: [PATCH net-next 01/16] qlge: Remove irq_cnt

2019-06-17 Thread Manish Chopra
> -Original Message- > From: Benjamin Poirier > Sent: Monday, June 17, 2019 1:19 PM > To: Manish Chopra ; GR-Linux-NIC-Dev nic-...@marvell.com>; netdev@vger.kernel.org > Subject: [PATCH net-next 01/16] qlge: Remove irq_cnt > > qlge uses an irq enable/disable re

RE: [EXT] [PATCH net-next 06/16] qlge: Remove useless dma synchronization calls

2019-06-17 Thread Manish Chopra
> -Original Message- > From: Benjamin Poirier > Sent: Monday, June 17, 2019 1:19 PM > To: Manish Chopra ; GR-Linux-NIC-Dev nic-...@marvell.com>; netdev@vger.kernel.org > Subject: [EXT] [PATCH net-next 06/16] qlge: Remove useless dma > synchronization call

[PATCH net 4/6] qede: Fix system crash on configuring channels.

2019-02-06 Thread Manish Chopra
From: Sudarsana Reddy Kalluru Under heavy traffic load, when changing number of channels via ethtool (ethtool -L) which will cause interface to be reloaded, it was observed that some packets gets transmitted on old TX channel/queue id which doesn't really exist after the channel configuration lea

[PATCH net 2/6] qed: Assign UFP TC value to vlan priority in UFP mode.

2019-02-06 Thread Manish Chopra
From: Sudarsana Reddy Kalluru In the case of Unified Fabric Port (UFP) mode, switch provides the traffic class (TC) value to be used for the traffic. Configure hardware to use this TC value for vlan priority. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- drivers/net/et

[PATCH net 5/6] qed: Change verbosity for coalescing message.

2019-02-06 Thread Manish Chopra
From: Rahul Verma Fix unnecessary logging of message in an expected default case where coalescing value read (via ethtool -c) migh not be valid unless they are configured explicitly in the hardware using ethtool -C. Signed-off-by: Rahul Verma Signed-off-by: Manish Chopra Signed-off-by: Ariel

[PATCH net 3/6] qed: Consider TX tcs while deriving the max num_queues for PF.

2019-02-06 Thread Manish Chopra
From: Sudarsana Reddy Kalluru Max supported queues is derived incorrectly in the case of multi-CoS. Need to consider TCs while calculating num_queues for PF. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_l2.c | 5 +++-- 1 file change

[PATCH net 6/6] qed*: Advance drivers version to 8.37.0.20

2019-02-06 Thread Manish Chopra
Version update for qed/qede modules. Signed-off-by: Manish Chopra Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed.h | 2 +- drivers/net/ethernet/qlogic/qede/qede.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed.h

[PATCH net 1/6] qed: Fix EQ full firmware assert.

2019-02-06 Thread Manish Chopra
: Manish Chopra Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_sp.h | 1 + drivers/net/ethernet/qlogic/qed/qed_spq.c | 15 +++ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_sp.h b/drivers/net/ethernet/qlogic/qed

[PATCH net 0/6] qed*: Bug fixes.

2019-02-06 Thread Manish Chopra
Hi David, This series contains general qed/qede fixes. Please consider applying this to "net" Thanks, Manish Manish Chopra (2): qed: Fix EQ full firmware assert. qed*: Advance drivers version to 8.37.0.20 Rahul Verma (1): qed: Change verbosity for coalescing message. Sudar

[PATCH net 4/5] qed: Fix system crash in ll2 xmit

2019-01-28 Thread Manish Chopra
Cache number of fragments in the skb locally as in case of linear skb (with zero fragments), tx completion (or freeing of skb) may happen before driver tries to get number of frgaments from the skb which could lead to stale access to an already freed skb. Signed-off-by: Manish Chopra Signed-off

[PATCH net 3/5] qed: Fix VF probe failure while FLR

2019-01-28 Thread Manish Chopra
as VF is marked disabled from HW perspective due to FLR, which will result into channel timeout and VF probe failure. In such cases, try retrying VF "acquire" message so that in later attempts it could be successful to pass message to PF after the VF FLR is completed and can be probed s

[PATCH net 1/5] qed: Fix bug in tx promiscuous mode settings

2019-01-28 Thread Manish Chopra
ckets. Later, it was found that driver doesn't really configure tx promiscuous mode settings to accept all unknown unicast macs. This patch fixes tx promiscuous mode settings to accept all unknown/unmatched unicast macs and works out the scenario. Signed-off-by: Manish Chopra Signed-off-by: A

[PATCH net 2/5] qed: Fix LACP pdu drops for VFs

2019-01-28 Thread Manish Chopra
pass the control frames such as LACP pdus. Signed-off-by: Manish Chopra Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_l2.c| 5 + drivers/net/ethernet/qlogic/qed/qed_l2.h| 3 +++ drivers/net/ethernet/qlogic/qed/qed_sriov.c | 10 -- 3 files changed, 16

[PATCH net 5/5] qed: Fix stack out of bounds bug

2019-01-28 Thread Manish Chopra
00 00 00 [ 196.624995] == Signed-off-by: Manish Chopra Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_dev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/q

[PATCH net 0/5] qed: Bug fixes

2019-01-28 Thread Manish Chopra
From: Manish Hi David, This series have SR-IOV and some general fixes. Please consider applying it to "net" Regards, Manish Manish Chopra (5): qed: Fix bug in tx promiscuous mode settings qed: Fix LACP pdu drops for VFs qed: Fix VF probe failure while FLR qed: Fix system cr

[PATCH net 1/1] qlge: Fix netdev features configuration.

2018-08-23 Thread Manish Chopra
qlge_fix_features() is not supposed to modify hardware or driver state, rather it is supposed to only fix requested fetures bits. Currently qlge_fix_features() also goes for interface down and up unnecessarily if there is not even any change in features set. This patch changes/fixes following - 1

[PATCH net 1/1] qlge: Fix netdev features configuration.

2018-08-23 Thread Manish Chopra
qlge_fix_features() is not supposed to modify hardware or driver state, rather it is supposed to only fix requested fetures bits. Currently qlge_fix_features() also goes for interface down and up unnecessarily if there is not even any change in features set. This patch changes/fixes following - 1

[PATCH net-next 3/3] qede: Ingress tc flower offload (drop action) support.

2018-08-09 Thread Manish Chopra
nt : flower \ skip_sw ip_proto tcp dst_port 98 action drop Signed-off-by: Manish Chopra Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qede/qede.h | 7 +- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 2 +- drivers/net/ethernet/qlogic/qede/qede_

[PATCH net-next 2/3] qede: Add destination ip based flow profile.

2018-08-09 Thread Manish Chopra
action -1 ethtool -N p5p1 flow-type udp4 dst-ip 192.168.50.100 action 1 ethtool -N p5p1 flow-type tcp4 dst-ip 192.168.60.100 action 0x1 Signed-off-by: Manish Chopra Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qede/qede_filter.c | 114 ++--- 1 file changed

[PATCH net-next 1/3] qed/qede: Multi CoS support.

2018-08-09 Thread Manish Chopra
hardware queues respectively. Signed-off-by: Manish Chopra Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_l2.c| 9 +- drivers/net/ethernet/qlogic/qed/qed_main.c | 5 +- drivers/net/ethernet/qlogic/qede/qede.h | 13 +++ drivers/net/ethernet/qlogic

[PATCH net-next 0/3] qed*: Enhancements

2018-08-09 Thread Manish Chopra
Hi David, This patch series adds following support in drivers - 1. Egress mqprio offload. 2. Add destination IP based flow profile. 3. Ingress flower offload (for drop action). Please consider applying this series to "net-next". Thanks, Manish Manish Chopra (3): qed/qede: Multi C

[PATCH net-next 4/5] qede: Support flow classification to the VFs.

2018-05-24 Thread Manish Chopra
src-ip 192.16.6.10 action 0x2 ethtool -U p5p1 flow-type tcp4 src-ip 192.168.40.100 dst-ip \ 192.168.40.200 src-port 6660 dst-port 5550 \ action 0x10000 Signed-off-by: Manish Chopra Signed-off-by: Shahed Shaikh Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogi

[PATCH net-next 5/5] qed*: Support drop action classification

2018-05-24 Thread Manish Chopra
action -1 Signed-off-by: Manish Chopra Signed-off-by: Shahed Shaikh Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_l2.c| 35 ++--- drivers/net/ethernet/qlogic/qede/qede.h | 1 + drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 1 + d

[PATCH net-next 2/5] qede: Validate unsupported configurations

2018-05-24 Thread Manish Chopra
Validate and prevent some of the configurations for unsupported [by firmware] inputs [for example - mac ext, vlans, masks/prefix, tos/tclass] via ethtool -N/-U. Signed-off-by: Manish Chopra Signed-off-by: Shahed Shaikh Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qede

[PATCH net-next 1/5] qede: Refactor ethtool rx classification flow.

2018-05-24 Thread Manish Chopra
This patch simplifies the ethtool rx flow configuration [via ethtool -U/-N] flow code base by dividing it logically into various APIs based on given protocols. It also separates various validations and calculations done along the flow in their own APIs. Signed-off-by: Manish Chopra Signed-off-by

[PATCH net-next 3/5] qed*: Support other classification modes.

2018-05-24 Thread Manish Chopra
action 1 ethtool -N enp7s0f0 flow-type udp6 dst-port 45762 action 3 Signed-off-by: Manish Chopra Signed-off-by: Shahed Shaikh Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_l2.c | 2 ++ drivers/net/ethernet/qlogic/qede/qede_filter.c | 31

[PATCH net-next 0/5] qed*: ethtool rx flow classification enhancements.

2018-05-24 Thread Manish Chopra
Hi David, This series re-structures the driver's ethtool rx flow classification flow, following that it adds other flow profiles and rx flow classification enhancements via "ethtool -N/-U" Please consider applying this to "net-next" Thanks, Manish Manish Chopra (5):

[PATCH net-next 1/1] qede: Add build_skb() support.

2018-05-17 Thread Manish Chopra
0.006.190.00 0.00 69.19 Signed-off-by: Ariel Elior Signed-off-by: Manish Chopra --- drivers/net/ethernet/qlogic/qede/qede.h | 5 +- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 3 +- drivers/net/ethernet/qlogic/qede/qede_fp.c | 227 +--- driver

[PATCH net 1/1] qede: Do not drop rx-checksum invalidated packets.

2018-03-28 Thread Manish Chopra
Today, driver drops received packets which are indicated as invalid checksum by the device. Instead of dropping such packets, pass them to the stack with CHECKSUM_NONE indication in skb. Signed-off-by: Ariel Elior Signed-off-by: Manish Chopra --- drivers/net/ethernet/qlogic/qede/qede_fp.c

[PATCH v2 net 1/1] qede: Fix barrier usage after tx doorbell write.

2018-03-27 Thread Manish Chopra
uot; in patchwork. (Not really sure for what reason).Resending it as v2. Signed-off-by: Ariel Elior Signed-off-by: Manish Chopra --- drivers/net/ethernet/qlogic/qede/qede_fp.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qede/q

[PATCH net 1/1] qede: Fix barrier usage after tx doorbell write.

2018-03-16 Thread Manish Chopra
ver on x86 mmiowb() does not flush the write combined buffer. This patch fixes this problem by replacing mmiowb() with wmb() after the write combined doorbell write so that writes are flushed and synchronized from more than one processor. Signed-off-by: Ariel Elior Signed-off-by: Manish Chopra --- d

[PATCH v2 net-next 0/7] qed/qede: Enhancements

2017-07-26 Thread Manish Chopra
ror=implicit-function-declaration] Thanks, Manish Manish Chopra (2): qede: Add getter APIs support for RX flow classification qed/qede: Add setter APIs support for RX flow classification Rahul Verma (3): qed: Add support for vf coalesce configuration. qed: Read per queue coalesce from hardw

[PATCH v2 net-next 3/7] qed: Add support for Energy efficient ethernet.

2017-07-26 Thread Manish Chopra
From: Sudarsana Reddy Kalluru The patch adds required driver support for reading/configuring the Energy Efficient Ethernet (EEE) parameters. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_dev.c | 72 ++-- dr

[PATCH v2 net-next 7/7] qed: enhanced per queue max coalesce value.

2017-07-26 Thread Manish Chopra
From: Rahul Verma Maximum coalesce per Rx/Tx queue is extended from 255 to 511. Signed-off-by: Rahul Verma Signed-off-by: Yuval Mintz --- include/linux/qed/qed_if.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/linux/qed/qed_if.h b/include/linux/qed/qed_if.

[PATCH v2 net-next 4/7] qede: Add ethtool support for Energy efficient ethernet.

2017-07-26 Thread Manish Chopra
From: Sudarsana Reddy Kalluru The patch adds ethtool callback implementations for querying/configuring the Energy Efficient Ethernet (EEE) parameters. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 84 +

[PATCH v2 net-next 1/7] qede: Add getter APIs support for RX flow classification

2017-07-26 Thread Manish Chopra
This patch adds support for ethtool getter APIs to query RX flow classification rules. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede.h | 10 ++- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 22 - drivers/net/ethernet

[PATCH v2 net-next 6/7] qed: Read per queue coalesce from hardware

2017-07-26 Thread Manish Chopra
From: Rahul Verma Retrieve the actual coalesce value from hardware for every Rx/Tx queue, instead of Rx/Tx coalesce value cached during set coalesce. Signed-off-by: Rahul Verma Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_dev_api.h | 26 -- drivers/net/ethernet/q

[PATCH v2 net-next 5/7] qed: Add support for vf coalesce configuration.

2017-07-26 Thread Manish Chopra
From: Rahul Verma This patch add the ethtool support to set RX/Tx coalesce value to the VF associated Rx/Tx queues. Signed-off-by: Rahul Verma Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_dev.c | 73 +--- drivers/net/ethernet/qlogic/qed/qed_dev_ap

[PATCH v2 net-next 2/7] qed/qede: Add setter APIs support for RX flow classification

2017-07-26 Thread Manish Chopra
This patch adds support for adding and deleting rx flow classification rules. Using this user can classify RX flow constituting of TCP/UDP 4-tuples [src_ip/dst_ip and src_port/dst_port] to be steered on a given RX queue Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net

[PATCH net-next 3/7] qed: Add support for Energy efficient ethernet.

2017-06-30 Thread Manish Chopra
From: Sudarsana Reddy Kalluru The patch adds required driver support for reading/configuring the Energy Efficient Ethernet (EEE) parameters. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_dev.c | 72 -- dr

[PATCH net-next 6/7] qed/qede: Read per queue coalesce from hardware

2017-06-30 Thread Manish Chopra
From: Rahul Verma Retrieve the actual coalesce value from hardware for every Rx/Tx queue, instead of Rx/Tx coalesce value cached during set coalesce. Signed-off-by: Rahul Verma Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_dev_api.h | 26 -- drivers/net/ethernet/ql

[PATCH net-next 5/7] qed/qede: Add support for vf coalesce configuration.

2017-06-30 Thread Manish Chopra
From: Rahul Verma This patch add the ethtool support to set RX/Tx coalesce value to the VF associated Rx/Tx queues. Signed-off-by: Rahul Verma Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_dev.c | 73 +++--- drivers/net/ethernet/qlogic/qed/qed_dev_ap

[PATCH net-next 0/7] qed/qede: Enhancements

2017-06-30 Thread Manish Chopra
"net-next" Thanks, Manish Manish Chopra (2): qede: Add getter APIs support for RX flow classification qed/qede: Add setter APIs support for RX flow classification Rahul Verma (3): qed/qede: Add support for vf coalesce configuration. qed/qede: Read per queue coalesce from hard

[PATCH net-next 4/7] qede: Add ethtool support for Energy efficient ethernet.

2017-06-30 Thread Manish Chopra
From: Sudarsana Reddy Kalluru The patch adds ethtool callback implementations for querying/configuring the Energy Efficient Ethernet (EEE) parameters. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 84 +++

[PATCH net-next 1/7] qede: Add getter APIs support for RX flow classification

2017-06-30 Thread Manish Chopra
This patch adds support for ethtool getter APIs to query RX flow classification rules. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede.h | 10 +- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 22 - drivers/net/ethernet/qlogic

[PATCH net-next 2/7] qed/qede: Add setter APIs support for RX flow classification

2017-06-30 Thread Manish Chopra
This patch adds support for adding and deleting rx flow classification rules. Using this user can classify RX flow constituting of TCP/UDP 4-tuples [src_ip/dst_ip and src_port/dst_port] to be steered on a given RX queue Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net

[PATCH net-next 7/7] qed: Increase per queue max coalesce value.

2017-06-30 Thread Manish Chopra
From: Rahul Verma Maximum coalesce per Rx/Tx queue is extended from 255 to 511. Signed-off-by: Rahul Verma Signed-off-by: Yuval Mintz --- include/linux/qed/qed_if.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/qed/qed_if.h b/include/linux/qed/qed_if.h inde

[PATCH net 1/1] qlcnic: Fix tunnel offload for 82xx adapters

2017-06-02 Thread Manish Chopra
Qlogic's 82xx series adapter doesn't support tunnel offloads, driver incorrectly assumes that it is supported and causes firmware hang while running tunnel IO. This patch fixes this by not advertising tunnel offloads for 82xx adapters. Signed-off-by: Manish Chopra --- drivers/ne

[PATCH net 2/2] qlcnic: Update version to 5.3.66

2017-05-11 Thread Manish Chopra
Bumping up the version as couple of fixes added after 5.3.65 Signed-off-by: Manish Chopra --- drivers/net/ethernet/qlogic/qlcnic/qlcnic.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h b/drivers/net/ethernet/qlogic/qlcnic

[PATCH net 0/2] qlcnic: Bug fix and update version

2017-05-11 Thread Manish Chopra
Hi David, This series has one fix and bumps up driver version. Please consider applying to "net" Thanks, Manish Manish Chopra (2): qlcnic: Fix link configuration with autoneg disabled qlcnic: Update version to 5.3.66 drivers/net/ethernet/qlogic/qlcnic/qlcnic.h| 4 +-

[PATCH net 1/2] qlcnic: Fix link configuration with autoneg disabled

2017-05-11 Thread Manish Chopra
types from hardware before any speed/autoneg configuration. Signed-off-by: Manish Chopra --- .../net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c| 34 ++ .../net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h| 1 + .../net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c| 3 ++ 3 fil

[PATCH net-next 5/6] qed/qede: Add UDP ports in bulletin board

2017-04-24 Thread Manish Chopra
This patch adds support for UDP ports in bulletin board to notify UDP ports change to the VFs Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_l2.c | 19 +++ drivers/net/ethernet/qlogic/qed/qed_sriov.c| 23

[PATCH net-next 6/6] qed - VF tunnelling support [VXLAN/GENEVE/GRE]

2017-04-24 Thread Manish Chopra
, although PF and it's child VFs share the same port. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed.h | 1 + drivers/net/ethernet/qlogic/qed/qed_dev.c | 15 +- drivers/net/ethernet/qlogic/qed/qed_l2.c | 3 - driver

[PATCH net-next 3/6] qede: Disable tunnel offloads for non offloaded UDP ports

2017-04-24 Thread Manish Chopra
This patch disables tunnel offloads via ndo_features_check() if given UDP port is not offloaded to hardware. This in turn allows to run multiple tunnel interfaces using different UDP ports. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede_fp.c

[PATCH net-next 4/6] qede: Configure UDP ports in local context.

2017-04-24 Thread Manish Chopra
This patch configures UDP ports locally instead of configuring them in deferred context which would be helpful in synchronizing UDP ports configuration for VFs which will be enabled in further patches. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede

[PATCH net-next 2/6] qed/qede: Enable tunnel offloads based on hw configuration

2017-04-24 Thread Manish Chopra
This patch enables tunnel feature offloads based on hw configuration at initialization time instead of enabling them always. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_main.c | 15 +++ drivers/net/ethernet/qlogic/qede

[PATCH net-next 0/6] qed/qede: VF tunnelling support

2017-04-24 Thread Manish Chopra
Hi David, With this series VFs can run vxlan/geneve/gre tunnels over it. Please consider applying this series to "net-next" Thanks, Manish Manish Chopra (6): qed: refactor tunnelling - API/Structs qed/qede: Enable tunnel offloads based on hw configuration qede: Disable tunnel of

[PATCH net-next 1/6] qed: refactor tunnelling - API/Structs

2017-04-24 Thread Manish Chopra
This patch changes the tunnel APIs to use per tunnel info instead of using bitmasks for all tunnels and also uses single struct to hold the data to prepare multiple variant of tunnel configuration ramrods to be sent to the hardware. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz

[PATCH net-next 2/2] qede: Add aRFS support

2017-04-13 Thread Manish Chopra
This patch adds support for aRFS for TCP and UDP protocols with IPv4/IPv6. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede.h| 22 +- drivers/net/ethernet/qlogic/qede/qede_filter.c | 441 + drivers/net/ethernet

[PATCH net-next 1/2] qed: aRFS infrastructure support

2017-04-13 Thread Manish Chopra
This patch adds necessary APIs to interface with qede aRFS support in successive patch. It also reserves separate PTT entry for aRFS, [as being in fastpath flow] for hardware access instead of trying to acquire it at run time from the ptt pool. Signed-off-by: Manish Chopra Signed-off-by: Yuval

[PATCH net-next 0/2] qed/qede: aRFS support

2017-04-13 Thread Manish Chopra
Hi David, This series adds support for Accelerated Flow Steering in qede driver for TCP/UDP over IPv4/IPv6 protocols. Please consider applying this series to "net-next" Thanks, Manish Manish Chopra (2): qed: aRFS infrastructure support qede: Add aRFS support drivers/net/ether

[PATCH v3 net-next 6/7] qed: Handle malicious VFs events

2016-10-14 Thread Manish Chopra
From: Yuval Mintz Malicious VFs might be caught in several different methods: - Misusing their bar permission and being blocked by hardware. - Misusing their fastpath logic and being blocked by firmware. - Misusing their interaction with their PF via hw-channel, and being blocked by PF

[PATCH v3 net-next 2/7] qede: GSO support for tunnels with outer csum

2016-10-14 Thread Manish Chopra
From: Manish Chopra This patch adds GSO support for GRE and UDP tunnels where outer checksums are enabled. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede.h | 1 + drivers/net/ethernet/qlogic/qede/qede_main.c | 26

[PATCH v3 net-next 3/7] qede: Prevent GSO on long Geneve headers

2016-10-14 Thread Manish Chopra
From: Manish Chopra Due to hardware limitation, when transmitting a geneve-encapsulated packet with more than 32 bytes worth of geneve options the hardware would not be able to crack the packet and consider it a regular UDP packet. This implements the ndo_features_check() in qede in order to

[PATCH v3 net-next 1/7] qed: Pass MAC hints to VFs

2016-10-14 Thread Manish Chopra
From: Yuval Mintz Some hypervisors can support MAC hints to their VFs. Even though we don't have such a hypervisor API in linux, we add sufficient logic for the VF to be able to receive such hints and set the mac accordingly - as long as the VF has not been set with a MAC already. Signed-off-by:

[PATCH v3 net-next 5/7] qed: Allow chance for fast ramrod completions

2016-10-14 Thread Manish Chopra
From: Yuval Mintz Whenever a ramrod is being sent for some device configuration, the driver is going to sleep at least 5ms between each iteration of polling on the completion of the ramrod. However, in almost every configuration scenario the firmware would be able to comply and complete the ramr

[PATCH v3 net-next 4/7] qed*: Allow unicast filtering

2016-10-14 Thread Manish Chopra
From: Yuval Mintz Apparently qede fails to set IFF_UNICAST_FLT, and as a result is not actually performing unicast MAC filtering. While we're at it - relax a hard-coded limitation that limits each interface into using at most 15 unicast MAC addresses before turning promiscuous. Instead utilize th

[PATCH v3 net-next 0/7] qed*: driver updates

2016-10-14 Thread Manish Chopra
From: Manish Chopra Hi David, There are several new additions in this series; Most are connected to either Tx offloading or Rx classifications [either fastpath changes or supporting configuration]. In addition, there's a single IOV enhancement. Please consider applying this series to

[PATCH v3 net-next 7/7] qed: Fix possible race when reading firmware return code.

2016-10-14 Thread Manish Chopra
From: Manish Chopra While handling SPQ ramrod completion, there is a possible race where driver might not read updated fw return code based on ramrod completion done. This patch ensures that fw return code is written first and then completion done flag is updated using appropriate memory

[PATCH v2 net-next 0/7] qed*: driver updates

2016-10-13 Thread Manish Chopra
From: Manish Chopra Hi David, There are several new additions in this series; Most are connected to either Tx offloading or Rx classifications [either fastpath changes or supporting configuration]. In addition, there's a single IOV enhancement. Please consider applying this series to

[PATCH v2 net-next 5/7] qed: Allow chance for fast ramrod completions

2016-10-13 Thread Manish Chopra
From: Yuval Mintz Whenever a ramrod is being sent for some device configuration, the driver is going to sleep at least 5ms between each iteration of polling on the completion of the ramrod. However, in almost every configuration scenario the firmware would be able to comply and complete the ramr

[PATCH v2 net-next 3/7] qede: Prevent GSO on long Geneve headers

2016-10-13 Thread Manish Chopra
From: Manish Chopra Due to hardware limitation, when transmitting a geneve-encapsulated packet with more than 32 bytes worth of geneve options the hardware would not be able to crack the packet and consider it a regular UDP packet. This implements the ndo_features_check() in qede in order to

[PATCH v2 net-next 6/7] qed: Handle malicious VFs events

2016-10-13 Thread Manish Chopra
From: Yuval Mintz Malicious VFs might be caught in several different methods: - Misusing their bar permission and being blocked by hardware. - Misusing their fastpath logic and being blocked by firmware. - Misusing their interaction with their PF via hw-channel, and being blocked by PF

[PATCH v2 net-next 7/7] qed: Fix possible race when reading firmware return code.

2016-10-13 Thread Manish Chopra
From: Manish Chopra While handling SPQ ramrod completion, there is a possible race where driver might not read updated fw return code based on ramrod completion done. This patch ensures that fw return code is written first and then completion done flag is updated using appropriate memory

[PATCH v2 net-next 4/7] qed*: Allow unicast filtering

2016-10-13 Thread Manish Chopra
From: Yuval Mintz Apparently qede fails to set IFF_UNICAST_FLT, and as a result is not actually performing unicast MAC filtering. While we're at it - relax a hard-coded limitation that limits each interface into using at most 15 unicast MAC addresses before turning promiscuous. Instead utilize th

[PATCH v2 net-next 1/7] qed: Pass MAC hints to VFs

2016-10-13 Thread Manish Chopra
From: Yuval Mintz Some hypervisors can support MAC hints to their VFs. Even though we don't have such a hypervisor API in linux, we add sufficient logic for the VF to be able to receive such hints and set the mac accordingly - as long as the VF has not been set with a MAC already. Signed-off-by:

[PATCH v2 net-next 2/7] qede: GSO support for tunnels with outer csum

2016-10-13 Thread Manish Chopra
From: Manish Chopra This patch adds GSO support for GRE and UDP tunnels where outer checksums are enabled. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede.h | 1 + drivers/net/ethernet/qlogic/qede/qede_main.c | 26

[PATCH net 2/3] qlcnic: fix napi budget alteration

2016-08-03 Thread Manish Chopra
Driver modifies the supplied NAPI budget in qlcnic_83xx_msix_tx_poll() function. Instead, it should use the budget as it is. Signed-off-by: Manish Chopra --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net

[PATCH net 3/3] qlcnic: Update version to 5.3.65

2016-08-03 Thread Manish Chopra
Signed-off-by: Manish Chopra --- drivers/net/ethernet/qlogic/qlcnic/qlcnic.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h b/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h index fd973f4..49bad00 100644 --- a/drivers/net

[PATCH net 0/3] qlcnic: bug fixes

2016-08-03 Thread Manish Chopra
Hi David, This series fixes a data structure corruption bug in VF's async mailbox commands handling and an issue realted to napi poll budget in the driver. Please consider applying this series to "net" Thanks, Manish Manish Chopra (3): qlcnic: fix data structure corrupti

[PATCH net 1/3] qlcnic: fix data structure corruption in async mbx command handling

2016-08-03 Thread Manish Chopra
: Rajesh Borundia Signed-off-by: Sony Chacko Signed-off-by: Manish Chopra --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov.h |9 +- .../ethernet/qlogic/qlcnic/qlcnic_sriov_common.c | 95 +++ 2 files changed, 60 insertions(+), 44 deletions(-) diff --git a/drivers/net

  1   2   >