Re: [PATCH] Revert "can: dev: __can_get_echo_skb(): print error message, if trying to echo non existing skb"

 Manfred Schlaegl | Leitung Entwicklung Linz  GINZINGER ELECTRONIC SYSTEMS GMBH Tel.: +43 7723 5422 153 Mobil: +43 676 841 208 253 Mail: manfred.schla...@ginzinger.com Web: www.ginzinger.com On 04.01.19 16:23, Marc Kleine-Budde wrote: > On 12/19/18 7:39 PM, Manfred Schlaegl wrote: >

[PATCH] Revert "can: dev: __can_get_echo_skb(): print error message, if trying to echo non existing skb"

set priv->echo_skb[idx]. It is therefore kept NULL. (As additional argument for revert: The order of check and usage of idx was changed. idx is used to access an array element before checking it's boundaries) Signed-off-by: Manfred Schlaegl --- drivers/net/can/dev.c | 27 +-

Re: [PATCH] net: fec: hard phy reset on open

t; >> This patch saves the reset dt properties on probe and does a reset on every >> open after clocks where enabled, to make sure the clock is stable while and >> after hard reset. >> >> Tested on i.MX6 and i.MX28, both using LAN8720. >> >> Signed-off-by:

[PATCH] net: fec: hard phy reset on open

clocks where enabled, to make sure the clock is stable while and after hard reset. Tested on i.MX6 and i.MX28, both using LAN8720. Signed-off-by: Manfred Schlaegl --- drivers/net/ethernet/freescale/fec.h | 4 ++ drivers/net/ethernet/freescale/fec_main.c | 77 +-- 2

[PATCH] net: phy: smsc: reintroduced unconditional soft reset

on. It was tested on linux-4.1.25 and linux-4.7.0-rc2. Signed-off-by: Manfred Schlaegl --- drivers/net/phy/smsc.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c index 2e21e93..b62c4aa 100644 --- a/drivers/net/

Re: [PATCH - regression 4.1-rc8] can: fix loss of CAN frames in raw_rcv

Hello Oliver, On 2015-06-22 12:34, Oliver Hartkopp wrote: > Hello Manfred, > > On 22.06.2015 12:10, Manfred Schlaegl wrote: >> On 2015-06-21 18:50, Oliver Hartkopp wrote: >>> As reported by Manfred Schlaegl here >>> >>> http://marc.info/?l=linux-n

Re: [PATCH - regression 4.1-rc8] can: fix loss of CAN frames in raw_rcv

Hello! On 2015-06-21 18:50, Oliver Hartkopp wrote: > As reported by Manfred Schlaegl here > >http://marc.info/?l=linux-netdev&m=143482089824232&w=2 > > commit 514ac99c64b "can: fix multiple delivery of a single CAN frame for > overlapping CAN filters" r

Re: [PATCH] can: fix loss of frames due to wrong assumption in raw_rcv

Hello Oliver, On 2015-06-21 00:42, Oliver Hartkopp wrote: >> 514ac99c64b22d83b52dfee3b8becaa69a92bc4a introduces a frame equality >> check. Since the sk_buff pointer is not sufficient to do this (buffers >> are reused), the check also compares time stamps. >> In short: pointer+time stamp was assu

[PATCH] can: fix loss of frames due to wrong assumption in raw_rcv

equality check is ensured. I'm not really deep in linux network subsystem, so there may exists more elegant solutions for the problem. Signed-off-by: Manfred Schlaegl --- drivers/net/can/dev.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/can/dev.c b/drivers/net/can