Re: Regarding possible bug in net/wan/x25_asy.c

2020-08-26 Thread Madhuparna Bhowmik
On Mon, Aug 24, 2020 at 01:49:04PM -0700, Xie He wrote: > On Mon, Aug 24, 2020 at 7:13 AM Madhuparna Bhowmik > wrote: > > > > Sure, I had a look at it and since you are already working on fixing > > this driver, don't think there is a need for a patch to fix the >

Re: Regarding possible bug in net/wan/x25_asy.c

2020-08-24 Thread Madhuparna Bhowmik
On Sun, Aug 23, 2020 at 12:12:01PM -0700, Xie He wrote: > On Sun, Aug 23, 2020 at 8:28 AM Madhuparna Bhowmik > wrote: > > > > sl->xhead is modified in both x25_asy_change_mtu() and > > x25_asy_write_wakeup(). However, sl->lock is not held in > > x25_asy_write_

Regarding possible bug in net/wan/x25_asy.c

2020-08-23 Thread Madhuparna Bhowmik
Hello, I have the following doubt: sl->xhead is modified in both x25_asy_change_mtu() and x25_asy_write_wakeup(). However, sl->lock is not held in x25_asy_write_wakeup(). So, I am not sure if it is indeed possible to have a race between these two functions. If it is possible that these two functi

Re: [PATCH] drivers: isdn: capi: Fix data-race bug

2020-07-24 Thread Madhuparna Bhowmik
On Fri, Jul 24, 2020 at 08:57:47AM +0200, Greg KH wrote: > On Fri, Jul 24, 2020 at 10:18:07AM +0530, Madhuparna Bhowmik wrote: > > On Thu, Jul 23, 2020 at 03:11:58PM -0700, David Miller wrote: > > > From: madhuparnabhowmi...@gmail.com > > > Date: Wed, 22 Jul 2020 22:53:2

Re: [PATCH] drivers: isdn: capi: Fix data-race bug

2020-07-23 Thread Madhuparna Bhowmik
On Thu, Jul 23, 2020 at 03:11:58PM -0700, David Miller wrote: > From: madhuparnabhowmi...@gmail.com > Date: Wed, 22 Jul 2020 22:53:29 +0530 > > > From: Madhuparna Bhowmik > > > > In capi_init(), after register_chrdev() the file operation callbacks > > can be cal

Re: [PATCH] Fix suspicious RCU usage warning

2020-05-16 Thread Madhuparna Bhowmik
On Thu, May 14, 2020 at 12:50:11PM -0700, David Miller wrote: > From: Madhuparna Bhowmik > Date: Thu, 14 May 2020 12:34:09 +0530 > > > Sorry for this malformed patch, I have sent a patch with all these > > corrections. > > It still needs more work, see Jakub's

Re: [PATCH net] ipv6: Fix suspicious RCU usage warning in ip6mr

2020-05-15 Thread Madhuparna Bhowmik
On Thu, May 14, 2020 at 09:40:08AM -0700, Jakub Kicinski wrote: > On Thu, 14 May 2020 12:32:04 +0530 madhuparnabhowmi...@gmail.com wrote: > > From: Madhuparna Bhowmik > > > > This patch fixes the following warning: > > > > =

Re: linux-next boot error: WARNING: suspicious RCU usage in bpq_device_event

2020-05-14 Thread Madhuparna Bhowmik
On Thu, May 14, 2020 at 08:24:54AM -0400, Qian Cai wrote: > > > > On May 14, 2020, at 7:37 AM, syzbot > > wrote: > > > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:c9529331 Add linux-next specific files for 20200514 > > git tree: linux-next > > console

Re: [PATCH] Fix suspicious RCU usage warning

2020-05-14 Thread Madhuparna Bhowmik
On Wed, May 13, 2020 at 12:00:10PM -0700, David Miller wrote: > From: madhuparnabhowmi...@gmail.com > Date: Wed, 13 May 2020 11:46:10 +0530 > > > From: Madhuparna Bhowmik > > > > This patch fixes the following warning: > > > >

Re: [PATCH net 2/2 RESEND] ipmr: Add lockdep expression to ipmr_for_each_table macro

2020-05-12 Thread Madhuparna Bhowmik
On Tue, May 12, 2020 at 09:32:31AM -0700, Jakub Kicinski wrote: > On Tue, 12 May 2020 10:47:05 +0530 Madhuparna Bhowmik wrote: > > > > #ifdef CONFIG_IP_MROUTE_MULTIPLE_TABLES > > > > -#define ipmr_for_each_table(mrt, net) \ > > > > - list_for_each_en

Re: [PATCH net 2/2 RESEND] ipmr: Add lockdep expression to ipmr_for_each_table macro

2020-05-11 Thread Madhuparna Bhowmik
On Sat, May 09, 2020 at 02:19:38PM -0700, Jakub Kicinski wrote: > On Sat, 9 May 2020 12:52:44 +0530 Amol Grover wrote: > > ipmr_for_each_table() uses list_for_each_entry_rcu() for > > traversing outside of an RCU read-side critical section but > > under the protection of pernet_ops_rwsem. Hence ad

Re: linux-next boot error: WARNING: suspicious RCU usage in ip6mr_get_table

2020-05-11 Thread Madhuparna Bhowmik
On Tue, May 12, 2020 at 11:28:47AM +1000, Stephen Rothwell wrote: > Hi all, > > On Fri, 8 May 2020 04:54:02 +0530 Madhuparna Bhowmik > wrote: > > > > On Thu, May 07, 2020 at 08:50:55AM -0400, Qian Cai wrote: > > > > > > > > >

Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-05-09 Thread Madhuparna Bhowmik
On Sat, May 09, 2020 at 12:59:37PM +0530, Amol Grover wrote: > On Tue, Apr 28, 2020 at 10:28:41AM -0400, Qian Cai wrote: > > > > > > > On Apr 28, 2020, at 10:11 AM, Madhuparna Bhowmik > > > wrote: > > > > > > On Tue, Apr 28, 2020 at 09:56:59A

Re: linux-next boot error: WARNING: suspicious RCU usage in ip6mr_get_table

2020-05-07 Thread Madhuparna Bhowmik
On Thu, May 07, 2020 at 08:50:55AM -0400, Qian Cai wrote: > > > > On May 7, 2020, at 5:32 AM, Dmitry Vyukov wrote: > > > > On Thu, May 7, 2020 at 11:26 AM syzbot > > wrote: > >> > >> Hello, > >> > >> syzbot found the following crash on: > >> > >> HEAD commit:6b43f715 Add linux-next spec

Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-04-28 Thread Madhuparna Bhowmik
On Tue, Apr 28, 2020 at 10:28:41AM -0400, Qian Cai wrote: > > > > On Apr 28, 2020, at 10:11 AM, Madhuparna Bhowmik > > wrote: > > > > On Tue, Apr 28, 2020 at 09:56:59AM -0400, Qian Cai wrote: > >> > >> > >>> On Apr 28, 2020, at 4

Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-04-28 Thread Madhuparna Bhowmik
On Tue, Apr 28, 2020 at 09:56:59AM -0400, Qian Cai wrote: > > > > On Apr 28, 2020, at 4:57 AM, Dmitry Vyukov wrote: > >> net/ipv4/ipmr.c:136 RCU-list traversed in non-reader section!! > > https://lore.kernel.org/netdev/20200222063835.14328-2-frextr...@gmail.com/ > > Never been picked up for a