On Tue, Nov 07, 2023 at 11:12:24AM +0800, Xuan Zhuo wrote:
> The virtnet_xdp_handler() is re-used. But
>
> 1. We need to copy data to create skb for XDP_PASS.
> 2. We need to call xsk_buff_free() to release the buffer.
> 3. The handle for xdp_buff is difference.
>
> If we pushed this logic into e
On Fri, Nov 10, 2023 at 10:38:04AM +0800, Xuan Zhuo wrote:
> On Thu, 9 Nov 2023 17:26:33 +0100, Maciej Fijalkowski
> wrote:
> > On Thu, Nov 09, 2023 at 07:11:46PM +0800, Xuan Zhuo wrote:
> > > On Thu, 9 Nov 2023 03:12:27 -0500, "Michael S. Tsirkin"
> > >
On Thu, Nov 09, 2023 at 07:11:46PM +0800, Xuan Zhuo wrote:
> On Thu, 9 Nov 2023 03:12:27 -0500, "Michael S. Tsirkin"
> wrote:
> > On Tue, Nov 07, 2023 at 11:12:22AM +0800, Xuan Zhuo wrote:
> > > Implement the logic of filling rq with XSK buffers.
> > >
> > > Signed-off-by: Xuan Zhuo
> > > ---
>
From: Björn Töpel
Remove two unused defines.
Signed-off-by: Björn Töpel
---
tools/testing/selftests/bpf/xdpxceiver.c | 7 +++
tools/testing/selftests/bpf/xdpxceiver.h | 2 --
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/tools/testing/selftests/bpf/xdpxceiver.c
b/tools/te
From: Björn Töpel
The usage of the condition variable is broken, and overkill. Replace it
with a pthread barrier.
Signed-off-by: Björn Töpel
---
tools/testing/selftests/bpf/xdpxceiver.c | 33
tools/testing/selftests/bpf/xdpxceiver.h | 3 +--
2 files changed, 6 inserti
From: Björn Töpel
There is really no reason to have a non-default thread stack
size. Remove that.
Signed-off-by: Björn Töpel
---
tools/testing/selftests/bpf/xdpxceiver.c | 9 ++---
tools/testing/selftests/bpf/xdpxceiver.h | 2 --
2 files changed, 2 insertions(+), 9 deletions(-)
diff --git
it doesn't
have anything in common with bi-directional testing.
Drop opt_queue command line argument as it wasn't working before anyway.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/test_xsk.sh | 3 +-
tools/testing/selftests/bpf/xdpxceiver.c | 179 +
Libbpf's xsk part calls get_channels() API to retrieve the queue count
of the underlying driver so that XSKMAP is sized accordingly.
Implement that in veth so multi queue scenarios can work properly.
Cc: Toshiaki Makita
Signed-off-by: Maciej Fijalkowski
---
drivers/net/veth.c
spinning_rx. This means that spinning_tx can be removed altogheter.
signal_tx_condition is never utilized, so simply remove it.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 15 +++
tools/testing/selftests/bpf/xdpxceiver.h | 2 --
2 files changed, 7
ional test. Thread creation now is
easey to follow.
switching_notify variable is useless, info about vector switch can be
printed based on bidi_pass state.
Last but not least, init/destroy synchronization variables only once,
not per each test.
Signed-off-by: Maciej Fijalkowski
---
tools/testing
final result will be a code base that is much
easier to follow.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 156 +++
1 file changed, 77 insertions(+), 79 deletions(-)
diff --git a/tools/testing/selftests/bpf/xdpxceiver.c
b/tools/testing/self
spin on atomic variable.
Note that this simplification wouldn't be possible if there would still
be a common worker thread.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 31 ++--
tools/testing/selftests/bpf/xdpxceiver.h | 2 --
2
t rid of logic around making sure
that it's possible to switch ns in validate_interfaces().
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 123 +++
tools/testing/selftests/bpf/xdpxceiver.h | 10 +-
2 files changed, 14 insertions(+), 119
no more
active users.
While at it, don't dump stats on error path.
Signed-off-by: Maciej Fijalkowski
---
samples/bpf/xdpsock_user.c | 55 ++
1 file changed, 14 insertions(+), 41 deletions(-)
diff --git a/samples/bpf/xdpsock_user.c b/samples/bpf/xdpsock_
Signed-off-by: Maciej Fijalkowski
---
tools/lib/bpf/xsk.c | 258
1 file changed, 213 insertions(+), 45 deletions(-)
diff --git a/tools/lib/bpf/xsk.c b/tools/lib/bpf/xsk.c
index 526fc35c0b23..95da0e19f4a5 100644
--- a/tools/lib/bpf/xsk.c
+++ b/tools/l
Store offsets to each layer in a separate variables rather than compute
them every single time.
Signed-off-by: Björn Töpel
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 47 +++-
1 file changed, 21 insertions(+), 26 deletions(-)
diff --git
Probably it was ported from xdpsock but is not used anywhere.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/tools/testing/selftests/bpf/xdpxceiver.c
b/tools/testing/selftests/bpf/xdpxceiver.c
Follow the kernel coding style guidelines and let compiler do the
decision about inlining.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/tools/testing/selftests/bpf
For TEST_TYPE_STATS, worker_pkt_validate() that places frames onto
pkt_buf is not called. Therefore, when dump mode is set, don't call
worker_pkt_dump() for mentioned test type, so that it won't crash on
pkt_buf() access.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/sel
ifaceconfigobj is not really useful, it is possible to keep the
functionality and simplify the code.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 65 +++-
tools/testing/selftests/bpf/xdpxceiver.h | 9
2 files changed, 30 insertions
com/
is needed.
Thanks,
Maciej
Björn Töpel (3):
selftests: xsk: remove thread attribute
selftests: xsk: Remove mutex and condition variable
selftests: xsk: Remove unused defines
Maciej Fijalkowski (14):
selftests: xsk: don't call worker_pkt_dump() for stats test
selftests: xsk:
On Mon, Mar 29, 2021 at 04:09:33PM +0200, Toke Høiland-Jørgensen wrote:
> Maciej Fijalkowski writes:
>
> > On Mon, Mar 29, 2021 at 01:05:44PM +0200, Toke Høiland-Jørgensen wrote:
> >> Maciej Fijalkowski writes:
> >>
> >> > Currently, if there are mult
On Mon, Mar 29, 2021 at 01:05:44PM +0200, Toke Høiland-Jørgensen wrote:
> Maciej Fijalkowski writes:
>
> > Currently, if there are multiple xdpsock instances running on a single
> > interface and in case one of the instances is terminated, the rest of
> > them are left in
From: Björn Töpel
The usage of the condition variable is broken, and overkill. Replace it
with a pthread barrier.
Signed-off-by: Björn Töpel
---
tools/testing/selftests/bpf/xdpxceiver.c | 33
tools/testing/selftests/bpf/xdpxceiver.h | 3 +--
2 files changed, 6 inserti
From: Björn Töpel
There is really no reason to have a non-default thread stack
size. Remove that.
Signed-off-by: Björn Töpel
---
tools/testing/selftests/bpf/xdpxceiver.c | 9 ++---
tools/testing/selftests/bpf/xdpxceiver.h | 2 --
2 files changed, 2 insertions(+), 9 deletions(-)
diff --git
final result will be a code base that is much
easier to follow.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 156 +++
1 file changed, 77 insertions(+), 79 deletions(-)
diff --git a/tools/testing/selftests/bpf/xdpxceiver.c
b/tools/testing/self
spinning_rx. This means that spinning_tx can be removed altogheter.
signal_tx_condition is never utilized, so simply remove it.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 15 +++
tools/testing/selftests/bpf/xdpxceiver.h | 2 --
2 files changed, 7
ional test. Thread creation now is
easey to follow.
switching_notify variable is useless, info about vector switch can be
printed based on bidi_pass state.
Last but not least, init/destroy synchronization variables only once,
not per each test.
Signed-off-by: Maciej Fijalkowski
---
tools/testing
From: Björn Töpel
Remove two unused defines.
Signed-off-by: Björn Töpel
---
tools/testing/selftests/bpf/xdpxceiver.c | 7 +++
tools/testing/selftests/bpf/xdpxceiver.h | 2 --
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/tools/testing/selftests/bpf/xdpxceiver.c
b/tools/te
it doesn't
have anything in common with bi-directional testing.
Drop opt_queue command line argument as it wasn't working before anyway.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/test_xsk.sh | 3 +-
tools/testing/selftests/bpf/xdpxceiver.c | 179 +
t rid of logic around making sure
that it's possible to switch ns in validate_interfaces().
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 123 +++
tools/testing/selftests/bpf/xdpxceiver.h | 10 +-
2 files changed, 14 insertions(+), 119
Libbpf's xsk part calls get_channels() API to retrieve the queue count
of the underlying driver so that XSKMAP is sized accordingly.
Implement that in veth so multi queue scenarios can work properly.
Signed-off-by: Maciej Fijalkowski
---
drivers/net/veth.c | 12
1 file change
Signed-off-by: Maciej Fijalkowski
---
tools/lib/bpf/xsk.c | 259
1 file changed, 214 insertions(+), 45 deletions(-)
diff --git a/tools/lib/bpf/xsk.c b/tools/lib/bpf/xsk.c
index 526fc35c0b23..c75067f0035f 100644
--- a/tools/lib/bpf/xsk.c
+++ b/tools/l
spin on atomic variable.
Note that this simplification wouldn't be possible if there would still
be a common worker thread.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 31 ++--
tools/testing/selftests/bpf/xdpxceiver.h | 2 --
2
Store offsets to each layer in a separate variables rather than compute
them every single time.
Signed-off-by: Björn Töpel
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 47 +++-
1 file changed, 21 insertions(+), 26 deletions(-)
diff --git
Follow the kernel coding style guidelines and let compiler do the
decision about inlining.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/tools/testing/selftests/bpf
no more
active users.
While at it, don't dump stats on error path.
Signed-off-by: Maciej Fijalkowski
---
samples/bpf/xdpsock_user.c | 55 ++
1 file changed, 14 insertions(+), 41 deletions(-)
diff --git a/samples/bpf/xdpsock_user.c b/samples/bpf/xdpsock_
Probably it was ported from xdpsock but is not used anywhere.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/tools/testing/selftests/bpf/xdpxceiver.c
b/tools/testing/selftests/bpf/xdpxceiver.c
ifaceconfigobj is not really useful, it is possible to keep the
functionality and simplify the code.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 65 +++-
tools/testing/selftests/bpf/xdpxceiver.h | 9
2 files changed, 30 insertions
For TEST_TYPE_STATS, worker_pkt_validate() that places frames onto
pkt_buf is not called. Therefore, when dump mode is set, don't call
worker_pkt_dump() for mentioned test type, so that it won't crash on
pkt_buf() access.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/sel
needed.
Thanks,
Maciej
Björn Töpel (3):
selftests: xsk: remove thread attribute
selftests: xsk: Remove mutex and condition variable
selftests: xsk: Remove unused defines
Maciej Fijalkowski (14):
selftests: xsk: don't call worker_pkt_dump() for stats test
selftests: xsk: remove struct if
On Thu, Mar 25, 2021 at 12:38:07AM +0100, Toke Høiland-Jørgensen wrote:
> Maciej Fijalkowski writes:
>
> > On Mon, Mar 22, 2021 at 10:47:09PM +0100, Toke Høiland-Jørgensen wrote:
> >> Maciej Fijalkowski writes:
> >>
> >> > Currently, if there are mult
On Mon, Mar 22, 2021 at 10:47:09PM +0100, Toke Høiland-Jørgensen wrote:
> Maciej Fijalkowski writes:
>
> > Currently, if there are multiple xdpsock instances running on a single
> > interface and in case one of the instances is terminated, the rest of
> > them are left in
ional test. Thread creation now is
easey to follow.
switching_notify variable is useless, info about vector switch can be
printed based on bidi_pass state.
Last but not least, init/destroy synchronization variables only once,
not per each test.
Signed-off-by: Maciej Fijalkowski
---
tools/testing
spin on atomic variable.
Note that this simplification wouldn't be possible if there would still
be a common worker thread.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 31 ++--
tools/testing/selftests/bpf/xdpxceiver.h | 2 --
2
spinning_rx. This means that spinning_tx can be removed altogheter.
signal_tx_condition is never utilized, so simply remove it.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 15 +++
tools/testing/selftests/bpf/xdpxceiver.h | 2 --
2 files changed, 7
From: Björn Töpel
The usage of the condition variable is broken, and overkill. Replace
with a pthread barrier.
Signed-off-by: Björn Töpel
---
tools/testing/selftests/bpf/xdpxceiver.c | 33
tools/testing/selftests/bpf/xdpxceiver.h | 3 +--
2 files changed, 6 insertions
From: Björn Töpel
There is really no reason to have a non-default thread stack
size. Remove that.
Signed-off-by: Björn Töpel
---
tools/testing/selftests/bpf/xdpxceiver.c | 9 ++---
tools/testing/selftests/bpf/xdpxceiver.h | 2 --
2 files changed, 2 insertions(+), 9 deletions(-)
diff --git
Libbpf's xsk part calls get_channels() API to retrieve the queue count
of the underlying driver so that XSKMAP is sized accordingly.
Implement that in veth so multi queue scenarios can work properly.
Signed-off-by: Maciej Fijalkowski
---
drivers/net/veth.c | 12
1 file change
From: Björn Töpel
Remove two unused defines.
Signed-off-by: Björn Töpel
---
tools/testing/selftests/bpf/xdpxceiver.c | 7 +++
tools/testing/selftests/bpf/xdpxceiver.h | 2 --
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/tools/testing/selftests/bpf/xdpxceiver.c
b/tools/te
it doesn't
have anything in common with bi-directional testing.
Drop opt_queue command line argument as it wasn't working before anyway.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/test_xsk.sh | 3 +-
tools/testing/selftests/bpf/xdpxceiver.c | 179 +
final result will be a code base that is much
easier to follow.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 156 +++
1 file changed, 77 insertions(+), 79 deletions(-)
diff --git a/tools/testing/selftests/bpf/xdpxceiver.c
b/tools/testing/self
t rid of logic around making sure
that it's possible to switch ns in validate_interfaces().
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 123 +++
tools/testing/selftests/bpf/xdpxceiver.h | 10 +-
2 files changed, 14 insertions(+), 119
ng the ifindexes from bpf_link and xsk socket.
For case where resources exist but they are not AF_XDP related, bail out
and ask user to remove existing prog and then retry.
Signed-off-by: Maciej Fijalkowski
---
tools/lib/bpf/xsk.c | 175 +++-
1 file change
no more
active users.
While at it, don't dump stats on error path.
Signed-off-by: Maciej Fijalkowski
---
samples/bpf/xdpsock_user.c | 55 ++
1 file changed, 14 insertions(+), 41 deletions(-)
diff --git a/samples/bpf/xdpsock_user.c b/samples/bpf/xdpsock_
Store offsets to each layer in a separate variables rather than compute
them every single time.
Signed-off-by: Björn Töpel
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 47 +++-
1 file changed, 21 insertions(+), 26 deletions(-)
diff --git
Probably it was ported from xdpsock but is not used anywhere.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/tools/testing/selftests/bpf/xdpxceiver.c
b/tools/testing/selftests/bpf/xdpxceiver.c
Follow the kernel coding style guidelines and let compiler do the
decision about inlining.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/tools/testing/selftests/bpf
ifaceconfigobj is not really useful, it is possible to keep the
functionality and simplify the code.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 65 +++-
tools/testing/selftests/bpf/xdpxceiver.h | 9
2 files changed, 30 insertions
For TEST_TYPE_STATS, worker_pkt_validate() that places frames onto
pkt_buf is not called. Therefore, when dump mode is set, don't call
worker_pkt_dump() for mentioned test type, so that it won't crash on
pkt_buf() access.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/sel
independently of XDP prog presence
https://lore.kernel.org/bpf/20210303152903.11172-1-maciej.fijalkow...@intel.com/
is needed.
Thanks,
Maciej
Björn Töpel (3):
selftests: xsk: remove thread attribute
selftest: xsk: Remove mutex and condition variable
selftests: xsk: Remove unused defines
Ma
On Mon, Mar 15, 2021 at 10:39:38PM -0700, Andrii Nakryiko wrote:
> On Thu, Mar 11, 2021 at 7:43 AM Maciej Fijalkowski
> wrote:
> >
> > Introduce a test that is supposed to verify the persistence of BPF
> > resources based on underlying bpf_link usage.
> >
> > T
On Tue, Mar 16, 2021 at 09:44:38AM +0100, Magnus Karlsson wrote:
> On Thu, Mar 11, 2021 at 4:43 PM Maciej Fijalkowski
> wrote:
> >
> > Libbpf's xsk part calls get_channels() API to retrieve the queue count
> > of the underlying driver so that XSKMAP is sized according
On Mon, Mar 15, 2021 at 10:34:11PM -0700, Andrii Nakryiko wrote:
> On Thu, Mar 11, 2021 at 7:42 AM Maciej Fijalkowski
> wrote:
> >
> > Currently, if there are multiple xdpsock instances running on a single
> > interface and in case one of the instances is terminated, the r
ackets as the budget since there might be more packets we can
> process.
>
> Fixes: 3106c580fb7c ("i40e: Use batched xsk Tx interfaces to increase
> performance")
> Reported-by: Sreedevi Joshi
> Signed-off-by: Magnus Karlsson
Acked-by: Maciej Fijalkowski
> --
From: Björn Töpel
Remove two unused defines.
Signed-off-by: Björn Töpel
---
tools/testing/selftests/bpf/xdpxceiver.c | 5 ++---
tools/testing/selftests/bpf/xdpxceiver.h | 2 --
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/tools/testing/selftests/bpf/xdpxceiver.c
b/tools/test
From: Björn Töpel
There is really no reason to have a non-default thread stack
size. Remove that.
Signed-off-by: Björn Töpel
---
tools/testing/selftests/bpf/xdpxceiver.c | 9 ++---
tools/testing/selftests/bpf/xdpxceiver.h | 2 --
2 files changed, 2 insertions(+), 9 deletions(-)
diff --git
it doesn't
have anything in common with bi-directional testing.
Drop opt_queue command line argument as it wasn't working before anyway.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/test_xsk.sh | 2 +-
tools/testing/selftests/bpf/xdpxceiver.c | 179 +
spinning_rx. This means that spinning_tx can be removed altogheter.
signal_tx_condition is never utilized, so simply remove it.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 15 +++
tools/testing/selftests/bpf/xdpxceiver.h | 2 --
2 files changed, 7
spin on atomic variable.
Note that this simplification wouldn't be possible if there would still
be a common worker thread.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 31 ++--
tools/testing/selftests/bpf/xdpxceiver.h | 2 --
2
Libbpf's xsk part calls get_channels() API to retrieve the queue count
of the underlying driver so that XSKMAP is sized accordingly.
Implement that in veth so multi queue scenarios can work properly.
Signed-off-by: Maciej Fijalkowski
---
drivers/net/veth.c | 12
1 file change
From: Björn Töpel
The usage of the condition variable is broken, and overkill. Replace
with a pthread barrier.
Signed-off-by: Björn Töpel
---
tools/testing/selftests/bpf/xdpxceiver.c | 33
tools/testing/selftests/bpf/xdpxceiver.h | 3 +--
2 files changed, 6 insertions
ional test. Thread creation now is
easey to follow.
switching_notify variable is useless, info about vector switch can be
printed based on bidi_pass state.
Last but not least, init/destroy synchronization variables only once,
not per each test.
Signed-off-by: Maciej Fijalkowski
---
tools/testing
t rid of logic around making sure
that it's possible to switch ns in validate_interfaces().
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 123 +++
tools/testing/selftests/bpf/xdpxceiver.h | 10 +-
2 files changed, 14 insertions(+), 119
ven the presence of
XDP_FLAGS_UPDATE_IF_NOEXIST.
If there's netlink-based XDP prog running on a interface, bail out and
ask user to do removal by himself.
Signed-off-by: Maciej Fijalkowski
---
tools/lib/bpf/xsk.c | 139 ++--
1 file changed, 120 insert
no more
active users.
While at it, don't dump stats on error path.
Signed-off-by: Maciej Fijalkowski
---
samples/bpf/xdpsock_user.c | 55 ++
1 file changed, 14 insertions(+), 41 deletions(-)
diff --git a/samples/bpf/xdpsock_user.c b/samples/bpf/xdpsock_
final result will be a code base that is much
easier to follow.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 156 +++
1 file changed, 77 insertions(+), 79 deletions(-)
diff --git a/tools/testing/selftests/bpf/xdpxceiver.c
b/tools/testing/self
Store offsets to each layer in a separate variables rather than compute
them every single time.
Signed-off-by: Björn Töpel
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 48 +++-
1 file changed, 22 insertions(+), 26 deletions(-)
diff --git
ded.
Thanks,
Maciej
Björn Töpel (3):
selftests: xsk: remove thread attribute
selftest: xsk: Remove mutex and condition variable
selftests: xsk: Remove unused defines
Maciej Fijalkowski (14):
selftests: xsk: don't call worker_pkt_dump() for stats test
selftests: xsk: remove struct i
Follow the kernel coding style guidelines and let compiler do the
decision about inlining.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/tools/testing/selftests/bpf
For TEST_TYPE_STATS, worker_pkt_validate() that places frames onto
pkt_buf is not called. Therefore, when dump mode is set, don't call
worker_pkt_dump() for mentioned test type, so that it won't crash on
pkt_buf() access.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/sel
Probably it was ported from xdpsock but is not used anywhere.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/tools/testing/selftests/bpf/xdpxceiver.c
b/tools/testing/selftests/bpf/xdpxceiver.c
ifaceconfigobj is not really useful, it is possible to keep the
functionality and simplify the code.
Signed-off-by: Maciej Fijalkowski
---
tools/testing/selftests/bpf/xdpxceiver.c | 65 +++-
tools/testing/selftests/bpf/xdpxceiver.h | 9
2 files changed, 30 insertions
a correct rxq.
To fix that, store queue_mapping independently of XDP prog presence on
peer interface.
Fixes: 638264dc9022 ("veth: Support per queue XDP ring")
Signed-off-by: Maciej Fijalkowski
---
drivers/net/veth.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
)
Reported-by: Jesper Dangaard Brouer
Co-developed-by: Jesper Dangaard Brouer
Signed-off-by: Jesper Dangaard Brouer
Signed-off-by: Maciej Fijalkowski
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 13 +
drivers/net/ethernet/intel/i40e/i40e_txrx.c | 12
2 files changed,
result of ixgbe_rx_offset() onto
ixgbe_ring")
Signed-off-by: Maciej Fijalkowski
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
b/drivers/net/ethernet/intel/ixgbe/ixg
)
Signed-off-by: Maciej Fijalkowski
---
drivers/net/ethernet/intel/ice/ice_base.c | 18 ++
drivers/net/ethernet/intel/ice/ice_txrx.c | 17 -
2 files changed, 18 insertions(+), 17 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_base.c
b/drivers/net/eth
://lore.kernel.org/bpf/20210118151318.12324-10-maciej.fijalkow...@intel.com/
Maciej Fijalkowski (3):
i40e: move headroom initialization to i40e_configure_rx_ring
ice: move headroom initialization to ice_setup_rx_ctx
ixgbe: move headroom initialization to ixgbe_configure_rx_ring
drivers/net/ethernet/intel
> Do not populate the fill queue and then try to receive pkts.
Thanks for adding descriptions!
Reviewed-by: Maciej Fijalkowski
>
> Signed-off-by: Ciara Loftus
> ---
> tools/testing/selftests/bpf/xdpxceiver.c | 137 ---
> tools/testing/selftests/bpf/xdpxceiver.h | 13 +++
> 2 files changed, 136 insertions(+), 14 deletions(-)
>
On Tue, Feb 23, 2021 at 10:35:05AM +, Ciara Loftus wrote:
> Launching xdpxceiver with -D enables what was formerly know as 'debug'
> mode. Rename this mode to 'dump-pkts' as it better describes the
> behavior enabled by the option. New usage:
>
> ./xdpxceiver .. -D
> or
> ./xdpxceiver .. --dum
se
> option, if further debugging is needed when a problem arises.
>
> To run the xsk tests with verbose output:
> ./test_xsk.sh -v
>
> Signed-off-by: Magnus Karlsson
> Signed-off-by: Ciara Loftus
Acked-by: Maciej Fijalkowski
On Wed, Feb 17, 2021 at 04:02:14PM +, Ciara Loftus wrote:
> This commit introduces a range of tests to the xsk testsuite
> for validating xsk statistics.
>
> A new test type called 'stats' is added. Within it there are
> four sub-tests which test the following statistics:
> 1. rx dropped
> 2.
sh | 24 +--
> 4 files changed, 139 insertions(+), 223 deletions(-)
>
Good cleanup! I have a series of fixes/cleanups as well and I need to
introduce a new test over here, so your work makes it easier for me.
One nit below and once you address Bjorn's request, then feel fr
On Tue, Feb 16, 2021 at 11:15:41AM -0800, John Fastabend wrote:
> Toke Høiland-Jørgensen wrote:
> > Björn Töpel writes:
> >
> > > On 2021-02-15 21:49, John Fastabend wrote:
> > >> Maciej Fijalkowski wrote:
> > >>> Currently, if there
On Tue, Feb 16, 2021 at 11:27:55AM +0100, Toke Høiland-Jørgensen wrote:
> Maciej Fijalkowski writes:
> >
> > Am I reading this right or you're trying to reject the fix of the long
> > standing issue due to a PR that is not ready yet on a standalone
> > project/li
On Tue, Feb 16, 2021 at 10:19:17AM -0800, John Fastabend wrote:
> Maciej Fijalkowski wrote:
> > On Mon, Feb 15, 2021 at 12:49:27PM -0800, John Fastabend wrote:
> > > Maciej Fijalkowski wrote:
> > > > Currently, if there are multiple xdpsock instances running on a s
On Tue, Feb 16, 2021 at 10:22:15AM +0100, Björn Töpel wrote:
> On 2021-02-15 21:24, John Fastabend wrote:
> > Maciej Fijalkowski wrote:
> > > With the introduction of bpf_link in xsk's libbpf part, there's no
> > > further need for explicit unload o
On Mon, Feb 15, 2021 at 12:33:37PM -0800, John Fastabend wrote:
> Maciej Fijalkowski wrote:
> > xsk_lookup_bpf_maps, based on prog_fd, looks whether current prog has a
> > reference to XSKMAP. BPF prog can include insns that work on various BPF
> > maps and this is covered
On Mon, Feb 15, 2021 at 12:49:27PM -0800, John Fastabend wrote:
> Maciej Fijalkowski wrote:
> > Currently, if there are multiple xdpsock instances running on a single
> > interface and in case one of the instances is terminated, the rest of
> > them are left in an inoperable
On Mon, Feb 15, 2021 at 04:18:28PM -0800, John Fastabend wrote:
> Toke Høiland-Jørgensen wrote:
> > John Fastabend writes:
> >
> > >> > However, in libxdp we can solve the original problem in a different
> > >> > way,
> > >> > and in fact I already suggested to Magnus that we should do this (see
1 - 100 of 384 matches
Mail list logo
