Re: [PATCH 00/10] rsi: fix comment syntax in file headers

2021-03-15 Thread Lukas Bulwahn
On Sun, Mar 14, 2021 at 9:18 PM Aditya Srivastava wrote: > > The opening comment mark '/**' is used for highlighting the beginning of > kernel-doc comments. > There are files in drivers/net/wireless/rsi which follow this syntax in > their file headers, i.e. start with '/**' like comments, which ca

[PATCH] net/mlx5: docs: correct section reference in table of contents

2021-02-05 Thread Lukas Bulwahn
rget name: "mlx5 port function". Correct the section reference in table of contents to the actual name of section in the documentation. Also, tune another section underline while visiting this document. Signed-off-by: Lukas Bulwahn --- Saeed, please pick this patch for yo

[PATCH for bpf-next] docs: bpf: add minimal markup to address doc warning

2021-01-18 Thread Lukas Bulwahn
Add some minimal markup to address this warning. Signed-off-by: Lukas Bulwahn --- applies cleanly on next-20210118 Brendan, please ack. Alexei, please pick this minor cleanup patch on your bpf-next. Documentation/networking/filter.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

Re: [PATCH] docs: octeontx2: tune rst markup

2021-01-06 Thread Lukas Bulwahn
On Tue, Jan 5, 2021 at 9:27 PM Randy Dunlap wrote: > > Hi Lukas, > > On 1/5/21 1:35 AM, Lukas Bulwahn wrote: > > Commit 80b9414832a1 ("docs: octeontx2: Add Documentation for NPA health > > reporters") added new documentation with improper formatting for rst, and

[PATCH v2] docs: octeontx2: tune rst markup

2021-01-06 Thread Lukas Bulwahn
Signed-off-by: Lukas Bulwahn --- v1 -> v2: minor stylistic tuning as suggested by Randy applies cleanly on current master (v5.11-rc2) and next-20210106 George, please ack. Jonathan, please pick this minor formatting clean-up patch. .../ethernet/marvell/octeontx2.rst| 62 +

[PATCH] docs: octeontx2: tune rst markup

2021-01-05 Thread Lukas Bulwahn
Signed-off-by: Lukas Bulwahn --- applies cleanly on current master (v5.11-rc2) and next-20201205 George, please ack. Jonathan, please pick this minor formatting clean-up patch. .../ethernet/marvell/octeontx2.rst| 59 +++ 1 file changed, 34 insertions(+), 25 deletion

Re: [PATCH] bpf: propagate __user annotations properly

2020-12-07 Thread Lukas Bulwahn
On Mon, Dec 7, 2020 at 5:12 PM Yonghong Song wrote: > > > > On 12/7/20 4:37 AM, Lukas Bulwahn wrote: > > __htab_map_lookup_and_delete_batch() stores a user pointer in the local > > variable ubatch and uses that in copy_{from,to}_user(), but ubatch misses a > >

[PATCH] bpf: propagate __user annotations properly

2020-12-07 Thread Lukas Bulwahn
__user annotations in __htab_map_lookup_and_delete_batch(). Signed-off-by: Lukas Bulwahn --- applies cleanly on current master (v5.10-rc7) and next-20201204 BPF maintainers, please pick this minor non-urgent clean-up patch. kernel/bpf/hashtab.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] net/ipv6: propagate user pointer annotation

2020-11-27 Thread Lukas Bulwahn
ed in the six alternative put_cmsg() calls, with msg_control_is_user being true, put_cmsg() picks msg_control_user preserving the __user annotation and passes that properly to copy_to_user(). No functional change. No change in object code. Signed-off-by: Lukas Bulwahn --- Christoph, please r

Re: [RFC] MAINTAINERS tag for cleanup robot

2020-11-23 Thread Lukas Bulwahn
On Mon, Nov 23, 2020 at 4:52 PM Jani Nikula wrote: > > On Sat, 21 Nov 2020, James Bottomley > wrote: > > On Sat, 2020-11-21 at 08:50 -0800, t...@redhat.com wrote: > >> A difficult part of automating commits is composing the subsystem > >> preamble in the commit log. For the ongoing effort of a

[PATCH] ipv6: remove unused function ipv6_skb_idev()

2020-11-13 Thread Lukas Bulwahn
; [-Wunused-function] So, remove this unused function and a -Wunused-function warning. Signed-off-by: Lukas Bulwahn --- Alexey, Hideaki-san, please ack. David, Jakub, please pick this minor non-urgent clean-up patch. net/ipv6/exthdrs.c | 4 1 file changed, 4 deletions(-) diff --git a/net/

Re: [PATCH] netfilter: conntrack: fix -Wformat

2020-11-07 Thread Lukas Bulwahn
On Sat, 7 Nov 2020, Joe Perches wrote: > On Fri, 2020-11-06 at 23:55 -0800, Nick Desaulniers wrote: > > Clang is more aggressive about -Wformat warnings when the format flag > > specifies a type smaller than the parameter. Fixes 8 instances of: > > > > warning: format specifies type 'unsigned s

Re: [PATCH] net: cls_api: remove unneeded local variable in tc_dump_chain()

2020-10-28 Thread Lukas Bulwahn
On Wed, 28 Oct 2020, Tom Rix wrote: > > On 10/28/20 4:35 AM, Lukas Bulwahn wrote: > > make clang-analyzer on x86_64 defconfig caught my attention with: > > > > net/sched/cls_api.c:2964:3: warning: Value stored to 'parent' is never read > &g

[PATCH] ipv6: mcast: make annotations for ip6_mc_msfget() consistent

2020-10-28 Thread Lukas Bulwahn
es) mcast.c:607:34:expected void [noderef] __user *to mcast.c:607:34:got struct __kernel_sockaddr_storage *p No functional change. No change in object code. Signed-off-by: Lukas Bulwahn --- applies cleanly on current master and next-20201028 David, Jakub, please pick this minor non-urgent c

[PATCH] net: cls_api: remove unneeded local variable in tc_dump_chain()

2020-10-28 Thread Lukas Bulwahn
e unneeded dead stores. Simplify the code to make clang-analyzer happy. As compilers will detect these unneeded assignments and optimize this anyway, the resulting binary is identical before and after this change. No functional change. No change in object code. Signed-off-by: Lukas Bulwahn ---

Re: [linux-safety] [PATCH] e1000: drop unneeded assignment in e1000_set_itr()

2020-10-12 Thread Lukas Bulwahn
PEED_1000)) { > - current_itr = 0; > new_itr = 4000; > goto set_itr_now; > } Alternatively, you could just inline the max(...) into the switch and completely drop the current_itr definition. But your solution probably does the job: it

[PATCH] net/mlx5: IPsec: make spdxcheck.py happy

2020-09-16 Thread Lukas Bulwahn
Bt Remove the typo and make spdxcheck.py happy. Signed-off-by: Lukas Bulwahn --- Greg, please pick this minor non-urgent patch into your spdx tree. drivers/net/ethernet/mellanox/mlx5/core/accel/ipsec_offload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ne

[PATCH] MAINTAINERS: repair reference in LYNX PCS MODULE

2020-09-05 Thread Lukas Bulwahn
.c Repair the LYNX PCS MODULE section by referring to the right location. Signed-off-by: Lukas Bulwahn --- applies cleanly on next-20200903 Ioana, please ack. David, please pick this minor non-urgent patch into your net-next. MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] MAINTAINERS: adjust entry in XDP SOCKETS to actual file name

2020-05-25 Thread Lukas Bulwahn
h. Hence, ./scripts/get_maintainer.pl --self-test=patterns complains: warning: no file matches F: include/net/xsk_buffer_pool.h Adjust the entry in XDP SOCKETS to the actual file name. Signed-off-by: Lukas Bulwahn --- Bj??rn, please pick this minor non-urgent patch. applies to next-20200525 o

[PATCH] MAINTAINERS: put DYNAMIC INTERRUPT MODERATION in proper order

2020-05-06 Thread Lukas Bulwahn
alphabetic order #5966: FILE: MAINTAINERS:5966: +F: lib/dim/ +F: Documentation/networking/net_dim.rst Reorder the file entries to keep MAINTAINERS nicely ordered. Signed-off-by: Lukas Bulwahn --- Jakub, please pick this minor non-urgent patch. applies cleanly on next-20200505 M