Re: [PATCH] coredump: rename umh_pipe_setup() to coredump_pipe_setup()

2018-05-11 Thread Luis R. Rodriguez
On Fri, May 11, 2018 at 03:48:51AM +0100, Al Viro wrote: > On Thu, May 10, 2018 at 11:32:47PM +0000, Luis R. Rodriguez wrote: > > > I think net-next makes sense if Al Viro is OK with that. This way it could > > go > > in regardless of the state of your series, but it

Re: [PATCH] coredump: rename umh_pipe_setup() to coredump_pipe_setup()

2018-05-10 Thread Luis R. Rodriguez
On Thu, May 10, 2018 at 04:19:09PM -0700, Alexei Starovoitov wrote: > On Mon, May 07, 2018 at 04:30:02PM -0700, Luis R. Rodriguez wrote: > > This makes it clearer this code is part of the coredump code, and > > is not an exported generic helper from kernel/umh.c. > > >

Re: [PATCH v6 05/13] firmware_loader: enhance Kconfig documentation over FW_LOADER

2018-05-09 Thread Luis R. Rodriguez
On Tue, May 08, 2018 at 03:42:33PM -0700, Kees Cook wrote: > On Tue, May 8, 2018 at 11:12 AM, Luis R. Rodriguez wrote: > > + This used to be the default firmware loading facility, and udev > > used > > + to listen for uvents to load firmware for the

Re: [PATCH v6 12/13] Documentation: remove stale firmware API reference

2018-05-09 Thread Luis R. Rodriguez
On Wed, May 09, 2018 at 12:12:09PM -0300, Mauro Carvalho Chehab wrote: > Em Tue, 8 May 2018 11:12:46 -0700 > "Luis R. Rodriguez" escreveu: > > > It refers to a pending patch, but this was merged eons ago. > > Didn't know that such patch was already

[PATCH v6 00/13] firmware_loader changes for v4.18

2018-05-08 Thread Luis R. Rodriguez
_request_nowarn() to load firmware ath10k: re-enable the firmware fallback mechanism for testmode Luis R. Rodriguez (7): firmware_loader: document firmware_sysfs_fallback() firmware_loader: enhance Kconfig documentation over FW_LOADER firmware_loader: move kconfig FW_LOADER ent

[PATCH v6 01/13] firmware: wrap FW_OPT_* into an enum

2018-05-08 Thread Luis R. Rodriguez
From: Andres Rodriguez This should let us associate enum kdoc to these values. While at it, kdocify the fw_opt. Signed-off-by: Andres Rodriguez Acked-by: Luis R. Rodriguez [mcgrof: coding style fixes, merge kdoc with enum move] Signed-off-by: Luis R. Rodriguez --- drivers/base

[PATCH v6 02/13] firmware: use () to terminate kernel-doc function names

2018-05-08 Thread Luis R. Rodriguez
From: Andres Rodriguez The kernel-doc spec dictates a function name ends in (). Signed-off-by: Andres Rodriguez Acked-by: Randy Dunlap Acked-by: Luis R. Rodriguez [mcgrof: adjust since the wide API rename is not yet merged] Signed-off-by: Luis R. Rodriguez --- drivers/base/firmware_loader

[PATCH v6 04/13] firmware_loader: document firmware_sysfs_fallback()

2018-05-08 Thread Luis R. Rodriguez
This also sets the expecations for future fallback interfaces, even if they are not exported. Signed-off-by: Luis R. Rodriguez --- drivers/base/firmware_loader/fallback.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/base/firmware_loader/fallback.c b/drivers

[PATCH v6 05/13] firmware_loader: enhance Kconfig documentation over FW_LOADER

2018-05-08 Thread Luis R. Rodriguez
firmware_loader/ directory later. This also now recommends using firmwared [0] for folks left needing a uevent handler in userspace for the sysfs firmware fallback mechanis given udev's uevent firmware mechanism was ripped out a while ago. [0] https://github.com/teg/firmwared Signed-off-by: L

[PATCH v6 03/13] firmware: rename fw_sysfs_fallback to firmware_fallback_sysfs()

2018-05-08 Thread Luis R. Rodriguez
From: Andres Rodriguez This is done since this call is now exposed through kernel-doc, and since this also paves the way for different future types of fallback mechanims. Signed-off-by: Andres Rodriguez Acked-by: Luis R. Rodriguez [mcgrof: small coding style changes] Signed-off-by: Luis R

[PATCH v6 06/13] firmware_loader: move kconfig FW_LOADER entries to its own file

2018-05-08 Thread Luis R. Rodriguez
This will make it easier to track and easier to understand what components and features are part of the FW_LOADER. There are some components related to firmware which have *nothing* to do with the FW_LOADER, souch as PREVENT_FIRMWARE_BUILD. Signed-off-by: Luis R. Rodriguez --- drivers/base

[PATCH v6 09/13] ath10k: use firmware_request_nowarn() to load firmware

2018-05-08 Thread Luis R. Rodriguez
From: Andres Rodriguez This reduces the unnecessary spew when trying to load optional firmware: "Direct firmware load for ... failed with error -2" Signed-off-by: Andres Rodriguez Acked-by: Kalle Valo Signed-off-by: Luis R. Rodriguez --- drivers/net/wireless/ath/ath10k/core.c | 2

[PATCH v6 10/13] ath10k: re-enable the firmware fallback mechanism for testmode

2018-05-08 Thread Luis R. Rodriguez
enabled. So use that instead. Signed-off-by: Andres Rodriguez Acked-by: Kalle Valo Signed-off-by: Luis R. Rodriguez --- drivers/net/wireless/ath/ath10k/testmode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/testmode.c b/drivers/net/wireless

[PATCH v6 07/13] firmware_loader: make firmware_fallback_sysfs() print more useful

2018-05-08 Thread Luis R. Rodriguez
RN when dealing with the fallback mechanism, we will soon, so just respect its use consistently. And even if you *don't* want to print always on failure, you may want to print when debugging so enable dynamic debug print when FW_OPT_NO_WARN is used. Signed-off-by: Luis R. Rodriguez --- drivers/

[PATCH v6 11/13] Documentation: fix few typos and clarifications for the firmware loader

2018-05-08 Thread Luis R. Rodriguez
Fix a few typos, and clarify a few sentences. Signed-off-by: Luis R. Rodriguez --- Documentation/driver-api/firmware/fallback-mechanisms.rst | 5 +++-- Documentation/driver-api/firmware/firmware_cache.rst | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a

[PATCH v6 08/13] firmware: add firmware_request_nowarn() - load firmware without warnings

2018-05-08 Thread Luis R. Rodriguez
. Rodriguez [mcgrof: used the old API calls as the full rename is not done yet, and add the caller for when FW_LOADER is disabled, enhance documentation ] Signed-off-by: Luis R. Rodriguez --- .../driver-api/firmware/request_firmware.rst | 5 drivers/base/firmware_loader/main.c | 27

[PATCH v6 12/13] Documentation: remove stale firmware API reference

2018-05-08 Thread Luis R. Rodriguez
It refers to a pending patch, but this was merged eons ago. Signed-off-by: Luis R. Rodriguez --- Documentation/dell_rbu.txt | 3 --- 1 file changed, 3 deletions(-) diff --git a/Documentation/dell_rbu.txt b/Documentation/dell_rbu.txt index 0fdb6aa2704c..077fdc29a0d0 100644 --- a/Documentation

[PATCH v6 13/13] Documentation: clarify firmware_class provenance and why we can't rename the module

2018-05-08 Thread Luis R. Rodriguez
Clarify the provenance of the firmware loader firmware_class module name and why we cannot rename the module in the future. Signed-off-by: Luis R. Rodriguez --- .../driver-api/firmware/fallback-mechanisms.rst | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a

Re: [PATCH v5 0/6] firmware_loader: cleanups for v4.18

2018-05-08 Thread Luis R. Rodriguez
On Fri, May 04, 2018 at 10:43:49AM -0700, Luis R. Rodriguez wrote: > Greg, > > I've reviewed the pending patches for the firmware_laoder and as for > v4.18, the following 3 patches from Andres have been iterated enough > that they're ready after I made some final m

Re: [PATCH v2 net-next 2/4] net: add skeleton of bpfilter kernel module

2018-05-07 Thread Luis R. Rodriguez
On Wed, May 02, 2018 at 09:36:02PM -0700, Alexei Starovoitov wrote: > bpfilter.ko consists of bpfilter_kern.c (normal kernel module code) > and user mode helper code that is embedded into bpfilter.ko > > The steps to build bpfilter.ko are the following: > - main.c is compiled by HOSTCC into the bp

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

2018-05-07 Thread Luis R. Rodriguez
On Fri, May 04, 2018 at 06:37:11PM -0700, Alexei Starovoitov wrote: > On Fri, May 04, 2018 at 07:56:43PM +0000, Luis R. Rodriguez wrote: > > What a mighty short list of reviewers. Adding some more. My review below. > > I'd appreciate a Cc on future versions of these patches.

Re: [PATCH v5 0/6] firmware_loader: cleanups for v4.18

2018-05-04 Thread Luis R. Rodriguez
On Fri, May 04, 2018 at 09:17:08PM +0200, Krzysztof Halasa wrote: > "Luis R. Rodriguez" writes: > > > * CONFIG_WANXL --> CONFIG_WANXL_BUILD_FIRMWARE > > * CONFIG_SCSI_AIC79XX --> CONFIG_AIC79XX_BUILD_FIRMWARE > > > > To this day both of thes

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

2018-05-04 Thread Luis R. Rodriguez
What a mighty short list of reviewers. Adding some more. My review below. I'd appreciate a Cc on future versions of these patches. On Wed, May 02, 2018 at 09:36:01PM -0700, Alexei Starovoitov wrote: > Introduce helper: > int fork_usermode_blob(void *data, size_t len, struct umh_info *info); > stru

[PATCH v5 1/6] firmware: wrap FW_OPT_* into an enum

2018-05-04 Thread Luis R. Rodriguez
From: Andres Rodriguez This should let us associate enum kdoc to these values. While at it, kdocify the fw_opt. Signed-off-by: Andres Rodriguez Acked-by: Luis R. Rodriguez [mcgrof: coding style fixes, merge kdoc with enum move] Signed-off-by: Luis R. Rodriguez --- drivers/base

[PATCH v5 0/6] firmware_loader: cleanups for v4.18

2018-05-04 Thread Luis R. Rodriguez
o an enum firmware: use () to terminate kernel-doc function names firmware: rename fw_sysfs_fallback to firmware_fallback_sysfs() Luis R. Rodriguez (3): firmware_loader: document firmware_sysfs_fallback() firmware_loader: enhance Kconfig documentation over FW_LOADER firmware_loader: move

[PATCH v5 3/6] firmware: rename fw_sysfs_fallback to firmware_fallback_sysfs()

2018-05-04 Thread Luis R. Rodriguez
From: Andres Rodriguez This is done since this call is now exposed through kernel-doc, and since this also paves the way for different future types of fallback mechanims. Signed-off-by: Andres Rodriguez Acked-by: Luis R. Rodriguez [mcgrof: small coding style changes] Signed-off-by: Luis R

[PATCH v5 2/6] firmware: use () to terminate kernel-doc function names

2018-05-04 Thread Luis R. Rodriguez
From: Andres Rodriguez The kernel-doc spec dictates a function name ends in (). Signed-off-by: Andres Rodriguez Acked-by: Randy Dunlap Acked-by: Luis R. Rodriguez Signed-off-by: Luis R. Rodriguez --- drivers/base/firmware_loader/fallback.c | 8 drivers/base/firmware_loader/main.c

[PATCH v5 4/6] firmware_loader: document firmware_sysfs_fallback()

2018-05-04 Thread Luis R. Rodriguez
This also sets the expecations for future fallback interfaces, even if they are not exported. Signed-off-by: Luis R. Rodriguez --- drivers/base/firmware_loader/fallback.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/base/firmware_loader/fallback.c b/drivers

[PATCH v5 6/6] firmware_loader: move kconfig FW_LOADER entries to its own file

2018-05-04 Thread Luis R. Rodriguez
This will make it easier to track and easier to understand what components and features are part of the FW_LOADER. There are some components related to firmware which have *nothing* to do with the FW_LOADER, souch as PREVENT_FIRMWARE_BUILD. Signed-off-by: Luis R. Rodriguez --- drivers/base

[PATCH v5 5/6] firmware_loader: enhance Kconfig documentation over FW_LOADER

2018-05-04 Thread Luis R. Rodriguez
firmware_loader/ directory later. Signed-off-by: Luis R. Rodriguez --- drivers/base/Kconfig | 160 ++- 1 file changed, 126 insertions(+), 34 deletions(-) diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig index 29b0eb452b3a..bf2d464b0e2c 100644 --- a/drivers

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

2018-03-22 Thread Luis R. Rodriguez
On Thu, Mar 22, 2018 at 3:15 PM, Andy Lutomirski wrote: > All we need to do is to make sure that, if this is > distributed as a module, that it's init routine doesn't wait for a > long time, right? Yeap. Luis

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

2018-03-22 Thread Luis R. Rodriguez
On Sat, Mar 10, 2018 at 03:16:52PM +, Luis R. Rodriguez wrote: > On Sat, Mar 10, 2018 at 02:08:43PM +0000, Luis R. Rodriguez wrote: > > The alternative to this would be a simple equivalent of > > try_then_request_module() > > for UMH modules: try_umhm_then_request_umh_mod

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

2018-03-11 Thread Luis R. Rodriguez
On Sat, Mar 10, 2018 at 02:08:43PM +, Luis R. Rodriguez wrote: > The alternative to this would be a simple equivalent of > try_then_request_module() > for UMH modules: try_umhm_then_request_umh_module() or whatever. So just as I > argued earlier over UMH limitations, this is no

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

2018-03-11 Thread Luis R. Rodriguez
Also, Alexei you never answered my questions out aliases with the umh modules. Long term this important to consider. Luis

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

2018-03-10 Thread Luis R. Rodriguez
On Fri, Mar 09, 2018 at 06:34:18PM -0800, Alexei Starovoitov wrote: > On 3/9/18 11:38 AM, Linus Torvalds wrote: > > On Fri, Mar 9, 2018 at 11:12 AM, Linus Torvalds > > wrote: > > > > > > How are you going to handle five processes doing the same setup > > > concurrently? Let's keep in mind we don

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

2018-03-08 Thread Luis R. Rodriguez
On Thu, Mar 08, 2018 at 03:07:01PM -0800, Alexei Starovoitov wrote: > On 3/7/18 5:23 PM, Luis R. Rodriguez wrote: > > > > request_module() has its own world though too. How often in your proof of > > concept is request_module() called? How many times do you envision it being

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

2018-03-07 Thread Luis R. Rodriguez
On Mon, Mar 05, 2018 at 05:34:57PM -0800, Alexei Starovoitov wrote: > As the first step in development of bpfilter project [1] So meta :) The URL refers an lwn article, which in turn refers to this effort's first RFC. As someone only getting *one* of these patches in emails, It would be useful if

Re: [PATCH] selftest: fix kselftest-merge depend on 'RUNTIME_TESTING_MENU'

2018-02-22 Thread Luis R. Rodriguez
On Thu, Feb 22, 2018 at 07:53:07PM +0800, Zong Li wrote: > Since the 'commit d3deafaa8b5c ("lib/: make RUNTIME_TESTS a menuconfig > to ease disabling it all")', the make kselftest-merge cannot merge the > config dependencies of kselftest to the existing .config file. > > These config dependencies

Re: [PATCH v2 0/6] wl1251: Fix MAC address for Nokia N900

2018-01-04 Thread Luis R. Rodriguez
On Tue, Jan 02, 2018 at 08:23:45PM +0100, Pali Rohár wrote: > On Friday 10 November 2017 00:38:22 Pali Rohár wrote: > > This patch series fix processing MAC address for wl1251 chip found in Nokia > > N900. > > > > Changes since v1: > > * Added Acked-by for Pavel Machek > > * Fixed grammar > > * M

Re: [PATCH v5 next 2/5] modules:capabilities: add cap_kernel_module_request() permission check

2017-11-29 Thread Luis R. Rodriguez
On Mon, Nov 27, 2017 at 06:18:35PM +0100, Djalal Harouni wrote: > +/* Determine whether a module auto-load operation is permitted. */ > +int may_autoload_module(char *kmod_name, int required_cap, > + const char *kmod_prefix); > + While we are reviewing a general LSM for this, i

Re: [PATCH v5 next 3/5] modules:capabilities: automatic module loading restriction

2017-11-29 Thread Luis R. Rodriguez
On Mon, Nov 27, 2017 at 06:18:36PM +0100, Djalal Harouni wrote: > diff --git a/include/linux/module.h b/include/linux/module.h > index 5cbb239..c36aed8 100644 > --- a/include/linux/module.h > +++ b/include/linux/module.h > @@ -261,7 +261,16 @@ struct notifier_block; > > #ifdef CONFIG_MODULES >

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

2017-11-28 Thread Luis R. Rodriguez
On Tue, Nov 28, 2017 at 02:18:18PM -0800, Kees Cook wrote: > On Tue, Nov 28, 2017 at 2:12 PM, Luis R. Rodriguez wrote: > > On Tue, Nov 28, 2017 at 01:39:58PM -0800, Kees Cook wrote: > >> On Tue, Nov 28, 2017 at 1:16 PM, Luis R. Rodriguez > >> wrote: > >> &

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

2017-11-28 Thread Luis R. Rodriguez
On Tue, Nov 28, 2017 at 10:33:27PM +0100, Djalal Harouni wrote: > On Tue, Nov 28, 2017 at 10:16 PM, Luis R. Rodriguez wrote: > > On Tue, Nov 28, 2017 at 12:11:34PM -0800, Kees Cook wrote: > >> On Tue, Nov 28, 2017 at 11:14 AM, Luis R. Rodriguez > >> wrote: > >

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

2017-11-28 Thread Luis R. Rodriguez
On Tue, Nov 28, 2017 at 01:39:58PM -0800, Kees Cook wrote: > On Tue, Nov 28, 2017 at 1:16 PM, Luis R. Rodriguez wrote: > > And *all* auto-loading uses aliases? What's the difference between > > auto-loading > > and direct-loading? > > The difference is the

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

2017-11-28 Thread Luis R. Rodriguez
On Tue, Nov 28, 2017 at 12:11:34PM -0800, Kees Cook wrote: > On Tue, Nov 28, 2017 at 11:14 AM, Luis R. Rodriguez wrote: > > kmod is just a helper to poke userpsace to load a module, that's it. > > > > The old init_module() and newer finit_module() do the real handy work

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

2017-11-28 Thread Luis R. Rodriguez
On Mon, Nov 27, 2017 at 06:18:34PM +0100, Djalal Harouni wrote: ... > After a discussion with Rusty Russell [1], the suggestion was to pass > the capability from request_module() to security_kernel_module_request() > for 'netdev-%s' modules that need CAP_NET_ADMIN, and after review from > Kees Coo

Re: [PATCH v2 5/6] firmware: Add request_firmware_prefer_user() function

2017-11-10 Thread Luis R. Rodriguez
On Fri, Nov 10, 2017 at 10:08:19PM +0100, Pali Rohár wrote: > On Friday 10 November 2017 21:26:01 Luis R. Rodriguez wrote: > > On Fri, Nov 10, 2017 at 12:38:27AM +0100, Pali Rohár wrote: > > > This function works pretty much like request_firmware(), but it prefer > > > u

Re: [PATCH v2 5/6] firmware: Add request_firmware_prefer_user() function

2017-11-10 Thread Luis R. Rodriguez
On Fri, Nov 10, 2017 at 12:26 PM, Luis R. Rodriguez wrote: > even if you *leave* the flag in place and a driver required > this, but the kernel was compiled without CONFIG_FW_LOADER_USER_HELPER then > calling fw_load_from_user_helper would just already return -ENOENT, as such it > w

Re: [PATCH v2 5/6] firmware: Add request_firmware_prefer_user() function

2017-11-10 Thread Luis R. Rodriguez
On Fri, Nov 10, 2017 at 12:38:27AM +0100, Pali Rohár wrote: > This function works pretty much like request_firmware(), but it prefer > usermode helper. If usermode helper fails then it fallback to direct > access. Useful for dynamic or model specific firmware data. > > Signed-off-by: Pali Rohár >

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-08-10 Thread Luis R. Rodriguez
On Fri, Jun 30, 2017 at 11:35:41PM +0200, Arend van Spriel wrote: > On 23-06-17 23:53, Luis R. Rodriguez wrote: > > On Tue, May 16, 2017 at 10:41:08AM +0200, Arend Van Spriel wrote: > >> On 16-5-2017 1:13, Luis R. Rodriguez wrote: > >>> Since no upstream delta is ne

Re: [PATCH V5 1/2] firmware: add more flexible request_firmware_async function

2017-08-10 Thread Luis R. Rodriguez
On Thu, Aug 03, 2017 at 05:55:18AM +, Coelho, Luciano wrote: > On Thu, 2017-08-03 at 08:23 +0300, Kalle Valo wrote: > > "Luis R. Rodriguez" writes: > > > > > > +int request_firmware_nowait(struct module *module, bool uevent, > > > > +

Re: [PATCH V5 1/2] firmware: add more flexible request_firmware_async function

2017-08-10 Thread Luis R. Rodriguez
On Thu, Aug 03, 2017 at 08:23:00AM +0300, Kalle Valo wrote: > "Luis R. Rodriguez" writes: > > >> +int request_firmware_nowait(struct module *module, bool uevent, > >> + const char *name, struct device *device, gfp_t gfp, > &g

Re: [PATCH V5 1/2] firmware: add more flexible request_firmware_async function

2017-08-03 Thread Luis R. Rodriguez
On Thu, Aug 03, 2017 at 05:55:18AM +, Coelho, Luciano wrote: > On Thu, 2017-08-03 at 08:23 +0300, Kalle Valo wrote: > > "Luis R. Rodriguez" writes: > > > > > > +int request_firmware_nowait(struct module *module, bool uevent, > > > > +

Re: sysctl, argument parsing, possible bug

2017-08-02 Thread Luis R. Rodriguez
On Tue, Aug 01, 2017 at 02:54:51PM -0700, Cong Wang wrote: > On Tue, Aug 1, 2017 at 2:34 PM, Massimo Sala > wrote: > > Do you confirm it is a sysctl parsing bug ? > > > > Bosybox handles these cases, so I think also standalone sysctl have to. > > > > Or at least someone must update sysctl docs /

Re: [PATCH V5 1/2] firmware: add more flexible request_firmware_async function

2017-08-02 Thread Luis R. Rodriguez
On Mon, Jul 31, 2017 at 05:09:44PM +0200, Rafał Miłecki wrote: > From: Rafał Miłecki > > So far we got only one function for loading firmware asynchronously: > request_firmware_nowait. It didn't allow much customization of firmware > loading process - there is only one bool uevent argument. Moreo

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-06-23 Thread Luis R. Rodriguez
On Tue, May 16, 2017 at 10:41:08AM +0200, Arend Van Spriel wrote: > On 16-5-2017 1:13, Luis R. Rodriguez wrote: > > Since no upstream delta is needed for firmwared I'd like to first encourage > > evaluating the above. While distributions don't carry it yet that may be >

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-16 Thread Luis R. Rodriguez
On Tue, May 16, 2017 at 10:41:08AM +0200, Arend Van Spriel wrote: > On 16-5-2017 1:13, Luis R. Rodriguez wrote: > > On Fri, May 12, 2017 at 11:02:26PM +0200, Arend Van Spriel wrote: > >> try again.. replacing email address from Michał > >> On 12-5-2017 22:55, Arend Van

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-15 Thread Luis R. Rodriguez
On Fri, May 12, 2017 at 11:02:26PM +0200, Arend Van Spriel wrote: > try again.. replacing email address from Michał > On 12-5-2017 22:55, Arend Van Spriel wrote: > > Let me explain the idea to refresh your memory (and mine). It started > > when we were working on adding driver support for OpenWrt i

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-03 Thread Luis R. Rodriguez
On Wed, May 03, 2017 at 09:02:20PM +0200, Arend Van Spriel wrote: > On 3-1-2017 18:59, Luis R. Rodriguez wrote: > > On Mon, Dec 26, 2016 at 05:35:59PM +0100, Pavel Machek wrote: > >> > >> Right question is "should we solve it without user-space help"? > &g

[RFC] igmp: address pmc kmemleak from on igmpv3_del_delrec()

2017-02-03 Thread Luis R. Rodriguez
4+0x0/0x6a [] 0x Signed-off-by: Luis R. Rodriguez --- I can reproduce this over time on a qemu box running next-20170125. After running this for a while I no longer see the splat. This needs confirmation form folks more familiar with the code, hence RFC. If this is a real f

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-29 Thread Luis R. Rodriguez
On Fri, Jan 27, 2017 at 02:11:46PM +0100, Pali Rohár wrote: > So there are only two options: > > 1) Disallow it and so these users will have non-working wifi. > > 2) Allow those data to be used as fallback mechanism. There is one "custom fallback" user in kernel which we recently determined was

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-03 Thread Luis R. Rodriguez
On Mon, Dec 26, 2016 at 05:35:59PM +0100, Pavel Machek wrote: > > Right question is "should we solve it without user-space help"? > > Answer is no, too. Way too complex. Yes, it would be nice if hardware > was designed in such a way that getting calibration data from kernel > is easy, and if you

Re: wl1251 & mac address & calibration data

2016-12-15 Thread Luis R. Rodriguez
On Thu, Dec 15, 2016 at 2:12 PM, Arend Van Spriel wrote: > On 15-12-2016 16:33, Pali Rohár wrote: >> On Thu Dec 15 09:18:44 2016 Kalle Valo wrote: >>> (Adding Luis because he has been working on request_firmware() lately) >>> >>> Pali Rohár writes: >>> >> So no, there is no argument against.

Re: [PATCH 0/2] wireless: Use complete() instead complete_all()

2016-08-18 Thread Luis R. Rodriguez
On Thu, Aug 18, 2016 at 03:12:04PM +0200, Daniel Wagner wrote: > This series ignores all complete_all() usages in the firmware loading > path. They will be hopefully address by Luis' sysdata patches [0]. > That leaves a couple of complete_all() calls. I had not considered this as a gain, but glad

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Move ioremap_wc tracking onto VMA

2016-04-20 Thread Luis R. Rodriguez
On Wed, Apr 20, 2016 at 01:17:30PM +0200, Daniel Vetter wrote: > On Wed, Apr 20, 2016 at 11:10:54AM +0200, Luis R. Rodriguez wrote: > > Reason I ask is since I noticed a while ago a lot of drivers > > were using info->fix.smem_start and info->fix.smem_len consistently > >

Re: [PATCH 02/19] io-mapping: Specify mapping size for io_mapping_map_wc()

2016-04-20 Thread Luis R. Rodriguez
On Wed, Apr 20, 2016 at 08:14:32PM +0100, Chris Wilson wrote: > On Wed, Apr 20, 2016 at 08:58:44PM +0200, Luis R. Rodriguez wrote: > > On Wed, Apr 20, 2016 at 07:42:13PM +0100, Chris Wilson wrote: > > > The ioremap() hidden behind the io_mapping_map_wc() convenience helper >

Re: [PATCH 02/19] io-mapping: Specify mapping size for io_mapping_map_wc()

2016-04-20 Thread Luis R. Rodriguez
n > Cc: Tvrtko Ursulin > Cc: Daniel Vetter > Cc: Jani Nikula > Cc: David Airlie > Cc: Yishai Hadas > Cc: Dan Williams > Cc: Ingo Molnar > Cc: "Peter Zijlstra (Intel)" > Cc: David Hildenbrand > Cc: Luis R. Rodriguez > Cc: intel-...@lists.freedesk

Re: [PATCH 4/4] drm/i915: Move ioremap_wc tracking onto VMA

2016-04-20 Thread Luis R. Rodriguez
On Tue, Apr 19, 2016 at 01:33:58PM +0100, Chris Wilson wrote: > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > index 6ce2c31b9a81..9ef47329e8ae 100644 > --- a/drivers/gpu/drm/i915/i915_gem.c > +++ b/drivers/gpu/drm/i915/i915_gem.c > @@ -3346,6 +3346,15 @@ static vo

Re: [PATCH v2 2/4] io-mapping: Specify mapping size for io_mapping_map_wc()

2016-04-19 Thread Luis R. Rodriguez
On Tue, Apr 19, 2016 at 01:02:25PM +0100, Chris Wilson wrote: > On Mon, Apr 18, 2016 at 12:14:00PM +0100, Chris Wilson wrote: > > The ioremap() hidden behind the io_mapping_map_wc() convenience helper > > can be used for remapping multiple pages. Extend the helper so that > > future callers can use

[PATCH v4 11/11] mtrr: bury MTRR - unexport mtrr_add() and mtrr_del()

2015-08-24 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" The crusade to replace mtrr_add() with architecture agnostic arch_phys_wc_add() is complete, this will ensure write-combining implementations (PAT on x86) is taken advantage instead of using MTRR. With the crusade done now, hide direct MTRR access for driver

Re: [PATCH v2] README: clarify redistribution requirements covering patents

2015-06-11 Thread Luis R. Rodriguez
On Thu, May 28, 2015 at 5:48 PM, Luis R. Rodriguez wrote: > On Tue, May 19, 2015 at 1:22 PM, Luis R. Rodriguez > wrote: >> This v2 just changes "licence" to "license" as requested by Arend. > > Please let me know if there is anything else needed.

Re: [PATCH v2] README: clarify redistribution requirements covering patents

2015-05-28 Thread Luis R. Rodriguez
On Tue, May 19, 2015 at 1:22 PM, Luis R. Rodriguez wrote: > This v2 just changes "licence" to "license" as requested by Arend. Please let me know if there is anything else needed. Luis -- To unsubscribe from this list: send the line "unsubscribe netdev" i

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-21 Thread Luis R. Rodriguez
On Tue, Apr 21, 2015 at 06:51:26PM -0400, Andy Walls wrote: > Sorry for the top post; mobile work email account. > > Luis, > > You do the changes to remove MTTR and point me to your dev repo and branch. > Also point me to the new functions/primitives I'll need. There is nothing new actually need

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-21 Thread Luis R. Rodriguez
On Tue, Apr 21, 2015 at 3:02 PM, Luis R. Rodriguez wrote: > Andy, can we live without MTRR support on this driver for future kernels? This > would only leave ipath as the only offending driver. Sorry to be clear, can we live with removal of write-combining on this driver? Luis

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-21 Thread Luis R. Rodriguez
On Wed, Apr 15, 2015 at 09:07:37PM -0400, Andy Walls wrote: > On Thu, 2015-04-16 at 01:58 +0200, Luis R. Rodriguez wrote: > > Hey Andy, thanks for your review, adding Hyong-Youb Kim for review of the > > full range ioremap_wc() idea below. > > > > On Wed, Apr 15, 201

[PATCH v3] ethernet: myri10ge: use arch_phys_wc_add()

2015-04-21 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This driver already uses ioremap_wc() on the same range so when write-combining is available that will be used instead. Cc: Hyong-Youb Kim Cc: Andy Lutomirski Cc: Suresh Siddha Cc: Ingo Molnar Cc: Thomas Gleixner Cc: Juergen Gross Cc: Daniel Vetter

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-16 Thread Luis R. Rodriguez
On Thu, Apr 16, 2015 at 01:18:37PM +0900, Hyong-Youb Kim wrote: > On Thu, Apr 16, 2015 at 01:58:16AM +0200, Luis R. Rodriguez wrote: > > > > An alternative... is to just ioremap_wc() the entire region, including > > MMIO registers for these old devices. I see one ethe

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-15 Thread Luis R. Rodriguez
Hey Andy, thanks for your review, adding Hyong-Youb Kim for review of the full range ioremap_wc() idea below. On Wed, Apr 15, 2015 at 06:38:51PM -0400, Andy Walls wrote: > Hi All, > > On Mon, 2015-04-13 at 19:49 +0200, Luis R. Rodriguez wrote: > > From the beginning it seems o

Re: Atheros driver

2008-01-07 Thread Luis R. Rodriguez
On Jan 6, 2008 4:21 PM, John W. Linville <[EMAIL PROTECTED]> wrote: > > On Sun, Jan 06, 2008 at 09:04:02PM +0100, Ralph Spitzner wrote: > > With Kernel 2.6.23.12 && ath5k I get this: > > -- > > > > Jan 6 20:42:44 meepmeep kernel: CPU:

Re: [PATCH] Fix infinite loop on dev_mc_unsync()

2007-11-09 Thread Luis R. Rodriguez
On Fri, Nov 09, 2007 at 11:07:16AM -0800, Joe Perches wrote: > On Fri, 2007-11-09 at 13:51 -0500, Luis R. Rodriguez wrote: > > While reviewing net/core/dev_mcast.c I found what I think is an > > infinite loop on dev_mc_unsync(). This fixes it. We make use of > > th

Re: [PATCH] Fix infinite loop on dev_mc_unsync()

2007-11-09 Thread Luis R. Rodriguez
Sorry, forgot to CC David. On Fri, Nov 09, 2007 at 10:11:35AM -0500, Luis R. Rodriguez wrote: While reviewing net/core/dev_mcast.c I found what I think is an infinite loop on dev_mc_unsync(). This fixes it. We make use of this guy on mac80211 in ieee80211_stop(). This is untested. Signed-off

[PATCH] Fix infinite loop on dev_mc_unsync()

2007-11-09 Thread Luis R. Rodriguez
While reviewing net/core/dev_mcast.c I found what I think is an infinite loop on dev_mc_unsync(). This fixes it. We make use of this guy on mac80211 in ieee80211_stop(). This is untested. Signed-off-by: Luis R. Rodriguez <[EMAIL PROTECTED]> diff --git a/net/core/dev_mcast.c b/ne

Re: RFC: Reproducible oops with lockdep on count_matching_names()

2007-11-03 Thread Luis R. Rodriguez
On 11/2/07, Peter Zijlstra <[EMAIL PROTECTED]> wrote: > On Thu, 2007-11-01 at 19:26 -0400, Michael Wu wrote: > > On Thursday 01 November 2007 15:17:16 Luis R. Rodriguez wrote: > > > [EMAIL PROTECTED]:~/devel/wireless-2.6$ git-describe > > > v2.6.24-rc1-146-g2280

Re: [PATCH] pegasos_eth.c: Fix compile error over MV643XX_ defines

2007-10-29 Thread Luis R. Rodriguez
On 10/29/07, Dale Farnsworth <[EMAIL PROTECTED]> wrote: > On Mon, Oct 29, 2007 at 05:27:29PM -0400, Luis R. Rodriguez wrote: > > This commit made an incorrect assumption: > > -- > > Author: Lennert Buytenhek <[EMAIL PROTECTED]> > > Date: Fri Oct 19 04:1

[PATCH] pegasos_eth.c: Fix compile error over MV643XX_ defines

2007-10-29 Thread Luis R. Rodriguez
' undeclared (first use in this function) arch/powerpc/platforms/chrp/pegasos_eth.c:154: error: 'MV643XX_ETH_BASE_ADDR_ENABLE_REG' undeclared (first use in this function) make[2]: *** [arch/powerpc/platforms/chrp/pegasos_eth.o] Error 1 make[1]: *** [arch/powerpc/platforms/chrp] Error 2

Re: That whole "Linux stealing our code" thing

2007-09-01 Thread Luis R. Rodriguez
On 9/1/07, Constantine A. Murenin <[EMAIL PROTECTED]> wrote: > On 01/09/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > > Jason Dixon wrote: > > > Once the grantor (Reyk) releases his code under that license, it must > > > remain. You are free to derive work and redistribute under your > > > license,

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-01 Thread Luis R. Rodriguez
I urge developers to not bait into this and just leave this alone. Those involved know what they are doing and have a strong team of attorneys watching their backs. Any *necessary* discussions are be done privately. Luis - To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

2007-08-28 Thread Luis R. Rodriguez
On 8/28/07, Larry Finger <[EMAIL PROTECTED]> wrote: > Johannes Berg wrote: > > On Tue, 2007-08-28 at 18:10 +0100, Christoph Hellwig wrote: > >> On Tue, Aug 28, 2007 at 11:58:52AM -0400, Jiri Slaby wrote: > >>> -ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o > >>> +ath5k-objs =

Re: [PATCH 4/5] Net: ath5k, license is GPLv2

2007-08-28 Thread Luis R. Rodriguez
On 8/28/07, Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Tue, Aug 28, 2007 at 12:00:50PM -0400, Jiri Slaby wrote: > > ath5k, license is GPLv2 > > > > The files are available only under GPLv2 since now. > > Is this really a good idea? Most of the reverse-engineering was > done by the OpenBSD f

Re: Removing the prism54 module

2007-07-31 Thread Luis R. Rodriguez
On 7/28/07, Edward Ando <[EMAIL PROTECTED]> wrote: > Dear All, > I am trying to set up software suspend 2 (TuxOnIce now it seems). This > has decided it wants to remove the prism54 module before starting the > hibernate process. > > When it tries to do this, (or when I manually do: "ifconfig eth1 >

Marvell Libertas 8388 802.11 USB - added to Orbit

2007-01-25 Thread Luis R. Rodriguez
I've slapped the two Marvell Libertas 8388 802.11 USB cards onto Winlab's Orbit testbed on sandbox 8. This allows anyone willing to help hack on the driver with access to a node with the wireless card. http://www.orbit-lab.org/wiki/Documentation/Developers Luis - To unsubscribe from this list:

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-12-05 Thread Luis R. Rodriguez
On 12/5/06, Stephen Hemminger <[EMAIL PROTECTED]> wrote: On Tue, 5 Dec 2006 10:15:33 -0500 "Luis R. Rodriguez" <[EMAIL PROTECTED]> wrote: > On 12/5/06, Michael Renzmann <[EMAIL PROTECTED]> wrote: > openhal here. > > > > I've set up the sugge

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-12-05 Thread Luis R. Rodriguez
On 12/5/06, Michael Renzmann <[EMAIL PROTECTED]> wrote: openhal here. I've set up the suggested branches, with slight changing to the proposed names: * http://svn.madwifi.org/branches/madwifi-old-openhal (based on r1142) * http://svn.madwifi.org/branches/dadwifi-openhal (based on r1827) Neithe

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-12-01 Thread Luis R. Rodriguez
On 12/1/06, Luis R. Rodriguez <[EMAIL PROTECTED]> wrote: * madwifi-1152-openhal: based on madwifi-1152, patched with my patch, added openhal, old hal removed. Working free solution. Should exist just as a reference and to allow users to checkout a working free alternative in the mea

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-12-01 Thread Luis R. Rodriguez
On 11/29/06, Stephen Hemminger <[EMAIL PROTECTED]> wrote: On Wed, 29 Nov 2006 08:03:28 -0800 David Kimdon <[EMAIL PROTECTED]> wrote: > On Wed, Nov 29, 2006 at 04:38:56PM +0100, Michael Buesch wrote: > > On Wednesday 29 November 2006 16:24, David Kimdon wrote: > > > On Wed, Nov 29, 2006 at 04:12:

Re: [PATCH wireless-2.6-git] prism54: WPA/RSN support for fullmac cards

2006-11-09 Thread Luis R. Rodriguez
On 11/9/06, Luis R. Rodriguez <[EMAIL PROTECTED]> wrote: On 11/9/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Am Mittwoch, 8. November 2006 01:39 schrieben Sie: > > On Fri, Nov 03, 2006 at 01:41:46PM -0500, Luis R. Rodriguez wrote: > > > On 11/3/06, [EMAI

Re: [PATCH wireless-2.6-git] prism54: WPA/RSN support for fullmac cards

2006-11-09 Thread Luis R. Rodriguez
On 11/9/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Am Mittwoch, 8. November 2006 01:39 schrieben Sie: > On Fri, Nov 03, 2006 at 01:41:46PM -0500, Luis R. Rodriguez wrote: > > On 11/3/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > >yes, especially mgt_com

Re: [PATCH wireless-2.6-git] prism54: WPA/RSN support for fullmac cards

2006-11-03 Thread Luis R. Rodriguez
On 11/3/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Am Freitag, 3. November 2006 17:06 schrieben Sie: > On 11/3/06, Dan Williams <[EMAIL PROTECTED]> wrote: > > On Tue, 2006-10-31 at 11:05 -0500, Dan Williams wrote: > > > On Mon, 2006-10-30 at 15:17 -0500, Luis

Re: [PATCH wireless-2.6-git] prism54: WPA/RSN support for fullmac cards

2006-11-03 Thread Luis R. Rodriguez
On 11/3/06, Dan Williams <[EMAIL PROTECTED]> wrote: On Tue, 2006-10-31 at 11:05 -0500, Dan Williams wrote: > On Mon, 2006-10-30 at 15:17 -0500, Luis R. Rodriguez wrote: > > On 10/29/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > > This patch completes WPA

Re: [patch] d80211: use pfifo_qdisc_ops rather than d80211-specific qdisc

2006-11-02 Thread Luis R. Rodriguez
On 11/2/06, Stephen Hemminger <[EMAIL PROTECTED]> wrote: Please have Ethernet (and wireless) devices show up as eth%d. For the master device, choose something else (mac%d ?). If ultimately we're going to make wireless devices, as John puts it, "1st class citizens" by making 802.11 a full proto

  1   2   >