Re: [PATCH v2 1/1] kernel.h: Split out panic and oops helpers

2021-04-09 Thread Luis Chamberlain
u > Acked-by: Rasmus Villemoes > Signed-off-by: Andrew Morton Acked-by: Luis Chamberlain Luis

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-07-03 Thread Luis Chamberlain
On Fri, Jul 03, 2020 at 09:52:01AM +0900, Tetsuo Handa wrote: > On 2020/07/03 4:46, Luis Chamberlain wrote: > > The alternative to making a compromise is using generic wrappers for > > things which make sense and letting the callers use those. > > I suggest just intr

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-07-02 Thread Luis Chamberlain
On Thu, Jul 02, 2020 at 01:26:53PM +0900, Tetsuo Handa wrote: > On 2020/07/02 0:38, Luis Chamberlain wrote: > > @@ -156,6 +156,18 @@ static void call_usermodehelper_exec_sync(struct > > subprocess_info *sub_info) > > */ > >

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-07-01 Thread Luis Chamberlain
On Wed, Jul 01, 2020 at 05:48:48PM +0200, Christian Borntraeger wrote: > > > On 01.07.20 17:38, Luis Chamberlain wrote: > > On Wed, Jul 01, 2020 at 11:08:57PM +0900, Tetsuo Handa wrote: > >> On 2020/07/01 22:53, Luis Chamberlain wrote: > >>>> Well, it is

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-07-01 Thread Luis Chamberlain
On Wed, Jul 01, 2020 at 11:08:57PM +0900, Tetsuo Handa wrote: > On 2020/07/01 22:53, Luis Chamberlain wrote: > >> Well, it is not br_stp_call_user() but br_stp_start() which is expecting > >> to set sub_info->retval for both KWIFEXITED() case and KWIFSIGNALED() case. > &

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-07-01 Thread Luis Chamberlain
On Wed, Jul 01, 2020 at 10:24:29PM +0900, Tetsuo Handa wrote: > On 2020/07/01 19:08, Christian Borntraeger wrote: > > > > > > On 30.06.20 19:57, Luis Chamberlain wrote: > >> On Fri, Jun 26, 2020 at 02:54:10AM +, Luis Chamberlain wrote: > >>>

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-07-01 Thread Luis Chamberlain
On Wed, Jul 01, 2020 at 12:08:11PM +0200, Christian Borntraeger wrote: > dmesg attached > [ 14.438482] virbr0: port 1(virbr0-nic) entered blocking state > [ 14.438485] virbr0: port 1(virbr0-nic) entered disabled state > [ 14.438635] device virbr0-nic entered promiscuous mode > [ 14.439654]

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-30 Thread Luis Chamberlain
On Fri, Jun 26, 2020 at 02:54:10AM +, Luis Chamberlain wrote: > On Wed, Jun 24, 2020 at 08:37:55PM +0200, Christian Borntraeger wrote: > > > > > > On 24.06.20 20:32, Christian Borntraeger wrote: > > [...]> > > > So the translations look correct

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-26 Thread Luis Chamberlain
On Fri, Jun 26, 2020 at 11:40:08AM +, Luis Chamberlain wrote: > Andrew, can you please revert these two for now: > > selftests: simplify kmod failure value > umh: fix processed error when UMH_WAIT_PROC is used > > Later, we'll add Christoph's simplier kern

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-26 Thread Luis Chamberlain
On Fri, Jun 26, 2020 at 10:00:01AM +0100, Christoph Hellwig wrote: > On Fri, Jun 26, 2020 at 07:22:34AM +0200, Christian Borntraeger wrote: > > > > > > On 26.06.20 04:54, Luis Chamberlain wrote: > > > On Wed, Jun 24, 2020 at 08:37:55PM +0200, Christian Borntraeger

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-25 Thread Luis Chamberlain
On Wed, Jun 24, 2020 at 08:37:55PM +0200, Christian Borntraeger wrote: > > > On 24.06.20 20:32, Christian Borntraeger wrote: > [...]> > > So the translations look correct. But your change is actually a sematic > > change > > if(ret) will only trigger if there is an error > > if (KWIFEXITED(ret)

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-24 Thread Luis Chamberlain
On Wed, Jun 24, 2020 at 01:17:25PM +, Luis Chamberlain wrote: > I found however an LTP bug indicating the need to test for > s390 wait macros [0] in light of a recent bug in glibc for s390. > I am asking for references to that issue given I cannot find > any mention of this

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-24 Thread Luis Chamberlain
On Wed, Jun 24, 2020 at 05:54:46PM +0200, Christian Borntraeger wrote: > > > On 24.06.20 16:43, Christoph Hellwig wrote: > > On Wed, Jun 24, 2020 at 01:11:54PM +0200, Christian Borntraeger wrote: > >> Does anyone have an idea why "umh: fix processed error when UMH_WAIT_PROC > >> is used" breaks

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-24 Thread Luis Chamberlain
Martin, your eyeballs would be appreciated for a bit on this. On Wed, Jun 24, 2020 at 12:05:46PM +, Luis Chamberlain wrote: > On Wed, Jun 24, 2020 at 01:11:54PM +0200, Christian Borntraeger wrote: > > > > > > On 23.06.20 16:23, Christian Borntraeger wrote: > > >

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-24 Thread Luis Chamberlain
On Wed, Jun 24, 2020 at 01:11:54PM +0200, Christian Borntraeger wrote: > > > On 23.06.20 16:23, Christian Borntraeger wrote: > > > > > > On 23.06.20 16:11, Christian Borntraeger wrote: > >> Jens Markwardt reported a regression in the linux-next runs. with "umh: > >> fix > >> processed error w

Re: [PATCH v3 0/8] kernel: taint when the driver firmware crashes

2020-05-28 Thread Luis Chamberlain
On Thu, May 28, 2020 at 08:04:50AM -0700, Ben Greear wrote: > > Could you post your devlink RFC patches somewhere public? This cover letter provided a URL to these. Luis

Re: [PATCH v3 0/8] kernel: taint when the driver firmware crashes

2020-05-28 Thread Luis Chamberlain
On Wed, May 27, 2020 at 02:36:42PM -0700, Jakub Kicinski wrote: > On Wed, 27 May 2020 03:19:18 +0000 Luis Chamberlain wrote: > > I read your patch, and granted, I will accept I was under the incorrect > > assumption that this can only be used by networking devices, however it

Re: [PATCH v3 0/8] kernel: taint when the driver firmware crashes

2020-05-26 Thread Luis Chamberlain
On Tue, May 26, 2020 at 04:30:31PM -0700, Jakub Kicinski wrote: > On Tue, 26 May 2020 23:07:48 +0000 Luis Chamberlain wrote: > > On Tue, May 26, 2020 at 03:46:06PM -0700, Jakub Kicinski wrote: > > > On Tue, 26 May 2020 14:58:07 +0000 Luis Chamberlain wrote: > > > >

Re: [PATCH v3 0/8] kernel: taint when the driver firmware crashes

2020-05-26 Thread Luis Chamberlain
On Tue, May 26, 2020 at 03:46:06PM -0700, Jakub Kicinski wrote: > On Tue, 26 May 2020 14:58:07 +0000 Luis Chamberlain wrote: > > To those new on CC -- this is intended to be a simple generic interface > > to the kernel to annotate when the firwmare has crashed leaving the > >

[PATCH v3 8/8] qed: use new taint_firmware_crashed()

2020-05-26 Thread Luis Chamberlain
annotate when this happens clearly. Cc: Ariel Elior Cc: gr-everest-linux...@marvell.com Reviewed-by: Igor Russkikh Acked-by: Rafael Aquini Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/qlogic/qed/qed_mcp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/qlogic

[PATCH v3 4/8] panic: make taint data type clearer

2020-05-26 Thread Luis Chamberlain
Let us be clearer about the the data type for the taint flag. Signed-off-by: Luis Chamberlain --- include/asm-generic/bug.h | 4 ++-- include/linux/kernel.h| 4 ++-- kernel/panic.c| 8 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/include/asm-generic

[PATCH v3 3/8] taint: add firmware crash taint support

2020-05-26 Thread Luis Chamberlain
add_taint_module(), just make the flag unsigned int clear. Signed-off-by: Luis Chamberlain --- Documentation/admin-guide/tainted-kernels.rst | 6 ++ include/linux/kernel.h| 2 +- include/linux/module.h| 13 + include/trace/events

[PATCH v3 5/8] ath10k: use new taint_firmware_crashed()

2020-05-26 Thread Luis Chamberlain
Valo Acked-by: Rafael Aquini Signed-off-by: Luis Chamberlain --- drivers/net/wireless/ath/ath10k/pci.c | 2 ++ drivers/net/wireless/ath/ath10k/sdio.c | 2 ++ drivers/net/wireless/ath/ath10k/snoc.c | 1 + 3 files changed, 5 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/dr

[PATCH v3 7/8] liquidio: use new taint_firmware_crashed()

2020-05-26 Thread Luis Chamberlain
annotate when this happens clearly. Cc: Derek Chickles Cc: Satanand Burla Cc: Felix Manlunas Acked-by: Rafael Aquini Reviewed-by: Derek Chickles Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net

[PATCH v3 2/8] panic: add uevent support

2020-05-26 Thread Luis Chamberlain
the kernel logs. Since not everyone is, add support to throw some bones to userspace that something might be fishy. Let userspace figure out how to inform users, and what to do. Signed-off-by: Luis Chamberlain --- MAINTAINERS | 8 + include/linux/panic_events.h

[PATCH v3 6/8] bnxt_en: use new taint_firmware_crashed()

2020-05-26 Thread Luis Chamberlain
taint flag allows us to annotate when this happens clearly. Cc: Michael Chan Cc: Luis Chamberlain Acked-by: Rafael Aquini Signed-off-by: Vasundhara Volam Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH v3 1/8] kernel.h: move taint and system state flags to uapi

2020-05-26 Thread Luis Chamberlain
The taint and system state flags will be used in a subsequent patch exposing these to userspace, so move them to uapi. We keep the TAINT_FLAGS_COUNT outside of uapi, as this value can change per release. Signed-off-by: Luis Chamberlain --- include/linux/kernel.h | 34

[PATCH v3 0/8] kernel: taint when the driver firmware crashes

2020-05-26 Thread Luis Chamberlain
aint-firmware-net-intro branch, based on linux-next tag next-20200526 [1]. [0] https://lkml.kernel.org/r/20200519211531.3702593-1-k...@kernel.org [1] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20200526-taint-firmware-net-intro Luis Chamberlain (7): kernel.h: mov

Re: [RFC 1/2] devlink: add simple fw crash helpers

2020-05-22 Thread Luis Chamberlain
On Fri, May 22, 2020 at 04:23:55PM -0700, Steve deRosier wrote: > Specifically, I don't think we should set a taint flag when a driver > easily handles a routine firmware crash and is confident that things > have come up just fine again. In other words, triggering the taint in > every driver module

Re: [PATCH v2 10/15] soc: qcom: ipa: use new module_firmware_crashed()

2020-05-22 Thread Luis Chamberlain
On Fri, May 22, 2020 at 03:52:44PM -0500, Alex Elder wrote: > On 5/22/20 12:28 AM, Luis Chamberlain wrote: > > OK thanks. Can the user be affected by this crash? If so how? Can > > we recover ? Is that always guaranteed? > > We can't guarantee anything about recov

Re: [RFC 1/2] devlink: add simple fw crash helpers

2020-05-22 Thread Luis Chamberlain
On Fri, May 22, 2020 at 10:46:07PM +0200, Johannes Berg wrote: > FWIW, I still completely disagree on that taint. You (Luis) obviously > have been running into a bug in that driver, I doubt the firmware > actually managed to wedge the hardware. This hasn't happened just once, its happed many times

Re: [RFC 1/2] devlink: add simple fw crash helpers

2020-05-22 Thread Luis Chamberlain
On Fri, May 22, 2020 at 10:17:38AM -0700, Jakub Kicinski wrote: > On Fri, 22 May 2020 05:20:46 +0000 Luis Chamberlain wrote: > > > diff --git a/net/core/Makefile b/net/core/Makefile > > > index 3e2c378e5f31..6f1513781c17 100644 > > > --- a/net/core/Makefile

Re: [PATCH v2 10/15] soc: qcom: ipa: use new module_firmware_crashed()

2020-05-21 Thread Luis Chamberlain
On Tue, May 19, 2020 at 05:34:13PM -0500, Alex Elder wrote: > On 5/15/20 4:28 PM, Luis Chamberlain wrote: > > This makes use of the new module_firmware_crashed() to help > > annotate when firmware for device drivers crash. When firmware > > crashes devices can sometimes bec

Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed()

2020-05-21 Thread Luis Chamberlain
On Fri, May 22, 2020 at 08:12:59AM +0300, Emmanuel Grumbach wrote: > > > > On Tue, May 19, 2020 at 10:37 PM Emmanuel Grumbach > > wrote: > > > So I believe we already have this uevent, it is the devcoredump. All > > > we need is to add the unique id. > > > > I think there are a few reasons that d

Re: [RFC 1/2] devlink: add simple fw crash helpers

2020-05-21 Thread Luis Chamberlain
On Tue, May 19, 2020 at 02:15:30PM -0700, Jakub Kicinski wrote: > Add infra for creating devlink instances for a device to report Thanks for doing this series as a PoC, counter to the module_firmware_crash() which I proposed to taint the kernel with a firmware crash flag to the kernel and module.

Re: [PATCH v2 01/15] taint: add module firmware crash taint support

2020-05-21 Thread Luis Chamberlain
On Tue, May 19, 2020 at 06:42:31PM +0200, Jessica Yu wrote: > +++ Luis Chamberlain [15/05/20 21:28 +]: > > Device driver firmware can crash, and sometimes, this can leave your > > system in a state which makes the device or subsystem completely > > useless. Detecting thi

Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed()

2020-05-19 Thread Luis Chamberlain
On Mon, May 18, 2020 at 06:23:33PM -0700, Brian Norris wrote: > On Sat, May 16, 2020 at 6:51 AM Johannes Berg > wrote: > > In addition, look what we have in iwl_trans_pcie_removal_wk(). If we > > detect that the device is really wedged enough that the only way we can > > still try to recover is b

Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed()

2020-05-18 Thread Luis Chamberlain
On Mon, May 18, 2020 at 03:16:45PM -0700, Jakub Kicinski wrote: > On Mon, 18 May 2020 21:22:02 +0000 Luis Chamberlain wrote: > > Indeed my issue with devlink is that it did not seem generic enough for > > all devices which use firmware and for which firmware can crash. Support >

Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed()

2020-05-18 Thread Luis Chamberlain
On Mon, May 18, 2020 at 01:46:43PM -0700, Jakub Kicinski wrote: > On Mon, 18 May 2020 22:41:48 +0200 Johannes Berg wrote: > > On Mon, 2020-05-18 at 13:35 -0700, Jakub Kicinski wrote: > > > It's intended to be a generic netlink channel for configuring devices. > > > > > > All the firmware-related i

Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed()

2020-05-18 Thread Luis Chamberlain
On Mon, May 18, 2020 at 10:07:49PM +0200, Johannes Berg wrote: > On Mon, 2020-05-18 at 19:59 +0000, Luis Chamberlain wrote: > > > > Err, no. Those two are most definitely related. Have you looked at (most > > > or some or whatever) staging drivers recently? Those co

Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed()

2020-05-18 Thread Luis Chamberlain
On Mon, May 18, 2020 at 09:25:09PM +0200, Johannes Berg wrote: > On Mon, 2020-05-18 at 19:09 +0000, Luis Chamberlain wrote: > > > > Unfortunately a "taint" is interpreted by many users as: "your kernel > > > is really F#*D up, you better do something abou

Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed()

2020-05-18 Thread Luis Chamberlain
On Mon, May 18, 2020 at 11:06:27AM -0700, Steve deRosier wrote: > On Mon, May 18, 2020 at 10:19 AM Luis Chamberlain wrote: > > From a support perspective it is a *crystal* clear sign that the device > > and / or device driver may be in a very bad state, in a generic way. > >

Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed()

2020-05-18 Thread Luis Chamberlain
On Mon, May 18, 2020 at 10:15:45AM -0700, Ben Greear wrote: > > > On 05/18/2020 10:09 AM, Luis Chamberlain wrote: > > On Mon, May 18, 2020 at 09:58:53AM -0700, Ben Greear wrote: > > > > > > > > > On 05/18/2020 09:51 AM, Luis Chamberlain wrote: > &

Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed()

2020-05-18 Thread Luis Chamberlain
On Mon, May 18, 2020 at 09:58:53AM -0700, Ben Greear wrote: > > > On 05/18/2020 09:51 AM, Luis Chamberlain wrote: > > On Sat, May 16, 2020 at 03:24:01PM +0200, Johannes Berg wrote: > > > On Fri, 2020-05-15 at 21:28 +, Luis Chamberlain wrote:> > > > modu

Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed()

2020-05-18 Thread Luis Chamberlain
On Sat, May 16, 2020 at 03:50:55PM +0200, Johannes Berg wrote: > On Sat, 2020-05-16 at 15:24 +0200, Johannes Berg wrote: > > > Instead of the kernel taint, IMHO you should provide an annotation in > > sysfs (or somewhere else) for the *struct device* that had its firmware > > crash. Or maybe, if i

Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed()

2020-05-18 Thread Luis Chamberlain
On Sat, May 16, 2020 at 03:24:01PM +0200, Johannes Berg wrote: > On Fri, 2020-05-15 at 21:28 +0000, Luis Chamberlain wrote:> > module_firmware_crashed > > You didn't CC me or the wireless list on the rest of the patches, so I'm > replying to a random one, but ...

[PATCH v2 02/15] ethernet/839: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
annotate when this happens clearly. Cc: "Michael S. Tsirkin" Cc: Shannon Nelson Cc: Jakub Kicinski Cc: Heiner Kallweit Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/8390/axnet_cs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/eth

[PATCH v2 01/15] taint: add module firmware crash taint support

2020-05-15 Thread Luis Chamberlain
in no way shape or form affect lockdep. This taint is device driver specific. Signed-off-by: Luis Chamberlain --- Documentation/admin-guide/tainted-kernels.rst | 6 ++ include/linux/kernel.h| 3 ++- include/linux/module.h| 13

[PATCH v2 14/15] brcm80211: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
ieter-Paul Giesberts Signed-off-by: Luis Chamberlain --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c index c88655acc78c..d6

[PATCH v2 03/15] bnx2x: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
annotate when this happens clearly. Cc: Ariel Elior Cc: Sudarsana Kalluru CC: gr-everest-linux...@marvell.com Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c

[PATCH v2 09/15] qed: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
annotate when this happens clearly. Cc: Ariel Elior Cc: gr-everest-linux...@marvell.com Reviewed-by: Igor Russkikh Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/qlogic/qed/qed_mcp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/qlogic/qed/qed_mcp.c b

[PATCH v2 12/15] ath10k: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
annotate when this happens clearly. Cc: linux-wirel...@vger.kernel.org Cc: ath...@lists.infradead.org Cc: Kalle Valo Signed-off-by: Luis Chamberlain --- drivers/net/wireless/ath/ath10k/pci.c | 2 ++ drivers/net/wireless/ath/ath10k/sdio.c | 2 ++ drivers/net/wireless/ath/ath10k/snoc.c | 1 + 3

[PATCH v2 05/15] bna: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
annotate when this happens clearly. Cc: Rasesh Mody Cc: Sudarsana Kalluru Cc: gr-linux-nic-...@marvell.com Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/brocade/bna/bfa_ioc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net

[PATCH v2 04/15] bnxt: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
annotate when this happens clearly. Cc: Michael Chan Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

[PATCH v2 07/15] cxgb4: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
annotate when this happens clearly. Cc: Vishal Kulkarni Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c index

[PATCH v2 11/15] wimax/i2400m: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
annotate when this happens clearly. Cc: linux-wi...@intel.com Cc: Inaky Perez-Gonzalez Signed-off-by: Luis Chamberlain --- drivers/net/wimax/i2400m/rx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wimax/i2400m/rx.c b/drivers/net/wimax/i2400m/rx.c index c9fb619a9e01

[PATCH v2 08/15] ehea: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
annotate when this happens clearly. Cc: Douglas Miller Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/ibm/ehea/ehea_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c index 0273fb7a9d01

[PATCH v2 10/15] soc: qcom: ipa: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
annotate when this happens clearly. Cc: Alex Elder Signed-off-by: Luis Chamberlain --- drivers/net/ipa/ipa_modem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ipa/ipa_modem.c b/drivers/net/ipa/ipa_modem.c index ed10818dd99f..1790b87446ed 100644 --- a/drivers/net/ipa

[PATCH v2 13/15] ath6kl: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
annotate when this happens clearly. Cc: linux-wirel...@vger.kernel.org Cc: ath...@lists.infradead.org Cc: Kalle Valo Signed-off-by: Luis Chamberlain --- drivers/net/wireless/ath/ath6kl/hif.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath6kl/hif.c b/drivers/net

[PATCH v2 15/15] mwl8k: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
annotate when this happens clearly. Cc: linux-wirel...@vger.kernel.org Cc: Lennert Buytenhek Cc: Kalle Valo Cc: "Gustavo A. R. Silva" Cc: Johannes Berg Cc: Ganapathi Bhat Signed-off-by: Luis Chamberlain --- drivers/net/wireless/marvell/mwl8k.c | 1 + 1 file changed, 1 insertion(+)

[PATCH v2 06/15] liquidio: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
annotate when this happens clearly. Cc: Derek Chickles Cc: Satanand Burla Cc: Felix Manlunas Reviewed-by: Derek Chickles Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/cavium/liquidio

[PATCH v2 00/15] net: taint when the device driver firmware crashes

2020-05-15 Thread Luis Chamberlain
d on linux-next tag next-20200515. You can find these changes on my tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20200515-taint-firmware-net Luis Chamberlain (15): taint: add module firmware crash taint support ethernet/839: use new module_firmware_crashed

Re: [EXT] [PATCH 09/15] qed: use new module_firmware_crashed()

2020-05-15 Thread Luis Chamberlain
On Thu, May 14, 2020 at 05:53:41PM +0300, Igor Russkikh wrote: > > > > So do you mean like the changes below? > > > > diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.c > > b/drivers/net/ethernet/qlogic/qed/qed_debug.c > > index f4eebaabb6d0..95cb7da2542e 100644 > > --- a/drivers/net/ethern

Re: [EXT] [PATCH 09/15] qed: use new module_firmware_crashed()

2020-05-12 Thread Luis Chamberlain
On Tue, May 12, 2020 at 07:23:28PM +0300, Igor Russkikh wrote: > > >> So I think its not a good place to insert this call. > >> Its hard to find exact good place to insert it in qed. > > > > Is there a way to check if what happened was indeed a fw crash? > > Our driver has two firmwares (slowpat

Re: [PATCH 00/15] net: taint when the device driver firmware crashes

2020-05-11 Thread Luis Chamberlain
On Sat, May 09, 2020 at 07:15:23PM -0700, Shannon Nelson wrote: > On 5/9/20 6:58 PM, Andrew Lunn wrote: > > On Sat, May 09, 2020 at 06:01:51PM -0700, Shannon Nelson wrote: > > As for firmware, how much damage can the firmware do as it crashed? If > > it is a DMA master, it could of splattered stuff

Re: [PATCH 00/15] net: taint when the device driver firmware crashes

2020-05-11 Thread Luis Chamberlain
On Sat, May 09, 2020 at 11:35:46AM -0700, Jakub Kicinski wrote: > On Sat, 9 May 2020 04:35:37 +0000 Luis Chamberlain wrote: > > Device driver firmware can crash, and sometimes, this can leave your > > system in a state which makes the device or subsystem completely > > usele

Re: [PATCH 01/15] taint: add module firmware crash taint support

2020-05-09 Thread Luis Chamberlain
On Sat, May 09, 2020 at 11:18:29AM -0400, Rafael Aquini wrote: > We are still missing the documentation bits for this > new flag, though. Ah yeah sorry about that. > How about having a blurb similar to: > > diff --git a/Documentation/admin-guide/tainted-kernels.rst > b/Documentation/admin-guide

Re: [EXT] [PATCH 09/15] qed: use new module_firmware_crashed()

2020-05-09 Thread Luis Chamberlain
sometimes requires a driver unload / reload and in the worst cases > > a reboot. > > > > Using a taint flag allows us to annotate when this happens clearly. > > > > Cc: Ariel Elior > > Cc: gr-everest-linux...@marvell.com > > Signed-off-by: Luis Cham

[PATCH 12/15] ath10k: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
annotate when this happens clearly. Cc: linux-wirel...@vger.kernel.org Cc: ath...@lists.infradead.org Cc: Kalle Valo Signed-off-by: Luis Chamberlain --- drivers/net/wireless/ath/ath10k/pci.c | 2 ++ drivers/net/wireless/ath/ath10k/sdio.c | 2 ++ drivers/net/wireless/ath/ath10k/snoc.c | 1 + 3

[PATCH 00/15] net: taint when the device driver firmware crashes

2020-05-08 Thread Luis Chamberlain
be found on my git tree as well: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20200509-taint-firmware-net Luis Chamberlain (15): taint: add module firmware crash taint support ethernet/839: use new module_firmware_crashed() bnx2x: use new module_firmware_crashe

[PATCH 01/15] taint: add module firmware crash taint support

2020-05-08 Thread Luis Chamberlain
in no way shape or form affect lockdep. This taint is device driver specific. Signed-off-by: Luis Chamberlain --- include/linux/kernel.h| 3 ++- include/linux/module.h| 13 + include/trace/events/module.h | 3 ++- kernel/module.c | 5 +++-- kernel

[PATCH 10/15] soc: qcom: ipa: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
annotate when this happens clearly. Cc: Alex Elder Signed-off-by: Luis Chamberlain --- drivers/net/ipa/ipa_modem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ipa/ipa_modem.c b/drivers/net/ipa/ipa_modem.c index ed10818dd99f..1790b87446ed 100644 --- a/drivers/net/ipa

[PATCH 08/15] ehea: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
annotate when this happens clearly. Cc: Douglas Miller Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/ibm/ehea/ehea_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c index 0273fb7a9d01

[PATCH 03/15] bnx2x: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
annotate when this happens clearly. Cc: Ariel Elior Cc: Sudarsana Kalluru CC: gr-everest-linux...@marvell.com Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c

[PATCH 11/15] wimax/i2400m: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
annotate when this happens clearly. Cc: linux-wi...@intel.com Cc: Inaky Perez-Gonzalez Signed-off-by: Luis Chamberlain --- drivers/net/wimax/i2400m/rx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wimax/i2400m/rx.c b/drivers/net/wimax/i2400m/rx.c index c9fb619a9e01

[PATCH 07/15] cxgb4: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
annotate when this happens clearly. Cc: Vishal Kulkarni Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c index

[PATCH 09/15] qed: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
annotate when this happens clearly. Cc: Ariel Elior Cc: gr-everest-linux...@marvell.com Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/qlogic/qed/qed_debug.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.c b/drivers/net/ethernet/qlogic

[PATCH 04/15] bnxt: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
annotate when this happens clearly. Cc: Michael Chan Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

[PATCH 06/15] liquidio: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
annotate when this happens clearly. Cc: Derek Chickles Cc: Satanand Burla Cc: Felix Manlunas Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net

[PATCH 15/15] mwl8k: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
annotate when this happens clearly. Cc: linux-wirel...@vger.kernel.org Cc: Lennert Buytenhek Cc: Kalle Valo Cc: "Gustavo A. R. Silva" Cc: Johannes Berg Cc: Ganapathi Bhat Signed-off-by: Luis Chamberlain --- drivers/net/wireless/marvell/mwl8k.c | 1 + 1 file changed, 1 insertion(+)

[PATCH 13/15] ath6kl: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
annotate when this happens clearly. Cc: linux-wirel...@vger.kernel.org Cc: ath...@lists.infradead.org Cc: Kalle Valo Signed-off-by: Luis Chamberlain --- drivers/net/wireless/ath/ath6kl/hif.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath6kl/hif.c b/drivers/net

[PATCH 05/15] bna: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
annotate when this happens clearly. Cc: Rasesh Mody Cc: Sudarsana Kalluru Cc: gr-linux-nic-...@marvell.com Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/brocade/bna/bfa_ioc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net

[PATCH 14/15] brcm80211: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
ieter-Paul Giesberts Signed-off-by: Luis Chamberlain --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c index c88655acc78c..d6

[PATCH 02/15] ethernet/839: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
annotate when this happens clearly. Cc: "Michael S. Tsirkin" Cc: Shannon Nelson Cc: Jakub Kicinski Cc: Heiner Kallweit Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/8390/axnet_cs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/eth

Re: [PATCH] sysctl: fix unused function warning

2020-05-05 Thread Luis Chamberlain
27;bpf_stats_handler' > [-Werror,-Wunused-function] > static int bpf_stats_handler(struct ctl_table *table, int write, > > Fix the check to match the reference. > > Fixes: d46edd671a14 ("bpf: Sharing bpf runtime stats with BPF_ENABLE_STATS") > Signed-off-by: Arnd Bergmann Reviewed-by: Luis Chamberlain Luis

Re: Module loading problem since 5.3

2019-10-16 Thread Luis Chamberlain
On Mon, Oct 14, 2019 at 03:44:40PM +0100, Matthias Maennich wrote: > Hi Luis! > > On Mon, Oct 14, 2019 at 08:52:35AM +0000, Luis Chamberlain wrote: > > On Fri, Oct 11, 2019 at 09:26:05PM +0200, Heiner Kallweit wrote: > > > On 10.10.2019 19:15, Luis Chamberlain wrote: &g

Re: [PATCH] sysctl: Fix proc_do_large_bitmap for large input buffers

2019-02-21 Thread Luis Chamberlain
On Thu, Feb 21, 2019 at 11:47:49AM -0600, Eric Sandeen wrote: > On 2/21/19 9:18 AM, Luis Chamberlain wrote: > > On Wed, Feb 20, 2019 at 05:35:04PM -0600, Eric Sandeen wrote: > >> Here's a pretty hacky test script to test this code via > >> ip_local_reserved_ports &

Re: [PATCH] sysctl: Fix proc_do_large_bitmap for large input buffers

2019-02-21 Thread Luis Chamberlain
On Wed, Feb 20, 2019 at 05:35:04PM -0600, Eric Sandeen wrote: > Here's a pretty hacky test script to test this code via > ip_local_reserved_ports Thanks Eric! So /proc/sys/net/ipv4/ip_local_reserved_ports is a production knob, and if we wanted to stress test it with a selftest it could break othe