Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files

2020-08-14 Thread Luca Ceresoli
Hi, On 14/08/20 16:51, Rob Herring wrote: > On Thu, Aug 13, 2020 at 4:31 AM Luca Ceresoli wrote: >> >> Hi Rob, >> >> On 12/08/20 22:36, Rob Herring wrote: >>> Clean-up incorrect indentation, extra spaces, long lines, and missing >>> EOF newline in sch

Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files

2020-08-13 Thread Luca Ceresoli
Hi Rob, On 12/08/20 22:36, Rob Herring wrote: > Clean-up incorrect indentation, extra spaces, long lines, and missing > EOF newline in schema files. Most of the clean-ups are for list > indentation which should always be 2 spaces more than the preceding > keyword. > > Found with yamllint (which I

Re: [PATCH] net: macb: fix error format in dev_err()

2019-05-14 Thread Luca Ceresoli
Hi Andrew, On 14/05/19 14:35, Andrew Lunn wrote: > On Tue, May 14, 2019 at 09:14:50AM +0200, Luca Ceresoli wrote: >> Errors are negative numbers. Using %u shows them as very large positive >> numbers such as 4294967277 that don't make sense. Use the %d format >> instead

[PATCH net RESEND] net: macb: fix error format in dev_err()

2019-05-14 Thread Luca Ceresoli
Errors are negative numbers. Using %u shows them as very large positive numbers such as 4294967277 that don't make sense. Use the %d format instead, and get a much nicer -19. Signed-off-by: Luca Ceresoli Fixes: b48e0bab142f ("net: macb: Migrate to devm clock interface") Fixes: 93b

[PATCH] net: macb: fix error format in dev_err()

2019-05-14 Thread Luca Ceresoli
Errors are negative numbers. Using %u shows them as very large positive numbers such as 4294967277 that don't make sense. Use the %d format instead, and get a much nicer -19. Signed-off-by: Luca Ceresoli --- drivers/net/ethernet/cadence/macb_main.c | 16 1 file chang