[PATCH BUGFIX] can: m_can: make m_can driver work with sleep state pinconfig

2020-06-25 Thread Lothar Waßmann
tion. Removing the bogus call to m_can_class_suspend() in the m_can_runtime_suspend() function fixes this. Fixes: f524f829b75a ("can: m_can: Create a m_can platform framework") Fixes: 0704c5743694 ("can: m_can_platform: remove unnecessary m_can_class_resume() call") Signed

Re: [PATCH 2/3] net: fec: convert to using gpiod framework

2015-12-01 Thread Lothar Waßmann
Hi, > From: Lothar Waßmann Sent: Monday, November 30, > 2015 7:33 PM > > To: Andrew Lunn; David S. Miller; Estevam Fabio-R49496; Greg Ungerer; > > Kevin Hao; Lothar Waßmann; Lucas Stach; Duan Fugang-B38611; Philippe > > Reynes; Richard Cochran; Russell King; Sascha Ha

Re: [PATCH 0/3] net: fec: Reset ethernet PHY whenever the enet_out clock

2015-11-30 Thread Lothar Waßmann
Hi, > From: Lothar Waßmann Sent: Monday, November 30, > 2015 7:33 PM > > To: Andrew Lunn; David S. Miller; Estevam Fabio-R49496; Greg Ungerer; > > Kevin Hao; Lothar Waßmann; Lucas Stach; Duan Fugang-B38611; Philippe > > Reynes; Richard Cochran; Russell King; Sascha Ha

Re: [PATCH 1/3] net: fec: Remove redundant checks for NULL clk pointer

2015-11-30 Thread Lothar Waßmann
Hi, > From: Lothar Waßmann Sent: Monday, November 30, > 2015 7:33 PM > > To: Andrew Lunn; David S. Miller; Estevam Fabio-R49496; Greg Ungerer; > > Kevin Hao; Lothar Waßmann; Lucas Stach; Duan Fugang-B38611; Philippe > > Reynes; Richard Cochran; Russell King; Sascha Ha

[PATCH 0/3] net: fec: Reset ethernet PHY whenever the enet_out clock

2015-11-30 Thread Lothar Waßmann
This patchset fixes a regression introduced by commit 8fff755e9f8d ("net: fec: Ensure clocks are enabled while using mdio bus") for ethernet PHYs that are using ENET_OUT as reference clock (on i.MX6 or i.MX28) The first patch is a cleanup patch that removes redundant NULL checks. The second patch

[PATCH 3/3] net: fec: Reset ethernet PHY whenever the enet_out clock is being enabled

2015-11-30 Thread Lothar Waßmann
.ethernet eth0: Link is Down fec 02188000.ethernet eth0: Link is Up - 100Mbps/Full - flow control rx/tx fec 02188000.ethernet eth0: Link is Down [...] Signed-off-by: Lothar Waßmann --- drivers/net/ethernet/freescale/fec.h | 1 + drivers/net/ethernet/freescale/fec_main.c | 46

[PATCH 2/3] net: fec: convert to using gpiod framework

2015-11-30 Thread Lothar Waßmann
Use gpiod_get_optional() instead of checking for a valid GPIO number and calling devm_gpio_request_one() conditionally. Signed-off-by: Lothar Waßmann --- drivers/net/ethernet/freescale/fec_main.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/net

[PATCH 1/3] net: fec: Remove redundant checks for NULL clk pointer

2015-11-30 Thread Lothar Waßmann
NULL is a valid argument to clk_enable()/clk_disable(). Remove redundant checks before calling those functions. Signed-off-by: Lothar Waßmann --- drivers/net/ethernet/freescale/fec_main.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers/net

Re: [PATCH] net: fec: fix enet_out clock handling

2015-11-29 Thread Lothar Waßmann
Hi, > From: Lothar Waßmann Sent: Friday, November 27, > 2015 9:39 PM > > To: Andrew Lunn; David S. Miller; Estevam Fabio-R49496; Kevin Hao; Lothar > > Waßmann; Lucas Stach; Duan Fugang-B38611; Philippe Reynes; Russell King; > > Uwe Kleine-König; linux-ker...

Re: [PATCH] net: fec: fix enet_out clock handling

2015-11-29 Thread Lothar Waßmann
Hi, > On Fri, Nov 27, 2015 at 02:39:10PM +0100, Lothar Waßmann wrote: > > When ENET_OUT is being used as reference clock for an external PHY, > > the clock must not be disabled while the PHY is active. Otherwise the > > PHY may lose its internal state and require a reset to

[PATCH] net: fec: fix enet_out clock handling

2015-11-27 Thread Lothar Waßmann
UP and DOWN state: fec 800f.ethernet eth0: Link is Up - 100Mbps/Full - flow control rx/tx fec 800f.ethernet eth0: Link is Down fec 800f.ethernet eth0: Link is Up - 100Mbps/Full - flow control rx/tx fec 800f.ethernet eth0: Link is Down [...] Signed-off-by: Lothar Waßmann --- drivers

Re: Problem with "swinging" ethernet link on i.MX28 based device

2015-11-27 Thread Lothar Waßmann
,6 +3504,8 @@ failed_init: if (fep->reg_phy) regulator_disable(fep->reg_phy); failed_regulator: + clk_disable_unprepare(fep->clk_enet_out); +failed_clk_enet_out: clk_disable_unprepare(fep->clk_ipg); failed_clk_ipg: fec_enet_clk_enable(ndev, fals

[linux-next] Regression in net/ipv4/route.c

2015-09-18 Thread Lothar Waßmann
74c>] (cpuidle_enter_state) from [<80055e58>] (cpu_startup_entry+0x174/0x24c) [<80055e58>] (cpu_startup_entry) from [<1000950c>] (0x1000950c) <--- snap ---> I bisected it down to: commit b7503e0cdb5d (net: Add FIB table id to rtable) There may be other ways to produ