Re: [PATCH net-next v2] net/mlx5e: Fix uninitialised struct field moder.comps

2021-04-20 Thread Leon Romanovsky
On Tue, Apr 20, 2021 at 05:28:43PM +0800, Zhu Yanjun wrote: > On Tue, Apr 20, 2021 at 5:21 PM Leon Romanovsky wrote: > > > > On Tue, Apr 20, 2021 at 03:09:03PM +0800, Zhu Yanjun wrote: > > > On Tue, Apr 20, 2021 at 3:01 PM wangyunjian > > > wrote: &

Re: [PATCH net-next v2] net/mlx5e: Fix uninitialised struct field moder.comps

2021-04-20 Thread Leon Romanovsky
On Tue, Apr 20, 2021 at 03:09:03PM +0800, Zhu Yanjun wrote: > On Tue, Apr 20, 2021 at 3:01 PM wangyunjian wrote: > > > > From: Yunjian Wang > > > > The 'comps' struct field in 'moder' is not being initialized in > > mlx5e_get_def_rx_moderation() and mlx5e_get_def_tx_moderation(). > > So initializ

Re: [PATCH] net/rds: Avoid potential use after free in rds_send_remove_from_sock

2021-04-20 Thread Leon Romanovsky
On Tue, Apr 20, 2021 at 12:09:06PM +0300, Leon Romanovsky wrote: > On Tue, Apr 06, 2021 at 07:09:12PM -0500, Aditya Pakki wrote: > > In case of rs failure in rds_send_remove_from_sock(), the 'rm' resource > > is freed and later under spinlock, causing potential use-aft

Re: [PATCH] net/rds: Avoid potential use after free in rds_send_remove_from_sock

2021-04-20 Thread Leon Romanovsky
On Tue, Apr 06, 2021 at 07:09:12PM -0500, Aditya Pakki wrote: > In case of rs failure in rds_send_remove_from_sock(), the 'rm' resource > is freed and later under spinlock, causing potential use-after-free. > Set the free pointer to NULL to avoid undefined behavior. > > Signed-off-by: Aditya Pakki

Re: [PATCH iproute2] lib: move get_task_name() from rdma

2021-04-19 Thread Leon Romanovsky
es changed, 26 insertions(+), 55 deletions(-) > Thanks, Acked-by: Leon Romanovsky

Re: [RFC v1 PATCH 3/3] driver: update all the code that use soc_device_match

2021-04-18 Thread Leon Romanovsky
On Mon, Apr 19, 2021 at 12:27:22PM +0800, Alice Guo (OSS) wrote: > From: Alice Guo > > Update all the code that use soc_device_match because add support for > soc_device_match returning -EPROBE_DEFER. > > Signed-off-by: Alice Guo > --- > drivers/bus/ti-sysc.c | 2 +- >

[PATCH rdma-next 0/2] Two fixes to -next

2021-04-18 Thread Leon Romanovsky
From: Leon Romanovsky The two fixes are targeted to the -next. Maor's change fixes DM code that was accepted in this cycle and Parav's change doesn't qualify urgency of -rc8. Thanks Maor Gottlieb (1): RDMA/mlx5: Fix type assignment for ICM DM Parav Pandit (1): IB/mlx5: Se

[PATCH mlx5-next 1/2] IB/mlx5: Set right RoCE l3 type and roce version while deleting GID

2021-04-18 Thread Leon Romanovsky
(0x3), syndrome (0x12822d) Hence set the right RoCE version during GID deletion provided by the core. Signed-off-by: Parav Pandit Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/main.c | 8 drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c | 4 ++-- 2 files

Re: [PATCH iproute2] rdma: stat: fix return code

2021-04-18 Thread Leon Romanovsky
)") > Reported-by: Leon Romanovsky > Signed-off-by: Andrea Claudi > --- > rdma/stat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Acked-by: Leon Romanovsky

Re: [PATCH iproute2] rdma: stat: initialize ret in stat_qp_show_parse_cb()

2021-04-18 Thread Leon Romanovsky
On Sun, Apr 18, 2021 at 02:00:38PM +0200, Andrea Claudi wrote: > On Sun, Apr 18, 2021 at 1:07 PM Leon Romanovsky wrote: > > > > On Wed, Apr 14, 2021 at 12:50:57AM +0200, Andrea Claudi wrote: > > > In the unlikely case in which the mnl_attr_for_each_nested() cycle is

Re: [PATCH v4 05/23] ice: Add devlink params support

2021-04-18 Thread Leon Romanovsky
On Wed, Apr 14, 2021 at 12:21:08AM +, Saleem, Shiraz wrote: > > Subject: RE: [PATCH v4 05/23] ice: Add devlink params support <...> > > > Why not just allow the setting to apply dynamically during a 'set' > > > itself with an unplug/plug of the auxdev with correct type. > > > > > This suggest

Re: [PATCH iproute2] rdma: stat: initialize ret in stat_qp_show_parse_cb()

2021-04-18 Thread Leon Romanovsky
On Wed, Apr 14, 2021 at 12:50:57AM +0200, Andrea Claudi wrote: > In the unlikely case in which the mnl_attr_for_each_nested() cycle is > not executed, this function return an uninitialized value. > > Fix this initializing ret to 0. > > Fixes: 5937552b42e4 ("rdma: Add "stat qp show" support") > Si

Re: [RFC V2 PATCH 11/12] HV/Netvsc: Add Isolation VM support for netvsc driver

2021-04-18 Thread Leon Romanovsky
On Tue, Apr 13, 2021 at 11:22:16AM -0400, Tianyu Lan wrote: > From: Tianyu Lan > > In Isolation VM, all shared memory with host needs to mark visible > to host via hvcall. vmbus_establish_gpadl() has already done it for > netvsc rx/tx ring buffer. The page buffer used by vmbus_sendpacket_ > pageb

Re: [PATCH rdma-next v2 0/5] Get rid of custom made module dependency

2021-04-17 Thread Leon Romanovsky
On Sun, Apr 18, 2021 at 12:09:16AM +0530, Devesh Sharma wrote: > On Sat, Apr 17, 2021 at 1:44 PM Leon Romanovsky wrote: > > > > On Wed, Apr 14, 2021 at 07:15:37PM +0530, Devesh Sharma wrote: > > > On Mon, Apr 12, 2021 at 1:10 PM Leon Romanovsky wrote: > > > >

Re: [PATCH rdma-next v2 0/5] Get rid of custom made module dependency

2021-04-17 Thread Leon Romanovsky
On Wed, Apr 14, 2021 at 07:15:37PM +0530, Devesh Sharma wrote: > On Mon, Apr 12, 2021 at 1:10 PM Leon Romanovsky wrote: > > > > On Thu, Apr 08, 2021 at 08:42:57PM +0530, Devesh Sharma wrote: > > > On Thu, Apr 8, 2021 at 5:14 PM Leon Romanovsky wrote: > > > > &

Re: [PATCH rdma-next v1 0/7] Add MEMIC operations support

2021-04-13 Thread Leon Romanovsky
On Tue, Apr 13, 2021 at 03:55:27PM -0300, Jason Gunthorpe wrote: > On Sun, Apr 11, 2021 at 03:29:17PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Changelog: > > v1: > > * Changed logic of patch #6 per-Jason's request. > >

Re: [PATCH for-next v3 0/2] Introduce rdma_set_min_rnr_timer() and use it in RDS

2021-04-13 Thread Leon Romanovsky
On Tue, Apr 13, 2021 at 11:13:38AM +, Haakon Bugge wrote: > > > > On 13 Apr 2021, at 08:29, Leon Romanovsky wrote: > > > > On Mon, Apr 12, 2021 at 07:58:47PM -0300, Jason Gunthorpe wrote: > >> On Wed, Mar 31, 2021 at 08:43:12PM +0200, Håkon Bugge wrote: >

Re: [PATCH for-next v3 0/2] Introduce rdma_set_min_rnr_timer() and use it in RDS

2021-04-12 Thread Leon Romanovsky
On Mon, Apr 12, 2021 at 07:58:47PM -0300, Jason Gunthorpe wrote: > On Wed, Mar 31, 2021 at 08:43:12PM +0200, Håkon Bugge wrote: > > ib_modify_qp() is an expensive operation on some HCAs running > > virtualized. This series removes two ib_modify_qp() calls from RDS. > > > > I am sending this as a v

Re: [PATCH net-next 4/5] bnxt_en: Refactor __bnxt_vf_reps_destroy().

2021-04-12 Thread Leon Romanovsky
On Mon, Apr 12, 2021 at 10:51:25AM -0700, Michael Chan wrote: > On Mon, Apr 12, 2021 at 10:33 AM Leon Romanovsky wrote: > > > > On Mon, Apr 12, 2021 at 09:31:33AM -0700, Michael Chan wrote: > > > On Mon, Apr 12, 2021 at 12:37 AM Leon Romanovsky wrote: > > > >

Re: [PATCH net-next 4/5] bnxt_en: Refactor __bnxt_vf_reps_destroy().

2021-04-12 Thread Leon Romanovsky
On Mon, Apr 12, 2021 at 09:31:33AM -0700, Michael Chan wrote: > On Mon, Apr 12, 2021 at 12:37 AM Leon Romanovsky wrote: > > > > On Sun, Apr 11, 2021 at 08:18:14PM -0400, Michael Chan wrote: > > > Add a new helper function __bnxt_free_one_vf_rep() to free one VF rep. >

Re: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-12 Thread Leon Romanovsky
On Mon, Apr 12, 2021 at 08:35:32AM +, Dexuan Cui wrote: > > From: Leon Romanovsky > > Sent: Monday, April 12, 2021 12:46 AM > > To: Dexuan Cui > > > ... > > > +#define ANA_MAJOR_VERSION0 > > > +#define ANA_MINOR_VERSION

Re: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-12 Thread Leon Romanovsky
On Sun, Apr 11, 2021 at 07:34:55PM -0700, Dexuan Cui wrote: > Add a VF driver for Microsoft Azure Network Adapter (MANA) that will be > available in the future. > > Co-developed-by: Haiyang Zhang > Signed-off-by: Haiyang Zhang > Co-developed-by: Shachar Raindel > Signed-off-by: Shachar Raindel

Re: [PATCH rdma-next v2 0/5] Get rid of custom made module dependency

2021-04-12 Thread Leon Romanovsky
On Thu, Apr 08, 2021 at 08:42:57PM +0530, Devesh Sharma wrote: > On Thu, Apr 8, 2021 at 5:14 PM Leon Romanovsky wrote: > > > > On Thu, Apr 08, 2021 at 05:06:24PM +0530, Devesh Sharma wrote: > > > On Sat, Apr 3, 2021 at 5:12 PM Leon Romanovsky wrote: > > > > &

Re: [PATCH net-next 4/5] bnxt_en: Refactor __bnxt_vf_reps_destroy().

2021-04-12 Thread Leon Romanovsky
On Sun, Apr 11, 2021 at 08:18:14PM -0400, Michael Chan wrote: > Add a new helper function __bnxt_free_one_vf_rep() to free one VF rep. > We also reintialize the VF rep fields to proper initial values so that > the function can be used without freeing the VF rep data structure. This > will be used

Re: [PATCH net-next 4/7] net: ipa: ipa_stop() does not return an error

2021-04-12 Thread Leon Romanovsky
On Sun, Apr 11, 2021 at 08:42:15AM -0500, Alex Elder wrote: > On 4/11/21 8:28 AM, Leon Romanovsky wrote: > >> I think *not* checking an available return value is questionable > >> practice. I'd really rather have a build option for a > >> "__need_not

Re: [PATCH net-next 4/7] net: ipa: ipa_stop() does not return an error

2021-04-11 Thread Leon Romanovsky
On Sun, Apr 11, 2021 at 08:09:55AM -0500, Alex Elder wrote: > On 4/11/21 1:34 AM, Leon Romanovsky wrote: > > On Fri, Apr 09, 2021 at 01:07:19PM -0500, Alex Elder wrote: > >> In ipa_modem_stop(), if the modem netdev pointer is non-null we call > >> ipa_stop(). We check

[PATCH rdma-next v1 5/7] RDMA/mlx5: Add support to MODIFY_MEMIC command

2021-04-11 Thread Leon Romanovsky
From: Maor Gottlieb Add two functions to allocate and deallocate MEMIC operations by using the MODIFY_MEMIC command. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/dm.c | 36 + drivers/infiniband/hw/mlx5/dm.h | 2

[PATCH rdma-next v1 7/7] RDMA/mlx5: Expose UAPI to query DM

2021-04-11 Thread Leon Romanovsky
From: Maor Gottlieb Expose UAPI to query MEMIC DM, this will let user space application that didn't allocate the DM but has access to by owning the matching command FD to retrieve its information. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5

[PATCH rdma-next v1 2/7] RDMA/uverbs: Make UVERBS_OBJECT_METHODS to consider line number

2021-04-11 Thread Leon Romanovsky
From: Maor Gottlieb In order to support multiple methods declaration in the same file we should use the line number as part of the name. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- include/rdma/uverbs_named_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH rdma-next v1 6/7] RDMA/mlx5: Add support in MEMIC operations

2021-04-11 Thread Leon Romanovsky
operation. 2. Hold the operations address in a list, so same operation to same DM will be allocated only once. 3. Manage refcount on the mlx5_ib_dm object, so it would be keep valid until all addresses were unmapped. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers

[PATCH rdma-next v1 4/7] RDMA/mlx5: Re-organize the DM code

2021-04-11 Thread Leon Romanovsky
to free the DM in the error flow. 3. Split mlx5_ib_dm struct to memic and icm proper typesafety throughout. Fixes: dc2316eba73f ("IB/mlx5: Fix device memory flows") Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/dm

[PATCH rdma-next v1 3/7] RDMA/mlx5: Move all DM logic to separate file

2021-04-11 Thread Leon Romanovsky
From: Maor Gottlieb Move all device memory related code to a separate file. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/Makefile | 1 + drivers/infiniband/hw/mlx5/cmd.c | 101 drivers/infiniband/hw/mlx5/cmd.h | 3 - drivers

[PATCH mlx5-next v1 1/7] net/mlx5: Add MEMIC operations related bits

2021-04-11 Thread Leon Romanovsky
From: Maor Gottlieb Add the MEMIC operations bits and structures to the mlx5_ifc file. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- include/linux/mlx5/mlx5_ifc.h | 42 ++- 1 file changed, 41 insertions(+), 1 deletion(-) diff --git a/include

[PATCH rdma-next v1 0/7] Add MEMIC operations support

2021-04-11 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v1: * Changed logic of patch #6 per-Jason's request. v0: https://lore.kernel.org/linux-rdma/20210318111548.674749-1-l...@kernel.org --- Hi, This series from Maor extends MEM

Re: [PATCH v4 01/23] iidc: Introduce iidc.h

2021-04-11 Thread Leon Romanovsky
On Fri, Apr 09, 2021 at 01:38:37AM +, Saleem, Shiraz wrote: > > Subject: Re: [PATCH v4 01/23] iidc: Introduce iidc.h > > > > On Wed, Apr 07, 2021 at 07:43:24PM -0300, Jason Gunthorpe wrote: > > > On Wed, Apr 07, 2021 at 08:58:49PM +, Saleem, Shiraz wrote: > > > > > Subject: Re: [PATCH v4 0

Re: [PATCH net-next 4/7] net: ipa: ipa_stop() does not return an error

2021-04-10 Thread Leon Romanovsky
On Fri, Apr 09, 2021 at 01:07:19PM -0500, Alex Elder wrote: > In ipa_modem_stop(), if the modem netdev pointer is non-null we call > ipa_stop(). We check for an error and if one is returned we handle > it. But ipa_stop() never returns an error, so this extra handling > is unnecessary. Simplify t

Re: [PATCH rdma-next v2 0/5] Get rid of custom made module dependency

2021-04-08 Thread Leon Romanovsky
On Thu, Apr 08, 2021 at 08:53:47AM -0300, Jason Gunthorpe wrote: > On Thu, Apr 08, 2021 at 02:44:45PM +0300, Leon Romanovsky wrote: > > > > In my internal testing, I am seeing a crash using the 3rd patch. I am > > > spending a few cycles on debugging it. expect

Re: [PATCH rdma-next v2 0/5] Get rid of custom made module dependency

2021-04-08 Thread Leon Romanovsky
On Thu, Apr 08, 2021 at 05:06:24PM +0530, Devesh Sharma wrote: > On Sat, Apr 3, 2021 at 5:12 PM Leon Romanovsky wrote: > > > > On Sat, Apr 03, 2021 at 03:52:13PM +0530, Devesh Sharma wrote: > > > On Thu, Apr 1, 2021 at 12:27 PM Leon Romanovsky wrote: > > >

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-08 Thread Leon Romanovsky
On Wed, Apr 07, 2021 at 09:59:52PM +, Dexuan Cui wrote: > > From: Leon Romanovsky > > Sent: Wednesday, April 7, 2021 5:45 AM > > > > > > > > BTW, you don't need to write { 0 }, the {} is enough. > > > > > > Thanks for the suggesti

Re: [PATCH v4 01/23] iidc: Introduce iidc.h

2021-04-08 Thread Leon Romanovsky
On Wed, Apr 07, 2021 at 07:43:24PM -0300, Jason Gunthorpe wrote: > On Wed, Apr 07, 2021 at 08:58:49PM +, Saleem, Shiraz wrote: > > > Subject: Re: [PATCH v4 01/23] iidc: Introduce iidc.h > > > > > > On Tue, Apr 06, 2021 at 04:01:03PM -0500, Shiraz Saleem wrote: > > > > > > > +/* Following APIs

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Leon Romanovsky
On Wed, Apr 07, 2021 at 03:05:26PM +, Haiyang Zhang wrote: > > > > -Original Message- > > From: Leon Romanovsky > > Sent: Wednesday, April 7, 2021 10:55 AM > > To: Haiyang Zhang > > Cc: Dexuan Cui ; da...@davemloft.net; > > k...@ker

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Leon Romanovsky
On Wed, Apr 07, 2021 at 02:41:45PM +, Haiyang Zhang wrote: > > > > -Original Message- > > From: Leon Romanovsky > > Sent: Wednesday, April 7, 2021 8:51 AM > > To: Dexuan Cui > > Cc: da...@davemloft.net; k...@kernel.org; KY Srinivasan > &g

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Leon Romanovsky
On Wed, Apr 07, 2021 at 08:40:13AM +, Dexuan Cui wrote: > > From: Leon Romanovsky > > Sent: Wednesday, April 7, 2021 1:10 AM > > > > <...> > > > > > +int gdma_verify_vf_version(struct pci_dev *pdev) > > > +{ > > > +

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Leon Romanovsky
On Wed, Apr 07, 2021 at 08:28:45AM +, Dexuan Cui wrote: > > From: Leon Romanovsky > > Sent: Wednesday, April 7, 2021 1:15 AM > > > ... > > > int gdma_test_eq(struct gdma_context *gc, struct gdma_queue *eq) > > > { > > >

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Leon Romanovsky
On Wed, Apr 07, 2021 at 08:02:17AM +, Dexuan Cui wrote: > > From: Andrew Lunn > > Sent: Tuesday, April 6, 2021 6:08 PM > > To: Dexuan Cui > > > > > +static int gdma_query_max_resources(struct pci_dev *pdev) > > > +{ > > > + struct gdma_context *gc = pci_get_drvdata(pdev); > > > + struct gdma

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Leon Romanovsky
On Tue, Apr 06, 2021 at 04:23:21PM -0700, Dexuan Cui wrote: > Add a VF driver for Microsoft Azure Network Adapter (MANA) that will be > available in the future. > > Co-developed-by: Haiyang Zhang > Signed-off-by: Haiyang Zhang > Signed-off-by: Dexuan Cui > --- > MAINTAINERS

Re: [PATCH rdma-next 02/10] RDMA/core: Enable Relaxed Ordering in __ib_alloc_pd()

2021-04-05 Thread Leon Romanovsky
On Mon, Apr 05, 2021 at 02:01:16PM -0400, Tom Talpey wrote: > On 4/5/2021 1:23 AM, Leon Romanovsky wrote: > > From: Avihai Horon > > > > Enable Relaxed Ordering in __ib_alloc_pd() allocation of the > > local_dma_lkey. > > > > This will take effect only

Re: [PATCH rdma-next 01/10] RDMA: Add access flags to ib_alloc_mr() and ib_mr_pool_init()

2021-04-05 Thread Leon Romanovsky
On Tue, Apr 06, 2021 at 07:27:17AM +0200, Christoph Hellwig wrote: > On Tue, Apr 06, 2021 at 08:23:28AM +0300, Leon Romanovsky wrote: > > The same proposal (enable unconditionally) was raised during > > submission preparations and we decided to follow same pattern > > as othe

Re: [PATCH rdma-next 01/10] RDMA: Add access flags to ib_alloc_mr() and ib_mr_pool_init()

2021-04-05 Thread Leon Romanovsky
On Mon, Apr 05, 2021 at 03:46:18PM +0200, Christoph Hellwig wrote: > On Mon, Apr 05, 2021 at 08:23:55AM +0300, Leon Romanovsky wrote: > > From: Avihai Horon > > > > Add access flags parameter to ib_alloc_mr() and to ib_mr_pool_init(), > > and refactor relevant code

Re: [PATCH rdma-next 01/10] RDMA: Add access flags to ib_alloc_mr() and ib_mr_pool_init()

2021-04-05 Thread Leon Romanovsky
On Mon, Apr 05, 2021 at 08:27:16AM -0700, Bart Van Assche wrote: > On 4/4/21 10:23 PM, Leon Romanovsky wrote: > > diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h > > index bed4cfe50554..59138174affa 100644 > > --- a/include/rdma/ib_verbs.h > > ++

Re: [PATCH rdma-next 00/10] Enable relaxed ordering for ULPs

2021-04-05 Thread Leon Romanovsky
On Mon, Apr 05, 2021 at 11:42:31PM +, Chuck Lever III wrote: > > > > On Apr 5, 2021, at 4:07 PM, Jason Gunthorpe wrote: > > > > On Mon, Apr 05, 2021 at 03:41:15PM +0200, Christoph Hellwig wrote: > >> On Mon, Apr 05, 2021 at 08:23:54AM +0300, Leon R

Re: [PATCH rdma-next 00/10] Enable relaxed ordering for ULPs

2021-04-05 Thread Leon Romanovsky
On Tue, Apr 06, 2021 at 10:37:38AM +0800, Honggang LI wrote: > On Mon, Apr 05, 2021 at 08:23:54AM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > From Avihai, > > > > Relaxed Ordering is a PCIe mechanism that relaxes the strict ordering > >

Re: [PATCH rdma-next 00/10] Enable relaxed ordering for ULPs

2021-04-05 Thread Leon Romanovsky
On Mon, Apr 05, 2021 at 03:41:15PM +0200, Christoph Hellwig wrote: > On Mon, Apr 05, 2021 at 08:23:54AM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > >From Avihai, > > > > Relaxed Ordering is a PCIe mechanism that relaxes the strict orde

Re: [PATCH net 1/2] net: hns3: Remove the left over redundant check & assignment

2021-04-05 Thread Leon Romanovsky
On Mon, Apr 05, 2021 at 12:26:37PM +, Salil Mehta wrote: > Hi Leon, > Thanks for the review. > > > From: Leon Romanovsky [mailto:l...@kernel.org] > > Sent: Sunday, April 4, 2021 7:26 AM > > To: Salil Mehta > > Cc: da...@davemloft.net; k...@kernel.org; netd

Re: [PATCH rdma-next 1/8] RDMA/core: Check if client supports IB device or not

2021-04-05 Thread Leon Romanovsky
On Mon, Apr 05, 2021 at 09:20:32AM +0300, Gal Pressman wrote: > On 05/04/2021 8:49, Leon Romanovsky wrote: > > From: Parav Pandit > > > > RDMA devices are of different transport(iWarp, IB, RoCE) and have > > different attributes. > > Not all clients are

[PATCH rdma-next 8/8] net/rds: Move to client_supported callback

2021-04-04 Thread Leon Romanovsky
From: Parav Pandit Use newly introduced client_supported() callback to avoid client additional if the RDMA device is not of IB type or if it doesn't support device memory extensions. Signed-off-by: Parav Pandit Signed-off-by: Leon Romanovsky --- net/rds/ib.c | 20 +--- 1

[PATCH rdma-next 4/8] IB/core: Skip device which doesn't have necessary capabilities

2021-04-04 Thread Leon Romanovsky
for a RDMA device consist of 128 ports. Signed-off-by: Parav Pandit Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/multicast.c | 15 ++- drivers/infiniband/core/sa_query.c | 15 ++- 2 files changed, 28 insertions(+), 2 deletions(-) diff --git a/drivers/infin

[PATCH rdma-next 7/8] net/smc: Move to client_supported callback

2021-04-04 Thread Leon Romanovsky
From: Parav Pandit Use newly introduced client_supported() callback to avoid client additional if the RDMA device is not of IB type. Signed-off-by: Parav Pandit Signed-off-by: Leon Romanovsky --- net/smc/smc_ib.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a

[PATCH rdma-next 6/8] IB/opa_vnic: Move to client_supported callback

2021-04-04 Thread Leon Romanovsky
From: Parav Pandit Move to newly introduced client_supported callback Avoid client registration using newly introduced helper callback if the IB device doesn't have OPA VNIC capability. Signed-off-by: Parav Pandit Signed-off-by: Leon Romanovsky --- drivers/infiniband/ulp/opa

[PATCH rdma-next 5/8] IB/IPoIB: Skip device which doesn't have InfiniBand port

2021-04-04 Thread Leon Romanovsky
From: Parav Pandit Skip RDMA device which doesn't have InfiniBand ports using newly introduced client_supported() callback. Signed-off-by: Parav Pandit Signed-off-by: Leon Romanovsky --- drivers/infiniband/ulp/ipoib/ipoib_main.c | 13 + 1 file changed, 13 insertions(+)

[PATCH rdma-next 1/8] RDMA/core: Check if client supports IB device or not

2021-04-04 Thread Leon Romanovsky
not for a given IB device, client combination. Signed-off-by: Parav Pandit Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/device.c | 3 +++ include/rdma/ib_verbs.h | 9 + 2 files changed, 12 insertions(+) diff --git a/drivers/infiniband/core/device.c b/drivers

[PATCH rdma-next 3/8] IB/cm: Skip device which doesn't support IB CM

2021-04-04 Thread Leon Romanovsky
device consist of 512 ports and also avoids unnecessary initialization for all above 3 types of devices. Signed-off-by: Parav Pandit Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/cm.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH rdma-next 0/8] Generalize if ULP supported check

2021-04-04 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This series adds new callback to check if ib client is supported/not_supported. Such general callback allows us to save memory footprint by not starting on devices that not going to work on them anyway. Thanks Parav Pandit (8): RDMA/core: Check if client supports

[PATCH rdma-next 2/8] RDMA/cma: Skip device which doesn't support CM

2021-04-04 Thread Leon Romanovsky
specific switchdev device Hence, when a IB device doesn't support IB CM or IW CM, avoid adding such device to the cma list. Signed-off-by: Parav Pandit Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/cma.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --

[PATCH rdma-next 09/10] net/smc: Enable Relaxed Ordering

2021-04-04 Thread Leon Romanovsky
From: Avihai Horon Enable Relaxed Ordering for smc. Relaxed Ordering is an optional access flag and as such, it is ignored by vendors that don't support it. Signed-off-by: Avihai Horon Reviewed-by: Michael Guralnik Signed-off-by: Leon Romanovsky --- net/smc/smc_ib.c | 3 ++- ne

[PATCH rdma-next 10/10] xprtrdma: Enable Relaxed Ordering

2021-04-04 Thread Leon Romanovsky
From: Avihai Horon Enable Relaxed Ordering for xprtrdma. Relaxed Ordering is an optional access flag and as such, it is ignored by vendors that don't support it. Signed-off-by: Avihai Horon Reviewed-by: Michael Guralnik Signed-off-by: Leon Romanovsky --- net/sunrpc/xprtrdma/frwr_ops.c

[PATCH rdma-next 06/10] nvme-rdma: Enable Relaxed Ordering

2021-04-04 Thread Leon Romanovsky
From: Avihai Horon Enable Relaxed Ordering for nvme. Relaxed Ordering is an optional access flag and as such, it is ignored by vendors that don't support it. Signed-off-by: Avihai Horon Reviewed-by: Max Gurtovoy Reviewed-by: Michael Guralnik Signed-off-by: Leon Romanovsky --- drivers

[PATCH rdma-next 08/10] net/rds: Enable Relaxed Ordering

2021-04-04 Thread Leon Romanovsky
From: Avihai Horon Enable Relaxed Ordering for rds. Relaxed Ordering is an optional access flag and as such, it is ignored by vendors that don't support it. Signed-off-by: Avihai Horon Reviewed-by: Michael Guralnik Signed-off-by: Leon Romanovsky --- net/rds/ib_frmr.c | 7 +++ 1

[PATCH rdma-next 02/10] RDMA/core: Enable Relaxed Ordering in __ib_alloc_pd()

2021-04-04 Thread Leon Romanovsky
From: Avihai Horon Enable Relaxed Ordering in __ib_alloc_pd() allocation of the local_dma_lkey. This will take effect only for devices that don't pre-allocate the lkey but allocate it per PD allocation. Signed-off-by: Avihai Horon Reviewed-by: Michael Guralnik Signed-off-by: Leon Roman

[PATCH rdma-next 07/10] cifs: smbd: Enable Relaxed Ordering

2021-04-04 Thread Leon Romanovsky
From: Avihai Horon Enable Relaxed Ordering for smbd. Relaxed Ordering is an optional access flag and as such, it is ignored by vendors that don't support it. Signed-off-by: Avihai Horon Reviewed-by: Michael Guralnik Signed-off-by: Leon Romanovsky --- fs/cifs/smbdirect.c

[PATCH rdma-next 05/10] RDMA/srp: Enable Relaxed Ordering

2021-04-04 Thread Leon Romanovsky
From: Avihai Horon Enable Relaxed Ordering for srp. Relaxed Ordering is an optional access flag and as such, it is ignored by vendors that don't support it. Signed-off-by: Avihai Horon Reviewed-by: Max Gurtovoy Reviewed-by: Michael Guralnik Signed-off-by: Leon Romanovsky --- dr

[PATCH rdma-next 04/10] RDMA/rtrs: Enable Relaxed Ordering

2021-04-04 Thread Leon Romanovsky
From: Avihai Horon Enable Relaxed Ordering fro rtrs client and server. Relaxed Ordering is an optional access flag and as such, it is ignored by vendors that don't support it. Signed-off-by: Avihai Horon Reviewed-by: Michael Guralnik Signed-off-by: Leon Romanovsky --- drivers/infin

[PATCH rdma-next 03/10] RDMA/iser: Enable Relaxed Ordering

2021-04-04 Thread Leon Romanovsky
From: Avihai Horon Enable Relaxed Ordering for iser. Relaxed Ordering is an optional access flag and as such, it is ignored by vendors that don't support it. Signed-off-by: Avihai Horon Reviewed-by: Max Gurtovoy Reviewed-by: Michael Guralnik Signed-off-by: Leon Romanovsky --- dr

[PATCH rdma-next 01/10] RDMA: Add access flags to ib_alloc_mr() and ib_mr_pool_init()

2021-04-04 Thread Leon Romanovsky
ib_alloc_mr() and ib_mr_pool_init() users. Signed-off-by: Avihai Horon Reviewed-by: Max Gurtovoy Reviewed-by: Michael Guralnik Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/mr_pool.c | 7 +- drivers/infiniband/core/rw.c | 12 ++-- drivers/infiniband/core

[PATCH rdma-next 00/10] Enable relaxed ordering for ULPs

2021-04-04 Thread Leon Romanovsky
From: Leon Romanovsky >From Avihai, Relaxed Ordering is a PCIe mechanism that relaxes the strict ordering imposed on PCI transactions, and thus, can improve performance. Until now, relaxed ordering could be set only by user space applications for user MRs. The following patch series enab

Re: [PATCH] net/mlx5: fix kfree mismatch in indir_table.c

2021-04-04 Thread Leon Romanovsky
/mlx5/core/esw/indir_table.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky

Re: [PATCH net-next 05/12] ionic: add hw timestamp support files

2021-04-04 Thread Leon Romanovsky
On Sun, Apr 04, 2021 at 04:05:26PM -0700, Richard Cochran wrote: > On Thu, Apr 01, 2021 at 10:56:03AM -0700, Shannon Nelson wrote: > > @@ -0,0 +1,589 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* Copyright(c) 2017 - 2021 Pensando Systems, Inc */ > > + > > +#include > > +#include > > + > > +

Re: [PATCH rdma-next 6/7] RDMA/mlx5: Add support in MEMIC operations

2021-04-04 Thread Leon Romanovsky
On Thu, Apr 01, 2021 at 02:47:04PM -0300, Jason Gunthorpe wrote: > On Thu, Mar 18, 2021 at 01:15:47PM +0200, Leon Romanovsky wrote: > > From: Maor Gottlieb > > > > MEMIC buffer, in addition to regular read and write operations, can > > support atomic operations from t

Re: [PATCH mlx5-next v8 0/4] Dynamically assign MSI-X vectors count

2021-04-04 Thread Leon Romanovsky
On Sun, Mar 14, 2021 at 02:42:52PM +0200, Leon Romanovsky wrote: > - > Changelog > v8: > * Added "physical/virtual function" words near PF and VF acronyms. > v7: https://lore.kernel.org/linux-

Re: [PATCH mlx5-next v8 1/4] PCI: Add a sysfs file to change the MSI-X table size of SR-IOV VFs

2021-04-04 Thread Leon Romanovsky
On Fri, Apr 02, 2021 at 07:24:26PM -0500, Bjorn Helgaas wrote: > Possible subject, since this adds *two* files, not just "a file": > > PCI/IOV: Add sysfs MSI-X vector assignment interface Sure > > On Sun, Mar 14, 2021 at 02:42:53PM +0200, Leon Romanovsky wrote: >

Re: [PATCH net 1/2] net: hns3: Remove the left over redundant check & assignment

2021-04-03 Thread Leon Romanovsky
On Sat, Apr 03, 2021 at 02:35:19AM +0100, Salil Mehta wrote: > This removes the left over check and assignment which is no longer used > anywhere in the function and should have been removed as part of the > below mentioned patch. > > Fixes: 012fcb52f67c ("net: hns3: activate reset timer when call

Re: [PATCH rdma-next v2 0/5] Get rid of custom made module dependency

2021-04-03 Thread Leon Romanovsky
On Sat, Apr 03, 2021 at 03:52:13PM +0530, Devesh Sharma wrote: > On Thu, Apr 1, 2021 at 12:27 PM Leon Romanovsky wrote: > > > > From: Leon Romanovsky > > > > Changelog: > > v2: > > * kbuild spotted that I didn't delete all code in patch #5, so deleted

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-04-01 Thread Leon Romanovsky
On Wed, Mar 31, 2021 at 08:23:40PM -0500, Bjorn Helgaas wrote: > [+cc Rafael, in case you're interested in the driver core issue here] > > On Wed, Mar 31, 2021 at 07:08:07AM +0300, Leon Romanovsky wrote: > > On Tue, Mar 30, 2021 at 03:41:41PM -0500, Bjorn Helgaas wrote: > &

Re: [PATCH for-next v3 1/2] IB/cma: Introduce rdma_set_min_rnr_timer()

2021-04-01 Thread Leon Romanovsky
On Wed, Mar 31, 2021 at 08:43:13PM +0200, Håkon Bugge wrote: > Introduce the ability for kernel ULPs to adjust the minimum RNR Retry > timer. The INIT -> RTR transition executed by RDMA CM will be used for > this adjustment. This avoids an additional ib_modify_qp() call. > > rdma_set_min_rnr_timer

[PATCH rdma-next v2 5/5] net/bnxt: Use direct API instead of useless indirection

2021-03-31 Thread Leon Romanovsky
From: Leon Romanovsky There is no need in any indirection complexity for one ULP user, remove all this complexity in favour of direct calls to the exported symbols. This allows us to greatly simplify the code. Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/bnxt_re/main.c

[PATCH rdma-next v2 0/5] Get rid of custom made module dependency

2021-03-31 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v2: * kbuild spotted that I didn't delete all code in patch #5, so deleted even more ulp_ops derefences. v1: https://lore.kernel.org/linux-rdma/20210329085212.257771-1-l...@kernel.org * Go much deeper and removed useless ULP indirection v0:

[PATCH rdma-next v2 3/5] RDMA/bnxt_re: Get rid of custom module reference counting

2021-03-31 Thread Leon Romanovsky
From: Leon Romanovsky Instead of manually messing with parent driver module reference counting rely on export symbol mechanism to ensure that proper probe/remove chain is performed. Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/bnxt_re/main.c | 16 ++-- 1 file changed

[PATCH rdma-next v2 4/5] net/bnxt: Remove useless check of non-existent ULP id

2021-03-31 Thread Leon Romanovsky
From: Leon Romanovsky There is no other bnxt ULP driver in the upstream and all checks for the ULP id are useless, so remove them and convert double array table to proper pointer structure. Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 189

[PATCH rdma-next v2 2/5] RDMA/bnxt_re: Create direct symbolic link between bnxt modules

2021-03-31 Thread Leon Romanovsky
From: Leon Romanovsky Convert indirect probe call to its direct equivalent to create symbols link between RDMA and netdev modules. This will give us an ability to remove custom module reference counting that doesn't belong to the driver. Signed-off-by: Leon Romanovsky --- drivers/infin

[PATCH rdma-next v2 1/5] RDMA/bnxt_re: Depend on bnxt ethernet driver and not blindly select it

2021-03-31 Thread Leon Romanovsky
From: Leon Romanovsky The "select" kconfig keyword provides reverse dependency, however it doesn't check that selected symbol meets its own dependencies. Usually "select" is used for non-visible symbols, so instead of trying to keep dependencies in sync with BNXT etherne

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-30 Thread Leon Romanovsky
On Tue, Mar 30, 2021 at 03:41:41PM -0500, Bjorn Helgaas wrote: > On Tue, Mar 30, 2021 at 04:47:16PM -0300, Jason Gunthorpe wrote: > > On Tue, Mar 30, 2021 at 10:00:19AM -0500, Bjorn Helgaas wrote: > > > On Tue, Mar 30, 2021 at 10:57:38AM -0300, Jason Gunthorpe wrote: > > > > On Mon, Mar 29, 2021 at

[PATCH rdma-next v1 4/5] net/bnxt: Remove useless check of non-existent ULP id

2021-03-29 Thread Leon Romanovsky
From: Leon Romanovsky There is no other bnxt ULP driver in the upstream and all checks for the ULP id are useless, so remove them and convert double array table to proper pointer structure. --- drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 189 +++--- drivers/net/ethernet/broadcom

[PATCH rdma-next v1 5/5] net/bnxt: Use direct API instead of useless indirection

2021-03-29 Thread Leon Romanovsky
From: Leon Romanovsky There is no need in any indirection complexity for one ULP user, remove all this complexity in favour of direct calls to the exported symbols. This allows us to greatly simplify the code. Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/bnxt_re/main.c

[PATCH rdma-next v1 1/5] RDMA/bnxt_re: Depend on bnxt ethernet driver and not blindly select it

2021-03-29 Thread Leon Romanovsky
From: Leon Romanovsky The "select" kconfig keyword provides reverse dependency, however it doesn't check that selected symbol meets its own dependencies. Usually "select" is used for non-visible symbols, so instead of trying to keep dependencies in sync with BNXT etherne

[PATCH rdma-next v1 2/5] RDMA/bnxt_re: Create direct symbolic link between bnxt modules

2021-03-29 Thread Leon Romanovsky
From: Leon Romanovsky Convert indirect probe call to its direct equivalent to create symbols link between RDMA and netdev modules. This will give us an ability to remove custom module reference counting that doesn't belong to the driver. Signed-off-by: Leon Romanovsky --- drivers/infin

[PATCH rdma-next v1 3/5] RDMA/bnxt_re: Get rid of custom module reference counting

2021-03-29 Thread Leon Romanovsky
From: Leon Romanovsky Instead of manually messing with parent driver module reference counting rely on export symbol mechanism to ensure that proper probe/remove chain is performed. Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/bnxt_re/main.c | 16 ++-- 1 file changed

[PATCH rdma-next v1 0/5] Get rid of custom made module dependency

2021-03-29 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v1: * Go much deeper and removed useless ULP indirection v0: https://lore.kernel.org/linux-rdma/20210324142524.1135319-1-l...@kernel.org --- The following series fixes issue spotted in [1

Re: [PATCH net-next] qrtr: move to staging

2021-03-28 Thread Leon Romanovsky
On Mon, Mar 29, 2021 at 07:30:08AM +0200, Greg Kroah-Hartman wrote: > On Mon, Mar 29, 2021 at 08:17:06AM +0300, Leon Romanovsky wrote: > > On Sun, Mar 28, 2021 at 02:26:21PM +0200, Greg Kroah-Hartman wrote: > > > There does not seem to be any developers willing to maintain the &g

Re: [PATCH net-next] qrtr: move to staging

2021-03-28 Thread Leon Romanovsky
On Sun, Mar 28, 2021 at 02:26:21PM +0200, Greg Kroah-Hartman wrote: > There does not seem to be any developers willing to maintain the > net/qrtr/ code, so move it to drivers/staging/ so that it can be removed > from the kernel tree entirely in a few kernel releases if no one steps > up to maintain

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-26 Thread Leon Romanovsky
On Fri, Mar 26, 2021 at 02:12:09PM -0300, Jason Gunthorpe wrote: > On Fri, Mar 26, 2021 at 12:08:31PM -0500, Bjorn Helgaas wrote: > > > Leon has implemented a ton of variations, but I don't think having all > > the files in the PF directory was one of them. > > If you promise this is the last of

  1   2   3   4   5   6   7   8   9   10   >