[PATCH] sundance: add IFF_RUNNING support

2007-02-12 Thread Leigh Brown
Patch to add IFF_RUNNING support for sundance. I copied the basic code for this from the forcedeth driver, and I've tested it using the ifplugstatus command from the ifplugd package. This is very handy if you use Quagga or keepalived. Signed-off-by: Leigh Brown <[EMAIL PROTECTED]>

Deadlock in MD5 Signature support

2006-12-17 Thread Leigh Brown
It was all going so well, and then it deadlocked. What can be done about this? SysRq : Show Regs Pid: 2330, comm: torture EIP: 0060:[] CPU: 0 EIP is at _spin_lock+0x5/0xf EFLAGS: 0282Not tainted (2.6.19.1 #2) EAX: c03187e4 EBX: ECX: fa01a8c0 EDX: c52f81e0 ESI: df9

[TCP]: Trivial fix to message in tcp_v4_inbound_md5_hash

2006-12-17 Thread Leigh Brown
The message logged in tcp_v4_inbound_md5_hash when the hash was expected but not found was reversed. Signed-off-by: Leigh Brown <[EMAIL PROTECTED]> diff -uprN a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c --- a/net/ipv4/tcp_ipv4.c 2006-12-17 10:05:54.0 + +++ b/net/ipv4/tcp_

[TCP]: Fix oops caused by tcp_v4_md5_do_del

2006-12-17 Thread Leigh Brown
md5sig_info.alloced4 must be set to zero when freeing keys4, otherwise it will not be alloc'd again when another key is added to the same socket by tcp_v4_md5_do_add. Signed-off-by: Leigh Brown <[EMAIL PROTECTED]> diff -uprN a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c --- a/net/ipv4

Re: kernel panic with the newly merged md5 signature support

2006-12-13 Thread Leigh Brown
On Wed, December 13, 2006 1:29 am, David Miller said: > I think we're still not onto the right fix. > > I took a look, and the issue seems to simply be that the > __tcp_put_md5sig_pool() is not doing the reference count > thing that __tcp_get_md5sig_pool() does (via tcp_md5sig_users). > > The direc

Re: kernel panic with the newly merged md5 signature support

2006-12-12 Thread Leigh Brown
On Tue, December 12, 2006 10:25 pm, David Miller said: > From: "Leigh Brown" <[EMAIL PROTECTED]> > Date: Tue, 12 Dec 2006 22:22:13 - (GMT) > >> I'm not sure what the correct way forward is. Could these functions >> not be just: >> >>

Re: kernel panic with the newly merged md5 signature support

2006-12-12 Thread Leigh Brown
On Mon, December 11, 2006 9:38 pm, I said: > I decided to try out the md5 signature support, with a view to eventually > fixing up Quagga to make use of it. As the API has changed quite a bit, > I modified a simple echo client/server as a simple test. I compiled > up 2.6.19-git17 and ran it under

kernel panic with the newly merged md5 signature support

2006-12-11 Thread Leigh Brown
Hello, I decided to try out the md5 signature support, with a view to eventually fixing up Quagga to make use of it. As the API has changed quite a bit, I modified a simple echo client/server as a simple test. I compiled up 2.6.19-git17 and ran it under debian etch. Unfortunately, both the clie