Re: [PATCH bpf-next] libbpf: add xsk_umem__adjust_offset

2019-09-13 Thread Laatz, Kevin
On 13/09/2019 05:59, Björn Töpel wrote: On Thu, 12 Sep 2019 at 17:47, Kevin Laatz wrote: Currently, xsk_umem_adjust_offset exists as a kernel internal function. This patch adds xsk_umem__adjust_offset to libbpf so that it can be used from userspace. This will take the responsibility of properly

Re: [PATCH bpf-next v5 03/11] xsk: add support to allow unaligned chunk placement

2019-08-23 Thread Laatz, Kevin
On 22/08/2019 19:43, Jonathan Lemon wrote: On 21 Aug 2019, at 18:44, Kevin Laatz wrote: Currently, addresses are chunk size aligned. This means, we are very restricted in terms of where we can place chunk within the umem. For example, if we have a chunk size of 2k, then our chunks can only be p

Re: [PATCH bpf-next v4 07/11] mlx5e: modify driver for handling offsets

2019-08-19 Thread Laatz, Kevin
On 19/08/2019 15:36, Maxim Mikityanskiy wrote: On 2019-08-01 13:05, Maxim Mikityanskiy wrote: On 2019-07-30 11:53, Kevin Laatz wrote: With the addition of the unaligned chunks option, we need to make sure we handle the offsets accordingly based on the mode we are currently running in. This patc

Re: [PATCH bpf-next v3 03/11] xsk: add support to allow unaligned chunk placement

2019-07-25 Thread Laatz, Kevin
On 25/07/2019 03:22, Jakub Kicinski wrote: On Wed, 24 Jul 2019 05:10:35 +, Kevin Laatz wrote: Currently, addresses are chunk size aligned. This means, we are very restricted in terms of where we can place chunk within the umem. For example, if we have a chunk size of 2k, then our chunks can

Re: [PATCH bpf-next v3 06/11] mlx5e: modify driver for handling offsets

2019-07-25 Thread Laatz, Kevin
On 25/07/2019 11:15, Maxim Mikityanskiy wrote: On 2019-07-24 08:10, Kevin Laatz wrote: With the addition of the unaligned chunks option, we need to make sure we handle the offsets accordingly based on the mode we are currently running in. This patch modifies the driver to appropriately mask the

Re: [PATCH bpf-next v3 08/11] samples/bpf: add unaligned chunks mode support to xdpsock

2019-07-25 Thread Laatz, Kevin
On 25/07/2019 10:43, Maxim Mikityanskiy wrote: On 2019-07-24 08:10, Kevin Laatz wrote: This patch adds support for the unaligned chunks mode. The addition of the unaligned chunks option will allow users to run the application with more relaxed chunk placement in the XDP umem. Unaligned chunks

Re: [PATCH bpf-next v3 03/11] xsk: add support to allow unaligned chunk placement

2019-07-25 Thread Laatz, Kevin
On 25/07/2019 10:27, Maxim Mikityanskiy wrote: On 2019-07-24 08:10, Kevin Laatz wrote: Currently, addresses are chunk size aligned. This means, we are very restricted in terms of where we can place chunk within the umem. For example, if we have a chunk size of 2k, then our chunks can only be p

Re: [PATCH 00/11] XDP unaligned chunk placement support

2019-07-01 Thread Laatz, Kevin
On 28/06/2019 21:29, Jonathan Lemon wrote: On 28 Jun 2019, at 9:19, Laatz, Kevin wrote: On 27/06/2019 22:25, Jakub Kicinski wrote: I think that's very limiting.  What is the challenge in providing aligned addresses, exactly? The challenges are two-fold: 1) it prevents using arbitrary b

Re: [PATCH 00/11] XDP unaligned chunk placement support

2019-06-28 Thread Laatz, Kevin
On 27/06/2019 22:25, Jakub Kicinski wrote: On Thu, 27 Jun 2019 12:14:50 +0100, Laatz, Kevin wrote: On the application side (xdpsock), we don't have to worry about the user defined headroom, since it is 0, so we only need to account for the XDP_PACKET_HEADROOM when computing the original ad

Re: [PATCH 00/11] XDP unaligned chunk placement support

2019-06-27 Thread Laatz, Kevin
On 25/06/2019 19:44, Jonathan Lemon wrote: On 20 Jun 2019, at 1:39, Kevin Laatz wrote: This patchset adds the ability to use unaligned chunks in the XDP umem. Currently, all chunk addresses passed to the umem are masked to be chunk size aligned (default is 2k, max is PAGE_SIZE). This limits

Re: [PATCH 03/11] xdp: add offset param to zero_copy_allocator

2019-06-25 Thread Laatz, Kevin
On 24/06/2019 20:23, Jakub Kicinski wrote: On Thu, 20 Jun 2019 09:09:50 +, Kevin Laatz wrote: diff --git a/include/net/xdp.h b/include/net/xdp.h index 0f25b3675c5c..ea801fd2bf98 100644 --- a/include/net/xdp.h +++ b/include/net/xdp.h @@ -53,7 +53,8 @@ struct xdp_mem_info {  struct page_pool

Re: [PATCH 00/11] XDP unaligned chunk placement support

2019-06-25 Thread Laatz, Kevin
On 24/06/2019 16:38, Björn Töpel wrote: On Thu, 20 Jun 2019 at 18:55, Kevin Laatz wrote: This patchset adds the ability to use unaligned chunks in the XDP umem. Currently, all chunk addresses passed to the umem are masked to be chunk size aligned (default is 2k, max is PAGE_SIZE). This limi